bootstrap minor improvements and clean-ups by onur-ozkan · Pull Request #128588 · rust-lang/rust

onur-ozkan · 2024-08-03T06:08:04Z

rustbot · 2024-08-03T06:08:13Z

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

onur-ozkan · 2024-08-03T06:09:13Z

- // FIXME: cargo bench/install do not accept `--release`
- // and miri doesn't want it


This doesn't seem like a FIXME note; it's more like a regular note.

onur-ozkan · 2024-08-03T06:10:26Z

- // FIXME: tool_std is not quite right, we shouldn't allow nightly features.
- // But `builder.cargo` doesn't know how to handle ToolBootstrap in stages other than 0,
- // and this is close enough for now.
- Rls, "src/tools/rls", "rls", stable=true, tool_std=true;


This is an outdated FIXME we had for rust-demangler.

onur-ozkan · 2024-08-03T06:12:20Z

- // FIXME: maybe we should do this for download-rustc as well? but it would be a pain to update
- // this on each and every nightly ...


It sounds painful and I think we will never be doing this.

For a future possibility, maybe distribute the hashes with the tarballs?
Or resurrect the signing of the artifacts...

bors · 2024-08-04T21:55:55Z

☔ The latest upstream changes (presumably #128534) made this pull request unmergeable. Please resolve the merge conflicts.

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan · 2024-08-06T17:33:45Z

Rebased.

Signed-off-by: onur-ozkan <work@onurozkan.dev>

albertlarsan68

LGTM

albertlarsan68 · 2024-08-19T17:45:33Z

- // FIXME: maybe we should do this for download-rustc as well? but it would be a pain to update
- // this on each and every nightly ...


For a future possibility, maybe distribute the hashes with the tarballs?
Or resurrect the signing of the artifacts...

albertlarsan68 · 2024-08-19T17:46:47Z

@bors r+ rollup=iffy

bors · 2024-08-19T17:46:50Z

📌 Commit 8d7c374 has been approved by albertlarsan68

It is now in the queue for this repository.

bors · 2024-08-19T18:15:04Z

⌛ Testing commit 8d7c374 with merge 5601d14...

bors · 2024-08-19T20:41:38Z

☀️ Test successful - checks-actions
Approved by: albertlarsan68
Pushing 5601d14 to master...

rust-timer · 2024-08-19T21:56:05Z

Finished benchmarking commit (5601d14): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.2%	[4.2%, 4.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.0%	[-5.0%, -5.0%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 749.361s -> 748.109s (-0.17%)
Artifact size: 336.71 MiB -> 336.74 MiB (0.01%)

rustbot assigned albertlarsan68 Aug 3, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 3, 2024

onur-ozkan commented Aug 3, 2024
View reviewed changes

onur-ozkan force-pushed the clean-up-bootstrap-internals branch from ff022f1 to 8d7c374Compare August 6, 2024 17:31

unify path syncing logic for vendor and dist
37984bb
Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan added 2 commits August 6, 2024 20:35

remove redundant FIXMEs
bc0bc91
Signed-off-by: onur-ozkan <work@onurozkan.dev>

improve rustup check in x setup
8d7c374
Signed-off-by: onur-ozkan <work@onurozkan.dev>

bjorn3 mentioned this pull request Aug 7, 2024
Change generate-copyright to generate HTML, with cargo dependencies included #128353
Merged

albertlarsan68 approved these changes Aug 19, 2024
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 19, 2024

bors merged commit 5601d14 into rust-lang:masterAug 19, 2024

rustbot added this to the 1.82.0 milestone Aug 19, 2024

bors mentioned this pull request Aug 19, 2024
do not build cargo-miri by default on stable channel #129243
Merged

onur-ozkan deleted the clean-up-bootstrap-internals branch August 20, 2024 04:25

		// FIXME: cargo bench/install do not accept `--release`
		// and miri doesn't want it

		// FIXME: maybe we should do this for download-rustc as well? but it would be a pain to update
		// this on each and every nightly ...

Uh oh!

Uh oh!

Conversation

onur-ozkan commented Aug 3, 2024

Uh oh!

rustbot commented Aug 3, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bors commented Aug 4, 2024

Uh oh!

onur-ozkan commented Aug 6, 2024

Uh oh!

albertlarsan68 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

albertlarsan68 commented Aug 19, 2024

Uh oh!

bors commented Aug 19, 2024

Uh oh!

bors commented Aug 19, 2024

Uh oh!

bors commented Aug 19, 2024

Uh oh!

rust-timer commented Aug 19, 2024

Overall result: no relevant changes - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants