Uh oh!
There was an error while loading. Please reload this page.
do not build cargo-miri by default on stable channel - #129243
Merged
Merged
Conversation
rustbot
commented
Aug 18, 2024
Collaborator
rustbot
commented
Aug 18, 2024
Collaborator
This PR modifies If appropriate, please update |
bors
commented
Aug 19, 2024
Collaborator
☔ The latest upstream changes (presumably #128588) made this pull request unmergeable. Please resolve the merge conflicts. |
miri skipped for stable channel by default, do the same for `cargo-miri`. Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Kobzol
commented
Aug 23, 2024
Member
@bors r+ rollup |
bors
commented
Aug 23, 2024
Collaborator
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 23, 2024
do not build `cargo-miri` by default on stable channel Skips `cargo-miri` build on `stable` channel just like `miri`. Closesrust-lang#129171 cc `@RalfJung`
This was referenced Aug 23, 2024
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 23, 2024
…llaumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#128511 (Document WebAssembly target feature expectations) - rust-lang#129243 (do not build `cargo-miri` by default on stable channel) - rust-lang#129263 (Add a missing compatibility note in the 1.80.0 release notes) - rust-lang#129276 (Stabilize feature `char_indices_offset`) - rust-lang#129350 (adapt integer comparison tests for LLVM 20 IR changes) - rust-lang#129408 (Fix handling of macro arguments within the `dropping_copy_types` lint) - rust-lang#129426 (rustdoc-search: use tighter json for names and parents) - rust-lang#129437 (Fix typo in a help diagnostic) - rust-lang#129457 (kobzol vacation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 23, 2024
Rollup merge of rust-lang#129243 - onur-ozkan:stuff, r=Kobzol do not build `cargo-miri` by default on stable channel Skips `cargo-miri` build on `stable` channel just like `miri`. Closesrust-lang#129171 cc ``@RalfJung``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skips
cargo-miribuild onstablechannel just likemiri.Closes#129171
cc @RalfJung