Skip to content

less noisy change-tracker - #130368

Closed
onur-ozkan wants to merge 5 commits into
rust-lang:masterfrom
onur-ozkan:less-noisy-change-tracker
Closed

less noisy change-tracker#130368
onur-ozkan wants to merge 5 commits into
rust-lang:masterfrom
onur-ozkan:less-noisy-change-tracker

Conversation

@onur-ozkan

Copy link
Copy Markdown
Contributor

Reduces noise from change-tracker by disabling change-tracker by default and displaying its help messages only in verbose mode. This means users won't see any change-tracker helper or change messages unless it is explicitly enabled in config.toml or the verbose flag is passed.

Alternative to #130356.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 14, 2024
@rustbot

Copy link
Copy Markdown
Collaborator

This PR modifies config.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@bjorn3

Copy link
Copy Markdown
Member

This should allow removing

, right? If so would you mind removing it in this PR?

@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

@bors

bors commented Sep 23, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #130716) made this pull request unmergeable. Please resolve the merge conflicts.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
onur-ozkanforce-pushed the less-noisy-change-tracker branch from f48da53 to 70216e6CompareSeptember 24, 2024 09:10
@onur-ozkan

Copy link
Copy Markdown
ContributorAuthor

Rebased to fix merge conflict.

@bors

bors commented Oct 8, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #122709) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this change, as I think "human" users should be warned about changes by default

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly useful for experts and we should just include this in the documentation instead of turning it on by default.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@onur-ozkan@rustbot@bjorn3@bors@albertlarsan68