Skip to content

don't warn about a missing change-id in CI - #130356

Merged
bors merged 1 commit into
rust-lang:masterfrom
lolbinarycat:ci-no-change-id
Oct 14, 2024
Merged

don't warn about a missing change-id in CI#130356
bors merged 1 commit into
rust-lang:masterfrom
lolbinarycat:ci-no-change-id

Conversation

@lolbinarycat

@lolbinarycatlolbinarycat commented Sep 14, 2024

Copy link
Copy Markdown
Contributor

fixes#130352

@rustbot

rustbot commented Sep 14, 2024

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @albertlarsan68 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 14, 2024
@onur-ozkan

onur-ozkan commented Sep 14, 2024

Copy link
Copy Markdown
Contributor

Why this doesn't work already?

rust/src/ci/run.sh

Lines 50 to 53 in e7386b3

# suppress change-tracker warnings on CI
if [ "$CI"!="" ];then
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set change-id=99999999"
fi

Directly ignoring the change tracker at the bootstrap level could have negative effects for downstream CIs.

@workingjubilee

workingjubilee commented Sep 14, 2024•
edited
Loading

Copy link
Copy Markdown
Member

as a downstream CI: I am also ignoring this in my CI because I do not care about all the notifications because they are never relevant to me.

@workingjubilee

workingjubilee commented Sep 14, 2024

Copy link
Copy Markdown
Member

if something happens that is important, the CI will probably break. until then, the 9 million tiny changes that only matter to interactive users are not very relevant. it doesn't matter if my eyes glaze over when I see the message or if I actively silence it: the same effect of "I ain't readin' all that" takes place.

@onur-ozkanonur-ozkan mentioned this pull request Sep 14, 2024
Closed
@onur-ozkan

onur-ozkan commented Sep 14, 2024

Copy link
Copy Markdown
Contributor

Directly ignoring the change tracker at the bootstrap level could have negative effects for downstream CIs.

Update on this: I initially thought this PR was ignoring the change messages, but it’s actually just skipping the help message for the missing field. That makes sense. I have just created an alternative PR that skips the help message for everyone by default unless running in verbose mode.

@workingjubilee

workingjubilee commented Sep 14, 2024

Copy link
Copy Markdown
Member

thank you! personally happy to see whatever variation on this people like better land.

albertlarsan68
albertlarsan68 approved these changes Oct 13, 2024
View reviewed changes

@albertlarsan68albertlarsan68 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay!

@albertlarsan68

albertlarsan68 commented Oct 13, 2024

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Oct 13, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 32f01b2 has been approved by albertlarsan68

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2024
@onur-ozkan

onur-ozkan commented Oct 13, 2024

Copy link
Copy Markdown
Contributor

LGTM, sorry for the delay!

Did you check #130368? If so, I will close that one.

@albertlarsan68

albertlarsan68 commented Oct 13, 2024

Copy link
Copy Markdown
Member

I think that those are quite orthogonal

@matthiaskrgrmatthiaskrgr mentioned this pull request Oct 13, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2024
@bors
Auto merge ofrust-lang#131662- matthiaskrgr:rollup-r1wkfxw, r=matth…
47017dd
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#130356 (don't warn about a missing change-id in CI)
- rust-lang#130900 (Do not output () on empty description)
- rust-lang#131066 (Add the Chinese translation entry to the RustByExample build process)
- rust-lang#131067 (Fix std_detect links)
- rust-lang#131644 (Clean up some Miri things in `sys/windows`)
- rust-lang#131646 (sys/unix: add comments for some Miri fallbacks)
- rust-lang#131653 (Remove const trait bound modifier hack)
- rust-lang#131659 (enable `download_ci_llvm` test)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2024
@bors
Auto merge ofrust-lang#131662- matthiaskrgr:rollup-r1wkfxw, r=matth…
5ceb623
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#130356 (don't warn about a missing change-id in CI)
- rust-lang#130900 (Do not output () on empty description)
- rust-lang#131066 (Add the Chinese translation entry to the RustByExample build process)
- rust-lang#131067 (Fix std_detect links)
- rust-lang#131644 (Clean up some Miri things in `sys/windows`)
- rust-lang#131646 (sys/unix: add comments for some Miri fallbacks)
- rust-lang#131653 (Remove const trait bound modifier hack)
- rust-lang#131659 (enable `download_ci_llvm` test)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1d0c7cf into rust-lang:masterOct 14, 2024
@rustbotrustbot added this to the 1.83.0 milestone Oct 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2024
@rust-timer
Unrolled build forrust-lang#130356
4e4c54e
Rollup merge of rust-lang#130356 - lolbinarycat:ci-no-change-id, r=albertlarsan68
don't warn about a missing change-id in CI
fixesrust-lang#130352
@cuvipercuviper modified the milestones: 1.83.0, 1.84.0Oct 14, 2024
@onur-ozkanonur-ozkan mentioned this pull request Oct 25, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 25, 2024
@matthiaskrgr
Rollup merge ofrust-lang#132130- onur-ozkan:remove-ci-change-id, r=…
f8cae25
…Kobzol
remove `change-id` from CI script
It's not necessary to set `change-id` for CI since rust-lang#130356.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 25, 2024
@rust-timer
Unrolled build forrust-lang#132130
34de88f
Rollup merge of rust-lang#132130 - onur-ozkan:remove-ci-change-id, r=Kobzol
remove `change-id` from CI script
It's not necessary to set `change-id` for CI since rust-lang#130356.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albertlarsan68albertlarsan68albertlarsan68 approved these changes

Assignees

@albertlarsan68albertlarsan68

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.84.0

Development

Successfully merging this pull request may close these issues.

change-id warning shows up as clutter in CI logs

7 participants

@lolbinarycat@rustbot@onur-ozkan@workingjubilee@albertlarsan68@bors@cuviper