Skip to content

Remove const trait bound modifier hack - #131653

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:no-modifier-hack
Oct 14, 2024
Merged

Remove const trait bound modifier hack#131653
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:no-modifier-hack

Conversation

@compiler-errors

@compiler-errorscompiler-errors commented Oct 13, 2024

Copy link
Copy Markdown
Contributor

It's no longer necessary, according to the test suite :D

r? @fee1-dead or anyone really

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 13, 2024
@fee1-dead

fee1-dead commented Oct 13, 2024

Copy link
Copy Markdown
Member

Although it still seems weird that we're pushing constness for traits in lower_path_segment somehow. Might need more investigation, though I'm a bit busy these few weeks.

@bors r+ rollup

@bors

bors commented Oct 13, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 204e6af has been approved by fee1-dead

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2024
@matthiaskrgrmatthiaskrgr mentioned this pull request Oct 13, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2024
@bors
Auto merge ofrust-lang#131662- matthiaskrgr:rollup-r1wkfxw, r=matth…
47017dd
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#130356 (don't warn about a missing change-id in CI)
- rust-lang#130900 (Do not output () on empty description)
- rust-lang#131066 (Add the Chinese translation entry to the RustByExample build process)
- rust-lang#131067 (Fix std_detect links)
- rust-lang#131644 (Clean up some Miri things in `sys/windows`)
- rust-lang#131646 (sys/unix: add comments for some Miri fallbacks)
- rust-lang#131653 (Remove const trait bound modifier hack)
- rust-lang#131659 (enable `download_ci_llvm` test)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2024
@bors
Auto merge ofrust-lang#131662- matthiaskrgr:rollup-r1wkfxw, r=matth…
5ceb623
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#130356 (don't warn about a missing change-id in CI)
- rust-lang#130900 (Do not output () on empty description)
- rust-lang#131066 (Add the Chinese translation entry to the RustByExample build process)
- rust-lang#131067 (Fix std_detect links)
- rust-lang#131644 (Clean up some Miri things in `sys/windows`)
- rust-lang#131646 (sys/unix: add comments for some Miri fallbacks)
- rust-lang#131653 (Remove const trait bound modifier hack)
- rust-lang#131659 (enable `download_ci_llvm` test)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 20add51 into rust-lang:masterOct 14, 2024
@rustbotrustbot added this to the 1.83.0 milestone Oct 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2024
@rust-timer
Unrolled build forrust-lang#131653
1640fce
Rollup merge of rust-lang#131653 - compiler-errors:no-modifier-hack, r=fee1-dead
Remove const trait bound modifier hack
It's no longer necessary, according to the test suite :D
r? `@fee1-dead` or anyone really
@fmease

fmease commented Oct 14, 2024•
edited
Loading

Copy link
Copy Markdown
Member

according to the test suite

Well the test that used to exercise this hack I added in #119540 was effectively 'disabled' by removing the effects feature flag: tests/ui/rfcs/rfc-2632-const-trait-impl/const-trait-bounds-trait-objects.rs. Though I haven't checked if that hack is still needed.

@compiler-errors

compiler-errors commented Oct 14, 2024

Copy link
Copy Markdown
ContributorAuthor

Ideally the hack would be implemented some other way since I'm cleaning up how we pass through trait bound modifiers in #131652.

@cuvipercuviper modified the milestones: 1.83.0, 1.84.0Oct 14, 2024
@fmease

fmease commented Oct 15, 2024•
edited
Loading

Copy link
Copy Markdown
Member

No longer seems to be necessary: rustc +9322d183f45e0fd5a509820874cc5ff27744a479 tests/ui/rfcs/rfc-2632-const-trait-impl/const-trait-bounds-trait-objects.rs --edition=2021 -Zcrate-attr='feature(effects)' -Znext-solver doesn't ICE. So good riddance!

@fmeasefmease added the PG-const-traits Project group: Const traits label Nov 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fee1-deadfee1-dead

Labels

PG-const-traitsProject group: Const traitsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.84.0

Development

Successfully merging this pull request may close these issues.

6 participants

@compiler-errors@fee1-dead@bors@fmease@cuviper@rustbot