Uh oh!
There was an error while loading. Please reload this page.
Remove lower_mono_bounds - #131967
Merged
Merged
Conversation
rustbot
commented
Oct 20, 2024
Collaborator
rustbot
commented
Oct 20, 2024
Collaborator
HIR ty lowering was modified cc @fmease |
fmease
approved these changes
Oct 20, 2024
fmease
commented
Oct 20, 2024
Member
Should we just rename |
compiler-errors
commented
Oct 20, 2024
ContributorAuthor
Ooh good point. |
compiler-errorsforce-pushed
the
lower-mono
branch
from
October 20, 2024 13:53
eba3563 to
10b0796Comparefmease
commented
Oct 20, 2024
Member
@bors r+ rollup |
bors
commented
Oct 20, 2024
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 20, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#131814 (`optimize` attribute applied to things other than methods/functions/c…) - rust-lang#131927 (Check for filecheck directives in files marked `skip-filecheck`) - rust-lang#131967 (Remove `lower_mono_bounds`) - rust-lang#131973 (fix(rustdoc-json-types): document rustc-hash feature) - rust-lang#131976 (feat(rustdoc-json-types): mark simple enums as copy) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 21, 2024
Rollup merge of rust-lang#131967 - compiler-errors:lower-mono, r=fmease Remove `lower_mono_bounds` I'm not convinced about the usefulness of `lower_mono_bounds`, especially since we have *so* many lower-bound-like fns in HIR lowering, so I've just inlined it into its callers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not convinced about the usefulness of
lower_mono_bounds, especially since we have so many lower-bound-like fns in HIR lowering, so I've just inlined it into its callers.