Uh oh!
There was an error while loading. Please reload this page.
feat(rustdoc-json-types): mark simple enums as copy - #131976
Merged
Merged
Conversation
rustbot
commented
Oct 20, 2024
Collaborator
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing |
Typos found some typos in the file, so I fixed them c:
jalil-salameforce-pushed
the
rustdoc-types-copy-enums
branch
from
October 20, 2024 17:01
0c7fdf4 to
afa75f0CompareaDotInTheVoid
commented
Oct 20, 2024
Member
Yep! It's really helpful, thanks for doing it. Rustbot will make it's best guess about who to assign if you don't but I'm not in that review queue. I'll probably still review it if it's a rustdoc-json change, but it avoids pinging someone else unnecessarily. |
aDotInTheVoid
commented
Oct 20, 2024
Member
@bors r+ rollup Thanks! |
bors
commented
Oct 20, 2024
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 20, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#131814 (`optimize` attribute applied to things other than methods/functions/c…) - rust-lang#131927 (Check for filecheck directives in files marked `skip-filecheck`) - rust-lang#131967 (Remove `lower_mono_bounds`) - rust-lang#131973 (fix(rustdoc-json-types): document rustc-hash feature) - rust-lang#131976 (feat(rustdoc-json-types): mark simple enums as copy) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 21, 2024
Rollup merge of rust-lang#131976 - jalil-salame:rustdoc-types-copy-enums, r=aDotInTheVoid feat(rustdoc-json-types): mark simple enums as copy Fixesrust-lang/rustdoc-types#26 and some typos in the documentation r? `@aDotInTheVoid` I have been assigning these PRs to you `@aDotInTheVoid,` is that okay? I think I'm out of PRs for now, but for future reference c:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixesrust-lang/rustdoc-types#26 and some typos in the documentation
r? @aDotInTheVoid
I have been assigning these PRs to you @aDotInTheVoid, is that okay? I think I'm out of PRs for now, but for future reference c: