Skip to content

Rollup of 3 pull requests - #132148

Merged
bors merged 6 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-c155tcy
Oct 25, 2024
Merged

Rollup of 3 pull requests#132148
bors merged 6 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-c155tcy

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Oct 25, 2024

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

maxcabrajacand others added 6 commits October 24, 2024 11:10
@maxcabrajac
Pass Ident by reference in ast Visitor
64a3451
@onur-ozkan
remove change-id from CI script
03d23a7
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@RalfJung
library: consistently use American spelling for 'behavior'
854e3c4
@matthiaskrgr
Rollup merge ofrust-lang#132106- maxcabrajac:ident_ref, r=petrochenkov
280790b
Pass Ident by reference in ast Visitor
`MutVisitor`'s version of `visit_ident` passes around `&Ident`, but `Visitor` copies `Ident`. This PR changes that
r? `@petrochenkov`
related to rust-lang#128974
@matthiaskrgr
Rollup merge ofrust-lang#132130- onur-ozkan:remove-ci-change-id, r=…
f8cae25
…Kobzol
remove `change-id` from CI script
It's not necessary to set `change-id` for CI since rust-lang#130356.
@matthiaskrgr
Rollup merge ofrust-lang#132137- RalfJung:behavior, r=Noratrieb
4f2e9c5
library: consistently use American spelling for 'behavior'
We use "behavior" a lot more often than "behaviour", but some "behaviour" have even snuck into user-facing docs. This makes the spelling consistent.
@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 25, 2024
@matthiaskrgr

matthiaskrgr commented Oct 25, 2024

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=3

@bors

bors commented Oct 25, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 4f2e9c5 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2024
@bors

bors commented Oct 25, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4f2e9c5 with merge c1db4dc...

@bors

bors commented Oct 25, 2024

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing c1db4dc to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 25, 2024
@bors
bors merged commit c1db4dc into rust-lang:masterOct 25, 2024
@rustbotrustbot added this to the 1.84.0 milestone Oct 25, 2024
@rust-timer

rust-timer commented Oct 25, 2024

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#132106Pass Ident by reference in ast Visitor83dacf7d762f942858fa5d7eb610dec2df1bdb0d (link)
#132130remove change-id from CI script34de88f1363e728029c54a331ba93cc12c4bcd2e (link)
#132137library: consistently use American spelling for 'behavior'35b5f0322b0204d97e20ea175404fe4c1d74db61 (link)

previous master: b188577f14

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@borsbors mentioned this pull request Oct 26, 2024
Closed
@rust-timer

rust-timer commented Oct 26, 2024

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (c1db4dc): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-1.2%[-1.2%, -1.2%]1
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-1.2%[-1.2%, -1.2%]1

Cycles

Results (primary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		1.0%[0.6%, 1.4%]7
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)1.0%[0.6%, 1.4%]7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 788.853s -> 787.658s (-0.15%)
Artifact size: 333.59 MiB -> 333.62 MiB (0.01%)

@matthiaskrgr
matthiaskrgr deleted the rollup-c155tcy branch January 25, 2025 09:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcmerged-by-borsThis PR was explicitly merged by bors.O-unixOperating system: Unix-likeO-windowsOperating system: WindowsrollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.84.0

Development

Successfully merging this pull request may close these issues.

7 participants

@matthiaskrgr@bors@rust-timer@rustbot@maxcabrajac@onur-ozkan@RalfJung