Skip to content

allow CFGuard on windows-gnullvm - #132965

Merged
bors merged 1 commit into
rust-lang:masterfrom
mati865:cfguard-gnullvm
Nov 15, 2024
Merged

allow CFGuard on windows-gnullvm#132965
bors merged 1 commit into
rust-lang:masterfrom
mati865:cfguard-gnullvm

Conversation

@mati865

@mati865mati865 commented Nov 12, 2024

Copy link
Copy Markdown
Member

No unit tests because of #132278

@rustbot

rustbot commented Nov 12, 2024

Copy link
Copy Markdown
Collaborator

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 12, 2024
@wesleywiser

wesleywiser commented Nov 12, 2024

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Nov 12, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 811c1db has been approved by wesleywiser

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 13, 2024
@GuillaumeGomez
Rollup merge ofrust-lang#132965- mati865:cfguard-gnullvm, r=wesleyw…
72a30db
…iser
allow CFGuard on windows-gnullvm
No unit tests because of rust-lang#132278
@GuillaumeGomezGuillaumeGomez mentioned this pull request Nov 13, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 13, 2024
@bors
Auto merge ofrust-lang#132989- GuillaumeGomez:rollup-p5jdno9, r=Gui…
bde4a78
…llaumeGomez
Rollup of 6 pull requests
Successful merges:
- rust-lang#132709 (optimize char::to_digit and assert radix is at least 2)
- rust-lang#132842 (ABI checks: add support for tier2 arches)
- rust-lang#132965 (allow CFGuard on windows-gnullvm)
- rust-lang#132967 (fix REGISTRY_USERNAME to reuse cache between auto and pr jobs)
- rust-lang#132971 (Handle infer vars in anon consts on stable)
- rust-lang#132979 (use `--exact` on `--skip` to avoid unintended substring matches)
r? `@ghost`
`@rustbot` modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 13, 2024
@GuillaumeGomez
Rollup merge ofrust-lang#132965- mati865:cfguard-gnullvm, r=wesleyw…
e211d40
…iser
allow CFGuard on windows-gnullvm
No unit tests because of rust-lang#132278
@GuillaumeGomezGuillaumeGomez mentioned this pull request Nov 13, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 13, 2024
@bors
Auto merge ofrust-lang#132997- GuillaumeGomez:rollup-8j97gl3, r=Gui…
d0d5602
…llaumeGomez
Rollup of 5 pull requests
Successful merges:
- rust-lang#132709 (optimize char::to_digit and assert radix is at least 2)
- rust-lang#132842 (ABI checks: add support for tier2 arches)
- rust-lang#132965 (allow CFGuard on windows-gnullvm)
- rust-lang#132967 (fix REGISTRY_USERNAME to reuse cache between auto and pr jobs)
- rust-lang#132971 (Handle infer vars in anon consts on stable)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 13, 2024
@bors
Auto merge ofrust-lang#132997- GuillaumeGomez:rollup-8j97gl3, r=Gui…
05b157e
…llaumeGomez
Rollup of 5 pull requests
Successful merges:
- rust-lang#132709 (optimize char::to_digit and assert radix is at least 2)
- rust-lang#132842 (ABI checks: add support for tier2 arches)
- rust-lang#132965 (allow CFGuard on windows-gnullvm)
- rust-lang#132967 (fix REGISTRY_USERNAME to reuse cache between auto and pr jobs)
- rust-lang#132971 (Handle infer vars in anon consts on stable)
r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee

workingjubilee commented Nov 13, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Trying to puzzle out a number of spurious MSVC CI failures

@bors rollup=iffy

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 13, 2024
@bors
Auto merge ofrust-lang#132997- GuillaumeGomez:rollup-8j97gl3, r=Gui…
0eafbd6
…llaumeGomez
Rollup of 5 pull requests
Successful merges:
- rust-lang#132709 (optimize char::to_digit and assert radix is at least 2)
- rust-lang#132842 (ABI checks: add support for tier2 arches)
- rust-lang#132965 (allow CFGuard on windows-gnullvm)
- rust-lang#132967 (fix REGISTRY_USERNAME to reuse cache between auto and pr jobs)
- rust-lang#132971 (Handle infer vars in anon consts on stable)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors

bors commented Nov 15, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 811c1db with merge 3bc6916...

@bors

bors commented Nov 15, 2024

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing 3bc6916 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 15, 2024
@bors
bors merged commit 3bc6916 into rust-lang:masterNov 15, 2024
@rustbotrustbot added this to the 1.84.0 milestone Nov 15, 2024
@rust-timer

rust-timer commented Nov 15, 2024

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (3bc6916): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.5%, secondary -2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		0.5%[0.5%, 0.5%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-2.5%[-2.5%, -2.5%]1
All ❌✅ (primary)0.5%[0.5%, 0.5%]1

Cycles

Results (secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		2.1%[1.7%, 2.5%]2
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 786.602s -> 787.326s (0.09%)
Artifact size: 335.30 MiB -> 335.29 MiB (-0.00%)

@ognevnyognevny mentioned this pull request Nov 28, 2024
Closed
@mati865
mati865 deleted the cfguard-gnullvm branch November 28, 2024 18:43
@mati865mati865 mentioned this pull request Feb 18, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiserwesleywiserwesleywiser approved these changes

Assignees

@compiler-errorscompiler-errors

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.84.0

Development

Successfully merging this pull request may close these issues.

7 participants

@mati865@rustbot@wesleywiser@bors@workingjubilee@rust-timer@compiler-errors