ABI checks: add support for tier2 arches by veluca93 · Pull Request #132842 · rust-lang/rust

veluca93 · 2024-11-10T10:38:43Z

See #131800 for the data collection behind this change.

r? RalfJung

RalfJung · 2024-11-10T11:15:51Z

Sorry, I'm going to hand this one off.

r? compiler

RalfJung · 2024-11-10T11:40:23Z

In terms of reviewers, I guess rolling the dice is unlikely to get an ABI person. ;)

r? @workingjubilee

bors · 2024-11-12T15:08:38Z

☔ The latest upstream changes (presumably #132843) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2024-11-12T21:27:26Z

✌️ @veluca93, you can now approve this pull request!

If @workingjubilee told you to "r=me" after making some further change, please make that change, then do @bors r=@workingjubilee

See rust-lang#131800 for the data collection behind this change. Also adds a test that exercise the "empty list of features" path.

veluca93 · 2024-11-12T21:36:34Z

Added all the suggested comments (in one form or the other :-))

@bors r=@workingjubilee

bors · 2024-11-12T21:36:37Z

📌 Commit 295cffc has been approved by workingjubilee

It is now in the queue for this repository.

…ngjubilee ABI checks: add support for tier2 arches See rust-lang#131800 for the data collection behind this change. r? RalfJung

…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#132709 (optimize char::to_digit and assert radix is at least 2) - rust-lang#132842 (ABI checks: add support for tier2 arches) - rust-lang#132965 (allow CFGuard on windows-gnullvm) - rust-lang#132967 (fix REGISTRY_USERNAME to reuse cache between auto and pr jobs) - rust-lang#132971 (Handle infer vars in anon consts on stable) - rust-lang#132979 (use `--exact` on `--skip` to avoid unintended substring matches) r? `@ghost` `@rustbot` modify labels: rollup

…ngjubilee ABI checks: add support for tier2 arches See rust-lang#131800 for the data collection behind this change. r? RalfJung

RalfJung · 2024-11-13T15:53:38Z

+const RISCV_FEATURES_FOR_CORRECT_VECTOR_ABI: &'static [(u64, &'static str)] =
+ &[/*(64, "zvl64b"), */ (128, "v")];
+// Always warn on SPARC, as the necessary target features cannot be enabled in Rust at the moment.
+const SPARC_FEATURES_FOR_CORRECT_VECTOR_ABI: &'static [(u64, &'static str)] = &[/*(128, "vis")*/];


What is the source for the 128 here?

@workingjubilee :-)

checks I could've sworn it was 128-bit, but apparently it's only 64-bit.

This is already rolled up so let's let it land, and then @veluca93 can you prepare a follow-up to fix the comment?

I know one of the SPARC CPUs has 128-bit registers, but I guess I was misremembering what extension defines that.

I think we can get it in the tier 3 pass, but yeah, it's just a comment.
I probably should've just skipped noting down a size at all.

I think we can get it in the tier 3 pass,
That also works.

…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#132709 (optimize char::to_digit and assert radix is at least 2) - rust-lang#132842 (ABI checks: add support for tier2 arches) - rust-lang#132965 (allow CFGuard on windows-gnullvm) - rust-lang#132967 (fix REGISTRY_USERNAME to reuse cache between auto and pr jobs) - rust-lang#132971 (Handle infer vars in anon consts on stable) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#126046 (Implement `mixed_integer_ops_unsigned_sub`) - rust-lang#132302 (rustdoc: Treat declarative macros more like other item kinds) - rust-lang#132842 (ABI checks: add support for tier2 arches) - rust-lang#132995 (compiletest: Add ``exact-llvm-major-version`` directive) - rust-lang#132996 (Trim extra space when suggesting removing bad `let`) - rust-lang#132998 (Unvacation myself) - rust-lang#133000 ([rustdoc] Fix duplicated footnote IDs) - rust-lang#133001 (actually test next solver) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#132842 - veluca93:abi-checks-tier2, r=workingjubilee ABI checks: add support for tier2 arches See rust-lang#131800 for the data collection behind this change. r? RalfJung

…jubilee ABI checks: add support for some tier3 arches, warn on others. Followup to - rust-lang#132842 - rust-lang#132173 - rust-lang#131800 r? `@workingjubilee`

…ngjubilee ABI checks: add support for some tier3 arches, warn on others. Followup to - rust-lang#132842 - rust-lang#132173 - rust-lang#131800 r? `@workingjubilee`

…ngjubilee ABI checks: add support for some tier3 arches, warn on others. Followup to - rust-lang#132842 - rust-lang#132173 - rust-lang#131800 r? ``@workingjubilee``

Rollup merge of rust-lang#133029 - veluca93:abi-checks-tier3, r=workingjubilee ABI checks: add support for some tier3 arches, warn on others. Followup to - rust-lang#132842 - rust-lang#132173 - rust-lang#131800 r? ``@workingjubilee``

riking · 2024-11-26T22:50:07Z

-ABI error: this function call uses a vector type that requires the `{$required_feature}` target feature, which is not enabled in the caller
+ this function call uses a SIMD vector type that (with the chosen ABI) requires the `{$required_feature}` target feature, which is not enabled in the caller
 .label = function called here
 .help = consider enabling it globally (`-C target-feature=+{$required_feature}`) or locally (`#[target_feature(enable="{$required_feature}")]`)


I think we should add a second line of help: consider passing a reference to the value instead

Sure if you control both sides of the FFI you can do that.

rustbot assigned RalfJung Nov 10, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 10, 2024

taiki-e reviewed Nov 10, 2024
View reviewed changes

Comment threadcompiler/rustc_target/src/target_features.rs Outdated
Comment threadcompiler/rustc_target/src/target_features.rs Outdated

rustbot assigned cjgillot and unassigned RalfJung Nov 10, 2024

RalfJung reviewed Nov 10, 2024
View reviewed changes

Comment threadcompiler/rustc_target/src/target_features.rs Outdated

RalfJung reviewed Nov 10, 2024
View reviewed changes

Comment threadcompiler/rustc_target/src/target_features.rs Outdated

veluca93 force-pushed the abi-checks-tier2 branch from ee0505d to bd742a9Compare November 10, 2024 11:23

rustbot assigned workingjubilee and unassigned cjgillot Nov 10, 2024

veluca93 force-pushed the abi-checks-tier2 branch from bd742a9 to 9cc9647Compare November 10, 2024 11:46

taiki-e reviewed Nov 10, 2024
View reviewed changes

Comment threadcompiler/rustc_target/src/target_features.rs Outdated
Comment threadcompiler/rustc_target/src/target_features.rs Outdated

veluca93 force-pushed the abi-checks-tier2 branch from 9cc9647 to 3ae72e3Compare November 10, 2024 14:26

taiki-e approved these changes Nov 10, 2024
View reviewed changes

RalfJung mentioned this pull request Nov 10, 2024
Figure out which target features are required for which SIMD size #131800
Closed
16 tasks

veluca93 force-pushed the abi-checks-tier2 branch 2 times, most recently from 30a21b5 to 9d3e137Compare November 10, 2024 16:25

RalfJung reviewed Nov 10, 2024
View reviewed changes

Comment threadcompiler/rustc_monomorphize/src/collector/abi_check.rs

veluca93 force-pushed the abi-checks-tier2 branch 2 times, most recently from 1cc2c1a to ff485c9Compare November 10, 2024 16:39

RalfJung reviewed Nov 10, 2024
View reviewed changes

Comment threadcompiler/rustc_monomorphize/messages.ftl

veluca93 force-pushed the abi-checks-tier2 branch from ff485c9 to db76ae2Compare November 10, 2024 17:29

RalfJung reviewed Nov 10, 2024
View reviewed changes

Comment threadcompiler/rustc_monomorphize/messages.ftl Outdated

veluca93 force-pushed the abi-checks-tier2 branch from db76ae2 to 9b0144bCompare November 10, 2024 17:45

workingjubilee reviewed Nov 11, 2024
View reviewed changes

Comment threadcompiler/rustc_target/src/target_features.rs
Comment threadcompiler/rustc_target/src/target_features.rs Outdated
Comment threadcompiler/rustc_target/src/target_features.rs Outdated
Comment threadcompiler/rustc_target/src/target_features.rs Outdated

veluca93 force-pushed the abi-checks-tier2 branch from 9b0144b to 8a98b79Compare November 11, 2024 07:12

ABI checks: add support for tier2 arches
295cffc
See rust-lang#131800 for the data collection behind this change. Also adds a test that exercise the "empty list of features" path.

veluca93 force-pushed the abi-checks-tier2 branch from 54ba4f7 to 295cffcCompare November 12, 2024 21:35

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2024

GuillaumeGomez mentioned this pull request Nov 13, 2024
Rollup of 6 pull requests #132989
Closed

GuillaumeGomez mentioned this pull request Nov 13, 2024
Rollup of 5 pull requests #132997
Closed

RalfJung reviewed Nov 13, 2024
View reviewed changes

Comment threadcompiler/rustc_target/src/target_features.rs

matthiaskrgr mentioned this pull request Nov 13, 2024
Rollup of 8 pull requests #133006
Merged

bors merged commit a5372ed into rust-lang:masterNov 14, 2024

rustbot added this to the 1.84.0 milestone Nov 14, 2024

workingjubilee mentioned this pull request Nov 16, 2024
ABI checks: add support for some tier3 arches, warn on others. #133029
Merged

workingjubilee mentioned this pull request Nov 17, 2024
How should we handle SPARC's vector ABI? #133141
Open

riking reviewed Nov 26, 2024
View reviewed changes

taiki-e mentioned this pull request Nov 30, 2024
Support s390x z13 vector ABI #131586
Merged

Uh oh!

Uh oh!

Conversation

veluca93 commented Nov 10, 2024

Uh oh!

Uh oh!

Uh oh!

RalfJung commented Nov 10, 2024

Uh oh!

Uh oh!

Uh oh!

RalfJung commented Nov 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bors commented Nov 12, 2024

Uh oh!

bors commented Nov 12, 2024

Uh oh!

veluca93 commented Nov 12, 2024

Uh oh!

bors commented Nov 12, 2024

Uh oh!

RalfJungNov 13, 2024

Choose a reason for hiding this comment

Uh oh!

veluca93Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

workingjubileeNov 13, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RalfJungNov 13, 2024

Choose a reason for hiding this comment

Uh oh!

workingjubileeNov 13, 2024

Choose a reason for hiding this comment

Uh oh!

workingjubileeNov 13, 2024

Choose a reason for hiding this comment

Uh oh!

RalfJungNov 13, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rikingNov 26, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RalfJungNov 27, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

workingjubileeNov 13, 2024•
edited
Loading

rikingNov 26, 2024•
edited
Loading