Skip to content

add "profiler" and "optimized-compiler-builtins" option coverage for ci-rustc - #133705

Merged
bors merged 2 commits into
rust-lang:masterfrom
onur-ozkan:profiler-check
Dec 3, 2024
Merged

add "profiler" and "optimized-compiler-builtins" option coverage for ci-rustc#133705
bors merged 2 commits into
rust-lang:masterfrom
onur-ozkan:profiler-check

Conversation

@onur-ozkan

@onur-ozkanonur-ozkan commented Dec 1, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Adds "profiler" and "optimized-compiler-builtins" option coverage in CI-rustc config compatibility check.

Resolves#133675

@onur-ozkan
add "profiler" option coverage for ci-rustc
20630c5
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@rustbot

rustbot commented Dec 1, 2024

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

rustbot commented Dec 1, 2024

Copy link
Copy Markdown
Collaborator

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 1, 2024
@onur-ozkanonur-ozkan mentioned this pull request Dec 1, 2024
Closed
RalfJung
RalfJung reviewed Dec 1, 2024
View reviewed changes
Comment threadsrc/bootstrap/src/core/config/config.rs Outdated
jieyouxu
jieyouxu approved these changes Dec 2, 2024
View reviewed changes

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you can r=me after also adding a check for optimized compiler builtins.

Comment threadsrc/bootstrap/src/core/config/config.rs Outdated
@jieyouxujieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2024
@onur-ozkanonur-ozkan changed the title add "profiler" option coverage for ci-rustcadd "profiler" and "optimized-compiler-builtins" option coverage for ci-rustcDec 2, 2024
@onur-ozkan

onur-ozkan commented Dec 2, 2024

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 2, 2024
@onur-ozkan
add "optimized-compiler-builtins" option coverage for ci-rustc
99e726b
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan

onur-ozkan commented Dec 2, 2024

Copy link
Copy Markdown
ContributorAuthor

@bors r=jieyouxu

@bors

bors commented Dec 2, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 99e726b has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2024
@GuillaumeGomezGuillaumeGomez mentioned this pull request Dec 2, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 3, 2024
@bors
Auto merge ofrust-lang#133770- GuillaumeGomez:rollup-l62iyyx, r=Gui…
41cbe3e
…llaumeGomez
Rollup of 10 pull requests
Successful merges:
- rust-lang#131713 (Stabilize `const_maybe_uninit_write`)
- rust-lang#133535 (show forbidden_lint_groups in future-compat reports)
- rust-lang#133610 (Move `Const::{from_anon_const,try_from_lit}` to hir_ty_lowering)
- rust-lang#133701 (Use c"lit" for CStrings without unwrap)
- rust-lang#133704 (fix ICE when promoted has layout size overflow)
- rust-lang#133705 (add "profiler" and "optimized-compiler-builtins" option coverage for ci-rustc)
- rust-lang#133710 (Reducing `target_feature` check-cfg merge conflicts)
- rust-lang#133732 (Fix `-Zdump-mir-dataflow`)
- rust-lang#133746 (Change `AttrArgs::Eq` to a struct variant)
- rust-lang#133763 (Fix `f16::midpoint` const feature gate)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7d67af9 into rust-lang:masterDec 3, 2024
@rustbotrustbot added this to the 1.85.0 milestone Dec 3, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 3, 2024
@rust-timer
Unrolled build forrust-lang#133705
3c8a7ec
Rollup merge of rust-lang#133705 - onur-ozkan:profiler-check, r=jieyouxu
add "profiler" and "optimized-compiler-builtins" option coverage for ci-rustc
Adds "profiler" and "optimized-compiler-builtins" option coverage in CI-rustc config compatibility check.
Resolvesrust-lang#133675
@onur-ozkan
onur-ozkan deleted the profiler-check branch December 3, 2024 08:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJungRalfJungRalfJung left review comments
@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.85.0

Development

Successfully merging this pull request may close these issues.

download-rustc fails to detect when profiler settings differ from local settings

5 participants

@onur-ozkan@rustbot@bors@RalfJung@jieyouxu