Uh oh!
There was an error while loading. Please reload this page.
Change AttrArgs::Eq to a struct variant - #133746
Merged
Merged
Conversation
rustbot
commented
Dec 2, 2024
Collaborator
rustbot
commented
Dec 2, 2024
Collaborator
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
AttrArgs::Eq to a struct variantjieyouxu
commented
Dec 2, 2024
Member
r? jieyouxu |
jieyouxu
approved these changes
Dec 2, 2024
jieyouxu
left a comment
Member
There was a problem hiding this comment.
Thanks, you can r=me after PR CI is green.
oli-obk
commented
Dec 2, 2024
ContributorAuthor
@bors r=jieyouxu |
bors
commented
Dec 2, 2024
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 3, 2024
…llaumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#131713 (Stabilize `const_maybe_uninit_write`) - rust-lang#133535 (show forbidden_lint_groups in future-compat reports) - rust-lang#133610 (Move `Const::{from_anon_const,try_from_lit}` to hir_ty_lowering) - rust-lang#133701 (Use c"lit" for CStrings without unwrap) - rust-lang#133704 (fix ICE when promoted has layout size overflow) - rust-lang#133705 (add "profiler" and "optimized-compiler-builtins" option coverage for ci-rustc) - rust-lang#133710 (Reducing `target_feature` check-cfg merge conflicts) - rust-lang#133732 (Fix `-Zdump-mir-dataflow`) - rust-lang#133746 (Change `AttrArgs::Eq` to a struct variant) - rust-lang#133763 (Fix `f16::midpoint` const feature gate) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 3, 2024
Rollup merge of rust-lang#133746 - oli-obk:push-xwyrylxmrtvq, r=jieyouxu Change `AttrArgs::Eq` to a struct variant Cleanups for simplifying rust-lang#131808 Basically changes `AttrArgs::Eq` to a struct variant and then avoids several matches on `AttrArgsEq` in favor of methods on it. This will make future refactorings simpler, as they can either keep methods or switch to field accesses without having to restructure code
Merged
github-merge-queueBot
pushed a commit
to model-checking/kani
that referenced
this pull request
Dec 9, 2024
Upgrade toolchain to 12/09. Culprit PRs: - rust-lang/rust#132410 - rust-lang/rust#133746 - Unnecessary `map_or` [clippy lint](https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or) As with previous toolchain upgrades, it's unclear why the LLBC tests regressed. Resolves#3754 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 15, 2024
Change `AttrArgs::Eq` to a struct variant Cleanups for simplifying rust-lang#131808 Basically changes `AttrArgs::Eq` to a struct variant and then avoids several matches on `AttrArgsEq` in favor of methods on it. This will make future refactorings simpler, as they can either keep methods or switch to field accesses without having to restructure code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanups for simplifying #131808
Basically changes
AttrArgs::Eqto a struct variant and then avoids several matches onAttrArgsEqin favor of methods on it. This will make future refactorings simpler, as they can either keep methods or switch to field accesses without having to restructure code