Skip to content

Tweak wording of non-const traits used as const bounds - #134094

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:const-trait-errors
Dec 11, 2024
Merged

Tweak wording of non-const traits used as const bounds#134094
bors merged 1 commit into
rust-lang:masterfrom
estebank:const-trait-errors

Conversation

@estebank

@estebankestebank commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

Use verbose suggestions and add additional labels/notes.

r? @compiler-errors

@rustbot

rustbot commented Dec 9, 2024

Copy link
Copy Markdown
Collaborator

HIR ty lowering was modified

cc @fmease

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 9, 2024
compiler-errors
compiler-errors suggested changes Dec 9, 2024
View reviewed changes
Comment threadtests/ui/consts/const-try.stderr
| ^^^^^^^^^^^^^^^^^^^
| ^^^^^^^^^^^^^^^^^^^ not marked with `#[const_trait]`
|
= note: marking a trait with `#[const_trait]` ensures all default method bodies are `const`

@compiler-errorscompiler-errorsDec 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but this note is kinda nonsense?

@estebankestebankDec 9, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an untouched note since at least 2022 (and before that it was moved from somewhere else), so it'll be hard to figure out what they wanted to say then :)

I think that with the current context we can remove this?

@compiler-errorscompiler-errorsDec 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, or it could just be guaranteed to only trigger within default methods, but that might be difficult to fix, and i'd rather not see hacks to do that.

Comment threadtests/ui/consts/const-try.stderr Outdated
Comment threadtests/ui/traits/const-traits/const-bounds-non-const-trait.stderr Outdated
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2024
@rustbot

rustbot commented Dec 9, 2024

Copy link
Copy Markdown
Collaborator

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@rustbotrustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Dec 9, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors

compiler-errors commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

please fix ci, then r=me

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors

compiler-errors commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Dec 9, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 781c622 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 9, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors

compiler-errors commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 9, 2024
@estebank
Tweak wording of non-const traits used as const bounds
4007fc9
Use verbose suggestions and add additional labels/notes.
Add more test cases for stable/nightly and feature enabled/disabled.
@estebank

estebank commented Dec 10, 2024

Copy link
Copy Markdown
ContributorAuthor

@bors r=compiler-errors

@bors

bors commented Dec 10, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 4007fc9 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 10, 2024
@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 10, 2024
fmease added a commit to fmease/rust that referenced this pull request Dec 10, 2024
@fmease
Rollup merge ofrust-lang#134094- estebank:const-trait-errors, r=com…
d16904a
…piler-errors
Tweak wording of non-const traits used as const bounds
Use verbose suggestions and add additional labels/notes.
r? `@compiler-errors`
@fmeasefmease mentioned this pull request Dec 10, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2024
@bors
Auto merge ofrust-lang#134133- fmease:rollup-6pmsnag, r=fmease
acf1ff8
Rollup of 9 pull requests
Successful merges:
- rust-lang#134042 (Add the `power8-crypto` target feature)
- rust-lang#134070 (Some asm! diagnostic adjustments and a papercut fix)
- rust-lang#134094 (Tweak wording of non-const traits used as const bounds)
- rust-lang#134100 (Remove rustc_const_stable attribute on const NOOP)
- rust-lang#134103 (Don't ICE when encountering never in range pattern)
- rust-lang#134113 (run-make: Fix `assert_stderr_not_contains_regex`)
- rust-lang#134115 (rustc_target: ppc64 target string fixes for LLVM 20)
- rust-lang#134116 (stabilize const_nonnull_new)
- rust-lang#134120 (Remove Felix from ping groups and review rotation)
r? `@ghost`
`@rustbot` modify labels: rollup
@fmeasefmease mentioned this pull request Dec 10, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2024
@bors
Auto merge ofrust-lang#134137- fmease:rollup-u1p7swx, r=fmease
8448734
Rollup of 9 pull requests
Successful merges:
- rust-lang#133583 (Fix type (exit → exist))
- rust-lang#134042 (Add the `power8-crypto` target feature)
- rust-lang#134094 (Tweak wording of non-const traits used as const bounds)
- rust-lang#134100 (Remove rustc_const_stable attribute on const NOOP)
- rust-lang#134103 (Don't ICE when encountering never in range pattern)
- rust-lang#134113 (run-make: Fix `assert_stderr_not_contains_regex`)
- rust-lang#134115 (rustc_target: ppc64 target string fixes for LLVM 20)
- rust-lang#134116 (stabilize const_nonnull_new)
- rust-lang#134120 (Remove Felix from ping groups and review rotation)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2024
@bors
Auto merge ofrust-lang#134137- fmease:rollup-u1p7swx, r=fmease
5726725
Rollup of 9 pull requests
Successful merges:
- rust-lang#133583 (Fix type (exit → exist))
- rust-lang#134042 (Add the `power8-crypto` target feature)
- rust-lang#134094 (Tweak wording of non-const traits used as const bounds)
- rust-lang#134100 (Remove rustc_const_stable attribute on const NOOP)
- rust-lang#134103 (Don't ICE when encountering never in range pattern)
- rust-lang#134113 (run-make: Fix `assert_stderr_not_contains_regex`)
- rust-lang#134115 (rustc_target: ppc64 target string fixes for LLVM 20)
- rust-lang#134116 (stabilize const_nonnull_new)
- rust-lang#134120 (Remove Felix from ping groups and review rotation)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2024
@bors
Auto merge ofrust-lang#134137- fmease:rollup-u1p7swx, r=fmease
5a6036a
Rollup of 9 pull requests
Successful merges:
- rust-lang#133583 (Fix type (exit → exist))
- rust-lang#134042 (Add the `power8-crypto` target feature)
- rust-lang#134094 (Tweak wording of non-const traits used as const bounds)
- rust-lang#134100 (Remove rustc_const_stable attribute on const NOOP)
- rust-lang#134103 (Don't ICE when encountering never in range pattern)
- rust-lang#134113 (run-make: Fix `assert_stderr_not_contains_regex`)
- rust-lang#134115 (rustc_target: ppc64 target string fixes for LLVM 20)
- rust-lang#134116 (stabilize const_nonnull_new)
- rust-lang#134120 (Remove Felix from ping groups and review rotation)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 185440a into rust-lang:masterDec 11, 2024
@rustbotrustbot added this to the 1.85.0 milestone Dec 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2024
@rust-timer
Unrolled build forrust-lang#134094
3aba02d
Rollup merge of rust-lang#134094 - estebank:const-trait-errors, r=compiler-errors
Tweak wording of non-const traits used as const bounds
Use verbose suggestions and add additional labels/notes.
r? ``@compiler-errors``
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@compiler-errorscompiler-errorscompiler-errors approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@compiler-errorscompiler-errors

Labels

A-run-makeArea: port run-make Makefiles to rmake.rsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.85.0

Development

Successfully merging this pull request may close these issues.

5 participants

@estebank@rustbot@rust-log-analyzer@compiler-errors@bors