Skip to content

Remove Felix from ping groups and review rotation - #134120

Merged
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:push-vryonyoqmonv
Dec 11, 2024
Merged

Remove Felix from ping groups and review rotation#134120
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:push-vryonyoqmonv

Conversation

@oli-obk

@oli-obkoli-obk commented Dec 10, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@rustbot

rustbot commented Dec 10, 2024

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@oli-obk

oli-obk commented Dec 10, 2024

Copy link
Copy Markdown
ContributorAuthor

r? @oli-obk

bors r plus

@bors

bors commented Dec 10, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 5a1adeb has been approved by oli-obk

It is now in the queue for this repository.

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 10, 2024
@oli-obk

oli-obk commented Dec 10, 2024

Copy link
Copy Markdown
ContributorAuthor

@bors rollup

@fmeasefmease mentioned this pull request Dec 10, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2024
@bors
Auto merge ofrust-lang#134125- fmease:rollup-u38o3ob, r=fmease
33c245b
Rollup of 11 pull requests
Successful merges:
- rust-lang#133478 (jsondocck: Parse, don't validate commands.)
- rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
- rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
- rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
- rust-lang#134008 (Make `Copy` unsafe to implement for ADTs with `unsafe` fields)
- rust-lang#134017 (Don't use `AsyncFnOnce::CallOnceFuture` bounds for signature deduction)
- rust-lang#134023 (handle cygwin environment in `install::sanitize_sh`)
- rust-lang#134041 (Use SourceMap to load debugger visualizer files)
- rust-lang#134065 (Move `write_graphviz_results`)
- rust-lang#134106 (Add compiler-maintainers who requested to be on review rotation)
- rust-lang#134123 (bootstrap: Forward cargo JSON output to stdout, not stderr)
Failed merges:
- rust-lang#134120 (Remove Felix from ping groups and review rotation)
r? `@ghost`
`@rustbot` modify labels: rollup
@rustbotrustbot added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Dec 10, 2024
@rustbot

rustbot commented Dec 10, 2024

Copy link
Copy Markdown
Collaborator

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbotrustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 10, 2024
@rustbot

This comment was marked as resolved.

Sign in to view
@fmease

fmease commented Dec 10, 2024

Copy link
Copy Markdown
Member

Aye, I shouldn't've used GH's web interface

@rustbotrustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 10, 2024
@fmease

fmease commented Dec 10, 2024

Copy link
Copy Markdown
Member

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 10, 2024
@fmease

fmease commented Dec 10, 2024

Copy link
Copy Markdown
Member

@bors r=oli-obk

@bors

bors commented Dec 10, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit e1689e6 has been approved by oli-obk

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 10, 2024
fmease added a commit to fmease/rust that referenced this pull request Dec 10, 2024
@fmease
Rollup merge ofrust-lang#134120- oli-obk:push-vryonyoqmonv, r=oli-obk
a36ceba
Remove Felix from ping groups and review rotation
@fmeasefmease mentioned this pull request Dec 10, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2024
@bors
Auto merge ofrust-lang#134133- fmease:rollup-6pmsnag, r=fmease
acf1ff8
Rollup of 9 pull requests
Successful merges:
- rust-lang#134042 (Add the `power8-crypto` target feature)
- rust-lang#134070 (Some asm! diagnostic adjustments and a papercut fix)
- rust-lang#134094 (Tweak wording of non-const traits used as const bounds)
- rust-lang#134100 (Remove rustc_const_stable attribute on const NOOP)
- rust-lang#134103 (Don't ICE when encountering never in range pattern)
- rust-lang#134113 (run-make: Fix `assert_stderr_not_contains_regex`)
- rust-lang#134115 (rustc_target: ppc64 target string fixes for LLVM 20)
- rust-lang#134116 (stabilize const_nonnull_new)
- rust-lang#134120 (Remove Felix from ping groups and review rotation)
r? `@ghost`
`@rustbot` modify labels: rollup
@fmeasefmease mentioned this pull request Dec 10, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2024
@bors
Auto merge ofrust-lang#134137- fmease:rollup-u1p7swx, r=fmease
8448734
Rollup of 9 pull requests
Successful merges:
- rust-lang#133583 (Fix type (exit → exist))
- rust-lang#134042 (Add the `power8-crypto` target feature)
- rust-lang#134094 (Tweak wording of non-const traits used as const bounds)
- rust-lang#134100 (Remove rustc_const_stable attribute on const NOOP)
- rust-lang#134103 (Don't ICE when encountering never in range pattern)
- rust-lang#134113 (run-make: Fix `assert_stderr_not_contains_regex`)
- rust-lang#134115 (rustc_target: ppc64 target string fixes for LLVM 20)
- rust-lang#134116 (stabilize const_nonnull_new)
- rust-lang#134120 (Remove Felix from ping groups and review rotation)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2024
@bors
Auto merge ofrust-lang#134137- fmease:rollup-u1p7swx, r=fmease
5726725
Rollup of 9 pull requests
Successful merges:
- rust-lang#133583 (Fix type (exit → exist))
- rust-lang#134042 (Add the `power8-crypto` target feature)
- rust-lang#134094 (Tweak wording of non-const traits used as const bounds)
- rust-lang#134100 (Remove rustc_const_stable attribute on const NOOP)
- rust-lang#134103 (Don't ICE when encountering never in range pattern)
- rust-lang#134113 (run-make: Fix `assert_stderr_not_contains_regex`)
- rust-lang#134115 (rustc_target: ppc64 target string fixes for LLVM 20)
- rust-lang#134116 (stabilize const_nonnull_new)
- rust-lang#134120 (Remove Felix from ping groups and review rotation)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2024
@bors
Auto merge ofrust-lang#134137- fmease:rollup-u1p7swx, r=fmease
5a6036a
Rollup of 9 pull requests
Successful merges:
- rust-lang#133583 (Fix type (exit → exist))
- rust-lang#134042 (Add the `power8-crypto` target feature)
- rust-lang#134094 (Tweak wording of non-const traits used as const bounds)
- rust-lang#134100 (Remove rustc_const_stable attribute on const NOOP)
- rust-lang#134103 (Don't ICE when encountering never in range pattern)
- rust-lang#134113 (run-make: Fix `assert_stderr_not_contains_regex`)
- rust-lang#134115 (rustc_target: ppc64 target string fixes for LLVM 20)
- rust-lang#134116 (stabilize const_nonnull_new)
- rust-lang#134120 (Remove Felix from ping groups and review rotation)
r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2024
@rust-timer
Unrolled build forrust-lang#134120
0196c7e
Rollup merge of rust-lang#134120 - oli-obk:push-vryonyoqmonv, r=oli-obk
Remove Felix from ping groups and review rotation
@bors
bors merged commit e60f6cd into rust-lang:masterDec 11, 2024
@rustbotrustbot added this to the 1.85.0 milestone Dec 11, 2024
flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 15, 2024
@bors
Auto merge ofrust-lang#134125- fmease:rollup-u38o3ob, r=fmease
1857833
Rollup of 11 pull requests
Successful merges:
- rust-lang#133478 (jsondocck: Parse, don't validate commands.)
- rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
- rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
- rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
- rust-lang#134008 (Make `Copy` unsafe to implement for ADTs with `unsafe` fields)
- rust-lang#134017 (Don't use `AsyncFnOnce::CallOnceFuture` bounds for signature deduction)
- rust-lang#134023 (handle cygwin environment in `install::sanitize_sh`)
- rust-lang#134041 (Use SourceMap to load debugger visualizer files)
- rust-lang#134065 (Move `write_graphviz_results`)
- rust-lang#134106 (Add compiler-maintainers who requested to be on review rotation)
- rust-lang#134123 (bootstrap: Forward cargo JSON output to stdout, not stderr)
Failed merges:
- rust-lang#134120 (Remove Felix from ping groups and review rotation)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obkoli-obk

Labels

A-metaArea: Issues & PRs about the rust-lang/rust repository itselfS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.85.0

Development

Successfully merging this pull request may close these issues.

5 participants

@oli-obk@rustbot@bors@fmease@Mark-Simulacrum