Skip to content

triagebot: label src/doc/rustc-dev-guide changes with A-rustc-dev-guide - #135129

Merged
bors merged 1 commit into
rust-lang:masterfrom
jieyouxu:tag-r-d-g
Jan 6, 2025
Merged

triagebot: label src/doc/rustc-dev-guide changes with A-rustc-dev-guide#135129
bors merged 1 commit into
rust-lang:masterfrom
jieyouxu:tag-r-d-g

Conversation

@jieyouxu

@jieyouxujieyouxu commented Jan 5, 2025

Copy link
Copy Markdown
Member

Probably should also create a dev-guide reviewer pool for this repo 🤔

r? @Kobzol

@jieyouxujieyouxu added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustc-dev-guide Area: rustc-dev-guide labels Jan 5, 2025
@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 5, 2025
@rustbot

rustbot commented Jan 5, 2025

Copy link
Copy Markdown
Collaborator

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@BoxyUwU

BoxyUwU commented Jan 5, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jan 5, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 5871867 has been approved by BoxyUwU

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2025
@BoxyUwUBoxyUwU assigned BoxyUwU and unassigned KobzolJan 5, 2025
@BoxyUwU

BoxyUwU commented Jan 5, 2025•
edited
Loading

Copy link
Copy Markdown
Member

For the reviewer pool stuff I somewhat feel like there's not much need- PRs that exclusively change dev guide should just go on the rustc-dev-guide repo and compiler changes that also happen to change the dev guide should just be reviewed by whoever is reviewing the compiler changes.

@jieyouxu

jieyouxu commented Jan 5, 2025

Copy link
Copy Markdown
MemberAuthor

Yeah, that's what I thought as well

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2025
@matthiaskrgr
Rollup merge ofrust-lang#135129- jieyouxu:tag-r-d-g, r=BoxyUwU
bcc86dd
triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`
Probably should also create a dev-guide reviewer pool for this repo 🤔
r? `@Kobzol`
@matthiaskrgrmatthiaskrgr mentioned this pull request Jan 5, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 5, 2025
@bors
Auto merge ofrust-lang#135133- matthiaskrgr:rollup-dpgdbbj, r=matth…
f5c158e
…iaskrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#135085 (add m68k-unknown-none-elf target)
- rust-lang#135111 (Add doc aliases for `libm` and IEEE names)
- rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`)
- rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2025
@bors
Auto merge ofrust-lang#135133- matthiaskrgr:rollup-dpgdbbj, r=matth…
67ffc25
…iaskrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#135085 (add m68k-unknown-none-elf target)
- rust-lang#135111 (Add doc aliases for `libm` and IEEE names)
- rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`)
- rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2025
@bors
Auto merge ofrust-lang#135133- matthiaskrgr:rollup-dpgdbbj, r=<try>
fdba8db
Rollup of 4 pull requests
Successful merges:
- rust-lang#135085 (add m68k-unknown-none-elf target)
- rust-lang#135111 (Add doc aliases for `libm` and IEEE names)
- rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`)
- rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler)
r? `@ghost`
`@rustbot` modify labels: rollup
try-job: dist-aarch64-apple
@matthiaskrgrmatthiaskrgr mentioned this pull request Jan 6, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2025
@bors
Auto merge ofrust-lang#135151- matthiaskrgr:rollup-2vy1hwl, r=matth…
13738b0
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#135111 (Add doc aliases for `libm` and IEEE names)
- rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`)
- rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler)
- rust-lang#135145 (Mention `unnameable_types` in `unreachable_pub` documentation.)
- rust-lang#135147 (A few borrowck tweaks to improve 2024 edition migration lints)
- rust-lang#135150 (move footnote to ordinary comment)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit bb2c4ad into rust-lang:masterJan 6, 2025
@rustbotrustbot added this to the 1.86.0 milestone Jan 6, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2025
@rust-timer
Unrolled build forrust-lang#135129
77f997c
Rollup merge of rust-lang#135129 - jieyouxu:tag-r-d-g, r=BoxyUwU
triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`
Probably should also create a dev-guide reviewer pool for this repo 🤔
r? ``@Kobzol``
@jieyouxu
jieyouxu deleted the tag-r-d-g branch January 6, 2025 10:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BoxyUwUBoxyUwU

Labels

A-metaArea: Issues & PRs about the rust-lang/rust repository itselfA-rustc-dev-guideArea: rustc-dev-guideS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jieyouxu@rustbot@BoxyUwU@bors@Kobzol