Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #135151
Merged
Merged
Conversation
Searching "fma" in the Rust documentation returns results for `intrinsics::fma*`, but does not point to the user-facing `mul_add`. Add aliases for `fma*` and the IEEE operation name `fusedMultiplyAdd`. Add the IEEE name to `sqrt` as well, `squareRoot`.
This link makes sense because someone who wishes to avoid unusable `pub` is likely, but not guaranteed, to be interested in avoiding unnameable types. Also fixed some grammar problems I noticed in the area. Fixesrust-lang#116604.
It's not really necessary
…trieb Add doc aliases for `libm` and IEEE names Searching "fma" in the Rust documentation returns results for `intrinsics::fma*`, but does not point to the user-facing `mul_add`. Add aliases for `fma*` and the IEEE operation name `fusedMultiplyAdd`. Add the IEEE name to `sqrt` as well, `squareRoot`.
triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide` Probably should also create a dev-guide reviewer pool for this repo 🤔 r? ``@Kobzol``
dev guide ping group and set adhoc reviewers to compiler r? ``@jieyouxu`` ``@Kobzol`` I added you both to the `cc` list since you're both also on the list of owners for `src/doc/rustc-dev-guide`
Mention `unnameable_types` in `unreachable_pub` documentation. This link makes sense because someone who wishes to avoid unusable `pub` is likely, but not guaranteed, to be interested in avoiding unnameable types. Also fixed some grammar problems I noticed in the area. Fixesrust-lang#116604. r? Urgau
…=chenyukang A few borrowck tweaks to improve 2024 edition migration lints See first two commits' changes to test outputs. Test coverage in this area is kinda weak, but I think it affects more cases than this (like the craters that will begin to trigger the `tail_expr_drop_order` tests in rust-lang#134523). Third commit is a drive-by change that removes a deref hack from `UseSpans` which doesn't really improve diagnostics much.
…oli-obk move footnote to ordinary comment cc rust-lang#135057
matthiaskrgr
commented
Jan 6, 2025
MemberAuthor
@bors r+ rollup=never p=6 |
bors
commented
Jan 6, 2025
Collaborator
bors
commented
Jan 6, 2025
Collaborator
bors
commented
Jan 6, 2025
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Jan 6, 2025
Collaborator
📌 Perf builds for each rolled up PR:
previous master: fd98df8f14 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Jan 6, 2025
rust-timer
commented
Jan 6, 2025
Collaborator
Finished benchmarking commit (13738b0): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -4.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 4.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 763.241s -> 764.087s (0.11%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
libmand IEEE names #135111 (Add doc aliases forlibmand IEEE names)src/doc/rustc-dev-guidechanges withA-rustc-dev-guide#135129 (triagebot: labelsrc/doc/rustc-dev-guidechanges withA-rustc-dev-guide)unnameable_typesinunreachable_pubdocumentation. #135145 (Mentionunnameable_typesinunreachable_pubdocumentation.)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup