Removed dependency on the field-offset crate, alternate approach by davidv1992 · Pull Request #136201 · rust-lang/rust

davidv1992 · 2025-01-28T16:50:21Z

This is an alternate approach to reach the same goals as #136003. As it touches the core of the query system, this too probably should be evaluated for performance.

r? @Mark-Simulacrum

rustbot · 2025-01-28T16:50:32Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

jieyouxu · 2025-01-29T09:57:00Z

@bors try @rust-timer queue

…t, r=<try> Removed dependency on the field-offset crate, alternate approach This is an alternate approach to reach the same goals as rust-lang#136003. As it touches the core of the query system, this too probably should be evaluated for performance. r? `@Mark-Simulacrum`

bors · 2025-01-29T09:58:14Z

⌛ Trying commit ef6ee83 with merge 3da1435...

bors · 2025-01-29T11:46:43Z

☀️ Try build successful - checks-actions
Build commit: 3da1435 (3da1435f5981c3c4f3e5a0d03ec124848afc2c8c)

rust-timer · 2025-01-29T13:57:49Z

Finished benchmarking commit (3da1435): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.1%, secondary 3.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.7%	[4.7%, 4.7%]	1
Regressions ❌ (secondary)	3.9%	[3.9%, 3.9%]	1
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[-2.4%, 4.7%]	2

Cycles

Results (secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 778.134s -> 774.743s (-0.44%)
Artifact size: 328.46 MiB -> 328.46 MiB (0.00%)

Mark-Simulacrum · 2025-01-31T15:33:55Z

@bors r+

I think this approach seems pretty clean and perf looks good.

bors · 2025-01-31T15:33:59Z

📌 Commit ef6ee83 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

Zoxc · 2025-02-01T05:35:37Z

Is there some reason field-offset isn't updated instead? A safe abstraction is nicer to use here.

davidv1992 · 2025-02-01T07:12:03Z

I chose to not pursue that approach as the use of that dependency was really small in the compiler, and furthermore that project seems to be unmaintained. Though even if it weren't it seems rather excessive to me to have 2 dependencies for this.

…t, r=Mark-Simulacrum Removed dependency on the field-offset crate, alternate approach This is an alternate approach to reach the same goals as rust-lang#136003. As it touches the core of the query system, this too probably should be evaluated for performance. r? `@Mark-Simulacrum`

bors · 2025-02-01T23:43:54Z

⌛ Testing commit ef6ee83 with merge 8b69ce0...

bors · 2025-02-02T01:44:34Z

💔 Test failed - checks-actions

bors · 2025-02-03T10:22:18Z

📌 Commit 2574281 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

Noratrieb · 2025-02-03T11:55:53Z

@bors rollup=maybe perf neutral

Rollup of 5 pull requests Successful merges: - rust-lang#134777 (Enable more tests on Windows) - rust-lang#135621 (Move some std tests to integration tests) - rust-lang#135844 ( Add new tool for dumping feature status based on tidy ) - rust-lang#136167 (Implement unstable `new_range` feature) - rust-lang#136334 (Extract `core::ffi` primitives to a separate (internal) module) Failed merges: - rust-lang#136201 (Removed dependency on the field-offset crate, alternate approach) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-02-04T15:57:47Z

☔ The latest upstream changes (presumably #136533) made this pull request unmergeable. Please resolve the merge conflicts.

davidv1992 · 2025-02-05T17:14:53Z

@rustbot ready

bjorn3 · 2025-02-07T09:11:03Z

@bors r=Mark-Simulacrum

bors · 2025-02-07T09:11:15Z

📌 Commit 62bbaa8 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

davidv1992 · 2025-02-09T20:25:00Z

Something weird is happening with bors on this one I think. It doesn't show approved in the queue yet.

bjorn3 · 2025-02-09T20:30:43Z

@bors r=Mark-Simulacrum

bors · 2025-02-09T20:30:45Z

📌 Commit 62bbaa8 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bjorn3 · 2025-02-09T20:31:22Z

Should be fixed now.

…alt, r=Mark-Simulacrum Removed dependency on the field-offset crate, alternate approach This is an alternate approach to reach the same goals as rust-lang#136003. As it touches the core of the query system, this too probably should be evaluated for performance. r? `@Mark-Simulacrum`

…kingjubilee Rollup of 12 pull requests Successful merges: - rust-lang#136053 (coverage: Defer part of counter-creation until codegen) - rust-lang#136201 (Removed dependency on the field-offset crate, alternate approach) - rust-lang#136228 (Simplify Rc::as_ptr docs + typo fix) - rust-lang#136353 (fix(libtest): Enable Instant on Emscripten targets) - rust-lang#136472 ([`compiletest`-related cleanups 2/7] Feed stage number to compiletest directly) - rust-lang#136487 (ci: stop mysql before removing it) - rust-lang#136552 (Use an `Option` for `FindNextFileHandle` in `ReadDir` instead of `INVALID_FILE_HANDLE` sentinel value) - rust-lang#136705 (Some miscellaneous edition-related library tweaks) - rust-lang#136707 (Bump `cc` to v1.2.13 for the compiler workspace) - rust-lang#136790 (Git blame ignore recent formatting commit) - rust-lang#136792 (Don't apply editorconfig to llvm) - rust-lang#136805 (ignore win_delete_self test in Miri) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#136201 - davidv1992:eliminate-field-offset-alt, r=Mark-Simulacrum Removed dependency on the field-offset crate, alternate approach This is an alternate approach to reach the same goals as rust-lang#136003. As it touches the core of the query system, this too probably should be evaluated for performance. r? ``@Mark-Simulacrum``

Rollup of 5 pull requests Successful merges: - rust-lang#134777 (Enable more tests on Windows) - rust-lang#135621 (Move some std tests to integration tests) - rust-lang#135844 ( Add new tool for dumping feature status based on tidy ) - rust-lang#136167 (Implement unstable `new_range` feature) - rust-lang#136334 (Extract `core::ffi` primitives to a separate (internal) module) Failed merges: - rust-lang#136201 (Removed dependency on the field-offset crate, alternate approach) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Mark-Simulacrum Jan 28, 2025

Noratrieb reviewed Jan 28, 2025
View reviewed changes

Comment threadcompiler/rustc_middle/src/query/plumbing.rs Outdated

davidv1992 force-pushed the eliminate-field-offset-alt branch from d8b458a to ef6ee83Compare January 28, 2025 17:53

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 29, 2025

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 29, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2025

Mark-Simulacrum mentioned this pull request Jan 31, 2025
Removed dependency on the field-offset crate. #136003
Closed

This comment has been minimized.
Sign in to view

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 2, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2025

jhpratt mentioned this pull request Feb 4, 2025
Rollup of 5 pull requests #136533
Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 4, 2025

Removed dependency on the field-offset crate.
62bbaa8

davidv1992 force-pushed the eliminate-field-offset-alt branch from 2574281 to 62bbaa8Compare February 5, 2025 16:56

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 5, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2025

workingjubilee mentioned this pull request Feb 10, 2025
Rollup of 12 pull requests #136809
Merged

bors merged commit ae732f3 into rust-lang:masterFeb 10, 2025

rustbot added this to the 1.86.0 milestone Feb 10, 2025

bjorn3 mentioned this pull request Feb 24, 2026
Improve how QueryCache/QueryState/QueryEngine are stored #152835
Merged

Uh oh!

Uh oh!

Conversation

davidv1992 commented Jan 28, 2025

Uh oh!

rustbot commented Jan 28, 2025

Uh oh!

Uh oh!

jieyouxu commented Jan 29, 2025

Uh oh!

This comment has been minimized.

bors commented Jan 29, 2025

Uh oh!

bors commented Jan 29, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jan 29, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Mark-Simulacrum commented Jan 31, 2025

Uh oh!

bors commented Jan 31, 2025

Uh oh!

Zoxc commented Feb 1, 2025

Uh oh!

davidv1992 commented Feb 1, 2025

Uh oh!

bors commented Feb 1, 2025

Uh oh!

This comment has been minimized.

bors commented Feb 2, 2025

Uh oh!

bors commented Feb 3, 2025

Uh oh!

Noratrieb commented Feb 3, 2025

Uh oh!

bors commented Feb 4, 2025

Uh oh!

davidv1992 commented Feb 5, 2025

Uh oh!

bjorn3 commented Feb 7, 2025

Uh oh!

bors commented Feb 7, 2025

Uh oh!

davidv1992 commented Feb 9, 2025

Uh oh!

bjorn3 commented Feb 9, 2025

Uh oh!

bors commented Feb 9, 2025

Uh oh!

bjorn3 commented Feb 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants