Skip to content

Bump cc to v1.2.13 for the compiler workspace - #136707

Merged
bors merged 1 commit into
rust-lang:masterfrom
clubby789:cmake-bisect
Feb 10, 2025
Merged

Bump cc to v1.2.13 for the compiler workspace#136707
bors merged 1 commit into
rust-lang:masterfrom
clubby789:cmake-bisect

Conversation

@clubby789

@clubby789clubby789 commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 7, 2025
@clubby789

Copy link
Copy Markdown
ContributorAuthor

@bors try

@clubby789clubby789 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 7, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2025
Bump `cc` to v1.2.12 for the compiler workspace
cc has had some further changes, lets see if it works on Apple yet
r? `@ghost`
try-job: dist-x86_64-linux
try-job: dist-x86_64-msvc
try-job: dist-apple-various
try-job: dist-various-2
@bors

bors commented Feb 7, 2025

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 97daf40 with merge dd50949...

@bors

bors commented Feb 7, 2025

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: dd50949 (dd509499f68882c27239f24fc5bf339cea094eef)

@clubby789
clubby789 marked this pull request as ready for review February 8, 2025 00:23
@rustbot

Copy link
Copy Markdown
Collaborator

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@clubby789

Copy link
Copy Markdown
ContributorAuthor

r? bootstrap

@jieyouxu

Copy link
Copy Markdown
Member

Thanks, let's see if this fails in full CI...

r? jieyouxu
@bors r+ rollup=iffy

@bors

bors commented Feb 8, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 97daf40 has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Feb 10, 2025
Bump `cc` to v1.2.12 for the compiler workspace
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
…kingjubilee
Rollup of 4 pull requests
Successful merges:
- rust-lang#133092 (Always set the deployment target when building std)
- rust-lang#134626 (Add Four Codegen Tests)
- rust-lang#136053 (coverage: Defer part of counter-creation until codegen)
- rust-lang#136707 (Bump `cc` to v1.2.12 for the compiler workspace)
r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee

Copy link
Copy Markdown
Member

checking for the error in #136800 (comment)
@bors r-
@bors try

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 10, 2025
@bors

bors commented Feb 10, 2025

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 97daf40 with merge 3d25636...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
Bump `cc` to v1.2.12 for the compiler workspace
try-job: i686-gnu
try-job: aarch64-gnu
try-job: dist-apple-various
try-job: dist-aarch64-apple
try-job: dist-various-2
try-job: x86_64-fuchsia
@rust-log-analyzer

This comment has been minimized.

@workingjubilee

Copy link
Copy Markdown
Member

whoops.

@bors try

@bors

bors commented Feb 10, 2025

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 97daf40 with merge 05c4349...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
Bump `cc` to v1.2.12 for the compiler workspace
try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: aarch64-gnu
try-job: dist-apple-various
try-job: dist-aarch64-apple
try-job: dist-various-2
try-job: x86_64-fuchsia
@ChrisDenton

Copy link
Copy Markdown
Member

This could now be updated to cc v1.2.13.

@bors

bors commented Feb 10, 2025

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 05c4349 (05c434955435f2958fd104e5b5fcded4387acae8)

@workingjubilee

Copy link
Copy Markdown
Member

and I assume @madsmtm would in fact like us to ship the cross-compilation fix

@workingjubileeworkingjubilee changed the title Bump cc to v1.2.12 for the compiler workspaceBump cc to v1.2.13 for the compiler workspaceFeb 10, 2025
@jieyouxu

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Feb 10, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 09f57b2 has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
…kingjubilee
Rollup of 12 pull requests
Successful merges:
- rust-lang#136053 (coverage: Defer part of counter-creation until codegen)
- rust-lang#136201 (Removed dependency on the field-offset crate, alternate approach)
- rust-lang#136228 (Simplify Rc::as_ptr docs + typo fix)
- rust-lang#136353 (fix(libtest): Enable Instant on Emscripten targets)
- rust-lang#136472 ([`compiletest`-related cleanups 2/7] Feed stage number to compiletest directly)
- rust-lang#136487 (ci: stop mysql before removing it)
- rust-lang#136552 (Use an `Option` for `FindNextFileHandle` in `ReadDir` instead of `INVALID_FILE_HANDLE` sentinel value)
- rust-lang#136705 (Some miscellaneous edition-related library tweaks)
- rust-lang#136707 (Bump `cc` to v1.2.13 for the compiler workspace)
- rust-lang#136790 (Git blame ignore recent formatting commit)
- rust-lang#136792 (Don't apply editorconfig to llvm)
- rust-lang#136805 (ignore win_delete_self test in Miri)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 26ca716 into rust-lang:masterFeb 10, 2025
@rustbotrustbot added this to the 1.86.0 milestone Feb 10, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
Rollup merge of rust-lang#136707 - clubby789:cmake-bisect, r=jieyouxu
Bump `cc` to v1.2.13 for the compiler workspace
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@clubby789@bors@rustbot@jieyouxu@workingjubilee@rust-log-analyzer@ChrisDenton@albertlarsan68