Skip to content

bootstrap: add doc for vendor build step - #137382

Merged
bors merged 1 commit into
rust-lang:masterfrom
bit-aloo:2025-02-21-add-vendor-step-doc
Feb 23, 2025
Merged

bootstrap: add doc for vendor build step#137382
bors merged 1 commit into
rust-lang:masterfrom
bit-aloo:2025-02-21-add-vendor-step-doc

Conversation

@bit-aloo

Copy link
Copy Markdown
Member

This PR adds docs for vendor build step.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 21, 2025

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the comments are quite obvious, but the root level comment and the fields comments are useful. Thanks! Left one nit.

Comment threadsrc/bootstrap/src/core/build_steps/vendor.rs Outdated
@Kobzol

Copy link
Copy Markdown
Member

Thanks.

@bors r+ rollup

@bors

bors commented Feb 21, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 034e505 has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2025
@bit-aloo
bit-alooforce-pushed the 2025-02-21-add-vendor-step-doc branch from 034e505 to 12a0e2bCompareFebruary 21, 2025 16:34
@Kobzol

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Feb 22, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 12a0e2b has been approved by Kobzol

It is now in the queue for this repository.

@jhprattjhpratt mentioned this pull request Feb 23, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 23, 2025
Rollup of 9 pull requests
Successful merges:
- rust-lang#135354 ([Debuginfo] Add MSVC Synthetic and Summary providers to LLDB)
- rust-lang#136826 (Replace mem::zeroed with mem::MaybeUninit::uninit for large struct in Unix)
- rust-lang#137194 (More const {} init in thread_local)
- rust-lang#137334 (Greatly simplify lifetime captures in edition 2024)
- rust-lang#137382 (bootstrap: add doc for vendor build step)
- rust-lang#137423 (Improve a bit HIR pretty printer)
- rust-lang#137435 (Fix "missing match arm body" suggestion involving `!`)
- rust-lang#137448 (Fix bugs due to unhandled `ControlFlow` in compiler)
- rust-lang#137458 (Fix missing self subst when rendering `impl Fn*<T>` with no output type)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 553fde4 into rust-lang:masterFeb 23, 2025
@rustbotrustbot added this to the 1.87.0 milestone Feb 23, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 23, 2025
Rollup merge of rust-lang#137382 - Shourya742:2025-02-21-add-vendor-step-doc, r=Kobzol
bootstrap: add doc for vendor build step
This PR adds docs for vendor build step.
@bit-aloo
bit-aloo deleted the 2025-02-21-add-vendor-step-doc branch March 29, 2025 01:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@bit-aloo@rustbot@Kobzol@bors@albertlarsan68