Skip to content

Fix missing self subst when rendering impl Fn*<T> with no output type - #137458

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:render-fn
Feb 23, 2025
Merged

Fix missing self subst when rendering impl Fn*<T> with no output type#137458
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:render-fn

Conversation

@compiler-errors

Copy link
Copy Markdown
Contributor

r? @fmease or reassign

Fixes#133597
cc #137456

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 23, 2025
@fmease

Copy link
Copy Markdown
Member

Thanks errs :) @bors r+ rollup

@bors

bors commented Feb 23, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 431b9aa has been approved by fmease

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2025
@jhprattjhpratt mentioned this pull request Feb 23, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 23, 2025
Rollup of 9 pull requests
Successful merges:
- rust-lang#135354 ([Debuginfo] Add MSVC Synthetic and Summary providers to LLDB)
- rust-lang#136826 (Replace mem::zeroed with mem::MaybeUninit::uninit for large struct in Unix)
- rust-lang#137194 (More const {} init in thread_local)
- rust-lang#137334 (Greatly simplify lifetime captures in edition 2024)
- rust-lang#137382 (bootstrap: add doc for vendor build step)
- rust-lang#137423 (Improve a bit HIR pretty printer)
- rust-lang#137435 (Fix "missing match arm body" suggestion involving `!`)
- rust-lang#137448 (Fix bugs due to unhandled `ControlFlow` in compiler)
- rust-lang#137458 (Fix missing self subst when rendering `impl Fn*<T>` with no output type)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit d415200 into rust-lang:masterFeb 23, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 23, 2025
Rollup merge of rust-lang#137458 - compiler-errors:render-fn, r=fmease
Fix missing self subst when rendering `impl Fn*<T>` with no output type
r? `@fmease` or reassign
Fixesrust-lang#133597
cc rust-lang#137456
@rustbotrustbot added this to the 1.87.0 milestone Feb 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: range end index 2 out of range for slice of length 1

4 participants

@compiler-errors@fmease@bors@rustbot