Skip to content

Revert "compiler/rustc_data_structures/src/sync/worker_local.rs: delete "unsafe impl Sync"" - #137996

Merged
bors merged 1 commit into
rust-lang:masterfrom
safinaskar:2025-03-04-revert-parallel
Mar 5, 2025
Merged

Revert "compiler/rustc_data_structures/src/sync/worker_local.rs: delete "unsafe impl Sync""#137996
bors merged 1 commit into
rust-lang:masterfrom
safinaskar:2025-03-04-revert-parallel

Conversation

@safinaskar

@safinaskarsafinaskar commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

Revert "compiler/rustc_data_structures/src/sync/worker_local.rs: delete "unsafe impl Sync""

This reverts commit 0240690.

See #136858 (comment)

cc "Parallel Rustc Front-end" #113349

r? SparrowLii

@rustbot label: +WG-compiler-parallel
@rustbot label: +C-cleanup

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-parallel-compiler Area: parallel compiler C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Mar 4, 2025
@safinaskarsafinaskar mentioned this pull request Mar 4, 2025
Merged
@compiler-errors

compiler-errors commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Mar 4, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit c6c4ea4 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 4, 2025
@workingjubilee
Rollup merge ofrust-lang#137996- safinaskar:2025-03-04-revert-paral…
f7b31e9
…lel, r=compiler-errors
Revert "compiler/rustc_data_structures/src/sync/worker_local.rs: delete "unsafe impl Sync""
Revert "compiler/rustc_data_structures/src/sync/worker_local.rs: delete "unsafe impl Sync""
This reverts commit 0240690.
See rust-lang#136858 (comment)
cc "Parallel Rustc Front-end" rust-lang#113349
r? SparrowLii
`@rustbot` label: +WG-compiler-parallel
`@rustbot` label: +C-cleanup
@workingjubileeworkingjubilee mentioned this pull request Mar 4, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2025
@bors
Auto merge ofrust-lang#138020- workingjubilee:rollup-eva637e, r=wor…
37d6b94
…kingjubilee
Rollup of 33 pull requests
Successful merges:
- rust-lang#136581 (Retire the legacy `Makefile`-based `run-make` test infra)
- rust-lang#136764 (Make `ptr_cast_add_auto_to_object` lint into hard error)
- rust-lang#136798 (Added documentation for flushing per rust-lang#74348)
- rust-lang#136865 (Perform deeper compiletest path normalization for `$TEST_BUILD_DIR` to account for compare-mode/debugger cases, and normalize long type file filename hashes)
- rust-lang#136975 (Look for `python3` first on MacOS, not `py`)
- rust-lang#137240 (Slightly reformat `std::fs::remove_dir_all` error docs)
- rust-lang#137303 (Remove `MaybeForgetReturn` suggestion)
- rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137502 (Don't include global asm in `mir_keys`, fix error body synthesis)
- rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums)
- rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in `Display` for `ByteStr`)
- rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137829 (Stabilize [T]::split_off... methods)
- rust-lang#137834 (rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME)
- rust-lang#137850 (Stabilize `box_uninit_write`)
- rust-lang#137912 (Do not recover missing lifetime with random in-scope lifetime)
- rust-lang#137913 (Allow struct field default values to reference struct's generics)
- rust-lang#137923 (Simplify `<Postorder as Iterator>::size_hint`)
- rust-lang#137949 (Update MSVC INSTALL.md instructions to recommend VS 2022 + recent Windows 10/11 SDK)
- rust-lang#137963 (Add ``dyn`` keyword to `E0373` examples)
- rust-lang#137975 (Remove unused `PpMode::needs_hir`)
- rust-lang#137986 (Fix some typos)
- rust-lang#137991 (Add `avr-none` to SUMMARY.md and platform-support.md)
- rust-lang#137993 (Remove obsolete comment from DeduceReadOnly)
- rust-lang#137996 (Revert "compiler/rustc_data_structures/src/sync/worker_local.rs: delete "unsafe impl Sync"")
r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubileeworkingjubilee mentioned this pull request Mar 5, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2025
@bors
Auto merge ofrust-lang#138031- workingjubilee:rollup-5bsotpz, r=wor…
4559163
…kingjubilee
Rollup of 15 pull requests
Successful merges:
- rust-lang#137829 (Stabilize [T]::split_off... methods)
- rust-lang#137850 (Stabilize `box_uninit_write`)
- rust-lang#137912 (Do not recover missing lifetime with random in-scope lifetime)
- rust-lang#137913 (Allow struct field default values to reference struct's generics)
- rust-lang#137923 (Simplify `<Postorder as Iterator>::size_hint`)
- rust-lang#137949 (Update MSVC INSTALL.md instructions to recommend VS 2022 + recent Windows 10/11 SDK)
- rust-lang#137963 (Add ``dyn`` keyword to `E0373` examples)
- rust-lang#137975 (Remove unused `PpMode::needs_hir`)
- rust-lang#137981 (rustdoc search: increase strictness of typechecking)
- rust-lang#137986 (Fix some typos)
- rust-lang#137991 (Add `avr-none` to SUMMARY.md and platform-support.md)
- rust-lang#137993 (Remove obsolete comment from DeduceReadOnly)
- rust-lang#137996 (Revert "compiler/rustc_data_structures/src/sync/worker_local.rs: delete "unsafe impl Sync"")
- rust-lang#138019 (Pretty-print `#[deprecated]` attribute in HIR.)
- rust-lang#138026 (Make CrateItem::body() function return an option)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit f32ba6b into rust-lang:masterMar 5, 2025
@rustbotrustbot added this to the 1.87.0 milestone Mar 5, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2025
@rust-timer
Unrolled build forrust-lang#137996
6ec1a03
Rollup merge of rust-lang#137996 - safinaskar:2025-03-04-revert-parallel, r=compiler-errors
Revert "compiler/rustc_data_structures/src/sync/worker_local.rs: delete "unsafe impl Sync""
Revert "compiler/rustc_data_structures/src/sync/worker_local.rs: delete "unsafe impl Sync""
This reverts commit 0240690.
See rust-lang#136858 (comment)
cc "Parallel Rustc Front-end" rust-lang#113349
r? SparrowLii
``@rustbot`` label: +WG-compiler-parallel
``@rustbot`` label: +C-cleanup
@safinaskar
safinaskar deleted the 2025-03-04-revert-parallel branch March 5, 2025 22:03
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Mar 14, 2025
@bors
Auto merge ofrust-lang#138031- workingjubilee:rollup-5bsotpz, r=wor…
0f84f75
…kingjubilee
Rollup of 15 pull requests
Successful merges:
- rust-lang#137829 (Stabilize [T]::split_off... methods)
- rust-lang#137850 (Stabilize `box_uninit_write`)
- rust-lang#137912 (Do not recover missing lifetime with random in-scope lifetime)
- rust-lang#137913 (Allow struct field default values to reference struct's generics)
- rust-lang#137923 (Simplify `<Postorder as Iterator>::size_hint`)
- rust-lang#137949 (Update MSVC INSTALL.md instructions to recommend VS 2022 + recent Windows 10/11 SDK)
- rust-lang#137963 (Add ``dyn`` keyword to `E0373` examples)
- rust-lang#137975 (Remove unused `PpMode::needs_hir`)
- rust-lang#137981 (rustdoc search: increase strictness of typechecking)
- rust-lang#137986 (Fix some typos)
- rust-lang#137991 (Add `avr-none` to SUMMARY.md and platform-support.md)
- rust-lang#137993 (Remove obsolete comment from DeduceReadOnly)
- rust-lang#137996 (Revert "compiler/rustc_data_structures/src/sync/worker_local.rs: delete "unsafe impl Sync"")
- rust-lang#138019 (Pretty-print `#[deprecated]` attribute in HIR.)
- rust-lang#138026 (Make CrateItem::body() function return an option)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@SparrowLiiSparrowLii

Labels

A-parallel-compilerArea: parallel compilerC-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.87.0

Development

Successfully merging this pull request may close these issues.

5 participants

@safinaskar@compiler-errors@bors@rustbot@SparrowLii