Build GCC on CI with GCC, not Clang by Kobzol · Pull Request #138451 · rust-lang/rust

Kobzol · 2025-03-13T10:32:19Z

It seems that GCC built with Clang misbehaves. I have tested that cg_gcc tests pass on CI with a downloaded GCC that was built in this way.

Prerequisite for #138395.

r? @ghost

rustbot · 2025-03-13T10:32:27Z

This PR changes how GCC is built. Consider updating src/bootstrap/download-ci-gcc-stamp.

Kobzol · 2025-03-13T10:33:38Z

@bors try

bors · 2025-03-13T10:34:53Z

⌛ Trying commit a1e034a with merge 94e2839...

Build GCC on CI with GCC, not Clang It seems that GCC built with Clang misbehaves. Prerequisite for rust-lang#138395. r? `@ghost`

bors · 2025-03-13T14:13:52Z

☀️ Try build successful - checks-actions
Build commit: 94e2839 (94e2839e4fb889d033894be1226b47344ce1a17f)

rustbot · 2025-03-13T15:27:51Z

Some changes occurred in src/tools/opt-dist

cc @Kobzol

Kobzol · 2025-03-13T15:27:58Z

@bors try

Build GCC on CI with GCC, not Clang It seems that GCC built with Clang misbehaves. Prerequisite for rust-lang#138395. r? `@ghost`

bors · 2025-03-13T15:29:15Z

⌛ Trying commit 545c5d3 with merge fb4237b...

bors · 2025-03-13T18:03:03Z

☀️ Try build successful - checks-actions
Build commit: fb4237b (fb4237bc14be8ce17d45c5221b52c3e792546032)

rustbot · 2025-03-13T18:49:03Z

This PR modifies config.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

So that follow-up CI commands can proceed normally. It will also avoid overwriting `config.toml` when running opt-dist tests locally.

Kobzol · 2025-03-13T20:34:29Z

r? @GuillaumeGomez

GuillaumeGomez

Apart from @antoyo's comment, looks good to me. Thanks!

Kobzol · 2025-03-14T08:16:34Z

Added a commit that checks if we don't compile GCC with Clang, and removed the flags.

GuillaumeGomez

Looks all good to me, thanks! r=me once CI pass

Kobzol · 2025-03-14T09:28:04Z

@bors r=GuillaumeGomez

bors · 2025-03-14T09:28:06Z

📌 Commit bf095f6 has been approved by GuillaumeGomez

It is now in the queue for this repository.

nikic · 2025-03-14T09:32:05Z

It seems that GCC built with Clang misbehaves.

Is there a bug report for that?

Kobzol · 2025-03-14T09:44:38Z

We think that the specific instance that we hit was https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117952, or something similar.

But more generally, I expect that building GCC with Clang would require various workarounds and have quirks, we already had to modify compiler flags to even get it to compile.

So just using GCC as the host compiler should be a more robust choice in the future.

…meGomez Build GCC on CI with GCC, not Clang It seems that GCC built with Clang misbehaves. I have tested that cg_gcc tests [pass](https://github.com/rust-lang/rust/actions/runs/13842365913/job/38732750617?pr=138451) on CI with a downloaded GCC that was built in this way. Prerequisite for rust-lang#138395. r? `@ghost`

Rollup of 6 pull requests Successful merges: - rust-lang#134720 (Display valid crate types in error message for --crate-type flag) - rust-lang#137424 (uefi: helpers: Add DevicePathNode abstractions) - rust-lang#137736 (Don't attempt to export compiler-builtins symbols from rust dylibs) - rust-lang#138451 (Build GCC on CI with GCC, not Clang) - rust-lang#138454 (Improve post-merge workflow) - rust-lang#138477 (Deny impls for `BikeshedGuaranteedNoDrop`) r? `@ghost` `@rustbot` modify labels: rollup

…meGomez Build GCC on CI with GCC, not Clang It seems that GCC built with Clang misbehaves. I have tested that cg_gcc tests [pass](https://github.com/rust-lang/rust/actions/runs/13842365913/job/38732750617?pr=138451) on CI with a downloaded GCC that was built in this way. Prerequisite for rust-lang#138395. r? ``@ghost``

Rollup of 8 pull requests Successful merges: - rust-lang#138056 (rustc_target: Add target features for LoongArch v1.1) - rust-lang#138349 (Emit function declarations for functions with `#[linkage="extern_weak"]`) - rust-lang#138451 (Build GCC on CI with GCC, not Clang) - rust-lang#138454 (Improve post-merge workflow) - rust-lang#138460 (Pass struct field HirId when check_expr_struct_fields) - rust-lang#138482 (Fix HIR printing of parameters) - rust-lang#138507 (Mirror NetBSD sources) - rust-lang#138511 (Make `Parser::parse_expr_cond` public) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 9 pull requests Successful merges: - rust-lang#138056 (rustc_target: Add target features for LoongArch v1.1) - rust-lang#138451 (Build GCC on CI with GCC, not Clang) - rust-lang#138454 (Improve post-merge workflow) - rust-lang#138460 (Pass struct field HirId when check_expr_struct_fields) - rust-lang#138474 (Refactor is_snake_case.) - rust-lang#138482 (Fix HIR printing of parameters) - rust-lang#138507 (Mirror NetBSD sources) - rust-lang#138511 (Make `Parser::parse_expr_cond` public) - rust-lang#138518 (Fix typo in hir lowering lint diag) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#138451 - Kobzol:gcc-ci-build-gcc, r=GuillaumeGomez Build GCC on CI with GCC, not Clang It seems that GCC built with Clang misbehaves. I have tested that cg_gcc tests [pass](https://github.com/rust-lang/rust/actions/runs/13842365913/job/38732750617?pr=138451) on CI with a downloaded GCC that was built in this way. Prerequisite for rust-lang#138395. r? ```@ghost```

nikic · 2025-03-15T08:58:51Z

We think that the specific instance that we hit was https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117952, or something similar.

Thanks, so this is just working around a GCC bug. Just wanted to make sure it's not Clang miscompiling GCC.

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 13, 2025
Auto merge ofrust-lang#138451- Kobzol:gcc-ci-build-gcc, r=<try>
94e2839
Build GCC on CI with GCC, not Clang It seems that GCC built with Clang misbehaves. Prerequisite for rust-lang#138395. r? `@ghost`

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 13, 2025
Auto merge ofrust-lang#138451- Kobzol:gcc-ci-build-gcc, r=<try>
fb4237b
Build GCC on CI with GCC, not Clang It seems that GCC built with Clang misbehaves. Prerequisite for rust-lang#138395. r? `@ghost`

Kobzol marked this pull request as draft March 13, 2025 18:49

Kobzol added 5 commits March 13, 2025 21:29

Create libgccjit.so.0 alias also for CI-downloaded GCC
c437178

Change GCC build flags
955aef5

Use GCC for building GCC
3fc7ca0

Do not overwrite original config.toml in opt-dist
34272a5
So that follow-up CI commands can proceed normally. It will also avoid overwriting `config.toml` when running opt-dist tests locally.

Store libgccjit.so in a lib directory in the GCC CI tarball
38fc116

Kobzol force-pushed the gcc-ci-build-gcc branch from 74bb463 to 38fc116Compare March 13, 2025 20:33

Kobzol marked this pull request as ready for review March 13, 2025 20:33

rustbot assigned GuillaumeGomez Mar 13, 2025

antoyo reviewed Mar 13, 2025
View reviewed changes

Comment threadsrc/bootstrap/src/core/build_steps/gcc.rs Outdated

GuillaumeGomez approved these changes Mar 13, 2025
View reviewed changes

Ensure that GCC is not built using Clang, as it misbehaves
bf095f6

GuillaumeGomez approved these changes Mar 14, 2025
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2025

jhpratt mentioned this pull request Mar 14, 2025
Rollup of 6 pull requests #138486
Closed

fmease mentioned this pull request Mar 14, 2025
Rollup of 8 pull requests #138516
Closed

fmease mentioned this pull request Mar 14, 2025
Rollup of 9 pull requests #138523
Merged

bors merged commit fc7ac81 into rust-lang:masterMar 15, 2025

rustbot added this to the 1.87.0 milestone Mar 15, 2025

Kobzol deleted the gcc-ci-build-gcc branch March 15, 2025 06:11

Uh oh!

Uh oh!

Conversation

Kobzol commented Mar 13, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 13, 2025

Uh oh!

Kobzol commented Mar 13, 2025

Uh oh!

bors commented Mar 13, 2025

Uh oh!

bors commented Mar 13, 2025

Uh oh!

rustbot commented Mar 13, 2025

Uh oh!

Kobzol commented Mar 13, 2025

Uh oh!

bors commented Mar 13, 2025

Uh oh!

bors commented Mar 13, 2025

Uh oh!

rustbot commented Mar 13, 2025

Uh oh!

Kobzol commented Mar 13, 2025

Uh oh!

Uh oh!

GuillaumeGomez left a comment

Choose a reason for hiding this comment

Uh oh!

Kobzol commented Mar 14, 2025

Uh oh!

GuillaumeGomez left a comment

Choose a reason for hiding this comment

Uh oh!

Kobzol commented Mar 14, 2025

Uh oh!

bors commented Mar 14, 2025

Uh oh!

nikic commented Mar 14, 2025

Uh oh!

Kobzol commented Mar 14, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nikic commented Mar 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Kobzol commented Mar 13, 2025•
edited
Loading

Kobzol commented Mar 14, 2025•
edited
Loading