Skip to content

Refactor is_snake_case. - #138474

Merged
bors merged 1 commit into
rust-lang:masterfrom
remexre:refactor-is-snake-case
Mar 15, 2025
Merged

Refactor is_snake_case.#138474
bors merged 1 commit into
rust-lang:masterfrom
remexre:refactor-is-snake-case

Conversation

@remexre

Copy link
Copy Markdown
Contributor

I wondered what the definition of this actually was, and found the original hard to read. I believe this change preserves the original behavior, but is hopefully clearer.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 14, 2025
@compiler-errors

Copy link
Copy Markdown
Contributor

I believe this does preserve the meaning.

r? compiler-errors @bors r+ rollup

@bors

bors commented Mar 14, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit b9f0ca1 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2025
@fmeasefmease mentioned this pull request Mar 14, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 15, 2025
Rollup of 9 pull requests
Successful merges:
- rust-lang#138056 (rustc_target: Add target features for LoongArch v1.1)
- rust-lang#138451 (Build GCC on CI with GCC, not Clang)
- rust-lang#138454 (Improve post-merge workflow)
- rust-lang#138460 (Pass struct field HirId when check_expr_struct_fields)
- rust-lang#138474 (Refactor is_snake_case.)
- rust-lang#138482 (Fix HIR printing of parameters)
- rust-lang#138507 (Mirror NetBSD sources)
- rust-lang#138511 (Make `Parser::parse_expr_cond` public)
- rust-lang#138518 (Fix typo in hir lowering lint diag)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 03cda6b into rust-lang:masterMar 15, 2025
@rustbotrustbot added this to the 1.87.0 milestone Mar 15, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 15, 2025
Rollup merge of rust-lang#138474 - remexre:refactor-is-snake-case, r=compiler-errors
Refactor is_snake_case.
I wondered what the definition of this actually was, and found the original hard to read. I believe this change preserves the original behavior, but is hopefully clearer.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@remexre@rustbot@compiler-errors@bors@davidtwco