') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add missing regression GUI test by GuillaumeGomez · Pull Request #139488 · rust-lang/rust · GitHub
Skip to content

Add missing regression GUI test - #139488

Merged
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:add-missing-gui-test
Apr 10, 2025
Merged

Add missing regression GUI test#139488
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:add-missing-gui-test

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Apr 7, 2025

Copy link
Copy Markdown
Member

Add missing GUI test for #139282 (and also fixes the invalid CSS).

cc @lolbinarycat
r? @notriddle

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Apr 7, 2025
@rustbot

rustbot commented Apr 7, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

@camelid

camelid commented Apr 9, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 30f56df has been approved by camelid

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2025
@matthiaskrgrmatthiaskrgr mentioned this pull request Apr 9, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
51548ce
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit ac41b94 into rust-lang:masterApr 10, 2025
@rustbotrustbot added this to the 1.88.0 milestone Apr 10, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 10, 2025
@rust-timer
Unrolled build forrust-lang#139488
e16d455
Rollup merge of rust-lang#139488 - GuillaumeGomez:add-missing-gui-test, r=camelid
Add missing regression GUI test
Add missing GUI test for rust-lang#139282 (and also fixes the invalid CSS).
cc `@lolbinarycat`
r? `@notriddle`
@GuillaumeGomez
GuillaumeGomez deleted the add-missing-gui-test branch April 10, 2025 08:53
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 19, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
1e4dce6
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camelidcamelidcamelid approved these changes

Assignees

@notriddlenotriddle

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

5 participants

@GuillaumeGomez@rustbot@camelid@bors@notriddle