triagebot: roll compiler reviewers for rustc/unstable book - #139521

Merged
bors merged 1 commit into
rust-lang:masterfrom
jieyouxu:compiler-doc-reviewers
Apr 10, 2025
Merged

triagebot: roll compiler reviewers for rustc/unstable book#139521
bors merged 1 commit into
rust-lang:masterfrom
jieyouxu:compiler-doc-reviewers

Conversation

@jieyouxu

@jieyouxujieyouxu commented Apr 8, 2025

Copy link
Copy Markdown
Member

r? compiler

@rustbotrustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2025
@rustbot

rustbot commented Apr 8, 2025

Copy link
Copy Markdown
Collaborator

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@jieyouxu

jieyouxu commented Apr 8, 2025

Copy link
Copy Markdown
MemberAuthor

cc @GuillaumeGomez since I think I noticed you having to reroll platform support doc PRs way too frequently :D

@GuillaumeGomez

GuillaumeGomez commented Apr 8, 2025

Copy link
Copy Markdown
Member

Thank you! T_T

Contribute once and become reviewer forever. 🤣

@jieyouxu

jieyouxu commented Apr 8, 2025

Copy link
Copy Markdown
MemberAuthor

hehe

@jieyouxu

jieyouxu commented Apr 8, 2025

Copy link
Copy Markdown
MemberAuthor

This is just a triagebot change so
@bors r=@GuillaumeGomez rollup

@bors

bors commented Apr 8, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit e459db2 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2025
@jieyouxu

jieyouxu commented Apr 8, 2025

Copy link
Copy Markdown
MemberAuthor

Technically unstable-book also has library/language features, but at least compiler is more likely to be the right set of reviewers.

@ehuss

ehuss commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

I'd like to stay a reviewer on /src/doc/rustc since I've written a lot of content there. Also, please CC me when removing me from rotation.

@jieyouxu

jieyouxu commented Apr 8, 2025

Copy link
Copy Markdown
MemberAuthor

Oh yeah sorry
@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 8, 2025
@jieyouxu

jieyouxu commented Apr 8, 2025

Copy link
Copy Markdown
MemberAuthor

Right, a more specific directory will remove u from rotation...

@jieyouxu
jieyouxuforce-pushed the compiler-doc-reviewers branch 2 times, most recently from 11eadf5 to cbf4da2CompareApril 8, 2025 13:58
@jieyouxu

jieyouxu commented Apr 8, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@ehuss sorry about that, didn't mean to remove you from rotation. Does the revised entries correctly preserve you on rotation (for unstable-book as well)?

@jieyouxu

jieyouxu commented Apr 8, 2025

Copy link
Copy Markdown
MemberAuthor

r? @ehuss
@rustbot ready

@rustbotrustbot assigned ehuss and unassigned GuillaumeGomezApr 8, 2025
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 8, 2025
ehuss
ehuss reviewed Apr 8, 2025
View reviewed changes

@ehussehuss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to approve with the suggestion applied.

Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.

Comment threadtriagebot.toml Outdated
@jieyouxu

jieyouxu commented Apr 8, 2025

Copy link
Copy Markdown
MemberAuthor

Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.

Hm yeah. Maybe a triagebot mention but that is potentially quite noisy.

@jieyouxujieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2025
@ehuss

ehuss commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

Yea, don't worry about it. I see the titles of most new PRs and can peek if I care.

@jieyouxu
jieyouxuforce-pushed the compiler-doc-reviewers branch from cbf4da2 to 616406dCompareApril 8, 2025 23:38
@jieyouxu

jieyouxu commented Apr 8, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Changed unstable-book entry as requested.
@bors r=GuillaumeGomez,ehuss rollup

@bors

bors commented Apr 8, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 616406d has been approved by GuillaumeGomez,ehuss

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 8, 2025
@matthiaskrgrmatthiaskrgr mentioned this pull request Apr 9, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
51548ce
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 78e59af into rust-lang:masterApr 10, 2025
@rustbotrustbot added this to the 1.88.0 milestone Apr 10, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 10, 2025
@rust-timer
Unrolled build forrust-lang#139521
7dc8e0d
Rollup merge of rust-lang#139521 - jieyouxu:compiler-doc-reviewers, r=GuillaumeGomez,ehuss
triagebot: roll compiler reviewers for rustc/unstable book
r? compiler
@jieyouxu
jieyouxu deleted the compiler-doc-reviewers branch April 10, 2025 01:42
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 19, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
1e4dce6
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes
+1 more reviewer
@ehussehussehuss left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ehussehuss

Labels

A-metaArea: Issues & PRs about the rust-lang/rust repository itselfS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jieyouxu@rustbot@GuillaumeGomez@bors@ehuss@estebank
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
triagebot: roll compiler reviewers for rustc/unstable book - #139521
Merged
bors merged 1 commit into
rust-lang:masterfrom 
jieyouxu:compiler-doc-reviewers
Apr 10, 2025
Merged
triagebot: roll compiler reviewers for rustc/unstable book#139521
bors merged 1 commit into
rust-lang:masterfrom 
jieyouxu:compiler-doc-reviewers
Conversation
@jieyouxu
@jieyouxujieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

Member
r? compiler
@rustbotrustbot
added

A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@rustbot
rustbot
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
triagebot.toml has been modified, there may have been changes to the review queue.
cc @davidtwco, @wesleywiser
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
cc @GuillaumeGomez since I think I noticed you having to reroll platform support doc PRs way too frequently :D
@GuillaumeGomez
GuillaumeGomez
commented
Apr 8, 2025

Copy link


Copy Markdown

Member
Thank you! T_T
Contribute once and become reviewer forever. 🤣
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
hehe
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
This is just a triagebot change so
@bors r=@GuillaumeGomez rollup
@bors
bors
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit e459db2 has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Technically unstable-book also has library/language features, but at least compiler is more likely to be the right set of reviewers.
@ehuss
ehuss
commented
Apr 8, 2025

Copy link


Copy Markdown

Contributor
I'd like to stay a reviewer on /src/doc/rustc since I've written a lot of content there. Also, please CC me when removing me from rotation.
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Oh yeah sorry
@bors r-
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 8, 2025
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Right, a more specific directory will remove u from rotation...
@jieyouxu
jieyouxuforce-pushed
the
compiler-doc-reviewers
branch
2 times, most recently
from
11eadf5 to
cbf4da2CompareApril 8, 2025 13:58
@jieyouxu
jieyouxu
commented
Apr 8, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@ehuss sorry about that, didn't mean to remove you from rotation. Does the revised entries correctly preserve you on rotation (for unstable-book as well)?
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
r? @ehuss
@rustbot ready
@rustbotrustbot
assigned ehuss and unassigned GuillaumeGomezApr 8, 2025
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 8, 2025
ehuss
ehuss
reviewed
Apr 8, 2025
View reviewed changes
@ehussehuss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to approve with the suggestion applied.
Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.
Comment threadtriagebot.toml
Outdated

@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.
Hm yeah. Maybe a triagebot mention but that is potentially quite noisy.
@jieyouxujieyouxu
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@ehuss
ehuss
commented
Apr 8, 2025

Copy link


Copy Markdown

Contributor
Yea, don't worry about it. I see the titles of most new PRs and can peek if I care.
@jieyouxu
jieyouxuforce-pushed
the
compiler-doc-reviewers
branch
from
cbf4da2 to
616406dCompareApril 8, 2025 23:38
@jieyouxu
jieyouxu
commented
Apr 8, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Changed unstable-book entry as requested.
@bors r=GuillaumeGomez,ehuss rollup
@bors
bors
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 616406d has been approved by GuillaumeGomez,ehuss
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 8, 2025
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Apr 9, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 9, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
51548ce
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 78e59af
into
rust-lang:masterApr 10, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 10, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2025
@rust-timer
Unrolled build forrust-lang#139521
7dc8e0d
Rollup merge of rust-lang#139521 - jieyouxu:compiler-doc-reviewers, r=GuillaumeGomez,ehuss
triagebot: roll compiler reviewers for rustc/unstable book
r? compiler
@jieyouxu
jieyouxu
deleted the

compiler-doc-reviewers

branch
April 10, 2025 01:42
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 19, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
1e4dce6
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

+1 more reviewer

@ehussehussehuss left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ehussehuss

Labels

A-metaArea: Issues & PRs about the rust-lang/rust repository itselfS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jieyouxu@rustbot@GuillaumeGomez@bors@ehuss@estebank

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
triagebot: roll compiler reviewers for rustc/unstable book - #139521
Merged
bors merged 1 commit into
rust-lang:masterfrom 
jieyouxu:compiler-doc-reviewers
Apr 10, 2025
Merged
triagebot: roll compiler reviewers for rustc/unstable book#139521
bors merged 1 commit into
rust-lang:masterfrom 
jieyouxu:compiler-doc-reviewers
Conversation
@jieyouxu
@jieyouxujieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

Member
r? compiler
@rustbotrustbot
added

A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@rustbot
rustbot
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
triagebot.toml has been modified, there may have been changes to the review queue.
cc @davidtwco, @wesleywiser
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
cc @GuillaumeGomez since I think I noticed you having to reroll platform support doc PRs way too frequently :D
@GuillaumeGomez
GuillaumeGomez
commented
Apr 8, 2025

Copy link


Copy Markdown

Member
Thank you! T_T
Contribute once and become reviewer forever. 🤣
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
hehe
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
This is just a triagebot change so
@bors r=@GuillaumeGomez rollup
@bors
bors
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit e459db2 has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Technically unstable-book also has library/language features, but at least compiler is more likely to be the right set of reviewers.
@ehuss
ehuss
commented
Apr 8, 2025

Copy link


Copy Markdown

Contributor
I'd like to stay a reviewer on /src/doc/rustc since I've written a lot of content there. Also, please CC me when removing me from rotation.
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Oh yeah sorry
@bors r-
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 8, 2025
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Right, a more specific directory will remove u from rotation...
@jieyouxu
jieyouxuforce-pushed
the
compiler-doc-reviewers
branch
2 times, most recently
from
11eadf5 to
cbf4da2CompareApril 8, 2025 13:58
@jieyouxu
jieyouxu
commented
Apr 8, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@ehuss sorry about that, didn't mean to remove you from rotation. Does the revised entries correctly preserve you on rotation (for unstable-book as well)?
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
r? @ehuss
@rustbot ready
@rustbotrustbot
assigned ehuss and unassigned GuillaumeGomezApr 8, 2025
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 8, 2025
ehuss
ehuss
reviewed
Apr 8, 2025
View reviewed changes
@ehussehuss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to approve with the suggestion applied.
Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.
Comment threadtriagebot.toml
Outdated

@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.
Hm yeah. Maybe a triagebot mention but that is potentially quite noisy.
@jieyouxujieyouxu
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@ehuss
ehuss
commented
Apr 8, 2025

Copy link


Copy Markdown

Contributor
Yea, don't worry about it. I see the titles of most new PRs and can peek if I care.
@jieyouxu
jieyouxuforce-pushed
the
compiler-doc-reviewers
branch
from
cbf4da2 to
616406dCompareApril 8, 2025 23:38
@jieyouxu
jieyouxu
commented
Apr 8, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Changed unstable-book entry as requested.
@bors r=GuillaumeGomez,ehuss rollup
@bors
bors
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 616406d has been approved by GuillaumeGomez,ehuss
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 8, 2025
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Apr 9, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 9, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
51548ce
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 78e59af
into
rust-lang:masterApr 10, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 10, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2025
@rust-timer
Unrolled build forrust-lang#139521
7dc8e0d
Rollup merge of rust-lang#139521 - jieyouxu:compiler-doc-reviewers, r=GuillaumeGomez,ehuss
triagebot: roll compiler reviewers for rustc/unstable book
r? compiler
@jieyouxu
jieyouxu
deleted the

compiler-doc-reviewers

branch
April 10, 2025 01:42
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 19, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
1e4dce6
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

+1 more reviewer

@ehussehussehuss left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ehussehuss

Labels

A-metaArea: Issues & PRs about the rust-lang/rust repository itselfS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jieyouxu@rustbot@GuillaumeGomez@bors@ehuss@estebank

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
triagebot: roll compiler reviewers for rustc/unstable book - #139521
Merged
bors merged 1 commit into
rust-lang:masterfrom 
jieyouxu:compiler-doc-reviewers
Apr 10, 2025
Merged
triagebot: roll compiler reviewers for rustc/unstable book#139521
bors merged 1 commit into
rust-lang:masterfrom 
jieyouxu:compiler-doc-reviewers
Conversation
@jieyouxu
@jieyouxujieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

Member
r? compiler
@rustbotrustbot
added

A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@rustbot
rustbot
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
triagebot.toml has been modified, there may have been changes to the review queue.
cc @davidtwco, @wesleywiser
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
cc @GuillaumeGomez since I think I noticed you having to reroll platform support doc PRs way too frequently :D
@GuillaumeGomez
GuillaumeGomez
commented
Apr 8, 2025

Copy link


Copy Markdown

Member
Thank you! T_T
Contribute once and become reviewer forever. 🤣
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
hehe
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
This is just a triagebot change so
@bors r=@GuillaumeGomez rollup
@bors
bors
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit e459db2 has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Technically unstable-book also has library/language features, but at least compiler is more likely to be the right set of reviewers.
@ehuss
ehuss
commented
Apr 8, 2025

Copy link


Copy Markdown

Contributor
I'd like to stay a reviewer on /src/doc/rustc since I've written a lot of content there. Also, please CC me when removing me from rotation.
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Oh yeah sorry
@bors r-
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 8, 2025
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Right, a more specific directory will remove u from rotation...
@jieyouxu
jieyouxuforce-pushed
the
compiler-doc-reviewers
branch
2 times, most recently
from
11eadf5 to
cbf4da2CompareApril 8, 2025 13:58
@jieyouxu
jieyouxu
commented
Apr 8, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@ehuss sorry about that, didn't mean to remove you from rotation. Does the revised entries correctly preserve you on rotation (for unstable-book as well)?
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
r? @ehuss
@rustbot ready
@rustbotrustbot
assigned ehuss and unassigned GuillaumeGomezApr 8, 2025
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 8, 2025
ehuss
ehuss
reviewed
Apr 8, 2025
View reviewed changes
@ehussehuss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to approve with the suggestion applied.
Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.
Comment threadtriagebot.toml
Outdated

@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.
Hm yeah. Maybe a triagebot mention but that is potentially quite noisy.
@jieyouxujieyouxu
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@ehuss
ehuss
commented
Apr 8, 2025

Copy link


Copy Markdown

Contributor
Yea, don't worry about it. I see the titles of most new PRs and can peek if I care.
@jieyouxu
jieyouxuforce-pushed
the
compiler-doc-reviewers
branch
from
cbf4da2 to
616406dCompareApril 8, 2025 23:38
@jieyouxu
jieyouxu
commented
Apr 8, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Changed unstable-book entry as requested.
@bors r=GuillaumeGomez,ehuss rollup
@bors
bors
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 616406d has been approved by GuillaumeGomez,ehuss
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 8, 2025
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Apr 9, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 9, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
51548ce
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 78e59af
into
rust-lang:masterApr 10, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 10, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2025
@rust-timer
Unrolled build forrust-lang#139521
7dc8e0d
Rollup merge of rust-lang#139521 - jieyouxu:compiler-doc-reviewers, r=GuillaumeGomez,ehuss
triagebot: roll compiler reviewers for rustc/unstable book
r? compiler
@jieyouxu
jieyouxu
deleted the

compiler-doc-reviewers

branch
April 10, 2025 01:42
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 19, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
1e4dce6
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

+1 more reviewer

@ehussehussehuss left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ehussehuss

Labels

A-metaArea: Issues & PRs about the rust-lang/rust repository itselfS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jieyouxu@rustbot@GuillaumeGomez@bors@ehuss@estebank

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
triagebot: roll compiler reviewers for rustc/unstable book - #139521
Merged
bors merged 1 commit into
rust-lang:masterfrom 
jieyouxu:compiler-doc-reviewers
Apr 10, 2025
Merged
triagebot: roll compiler reviewers for rustc/unstable book#139521
bors merged 1 commit into
rust-lang:masterfrom 
jieyouxu:compiler-doc-reviewers
Conversation
@jieyouxu
@jieyouxujieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

Member
r? compiler
@rustbotrustbot
added

A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@rustbot
rustbot
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
triagebot.toml has been modified, there may have been changes to the review queue.
cc @davidtwco, @wesleywiser
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
cc @GuillaumeGomez since I think I noticed you having to reroll platform support doc PRs way too frequently :D
@GuillaumeGomez
GuillaumeGomez
commented
Apr 8, 2025

Copy link


Copy Markdown

Member
Thank you! T_T
Contribute once and become reviewer forever. 🤣
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
hehe
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
This is just a triagebot change so
@bors r=@GuillaumeGomez rollup
@bors
bors
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit e459db2 has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Technically unstable-book also has library/language features, but at least compiler is more likely to be the right set of reviewers.
@ehuss
ehuss
commented
Apr 8, 2025

Copy link


Copy Markdown

Contributor
I'd like to stay a reviewer on /src/doc/rustc since I've written a lot of content there. Also, please CC me when removing me from rotation.
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Oh yeah sorry
@bors r-
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 8, 2025
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Right, a more specific directory will remove u from rotation...
@jieyouxu
jieyouxuforce-pushed
the
compiler-doc-reviewers
branch
2 times, most recently
from
11eadf5 to
cbf4da2CompareApril 8, 2025 13:58
@jieyouxu
jieyouxu
commented
Apr 8, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@ehuss sorry about that, didn't mean to remove you from rotation. Does the revised entries correctly preserve you on rotation (for unstable-book as well)?
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
r? @ehuss
@rustbot ready
@rustbotrustbot
assigned ehuss and unassigned GuillaumeGomezApr 8, 2025
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 8, 2025
ehuss
ehuss
reviewed
Apr 8, 2025
View reviewed changes
@ehussehuss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to approve with the suggestion applied.
Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.
Comment threadtriagebot.toml
Outdated

@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.
Hm yeah. Maybe a triagebot mention but that is potentially quite noisy.
@jieyouxujieyouxu
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@ehuss
ehuss
commented
Apr 8, 2025

Copy link


Copy Markdown

Contributor
Yea, don't worry about it. I see the titles of most new PRs and can peek if I care.
@jieyouxu
jieyouxuforce-pushed
the
compiler-doc-reviewers
branch
from
cbf4da2 to
616406dCompareApril 8, 2025 23:38
@jieyouxu
jieyouxu
commented
Apr 8, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Changed unstable-book entry as requested.
@bors r=GuillaumeGomez,ehuss rollup
@bors
bors
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 616406d has been approved by GuillaumeGomez,ehuss
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 8, 2025
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Apr 9, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 9, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
51548ce
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 78e59af
into
rust-lang:masterApr 10, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 10, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2025
@rust-timer
Unrolled build forrust-lang#139521
7dc8e0d
Rollup merge of rust-lang#139521 - jieyouxu:compiler-doc-reviewers, r=GuillaumeGomez,ehuss
triagebot: roll compiler reviewers for rustc/unstable book
r? compiler
@jieyouxu
jieyouxu
deleted the

compiler-doc-reviewers

branch
April 10, 2025 01:42
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 19, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
1e4dce6
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

+1 more reviewer

@ehussehussehuss left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ehussehuss

Labels

A-metaArea: Issues & PRs about the rust-lang/rust repository itselfS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jieyouxu@rustbot@GuillaumeGomez@bors@ehuss@estebank

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
triagebot: roll compiler reviewers for rustc/unstable book - #139521
Merged
bors merged 1 commit into
rust-lang:masterfrom 
jieyouxu:compiler-doc-reviewers
Apr 10, 2025
Merged
triagebot: roll compiler reviewers for rustc/unstable book#139521
bors merged 1 commit into
rust-lang:masterfrom 
jieyouxu:compiler-doc-reviewers
Conversation
@jieyouxu
@jieyouxujieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

Member
r? compiler
@rustbotrustbot
added

A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@rustbot
rustbot
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
triagebot.toml has been modified, there may have been changes to the review queue.
cc @davidtwco, @wesleywiser
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
cc @GuillaumeGomez since I think I noticed you having to reroll platform support doc PRs way too frequently :D
@GuillaumeGomez
GuillaumeGomez
commented
Apr 8, 2025

Copy link


Copy Markdown

Member
Thank you! T_T
Contribute once and become reviewer forever. 🤣
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
hehe
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
This is just a triagebot change so
@bors r=@GuillaumeGomez rollup
@bors
bors
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit e459db2 has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Technically unstable-book also has library/language features, but at least compiler is more likely to be the right set of reviewers.
@ehuss
ehuss
commented
Apr 8, 2025

Copy link


Copy Markdown

Contributor
I'd like to stay a reviewer on /src/doc/rustc since I've written a lot of content there. Also, please CC me when removing me from rotation.
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Oh yeah sorry
@bors r-
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 8, 2025
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Right, a more specific directory will remove u from rotation...
@jieyouxu
jieyouxuforce-pushed
the
compiler-doc-reviewers
branch
2 times, most recently
from
11eadf5 to
cbf4da2CompareApril 8, 2025 13:58
@jieyouxu
jieyouxu
commented
Apr 8, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@ehuss sorry about that, didn't mean to remove you from rotation. Does the revised entries correctly preserve you on rotation (for unstable-book as well)?
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
r? @ehuss
@rustbot ready
@rustbotrustbot
assigned ehuss and unassigned GuillaumeGomezApr 8, 2025
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 8, 2025
ehuss
ehuss
reviewed
Apr 8, 2025
View reviewed changes
@ehussehuss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to approve with the suggestion applied.
Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.
Comment threadtriagebot.toml
Outdated

@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.
Hm yeah. Maybe a triagebot mention but that is potentially quite noisy.
@jieyouxujieyouxu
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@ehuss
ehuss
commented
Apr 8, 2025

Copy link


Copy Markdown

Contributor
Yea, don't worry about it. I see the titles of most new PRs and can peek if I care.
@jieyouxu
jieyouxuforce-pushed
the
compiler-doc-reviewers
branch
from
cbf4da2 to
616406dCompareApril 8, 2025 23:38
@jieyouxu
jieyouxu
commented
Apr 8, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Changed unstable-book entry as requested.
@bors r=GuillaumeGomez,ehuss rollup
@bors
bors
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 616406d has been approved by GuillaumeGomez,ehuss
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 8, 2025
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Apr 9, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 9, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
51548ce
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 78e59af
into
rust-lang:masterApr 10, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 10, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2025
@rust-timer
Unrolled build forrust-lang#139521
7dc8e0d
Rollup merge of rust-lang#139521 - jieyouxu:compiler-doc-reviewers, r=GuillaumeGomez,ehuss
triagebot: roll compiler reviewers for rustc/unstable book
r? compiler
@jieyouxu
jieyouxu
deleted the

compiler-doc-reviewers

branch
April 10, 2025 01:42
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 19, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
1e4dce6
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

+1 more reviewer

@ehussehussehuss left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ehussehuss

Labels

A-metaArea: Issues & PRs about the rust-lang/rust repository itselfS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jieyouxu@rustbot@GuillaumeGomez@bors@ehuss@estebank

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
triagebot: roll compiler reviewers for rustc/unstable book - #139521
Merged
bors merged 1 commit into
rust-lang:masterfrom 
jieyouxu:compiler-doc-reviewers
Apr 10, 2025
Merged
triagebot: roll compiler reviewers for rustc/unstable book#139521
bors merged 1 commit into
rust-lang:masterfrom 
jieyouxu:compiler-doc-reviewers
Conversation
@jieyouxu
@jieyouxujieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

Member
r? compiler
@rustbotrustbot
added

A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@rustbot
rustbot
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
triagebot.toml has been modified, there may have been changes to the review queue.
cc @davidtwco, @wesleywiser
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
cc @GuillaumeGomez since I think I noticed you having to reroll platform support doc PRs way too frequently :D
@GuillaumeGomez
GuillaumeGomez
commented
Apr 8, 2025

Copy link


Copy Markdown

Member
Thank you! T_T
Contribute once and become reviewer forever. 🤣
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
hehe
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
This is just a triagebot change so
@bors r=@GuillaumeGomez rollup
@bors
bors
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit e459db2 has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Technically unstable-book also has library/language features, but at least compiler is more likely to be the right set of reviewers.
@ehuss
ehuss
commented
Apr 8, 2025

Copy link


Copy Markdown

Contributor
I'd like to stay a reviewer on /src/doc/rustc since I've written a lot of content there. Also, please CC me when removing me from rotation.
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Oh yeah sorry
@bors r-
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 8, 2025
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Right, a more specific directory will remove u from rotation...
@jieyouxu
jieyouxuforce-pushed
the
compiler-doc-reviewers
branch
2 times, most recently
from
11eadf5 to
cbf4da2CompareApril 8, 2025 13:58
@jieyouxu
jieyouxu
commented
Apr 8, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@ehuss sorry about that, didn't mean to remove you from rotation. Does the revised entries correctly preserve you on rotation (for unstable-book as well)?
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
r? @ehuss
@rustbot ready
@rustbotrustbot
assigned ehuss and unassigned GuillaumeGomezApr 8, 2025
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 8, 2025
ehuss
ehuss
reviewed
Apr 8, 2025
View reviewed changes
@ehussehuss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to approve with the suggestion applied.
Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.
Comment threadtriagebot.toml
Outdated

@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.
Hm yeah. Maybe a triagebot mention but that is potentially quite noisy.
@jieyouxujieyouxu
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@ehuss
ehuss
commented
Apr 8, 2025

Copy link


Copy Markdown

Contributor
Yea, don't worry about it. I see the titles of most new PRs and can peek if I care.
@jieyouxu
jieyouxuforce-pushed
the
compiler-doc-reviewers
branch
from
cbf4da2 to
616406dCompareApril 8, 2025 23:38
@jieyouxu
jieyouxu
commented
Apr 8, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Changed unstable-book entry as requested.
@bors r=GuillaumeGomez,ehuss rollup
@bors
bors
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 616406d has been approved by GuillaumeGomez,ehuss
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 8, 2025
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Apr 9, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 9, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
51548ce
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 78e59af
into
rust-lang:masterApr 10, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 10, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2025
@rust-timer
Unrolled build forrust-lang#139521
7dc8e0d
Rollup merge of rust-lang#139521 - jieyouxu:compiler-doc-reviewers, r=GuillaumeGomez,ehuss
triagebot: roll compiler reviewers for rustc/unstable book
r? compiler
@jieyouxu
jieyouxu
deleted the

compiler-doc-reviewers

branch
April 10, 2025 01:42
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 19, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
1e4dce6
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

+1 more reviewer

@ehussehussehuss left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ehussehuss

Labels

A-metaArea: Issues & PRs about the rust-lang/rust repository itselfS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jieyouxu@rustbot@GuillaumeGomez@bors@ehuss@estebank

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
triagebot: roll compiler reviewers for rustc/unstable book - #139521
Merged
bors merged 1 commit into
rust-lang:masterfrom 
jieyouxu:compiler-doc-reviewers
Apr 10, 2025
Merged
triagebot: roll compiler reviewers for rustc/unstable book#139521
bors merged 1 commit into
rust-lang:masterfrom 
jieyouxu:compiler-doc-reviewers
Conversation
@jieyouxu
@jieyouxujieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

Member
r? compiler
@rustbotrustbot
added

A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@rustbot
rustbot
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
triagebot.toml has been modified, there may have been changes to the review queue.
cc @davidtwco, @wesleywiser
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
cc @GuillaumeGomez since I think I noticed you having to reroll platform support doc PRs way too frequently :D
@GuillaumeGomez
GuillaumeGomez
commented
Apr 8, 2025

Copy link


Copy Markdown

Member
Thank you! T_T
Contribute once and become reviewer forever. 🤣
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
hehe
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
This is just a triagebot change so
@bors r=@GuillaumeGomez rollup
@bors
bors
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit e459db2 has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Technically unstable-book also has library/language features, but at least compiler is more likely to be the right set of reviewers.
@ehuss
ehuss
commented
Apr 8, 2025

Copy link


Copy Markdown

Contributor
I'd like to stay a reviewer on /src/doc/rustc since I've written a lot of content there. Also, please CC me when removing me from rotation.
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Oh yeah sorry
@bors r-
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 8, 2025
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Right, a more specific directory will remove u from rotation...
@jieyouxu
jieyouxuforce-pushed
the
compiler-doc-reviewers
branch
2 times, most recently
from
11eadf5 to
cbf4da2CompareApril 8, 2025 13:58
@jieyouxu
jieyouxu
commented
Apr 8, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
@ehuss sorry about that, didn't mean to remove you from rotation. Does the revised entries correctly preserve you on rotation (for unstable-book as well)?
@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
r? @ehuss
@rustbot ready
@rustbotrustbot
assigned ehuss and unassigned GuillaumeGomezApr 8, 2025
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 8, 2025
ehuss
ehuss
reviewed
Apr 8, 2025
View reviewed changes
@ehussehuss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to approve with the suggestion applied.
Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.
Comment threadtriagebot.toml
Outdated

@jieyouxu
jieyouxu
commented
Apr 8, 2025

Copy link


Copy Markdown

MemberAuthor
Thinking more, the chances that I'll get assigned amongst the entire compiler team is vanishingly small since there are so few PRs and so many reviewers. But I'm fine with that I think.
Hm yeah. Maybe a triagebot mention but that is potentially quite noisy.
@jieyouxujieyouxu
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 8, 2025
@ehuss
ehuss
commented
Apr 8, 2025

Copy link


Copy Markdown

Contributor
Yea, don't worry about it. I see the titles of most new PRs and can peek if I care.
@jieyouxu
jieyouxuforce-pushed
the
compiler-doc-reviewers
branch
from
cbf4da2 to
616406dCompareApril 8, 2025 23:38
@jieyouxu
jieyouxu
commented
Apr 8, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Changed unstable-book entry as requested.
@bors r=GuillaumeGomez,ehuss rollup
@bors
bors
commented
Apr 8, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 616406d has been approved by GuillaumeGomez,ehuss
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 8, 2025
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Apr 9, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 9, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
51548ce
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 78e59af
into
rust-lang:masterApr 10, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 10, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2025
@rust-timer
Unrolled build forrust-lang#139521
7dc8e0d
Rollup merge of rust-lang#139521 - jieyouxu:compiler-doc-reviewers, r=GuillaumeGomez,ehuss
triagebot: roll compiler reviewers for rustc/unstable book
r? compiler
@jieyouxu
jieyouxu
deleted the

compiler-doc-reviewers

branch
April 10, 2025 01:42
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 19, 2025
@bors
Auto merge ofrust-lang#139595- matthiaskrgr:rollup-kaa8aim, r=matth…
1e4dce6
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138470 (Test interaction between RFC 2229 migration and use closures)
- rust-lang#138628 (Add more ergonomic clone tests)
- rust-lang#139164 (std: improve documentation for get_mut() methods regarding forgotten guards)
- rust-lang#139488 (Add missing regression GUI test)
- rust-lang#139489 (compiletest: Add directive `dont-require-annotations`)
- rust-lang#139513 (Report higher-ranked trait error when higher-ranked projection goal fails in new solver)
- rust-lang#139521 (triagebot: roll compiler reviewers for rustc/unstable book)
- rust-lang#139532 (Update `u8`-to-and-from-`i8` suggestions.)
- rust-lang#139551 (report call site of inlined scopes for large assignment lints)
- rust-lang#139575 (Remove redundant words)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

+1 more reviewer

@ehussehussehuss left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ehussehuss

Labels

A-metaArea: Issues & PRs about the rust-lang/rust repository itselfS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jieyouxu@rustbot@GuillaumeGomez@bors@ehuss@estebank