ci: use aws codebuild for the dist-x86_64-linux job - #140349

Merged
bors merged 1 commit into
rust-lang:masterfrom
marcoieni:codebuild-linux-large-runners
Apr 28, 2025
Merged

ci: use aws codebuild for the dist-x86_64-linux job#140349
bors merged 1 commit into
rust-lang:masterfrom
marcoieni:codebuild-linux-large-runners

Conversation

@marcoieni

@marcoienimarcoieni commented Apr 26, 2025•
edited by Kobzol
Loading

Copy link
Copy Markdown
Member

r? @ghost

We want to use aws credits for linux runners.

try-job: dist-x86_64-linux

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 26, 2025
@marcoieni

marcoieni commented Apr 26, 2025

Copy link
Copy Markdown
MemberAuthor

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
1c29b93
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
try-job: x86_64-gnu-distcheck
@bors

bors commented Apr 26, 2025

Copy link
Copy Markdown
Collaborator

⌛ Trying commit c2922b4 with merge 1c29b93...

@bors

bors commented Apr 26, 2025

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@marcoieni
marcoieniforce-pushed the codebuild-linux-large-runners branch 3 times, most recently from 48990e2 to ed20b7fCompareApril 27, 2025 09:11
@marcoieni

marcoieni commented Apr 27, 2025

Copy link
Copy Markdown
MemberAuthor

@bors try

@bors

bors commented Apr 27, 2025

Copy link
Copy Markdown
Collaborator

⌛ Trying commit ed20b7f with merge 51349b0...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
51349b0
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors

bors commented Apr 27, 2025

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 51349b0 (51349b0d6ae41043c5e7b4925d19f587cdeb7c72)

@Kobzol

Kobzol commented Apr 27, 2025

Copy link
Copy Markdown
Member

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
0148c0b
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors

bors commented Apr 27, 2025

Copy link
Copy Markdown
Collaborator

⌛ Trying commit ed20b7f with merge 0148c0b...

@bors

bors commented Apr 27, 2025

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 0148c0b (0148c0b5e1aa4da2470d93e88991a3cb8e2148a1)

@marcoieni

marcoieni commented Apr 27, 2025

Copy link
Copy Markdown
MemberAuthor

@bors try

@bors

bors commented Apr 27, 2025

Copy link
Copy Markdown
Collaborator

⌛ Trying commit ed20b7f with merge 59ef764...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
59ef764
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@marcoieni

marcoieni commented Apr 27, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

oh I didn't see you already retried Jakub. It's quite weird that with 36 cores the jobs take so long. Maybe GitHub runners have faster cores? Or maybe some caching is not working. We need to analyze the logs.
image

@bors

bors commented Apr 27, 2025

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 59ef764 (59ef764abee62044f1dc9818d9ccc95f65d962ef)

@marcoieni

marcoieni commented Apr 28, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I compared the logs for the dist-x86_64-linux-alt job (try build vs auto build in rust-lang-ci). Building LLVM takes 2x in the try build. Not sure why.

EDIT: I was comparing things in the wrong way. Apparently compiling llvm in the try job is faster. I need to check where the try job is slower.

@marcoieni
marcoieniforce-pushed the codebuild-linux-large-runners branch from ed20b7f to 7bc2b01CompareApril 28, 2025 06:46
@marcoienimarcoieni changed the title ci: use aws codebuild for x86 linux large runnersci: use aws codebuild for the dist-x86_64-linux jobApr 28, 2025
@marcoieni
marcoieniforce-pushed the codebuild-linux-large-runners branch from 7bc2b01 to 480d007CompareApril 28, 2025 06:48
@marcoieni

marcoieni commented Apr 28, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I don't know why the alt job is that slow. I edited this PR to only convert the dist-x86_64-linux job for now.

Imo this PR can be a rollup because we tried this job multiple times.

@marcoieni
marcoieni marked this pull request as ready for review April 28, 2025 06:48
@marcoieni

marcoieni commented Apr 28, 2025

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 28, 2025
@marcoieni
marcoieni requested a review from KobzolApril 28, 2025 06:50
@Kobzol

Kobzol commented Apr 28, 2025

Copy link
Copy Markdown
Member

Hmm, it's weird. Most of the bootstrap steps were faster, some of them significantly, but the run as a whole was ~15 minutes slower. sccache stats also look good in both. I tried to go through both logs in parallel, but haven't found anything useful, it would be great to have some visualization of the log timeline. It's like the slowdown happened in between bootstrap steps or something.

But otherwise it looks fine.

@bors r+

@bors

bors commented Apr 28, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 480d007 has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2025
@GuillaumeGomezGuillaumeGomez mentioned this pull request Apr 28, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
25cdf1f
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 117202e into rust-lang:masterApr 28, 2025
@rustbotrustbot added this to the 1.88.0 milestone Apr 28, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2025
@rust-timer
Unrolled build forrust-lang#140349
58cb389
Rollup merge of rust-lang#140349 - marcoieni:codebuild-linux-large-runners, r=Kobzol
ci: use aws codebuild for the `dist-x86_64-linux` job
try-job: dist-x86_64-linux
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KobzolKobzolAwaiting requested review from Kobzol

Assignees

No one assigned

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

5 participants

@marcoieni@bors@rust-log-analyzer@Kobzol@rustbot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ci: use aws codebuild for the dist-x86_64-linux job - #140349
Merged
bors merged 1 commit into
rust-lang:masterfrom 
marcoieni:codebuild-linux-large-runners
Apr 28, 2025
Merged
ci: use aws codebuild for the dist-x86_64-linux job#140349
bors merged 1 commit into
rust-lang:masterfrom 
marcoieni:codebuild-linux-large-runners
Conversation
@marcoieni
@marcoienimarcoieni
commented
Apr 26, 2025•

edited by Kobzol

Loading

Copy link


Copy Markdown

Member
r? @ghost
We want to use aws credits for linux runners.
try-job: dist-x86_64-linux
@rustbotrustbot
added

A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
Apr 26, 2025
@marcoieni
marcoieni
commented
Apr 26, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
1c29b93
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
try-job: x86_64-gnu-distcheck
@bors
bors
commented
Apr 26, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit c2922b4 with merge 1c29b93...
@bors
bors
commented
Apr 26, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 26, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
3 times, most recently
from
48990e2 to
ed20b7fCompareApril 27, 2025 09:11
@marcoieni
marcoieni
commented
Apr 27, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 51349b0...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
51349b0
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 51349b0 (51349b0d6ae41043c5e7b4925d19f587cdeb7c72)
@Kobzol
Kobzol
commented
Apr 27, 2025

Copy link


Copy Markdown

Member
@bors try
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
0148c0b
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 0148c0b...
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 0148c0b (0148c0b5e1aa4da2470d93e88991a3cb8e2148a1)
@marcoieni
marcoieni
commented
Apr 27, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 59ef764...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
59ef764
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@marcoieni
marcoieni
commented
Apr 27, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
oh I didn't see you already retried Jakub. It's quite weird that with 36 cores the jobs take so long. Maybe GitHub runners have faster cores? Or maybe some caching is not working. We need to analyze the logs.
image
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 59ef764 (59ef764abee62044f1dc9818d9ccc95f65d962ef)
@marcoieni
marcoieni
commented
Apr 28, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I compared the logs for the dist-x86_64-linux-alt job (try build vs auto build in rust-lang-ci). Building LLVM takes 2x in the try build. Not sure why.
EDIT: I was comparing things in the wrong way. Apparently compiling llvm in the try job is faster. I need to check where the try job is slower.
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
from
ed20b7f to
7bc2b01CompareApril 28, 2025 06:46
@marcoienimarcoieni
changed the title
ci: use aws codebuild for x86 linux large runnersci: use aws codebuild for the dist-x86_64-linux jobApr 28, 2025
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
from
7bc2b01 to
480d007CompareApril 28, 2025 06:48
@marcoieni
marcoieni
commented
Apr 28, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I don't know why the alt job is that slow. I edited this PR to only convert the dist-x86_64-linux job for now.
Imo this PR can be a rollup because we tried this job multiple times.
@marcoieni
marcoieni
marked this pull request as ready for review
April 28, 2025 06:48
@marcoieni
marcoieni
commented
Apr 28, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 28, 2025
@marcoieni
marcoieni
requested a review
from KobzolApril 28, 2025 06:50
@Kobzol
Kobzol
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
Hmm, it's weird. Most of the bootstrap steps were faster, some of them significantly, but the run as a whole was ~15 minutes slower. sccache stats also look good in both. I tried to go through both logs in parallel, but haven't found anything useful, it would be great to have some visualization of the log timeline. It's like the slowdown happened in between bootstrap steps or something.
But otherwise it looks fine.
@bors r+
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 480d007 has been approved by Kobzol
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Apr 28, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
25cdf1f
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 117202e
into
rust-lang:masterApr 28, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 28, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@rust-timer
Unrolled build forrust-lang#140349
58cb389
Rollup merge of rust-lang#140349 - marcoieni:codebuild-linux-large-runners, r=Kobzol
ci: use aws codebuild for the `dist-x86_64-linux` job
try-job: dist-x86_64-linux
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@KobzolKobzolAwaiting requested review from Kobzol

Assignees


No one assigned


Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

5 participants

@marcoieni@bors@rust-log-analyzer@Kobzol@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ci: use aws codebuild for the dist-x86_64-linux job - #140349
Merged
bors merged 1 commit into
rust-lang:masterfrom 
marcoieni:codebuild-linux-large-runners
Apr 28, 2025
Merged
ci: use aws codebuild for the dist-x86_64-linux job#140349
bors merged 1 commit into
rust-lang:masterfrom 
marcoieni:codebuild-linux-large-runners
Conversation
@marcoieni
@marcoienimarcoieni
commented
Apr 26, 2025•

edited by Kobzol

Loading

Copy link


Copy Markdown

Member
r? @ghost
We want to use aws credits for linux runners.
try-job: dist-x86_64-linux
@rustbotrustbot
added

A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
Apr 26, 2025
@marcoieni
marcoieni
commented
Apr 26, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
1c29b93
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
try-job: x86_64-gnu-distcheck
@bors
bors
commented
Apr 26, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit c2922b4 with merge 1c29b93...
@bors
bors
commented
Apr 26, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 26, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
3 times, most recently
from
48990e2 to
ed20b7fCompareApril 27, 2025 09:11
@marcoieni
marcoieni
commented
Apr 27, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 51349b0...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
51349b0
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 51349b0 (51349b0d6ae41043c5e7b4925d19f587cdeb7c72)
@Kobzol
Kobzol
commented
Apr 27, 2025

Copy link


Copy Markdown

Member
@bors try
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
0148c0b
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 0148c0b...
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 0148c0b (0148c0b5e1aa4da2470d93e88991a3cb8e2148a1)
@marcoieni
marcoieni
commented
Apr 27, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 59ef764...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
59ef764
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@marcoieni
marcoieni
commented
Apr 27, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
oh I didn't see you already retried Jakub. It's quite weird that with 36 cores the jobs take so long. Maybe GitHub runners have faster cores? Or maybe some caching is not working. We need to analyze the logs.
image
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 59ef764 (59ef764abee62044f1dc9818d9ccc95f65d962ef)
@marcoieni
marcoieni
commented
Apr 28, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I compared the logs for the dist-x86_64-linux-alt job (try build vs auto build in rust-lang-ci). Building LLVM takes 2x in the try build. Not sure why.
EDIT: I was comparing things in the wrong way. Apparently compiling llvm in the try job is faster. I need to check where the try job is slower.
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
from
ed20b7f to
7bc2b01CompareApril 28, 2025 06:46
@marcoienimarcoieni
changed the title
ci: use aws codebuild for x86 linux large runnersci: use aws codebuild for the dist-x86_64-linux jobApr 28, 2025
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
from
7bc2b01 to
480d007CompareApril 28, 2025 06:48
@marcoieni
marcoieni
commented
Apr 28, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I don't know why the alt job is that slow. I edited this PR to only convert the dist-x86_64-linux job for now.
Imo this PR can be a rollup because we tried this job multiple times.
@marcoieni
marcoieni
marked this pull request as ready for review
April 28, 2025 06:48
@marcoieni
marcoieni
commented
Apr 28, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 28, 2025
@marcoieni
marcoieni
requested a review
from KobzolApril 28, 2025 06:50
@Kobzol
Kobzol
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
Hmm, it's weird. Most of the bootstrap steps were faster, some of them significantly, but the run as a whole was ~15 minutes slower. sccache stats also look good in both. I tried to go through both logs in parallel, but haven't found anything useful, it would be great to have some visualization of the log timeline. It's like the slowdown happened in between bootstrap steps or something.
But otherwise it looks fine.
@bors r+
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 480d007 has been approved by Kobzol
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Apr 28, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
25cdf1f
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 117202e
into
rust-lang:masterApr 28, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 28, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@rust-timer
Unrolled build forrust-lang#140349
58cb389
Rollup merge of rust-lang#140349 - marcoieni:codebuild-linux-large-runners, r=Kobzol
ci: use aws codebuild for the `dist-x86_64-linux` job
try-job: dist-x86_64-linux
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@KobzolKobzolAwaiting requested review from Kobzol

Assignees


No one assigned


Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

5 participants

@marcoieni@bors@rust-log-analyzer@Kobzol@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ci: use aws codebuild for the dist-x86_64-linux job - #140349
Merged
bors merged 1 commit into
rust-lang:masterfrom 
marcoieni:codebuild-linux-large-runners
Apr 28, 2025
Merged
ci: use aws codebuild for the dist-x86_64-linux job#140349
bors merged 1 commit into
rust-lang:masterfrom 
marcoieni:codebuild-linux-large-runners
Conversation
@marcoieni
@marcoienimarcoieni
commented
Apr 26, 2025•

edited by Kobzol

Loading

Copy link


Copy Markdown

Member
r? @ghost
We want to use aws credits for linux runners.
try-job: dist-x86_64-linux
@rustbotrustbot
added

A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
Apr 26, 2025
@marcoieni
marcoieni
commented
Apr 26, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
1c29b93
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
try-job: x86_64-gnu-distcheck
@bors
bors
commented
Apr 26, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit c2922b4 with merge 1c29b93...
@bors
bors
commented
Apr 26, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 26, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
3 times, most recently
from
48990e2 to
ed20b7fCompareApril 27, 2025 09:11
@marcoieni
marcoieni
commented
Apr 27, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 51349b0...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
51349b0
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 51349b0 (51349b0d6ae41043c5e7b4925d19f587cdeb7c72)
@Kobzol
Kobzol
commented
Apr 27, 2025

Copy link


Copy Markdown

Member
@bors try
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
0148c0b
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 0148c0b...
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 0148c0b (0148c0b5e1aa4da2470d93e88991a3cb8e2148a1)
@marcoieni
marcoieni
commented
Apr 27, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 59ef764...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
59ef764
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@marcoieni
marcoieni
commented
Apr 27, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
oh I didn't see you already retried Jakub. It's quite weird that with 36 cores the jobs take so long. Maybe GitHub runners have faster cores? Or maybe some caching is not working. We need to analyze the logs.
image
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 59ef764 (59ef764abee62044f1dc9818d9ccc95f65d962ef)
@marcoieni
marcoieni
commented
Apr 28, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I compared the logs for the dist-x86_64-linux-alt job (try build vs auto build in rust-lang-ci). Building LLVM takes 2x in the try build. Not sure why.
EDIT: I was comparing things in the wrong way. Apparently compiling llvm in the try job is faster. I need to check where the try job is slower.
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
from
ed20b7f to
7bc2b01CompareApril 28, 2025 06:46
@marcoienimarcoieni
changed the title
ci: use aws codebuild for x86 linux large runnersci: use aws codebuild for the dist-x86_64-linux jobApr 28, 2025
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
from
7bc2b01 to
480d007CompareApril 28, 2025 06:48
@marcoieni
marcoieni
commented
Apr 28, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I don't know why the alt job is that slow. I edited this PR to only convert the dist-x86_64-linux job for now.
Imo this PR can be a rollup because we tried this job multiple times.
@marcoieni
marcoieni
marked this pull request as ready for review
April 28, 2025 06:48
@marcoieni
marcoieni
commented
Apr 28, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 28, 2025
@marcoieni
marcoieni
requested a review
from KobzolApril 28, 2025 06:50
@Kobzol
Kobzol
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
Hmm, it's weird. Most of the bootstrap steps were faster, some of them significantly, but the run as a whole was ~15 minutes slower. sccache stats also look good in both. I tried to go through both logs in parallel, but haven't found anything useful, it would be great to have some visualization of the log timeline. It's like the slowdown happened in between bootstrap steps or something.
But otherwise it looks fine.
@bors r+
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 480d007 has been approved by Kobzol
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Apr 28, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
25cdf1f
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 117202e
into
rust-lang:masterApr 28, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 28, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@rust-timer
Unrolled build forrust-lang#140349
58cb389
Rollup merge of rust-lang#140349 - marcoieni:codebuild-linux-large-runners, r=Kobzol
ci: use aws codebuild for the `dist-x86_64-linux` job
try-job: dist-x86_64-linux
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@KobzolKobzolAwaiting requested review from Kobzol

Assignees


No one assigned


Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

5 participants

@marcoieni@bors@rust-log-analyzer@Kobzol@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ci: use aws codebuild for the dist-x86_64-linux job - #140349
Merged
bors merged 1 commit into
rust-lang:masterfrom 
marcoieni:codebuild-linux-large-runners
Apr 28, 2025
Merged
ci: use aws codebuild for the dist-x86_64-linux job#140349
bors merged 1 commit into
rust-lang:masterfrom 
marcoieni:codebuild-linux-large-runners
Conversation
@marcoieni
@marcoienimarcoieni
commented
Apr 26, 2025•

edited by Kobzol

Loading

Copy link


Copy Markdown

Member
r? @ghost
We want to use aws credits for linux runners.
try-job: dist-x86_64-linux
@rustbotrustbot
added

A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
Apr 26, 2025
@marcoieni
marcoieni
commented
Apr 26, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
1c29b93
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
try-job: x86_64-gnu-distcheck
@bors
bors
commented
Apr 26, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit c2922b4 with merge 1c29b93...
@bors
bors
commented
Apr 26, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 26, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
3 times, most recently
from
48990e2 to
ed20b7fCompareApril 27, 2025 09:11
@marcoieni
marcoieni
commented
Apr 27, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 51349b0...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
51349b0
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 51349b0 (51349b0d6ae41043c5e7b4925d19f587cdeb7c72)
@Kobzol
Kobzol
commented
Apr 27, 2025

Copy link


Copy Markdown

Member
@bors try
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
0148c0b
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 0148c0b...
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 0148c0b (0148c0b5e1aa4da2470d93e88991a3cb8e2148a1)
@marcoieni
marcoieni
commented
Apr 27, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 59ef764...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
59ef764
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@marcoieni
marcoieni
commented
Apr 27, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
oh I didn't see you already retried Jakub. It's quite weird that with 36 cores the jobs take so long. Maybe GitHub runners have faster cores? Or maybe some caching is not working. We need to analyze the logs.
image
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 59ef764 (59ef764abee62044f1dc9818d9ccc95f65d962ef)
@marcoieni
marcoieni
commented
Apr 28, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I compared the logs for the dist-x86_64-linux-alt job (try build vs auto build in rust-lang-ci). Building LLVM takes 2x in the try build. Not sure why.
EDIT: I was comparing things in the wrong way. Apparently compiling llvm in the try job is faster. I need to check where the try job is slower.
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
from
ed20b7f to
7bc2b01CompareApril 28, 2025 06:46
@marcoienimarcoieni
changed the title
ci: use aws codebuild for x86 linux large runnersci: use aws codebuild for the dist-x86_64-linux jobApr 28, 2025
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
from
7bc2b01 to
480d007CompareApril 28, 2025 06:48
@marcoieni
marcoieni
commented
Apr 28, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I don't know why the alt job is that slow. I edited this PR to only convert the dist-x86_64-linux job for now.
Imo this PR can be a rollup because we tried this job multiple times.
@marcoieni
marcoieni
marked this pull request as ready for review
April 28, 2025 06:48
@marcoieni
marcoieni
commented
Apr 28, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 28, 2025
@marcoieni
marcoieni
requested a review
from KobzolApril 28, 2025 06:50
@Kobzol
Kobzol
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
Hmm, it's weird. Most of the bootstrap steps were faster, some of them significantly, but the run as a whole was ~15 minutes slower. sccache stats also look good in both. I tried to go through both logs in parallel, but haven't found anything useful, it would be great to have some visualization of the log timeline. It's like the slowdown happened in between bootstrap steps or something.
But otherwise it looks fine.
@bors r+
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 480d007 has been approved by Kobzol
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Apr 28, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
25cdf1f
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 117202e
into
rust-lang:masterApr 28, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 28, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@rust-timer
Unrolled build forrust-lang#140349
58cb389
Rollup merge of rust-lang#140349 - marcoieni:codebuild-linux-large-runners, r=Kobzol
ci: use aws codebuild for the `dist-x86_64-linux` job
try-job: dist-x86_64-linux
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@KobzolKobzolAwaiting requested review from Kobzol

Assignees


No one assigned


Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

5 participants

@marcoieni@bors@rust-log-analyzer@Kobzol@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ci: use aws codebuild for the dist-x86_64-linux job - #140349
Merged
bors merged 1 commit into
rust-lang:masterfrom 
marcoieni:codebuild-linux-large-runners
Apr 28, 2025
Merged
ci: use aws codebuild for the dist-x86_64-linux job#140349
bors merged 1 commit into
rust-lang:masterfrom 
marcoieni:codebuild-linux-large-runners
Conversation
@marcoieni
@marcoienimarcoieni
commented
Apr 26, 2025•

edited by Kobzol

Loading

Copy link


Copy Markdown

Member
r? @ghost
We want to use aws credits for linux runners.
try-job: dist-x86_64-linux
@rustbotrustbot
added

A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
Apr 26, 2025
@marcoieni
marcoieni
commented
Apr 26, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
1c29b93
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
try-job: x86_64-gnu-distcheck
@bors
bors
commented
Apr 26, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit c2922b4 with merge 1c29b93...
@bors
bors
commented
Apr 26, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 26, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
3 times, most recently
from
48990e2 to
ed20b7fCompareApril 27, 2025 09:11
@marcoieni
marcoieni
commented
Apr 27, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 51349b0...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
51349b0
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 51349b0 (51349b0d6ae41043c5e7b4925d19f587cdeb7c72)
@Kobzol
Kobzol
commented
Apr 27, 2025

Copy link


Copy Markdown

Member
@bors try
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
0148c0b
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 0148c0b...
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 0148c0b (0148c0b5e1aa4da2470d93e88991a3cb8e2148a1)
@marcoieni
marcoieni
commented
Apr 27, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 59ef764...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
59ef764
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@marcoieni
marcoieni
commented
Apr 27, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
oh I didn't see you already retried Jakub. It's quite weird that with 36 cores the jobs take so long. Maybe GitHub runners have faster cores? Or maybe some caching is not working. We need to analyze the logs.
image
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 59ef764 (59ef764abee62044f1dc9818d9ccc95f65d962ef)
@marcoieni
marcoieni
commented
Apr 28, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I compared the logs for the dist-x86_64-linux-alt job (try build vs auto build in rust-lang-ci). Building LLVM takes 2x in the try build. Not sure why.
EDIT: I was comparing things in the wrong way. Apparently compiling llvm in the try job is faster. I need to check where the try job is slower.
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
from
ed20b7f to
7bc2b01CompareApril 28, 2025 06:46
@marcoienimarcoieni
changed the title
ci: use aws codebuild for x86 linux large runnersci: use aws codebuild for the dist-x86_64-linux jobApr 28, 2025
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
from
7bc2b01 to
480d007CompareApril 28, 2025 06:48
@marcoieni
marcoieni
commented
Apr 28, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I don't know why the alt job is that slow. I edited this PR to only convert the dist-x86_64-linux job for now.
Imo this PR can be a rollup because we tried this job multiple times.
@marcoieni
marcoieni
marked this pull request as ready for review
April 28, 2025 06:48
@marcoieni
marcoieni
commented
Apr 28, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 28, 2025
@marcoieni
marcoieni
requested a review
from KobzolApril 28, 2025 06:50
@Kobzol
Kobzol
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
Hmm, it's weird. Most of the bootstrap steps were faster, some of them significantly, but the run as a whole was ~15 minutes slower. sccache stats also look good in both. I tried to go through both logs in parallel, but haven't found anything useful, it would be great to have some visualization of the log timeline. It's like the slowdown happened in between bootstrap steps or something.
But otherwise it looks fine.
@bors r+
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 480d007 has been approved by Kobzol
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Apr 28, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
25cdf1f
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 117202e
into
rust-lang:masterApr 28, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 28, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@rust-timer
Unrolled build forrust-lang#140349
58cb389
Rollup merge of rust-lang#140349 - marcoieni:codebuild-linux-large-runners, r=Kobzol
ci: use aws codebuild for the `dist-x86_64-linux` job
try-job: dist-x86_64-linux
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@KobzolKobzolAwaiting requested review from Kobzol

Assignees


No one assigned


Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

5 participants

@marcoieni@bors@rust-log-analyzer@Kobzol@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ci: use aws codebuild for the dist-x86_64-linux job - #140349
Merged
bors merged 1 commit into
rust-lang:masterfrom 
marcoieni:codebuild-linux-large-runners
Apr 28, 2025
Merged
ci: use aws codebuild for the dist-x86_64-linux job#140349
bors merged 1 commit into
rust-lang:masterfrom 
marcoieni:codebuild-linux-large-runners
Conversation
@marcoieni
@marcoienimarcoieni
commented
Apr 26, 2025•

edited by Kobzol

Loading

Copy link


Copy Markdown

Member
r? @ghost
We want to use aws credits for linux runners.
try-job: dist-x86_64-linux
@rustbotrustbot
added

A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
Apr 26, 2025
@marcoieni
marcoieni
commented
Apr 26, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
1c29b93
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
try-job: x86_64-gnu-distcheck
@bors
bors
commented
Apr 26, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit c2922b4 with merge 1c29b93...
@bors
bors
commented
Apr 26, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 26, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
3 times, most recently
from
48990e2 to
ed20b7fCompareApril 27, 2025 09:11
@marcoieni
marcoieni
commented
Apr 27, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 51349b0...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
51349b0
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 51349b0 (51349b0d6ae41043c5e7b4925d19f587cdeb7c72)
@Kobzol
Kobzol
commented
Apr 27, 2025

Copy link


Copy Markdown

Member
@bors try
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
0148c0b
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 0148c0b...
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 0148c0b (0148c0b5e1aa4da2470d93e88991a3cb8e2148a1)
@marcoieni
marcoieni
commented
Apr 27, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 59ef764...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
59ef764
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@marcoieni
marcoieni
commented
Apr 27, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
oh I didn't see you already retried Jakub. It's quite weird that with 36 cores the jobs take so long. Maybe GitHub runners have faster cores? Or maybe some caching is not working. We need to analyze the logs.
image
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 59ef764 (59ef764abee62044f1dc9818d9ccc95f65d962ef)
@marcoieni
marcoieni
commented
Apr 28, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I compared the logs for the dist-x86_64-linux-alt job (try build vs auto build in rust-lang-ci). Building LLVM takes 2x in the try build. Not sure why.
EDIT: I was comparing things in the wrong way. Apparently compiling llvm in the try job is faster. I need to check where the try job is slower.
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
from
ed20b7f to
7bc2b01CompareApril 28, 2025 06:46
@marcoienimarcoieni
changed the title
ci: use aws codebuild for x86 linux large runnersci: use aws codebuild for the dist-x86_64-linux jobApr 28, 2025
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
from
7bc2b01 to
480d007CompareApril 28, 2025 06:48
@marcoieni
marcoieni
commented
Apr 28, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I don't know why the alt job is that slow. I edited this PR to only convert the dist-x86_64-linux job for now.
Imo this PR can be a rollup because we tried this job multiple times.
@marcoieni
marcoieni
marked this pull request as ready for review
April 28, 2025 06:48
@marcoieni
marcoieni
commented
Apr 28, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 28, 2025
@marcoieni
marcoieni
requested a review
from KobzolApril 28, 2025 06:50
@Kobzol
Kobzol
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
Hmm, it's weird. Most of the bootstrap steps were faster, some of them significantly, but the run as a whole was ~15 minutes slower. sccache stats also look good in both. I tried to go through both logs in parallel, but haven't found anything useful, it would be great to have some visualization of the log timeline. It's like the slowdown happened in between bootstrap steps or something.
But otherwise it looks fine.
@bors r+
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 480d007 has been approved by Kobzol
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Apr 28, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
25cdf1f
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 117202e
into
rust-lang:masterApr 28, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 28, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@rust-timer
Unrolled build forrust-lang#140349
58cb389
Rollup merge of rust-lang#140349 - marcoieni:codebuild-linux-large-runners, r=Kobzol
ci: use aws codebuild for the `dist-x86_64-linux` job
try-job: dist-x86_64-linux
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@KobzolKobzolAwaiting requested review from Kobzol

Assignees


No one assigned


Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

5 participants

@marcoieni@bors@rust-log-analyzer@Kobzol@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ci: use aws codebuild for the dist-x86_64-linux job - #140349
Merged
bors merged 1 commit into
rust-lang:masterfrom 
marcoieni:codebuild-linux-large-runners
Apr 28, 2025
Merged
ci: use aws codebuild for the dist-x86_64-linux job#140349
bors merged 1 commit into
rust-lang:masterfrom 
marcoieni:codebuild-linux-large-runners
Conversation
@marcoieni
@marcoienimarcoieni
commented
Apr 26, 2025•

edited by Kobzol

Loading

Copy link


Copy Markdown

Member
r? @ghost
We want to use aws credits for linux runners.
try-job: dist-x86_64-linux
@rustbotrustbot
added

A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
Apr 26, 2025
@marcoieni
marcoieni
commented
Apr 26, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
1c29b93
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
try-job: x86_64-gnu-distcheck
@bors
bors
commented
Apr 26, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit c2922b4 with merge 1c29b93...
@bors
bors
commented
Apr 26, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 26, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
3 times, most recently
from
48990e2 to
ed20b7fCompareApril 27, 2025 09:11
@marcoieni
marcoieni
commented
Apr 27, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 51349b0...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
51349b0
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 51349b0 (51349b0d6ae41043c5e7b4925d19f587cdeb7c72)
@Kobzol
Kobzol
commented
Apr 27, 2025

Copy link


Copy Markdown

Member
@bors try
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
0148c0b
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 0148c0b...
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 0148c0b (0148c0b5e1aa4da2470d93e88991a3cb8e2148a1)
@marcoieni
marcoieni
commented
Apr 27, 2025

Copy link


Copy Markdown

MemberAuthor
@bors try
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
⌛ Trying commit ed20b7f with merge 59ef764...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
@bors
Auto merge ofrust-lang#140349- marcoieni:codebuild-linux-large-runn…
59ef764
…ers, r=<try>
ci: use aws codebuild for x86 linux large runners
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@marcoieni
marcoieni
commented
Apr 27, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
oh I didn't see you already retried Jakub. It's quite weird that with 36 cores the jobs take so long. Maybe GitHub runners have faster cores? Or maybe some caching is not working. We need to analyze the logs.
image
@bors
bors
commented
Apr 27, 2025

Copy link


Copy Markdown

Collaborator
☀️ Try build successful - checks-actions

Build commit: 59ef764 (59ef764abee62044f1dc9818d9ccc95f65d962ef)
@marcoieni
marcoieni
commented
Apr 28, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I compared the logs for the dist-x86_64-linux-alt job (try build vs auto build in rust-lang-ci). Building LLVM takes 2x in the try build. Not sure why.
EDIT: I was comparing things in the wrong way. Apparently compiling llvm in the try job is faster. I need to check where the try job is slower.
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
from
ed20b7f to
7bc2b01CompareApril 28, 2025 06:46
@marcoienimarcoieni
changed the title
ci: use aws codebuild for x86 linux large runnersci: use aws codebuild for the dist-x86_64-linux jobApr 28, 2025
@marcoieni
marcoieniforce-pushed
the
codebuild-linux-large-runners
branch
from
7bc2b01 to
480d007CompareApril 28, 2025 06:48
@marcoieni
marcoieni
commented
Apr 28, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I don't know why the alt job is that slow. I edited this PR to only convert the dist-x86_64-linux job for now.
Imo this PR can be a rollup because we tried this job multiple times.
@marcoieni
marcoieni
marked this pull request as ready for review
April 28, 2025 06:48
@marcoieni
marcoieni
commented
Apr 28, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 28, 2025
@marcoieni
marcoieni
requested a review
from KobzolApril 28, 2025 06:50
@Kobzol
Kobzol
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
Hmm, it's weird. Most of the bootstrap steps were faster, some of them significantly, but the run as a whole was ~15 minutes slower. sccache stats also look good in both. I tried to go through both logs in parallel, but haven't found anything useful, it would be great to have some visualization of the log timeline. It's like the slowdown happened in between bootstrap steps or something.
But otherwise it looks fine.
@bors r+
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 480d007 has been approved by Kobzol
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Apr 28, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
25cdf1f
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 117202e
into
rust-lang:masterApr 28, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 28, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@rust-timer
Unrolled build forrust-lang#140349
58cb389
Rollup merge of rust-lang#140349 - marcoieni:codebuild-linux-large-runners, r=Kobzol
ci: use aws codebuild for the `dist-x86_64-linux` job
try-job: dist-x86_64-linux
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@KobzolKobzolAwaiting requested review from Kobzol

Assignees


No one assigned


Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

5 participants

@marcoieni@bors@rust-log-analyzer@Kobzol@rustbot