Rollup of 7 pull requests - #140388

Merged
bors merged 39 commits into
rust-lang:masterfrom
GuillaumeGomez:rollup-aj9o3ch
Apr 28, 2025
Merged

Rollup of 7 pull requests#140388
bors merged 39 commits into
rust-lang:masterfrom
GuillaumeGomez:rollup-aj9o3ch

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Apr 28, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

hwhsu1231and others added 30 commits April 18, 2025 18:49
@hwhsu1231
fix(docs): add newlines between prefix/suffix chapters
399cf1f
add newlines between prefix/suffix chapters in SUMMARY.md
to ensure correct extraction by mdbook-i18n-helpers.
@tshepang
toolchain version does not need to be specified
1b5f2aa
- Rust backcompat removes the need to specify the version here
- Using these commands can result in a needless toolchain getting
downloaded, like in the case where user only has Nightly installed
@ZuseZ4
update build and test instructions
e9896cc
@ZuseZ4
Merge pull requestrust-lang#2350from rust-lang/update-autodiff-buil…
deed996
…d-instr
update build and test instructions
@GuillaumeGomez
Fix detection of main function if there are expressions around it
3536324
@GuillaumeGomez
Add regression ui test forrust-lang#140162and forrust-lang#139651
81438c0
Preparing for merge from rustc
745500f
Merge from rustc
1b315ad
@BoxyUwU
Remove weak alias terminology
bdfeb8f
@tshepang
typo
ba6dd90
@tshepang
Merge pull requestrust-lang#2353from rust-lang/tshepang-patch-1
e6472b3
typo
@GuillaumeGomez
Improve code
3ededc1
@GuillaumeGomez
If there is a ; alone, we consider that the doctest needs to be put…
3ef98a5
… inside a function
@yuk1ty
Fix error message for static references or mutable references
bffb760
@tshepang
Merge pull requestrust-lang#2345from rust-lang/extraneous
7a70f33
toolchain version does not need to be specified
@tshepang
Merge pull requestrust-lang#2343from hwhsu1231-fork/fix-prefix-chapter
3945ae9
fix(docs): add newlines between prefix/suffix chapters
@tshepang
use correct code block markers
79faff2
@tshepang
Merge pull requestrust-lang#2354from rust-lang/tshepang-fix-code-bl…
26a60d4
…ocks
use correct code block markers
@tshepang
copy-paste ease
9eeadbf
@tshepang
Merge pull requestrust-lang#2355from rust-lang/tshepang-patch-1
e40391a
copy-paste ease
@tshepang
replace command that does not work
9c4d568
@tshepang
Merge pull requestrust-lang#2356from rust-lang/tshepang-patch-2
89bb181
replace command that does not work
@GuillaumeGomez
Fix bad handling of macros if there is already a main function
aa69e3a
@marcoieni
ci: clean more disk space in codebuild
474466d
@JohnTitor
Merge pull requestrust-lang#2351from rust-lang/rustc-pull
d91ffb6
Preparing for merge from rustc
de491f9
Merge from rustc
aa15830
@tshepang
Merge pull requestrust-lang#2358from rust-lang/rustc-pull
1b53c12
Rustc pull update
@nnethercote
Introduce BoxMarker to pretty-printing.
aff1be2
The pretty-printers open and close "boxes" of text a lot. The open and
close operations must be matched. The matching is currently all implicit
and very easy to get wrong. (rust-lang#140280 and rust-lang#140246 are two recent
pretty-printing fixes that both involved unclosed boxes.)
This commit introduces `BoxMarker`, a marker type that represents an
open box. It makes box opening/closing explicit, which makes it much
easier to understand and harder to get wrong.
The commit also removes many comments are on `end` calls saying things
like "end outer head-block", "Close the outer-box". These demonstrate
how confusing the implicit approach was, but aren't necessary any more.
@nnethercote
Use PrintState::head in PrintState::block_to_string.
61a66b1
@GuillaumeGomez

GuillaumeGomez commented Apr 28, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=5 rollup=never

@bors

bors commented Apr 28, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit dd3ca71 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2025
@bors

bors commented Apr 28, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit dd3ca71 with merge 6655f5c...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer

rust-log-analyzer commented Apr 28, 2025

Copy link
Copy Markdown
Collaborator

The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
---- [run-make] tests\run-make\amdgpu-kd stdout ----
error: rmake recipe failed to complete
status: exit code: 1
command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake.exe"
stdout: none
--- stderr -------------------------------
command failed at line 18
Command { cmd: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "--crate-name" "foo" "--target=amdgcn-amd-amdhsa" "-Ctarget-cpu=gfx900" "--crate-type" "cdylib" "foo.rs", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe", defused: true, armed_location: Location { file: "D:\\a\\rust\\rust\\tests\\run-make\\amdgpu-kd\\rmake.rs", line: 12, col: 5 } }, already_executed: true }
output status: `exit code: 1`
=== STDOUT ===
=== STDERR ===
error: linking with `rust-lld` failed: exit code: 0xc0000374
|
= note: "rust-lld" "-flavor" "gnu" "--version-script=C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\list" "--no-undefined-version" "<1 object files omitted>" "--as-needed" "-L" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\raw-dylibs" "-Bdynamic" "--eh-frame-hdr" "-z" "noexecstack" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "-o" "foo.elf" "--gc-sections" "-shared"
= note: some arguments are omitted. use `--verbose` to show all linker arguments
= note: error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 279 passed; 1 failed; 110 ignored; 0 measured; 6 filtered out; finished in 202.94s
Some tests failed in compiletest suite=run-make mode=run-make host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 2:28:20
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Mon Apr 28 14:12:18 CUT 2025
network time: Mon, 28 Apr 2025 14:12:18 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors

bors commented Apr 28, 2025

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 28, 2025
@ChrisDenton

ChrisDenton commented Apr 28, 2025

Copy link
Copy Markdown
Member

spurious

@bors retry x86_64-mingw-1 0xc0000374

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2025
@ChrisDentonChrisDenton added the CI-spurious-fail-rust-lld-crash CI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruption label Apr 28, 2025
@bors

bors commented Apr 28, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit dd3ca71 with merge 25cdf1f...

@rust-highfive

rust-highfive commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #140388!

Tested on commit 25cdf1f.
Direct link to PR: #140388

💔 reference on windows: test-pass → test-fail (cc @ehuss).
💔 reference on linux: test-pass → test-fail (cc @ehuss).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 28, 2025
@rust-highfive
📣 Toolstate changed byrust-lang/rust#140388!
054bf2b
Tested on commit rust-lang/rust@25cdf1f.
Direct link to PR: <rust-lang/rust#140388>
💔 reference on windows: test-pass → test-fail (cc @ehuss).
💔 reference on linux: test-pass → test-fail (cc @ehuss).
@bors

bors commented Apr 28, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 25cdf1f to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Apr 28, 2025
@bors
bors merged commit 25cdf1f into rust-lang:masterApr 28, 2025
@rustbotrustbot added this to the 1.88.0 milestone Apr 28, 2025
@github-actions

github-actionsBot commented Apr 28, 2025

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7d65abf (parent) -> 25cdf1f (this PR)

Test differences

Show 8 test diffs

Stage 1

  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J0)

Stage 2

  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J1)

Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 25cdf1f67463c9365d8d83778c933ec7480e940b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-arm-linux: 3456.9s -> 6261.6s (81.1%)
  2. dist-aarch64-linux: 5480.9s -> 7688.6s (40.3%)
  3. dist-x86_64-mingw: 7434.0s -> 9140.9s (23.0%)
  4. x86_64-apple-1: 7256.8s -> 8119.9s (11.9%)
  5. dist-aarch64-apple: 4672.3s -> 5184.4s (11.0%)
  6. dist-x86_64-linux: 5555.9s -> 4994.8s (-10.1%)
  7. i686-msvc-1: 9172.8s -> 10079.0s (9.9%)
  8. dist-apple-various: 6409.8s -> 5839.6s (-8.9%)
  9. x86_64-apple-2: 5323.5s -> 5737.7s (7.8%)
  10. x86_64-gnu-llvm-19-1: 5186.8s -> 5547.5s (7.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Apr 28, 2025

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#140056Fix a wrong error message in 2024 editiond17b7f61e47b3d955ba3ffc936d2c6595af6d870 (link)
#140220Fix detection of main function if there are expressions aro…4f8ada3a92a69b926a855805b7273af20bc4d327 (link)
#140249Remove weak alias terminology676258125ecaa2a0ee386d4311857f47227ed794 (link)
#140316Introduce BoxMarker to improve pretty-printing correctness811001142947076865ab8fda8a87f6eff86d3823 (link)
#140347ci: clean more disk space in codebuild3c44de5caa192bf27dcaa2865f7628f28815f8cd (link)
#140349ci: use aws codebuild for the dist-x86_64-linux job58cb389ea83ffbe73206abf143f65efb6086d66e (link)
#140379rustc-dev-guide subtree update79423ca0196dc2cb74480da44c83f0be10ebdab1 (link)

previous master: 7d65abfe80

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@GuillaumeGomez
GuillaumeGomez deleted the rollup-aj9o3ch branch April 28, 2025 20:31
This was referenced Apr 28, 2025
Merged
Closed
Merged
Merged
Merged
@rust-timer

rust-timer commented Apr 28, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (25cdf1f): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-0.6%[-0.6%, -0.6%]1
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (primary 0.6%, secondary 3.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		0.7%[0.4%, 1.5%]11
Regressions ❌
(secondary)		3.5%[2.3%, 4.8%]2
Improvements ✅
(primary)		-0.4%[-0.4%, -0.4%]1
Improvements ✅
(secondary)		--0
All ❌✅ (primary)0.6%[-0.4%, 1.5%]12

Cycles

Results (primary -0.2%, secondary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		1.2%[0.9%, 1.6%]2
Regressions ❌
(secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅
(primary)		-0.6%[-0.9%, -0.4%]6
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-0.2%[-0.9%, 1.6%]8

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 765.314s -> 765.701s (0.05%)
Artifact size: 365.17 MiB -> 365.36 MiB (0.05%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcCI-spurious-fail-rust-lld-crashCI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruptionmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

15 participants

@GuillaumeGomez@bors@rust-log-analyzer@ChrisDenton@rust-highfive@rust-timer@rustbot@hwhsu1231@tshepang@ZuseZ4@BoxyUwU@yuk1ty@marcoieni@JohnTitor@nnethercote
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Rollup of 7 pull requests - #140388
Merged
bors merged 39 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-aj9o3ch
Apr 28, 2025
Merged
Rollup of 7 pull requests#140388
bors merged 39 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-aj9o3ch
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
hwhsu1231and others
added 30 commits
April 18, 2025 18:49
@hwhsu1231
fix(docs): add newlines between prefix/suffix chapters
399cf1f
add newlines between prefix/suffix chapters in SUMMARY.md
to ensure correct extraction by mdbook-i18n-helpers.
@tshepang
toolchain version does not need to be specified
1b5f2aa
- Rust backcompat removes the need to specify the version here
- Using these commands can result in a needless toolchain getting
downloaded, like in the case where user only has Nightly installed
@ZuseZ4
update build and test instructions
e9896cc
@ZuseZ4
Merge pull requestrust-lang#2350from rust-lang/update-autodiff-buil…
deed996
…d-instr
update build and test instructions
@GuillaumeGomez
Fix detection of main function if there are expressions around it
3536324
@GuillaumeGomez
Add regression ui test forrust-lang#140162and forrust-lang#139651
81438c0
Preparing for merge from rustc
745500f
Merge from rustc
1b315ad
@BoxyUwU
Remove weak alias terminology
bdfeb8f
@tshepang
typo
ba6dd90
@tshepang
Merge pull requestrust-lang#2353from rust-lang/tshepang-patch-1
e6472b3
typo
@GuillaumeGomez
Improve code
3ededc1
@GuillaumeGomez
If there is a ; alone, we consider that the doctest needs to be put…
3ef98a5
… inside a function
@yuk1ty
Fix error message for static references or mutable references
bffb760
@tshepang
Merge pull requestrust-lang#2345from rust-lang/extraneous
7a70f33
toolchain version does not need to be specified
@tshepang
Merge pull requestrust-lang#2343from hwhsu1231-fork/fix-prefix-chapter
3945ae9
fix(docs): add newlines between prefix/suffix chapters
@tshepang
use correct code block markers
79faff2
@tshepang
Merge pull requestrust-lang#2354from rust-lang/tshepang-fix-code-bl…
26a60d4
…ocks
use correct code block markers
@tshepang
copy-paste ease
9eeadbf
@tshepang
Merge pull requestrust-lang#2355from rust-lang/tshepang-patch-1
e40391a
copy-paste ease
@tshepang
replace command that does not work
9c4d568
@tshepang
Merge pull requestrust-lang#2356from rust-lang/tshepang-patch-2
89bb181
replace command that does not work
@GuillaumeGomez
Fix bad handling of macros if there is already a main function
aa69e3a
@marcoieni
ci: clean more disk space in codebuild
474466d
@JohnTitor
Merge pull requestrust-lang#2351from rust-lang/rustc-pull
d91ffb6
Preparing for merge from rustc
de491f9
Merge from rustc
aa15830
@tshepang
Merge pull requestrust-lang#2358from rust-lang/rustc-pull
1b53c12
Rustc pull update
@nnethercote
Introduce BoxMarker to pretty-printing.
aff1be2
The pretty-printers open and close "boxes" of text a lot. The open and
close operations must be matched. The matching is currently all implicit
and very easy to get wrong. (rust-lang#140280 and rust-lang#140246 are two recent
pretty-printing fixes that both involved unclosed boxes.)
This commit introduces `BoxMarker`, a marker type that represents an
open box. It makes box opening/closing explicit, which makes it much
easier to understand and harder to get wrong.
The commit also removes many comments are on `end` calls saying things
like "end outer head-block", "Close the outer-box". These demonstrate
how confusing the implicit approach was, but aren't necessary any more.
@nnethercote
Use PrintState::head in PrintState::block_to_string.
61a66b1
@GuillaumeGomez
GuillaumeGomez
commented
Apr 28, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ p=5 rollup=never
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit dd3ca71 has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dd3ca71 with merge 6655f5c...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
rust-log-analyzer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)
Click to see the possible cause of the failure (guessed by this bot)
---- [run-make] tests\run-make\amdgpu-kd stdout ----
error: rmake recipe failed to complete
status: exit code: 1
command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake.exe"
stdout: none
--- stderr -------------------------------
command failed at line 18
Command { cmd: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "--crate-name" "foo" "--target=amdgcn-amd-amdhsa" "-Ctarget-cpu=gfx900" "--crate-type" "cdylib" "foo.rs", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe", defused: true, armed_location: Location { file: "D:\\a\\rust\\rust\\tests\\run-make\\amdgpu-kd\\rmake.rs", line: 12, col: 5 } }, already_executed: true }
output status: `exit code: 1`
=== STDOUT ===
=== STDERR ===
error: linking with `rust-lld` failed: exit code: 0xc0000374
|
= note: "rust-lld" "-flavor" "gnu" "--version-script=C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\list" "--no-undefined-version" "<1 object files omitted>" "--as-needed" "-L" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\raw-dylibs" "-Bdynamic" "--eh-frame-hdr" "-z" "noexecstack" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "-o" "foo.elf" "--gc-sections" "-shared"
= note: some arguments are omitted. use `--verbose` to show all linker arguments
= note: error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 279 passed; 1 failed; 110 ignored; 0 measured; 6 filtered out; finished in 202.94s
Some tests failed in compiletest suite=run-make mode=run-make host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 2:28:20
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Mon Apr 28 14:12:18 CUT 2025
network time: Mon, 28 Apr 2025 14:12:18 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 28, 2025
@ChrisDenton
ChrisDenton
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
spurious
@bors retry x86_64-mingw-1 0xc0000374
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@ChrisDentonChrisDenton
added
the 
CI-spurious-fail-rust-lld-crash
CI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruption
label
Apr 28, 2025
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dd3ca71 with merge 25cdf1f...
@rust-highfive
rust-highfive
commented
Apr 28, 2025

Copy link


Copy Markdown

Contributor
📣 Toolstate changed by #140388!
Tested on commit 25cdf1f.

Direct link to PR: #140388
💔 reference on windows: test-pass → test-fail (cc @ehuss).

💔 reference on linux: test-pass → test-fail (cc @ehuss).
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 28, 2025
@rust-highfive
📣 Toolstate changed byrust-lang/rust#140388!
054bf2b
Tested on commit rust-lang/rust@25cdf1f.
Direct link to PR: <rust-lang/rust#140388>
💔 reference on windows: test-pass → test-fail (cc @ehuss).
💔 reference on linux: test-pass → test-fail (cc @ehuss).
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: GuillaumeGomez

Pushing 25cdf1f to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Apr 28, 2025
@bors
bors
merged commit 25cdf1f
into
rust-lang:masterApr 28, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 28, 2025
@github-actions
github-actionsBot
commented
Apr 28, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7d65abf (parent) -> 25cdf1f (this PR)
Test differences
Show 8 test diffs

Stage 1
  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J0)
Stage 2
  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J1)
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 25cdf1f67463c9365d8d83778c933ec7480e940b --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-arm-linux: 3456.9s -> 6261.6s (81.1%)
  2. dist-aarch64-linux: 5480.9s -> 7688.6s (40.3%)
  3. dist-x86_64-mingw: 7434.0s -> 9140.9s (23.0%)
  4. x86_64-apple-1: 7256.8s -> 8119.9s (11.9%)
  5. dist-aarch64-apple: 4672.3s -> 5184.4s (11.0%)
  6. dist-x86_64-linux: 5555.9s -> 4994.8s (-10.1%)
  7. i686-msvc-1: 9172.8s -> 10079.0s (9.9%)
  8. dist-apple-various: 6409.8s -> 5839.6s (-8.9%)
  9. x86_64-apple-2: 5323.5s -> 5737.7s (7.8%)
  10. x86_64-gnu-llvm-19-1: 5186.8s -> 5547.5s (7.0%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#140056Fix a wrong error message in 2024 editiond17b7f61e47b3d955ba3ffc936d2c6595af6d870 (link)
#140220Fix detection of main function if there are expressions aro…4f8ada3a92a69b926a855805b7273af20bc4d327 (link)
#140249Remove weak alias terminology676258125ecaa2a0ee386d4311857f47227ed794 (link)
#140316Introduce BoxMarker to improve pretty-printing correctness811001142947076865ab8fda8a87f6eff86d3823 (link)
#140347ci: clean more disk space in codebuild3c44de5caa192bf27dcaa2865f7628f28815f8cd (link)
#140349ci: use aws codebuild for the dist-x86_64-linux job58cb389ea83ffbe73206abf143f65efb6086d66e (link)
#140379rustc-dev-guide subtree update79423ca0196dc2cb74480da44c83f0be10ebdab1 (link)
previous master: 7d65abfe80
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@GuillaumeGomez
GuillaumeGomez
deleted the

rollup-aj9o3ch

branch
April 28, 2025 20:31

This was referenced Apr 28, 2025
 Merged

 Closed

 Merged

 Merged

 Merged

@rust-timer
rust-timer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (25cdf1f): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.6%[-0.6%, -0.6%]1
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary 0.6%, secondary 3.5%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		0.7%[0.4%, 1.5%]11
Regressions ❌ 
 (secondary)		3.5%[2.3%, 4.8%]2
Improvements ✅ 
 (primary)		-0.4%[-0.4%, -0.4%]1
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)0.6%[-0.4%, 1.5%]12
Cycles
Results (primary -0.2%, secondary 3.0%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		1.2%[0.9%, 1.6%]2
Regressions ❌ 
 (secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅ 
 (primary)		-0.6%[-0.9%, -0.4%]6
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-0.2%[-0.9%, 1.6%]8
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 765.314s -> 765.701s (0.05%)
Artifact size: 365.17 MiB -> 365.36 MiB (0.05%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcCI-spurious-fail-rust-lld-crashCI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruptionmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

15 participants

@GuillaumeGomez@bors@rust-log-analyzer@ChrisDenton@rust-highfive@rust-timer@rustbot@hwhsu1231@tshepang@ZuseZ4@BoxyUwU@yuk1ty@marcoieni@JohnTitor@nnethercote

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 7 pull requests - #140388
Merged
bors merged 39 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-aj9o3ch
Apr 28, 2025
Merged
Rollup of 7 pull requests#140388
bors merged 39 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-aj9o3ch
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
hwhsu1231and others
added 30 commits
April 18, 2025 18:49
@hwhsu1231
fix(docs): add newlines between prefix/suffix chapters
399cf1f
add newlines between prefix/suffix chapters in SUMMARY.md
to ensure correct extraction by mdbook-i18n-helpers.
@tshepang
toolchain version does not need to be specified
1b5f2aa
- Rust backcompat removes the need to specify the version here
- Using these commands can result in a needless toolchain getting
downloaded, like in the case where user only has Nightly installed
@ZuseZ4
update build and test instructions
e9896cc
@ZuseZ4
Merge pull requestrust-lang#2350from rust-lang/update-autodiff-buil…
deed996
…d-instr
update build and test instructions
@GuillaumeGomez
Fix detection of main function if there are expressions around it
3536324
@GuillaumeGomez
Add regression ui test forrust-lang#140162and forrust-lang#139651
81438c0
Preparing for merge from rustc
745500f
Merge from rustc
1b315ad
@BoxyUwU
Remove weak alias terminology
bdfeb8f
@tshepang
typo
ba6dd90
@tshepang
Merge pull requestrust-lang#2353from rust-lang/tshepang-patch-1
e6472b3
typo
@GuillaumeGomez
Improve code
3ededc1
@GuillaumeGomez
If there is a ; alone, we consider that the doctest needs to be put…
3ef98a5
… inside a function
@yuk1ty
Fix error message for static references or mutable references
bffb760
@tshepang
Merge pull requestrust-lang#2345from rust-lang/extraneous
7a70f33
toolchain version does not need to be specified
@tshepang
Merge pull requestrust-lang#2343from hwhsu1231-fork/fix-prefix-chapter
3945ae9
fix(docs): add newlines between prefix/suffix chapters
@tshepang
use correct code block markers
79faff2
@tshepang
Merge pull requestrust-lang#2354from rust-lang/tshepang-fix-code-bl…
26a60d4
…ocks
use correct code block markers
@tshepang
copy-paste ease
9eeadbf
@tshepang
Merge pull requestrust-lang#2355from rust-lang/tshepang-patch-1
e40391a
copy-paste ease
@tshepang
replace command that does not work
9c4d568
@tshepang
Merge pull requestrust-lang#2356from rust-lang/tshepang-patch-2
89bb181
replace command that does not work
@GuillaumeGomez
Fix bad handling of macros if there is already a main function
aa69e3a
@marcoieni
ci: clean more disk space in codebuild
474466d
@JohnTitor
Merge pull requestrust-lang#2351from rust-lang/rustc-pull
d91ffb6
Preparing for merge from rustc
de491f9
Merge from rustc
aa15830
@tshepang
Merge pull requestrust-lang#2358from rust-lang/rustc-pull
1b53c12
Rustc pull update
@nnethercote
Introduce BoxMarker to pretty-printing.
aff1be2
The pretty-printers open and close "boxes" of text a lot. The open and
close operations must be matched. The matching is currently all implicit
and very easy to get wrong. (rust-lang#140280 and rust-lang#140246 are two recent
pretty-printing fixes that both involved unclosed boxes.)
This commit introduces `BoxMarker`, a marker type that represents an
open box. It makes box opening/closing explicit, which makes it much
easier to understand and harder to get wrong.
The commit also removes many comments are on `end` calls saying things
like "end outer head-block", "Close the outer-box". These demonstrate
how confusing the implicit approach was, but aren't necessary any more.
@nnethercote
Use PrintState::head in PrintState::block_to_string.
61a66b1
@GuillaumeGomez
GuillaumeGomez
commented
Apr 28, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ p=5 rollup=never
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit dd3ca71 has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dd3ca71 with merge 6655f5c...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
rust-log-analyzer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)
Click to see the possible cause of the failure (guessed by this bot)
---- [run-make] tests\run-make\amdgpu-kd stdout ----
error: rmake recipe failed to complete
status: exit code: 1
command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake.exe"
stdout: none
--- stderr -------------------------------
command failed at line 18
Command { cmd: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "--crate-name" "foo" "--target=amdgcn-amd-amdhsa" "-Ctarget-cpu=gfx900" "--crate-type" "cdylib" "foo.rs", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe", defused: true, armed_location: Location { file: "D:\\a\\rust\\rust\\tests\\run-make\\amdgpu-kd\\rmake.rs", line: 12, col: 5 } }, already_executed: true }
output status: `exit code: 1`
=== STDOUT ===
=== STDERR ===
error: linking with `rust-lld` failed: exit code: 0xc0000374
|
= note: "rust-lld" "-flavor" "gnu" "--version-script=C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\list" "--no-undefined-version" "<1 object files omitted>" "--as-needed" "-L" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\raw-dylibs" "-Bdynamic" "--eh-frame-hdr" "-z" "noexecstack" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "-o" "foo.elf" "--gc-sections" "-shared"
= note: some arguments are omitted. use `--verbose` to show all linker arguments
= note: error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 279 passed; 1 failed; 110 ignored; 0 measured; 6 filtered out; finished in 202.94s
Some tests failed in compiletest suite=run-make mode=run-make host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 2:28:20
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Mon Apr 28 14:12:18 CUT 2025
network time: Mon, 28 Apr 2025 14:12:18 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 28, 2025
@ChrisDenton
ChrisDenton
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
spurious
@bors retry x86_64-mingw-1 0xc0000374
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@ChrisDentonChrisDenton
added
the 
CI-spurious-fail-rust-lld-crash
CI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruption
label
Apr 28, 2025
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dd3ca71 with merge 25cdf1f...
@rust-highfive
rust-highfive
commented
Apr 28, 2025

Copy link


Copy Markdown

Contributor
📣 Toolstate changed by #140388!
Tested on commit 25cdf1f.

Direct link to PR: #140388
💔 reference on windows: test-pass → test-fail (cc @ehuss).

💔 reference on linux: test-pass → test-fail (cc @ehuss).
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 28, 2025
@rust-highfive
📣 Toolstate changed byrust-lang/rust#140388!
054bf2b
Tested on commit rust-lang/rust@25cdf1f.
Direct link to PR: <rust-lang/rust#140388>
💔 reference on windows: test-pass → test-fail (cc @ehuss).
💔 reference on linux: test-pass → test-fail (cc @ehuss).
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: GuillaumeGomez

Pushing 25cdf1f to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Apr 28, 2025
@bors
bors
merged commit 25cdf1f
into
rust-lang:masterApr 28, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 28, 2025
@github-actions
github-actionsBot
commented
Apr 28, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7d65abf (parent) -> 25cdf1f (this PR)
Test differences
Show 8 test diffs

Stage 1
  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J0)
Stage 2
  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J1)
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 25cdf1f67463c9365d8d83778c933ec7480e940b --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-arm-linux: 3456.9s -> 6261.6s (81.1%)
  2. dist-aarch64-linux: 5480.9s -> 7688.6s (40.3%)
  3. dist-x86_64-mingw: 7434.0s -> 9140.9s (23.0%)
  4. x86_64-apple-1: 7256.8s -> 8119.9s (11.9%)
  5. dist-aarch64-apple: 4672.3s -> 5184.4s (11.0%)
  6. dist-x86_64-linux: 5555.9s -> 4994.8s (-10.1%)
  7. i686-msvc-1: 9172.8s -> 10079.0s (9.9%)
  8. dist-apple-various: 6409.8s -> 5839.6s (-8.9%)
  9. x86_64-apple-2: 5323.5s -> 5737.7s (7.8%)
  10. x86_64-gnu-llvm-19-1: 5186.8s -> 5547.5s (7.0%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#140056Fix a wrong error message in 2024 editiond17b7f61e47b3d955ba3ffc936d2c6595af6d870 (link)
#140220Fix detection of main function if there are expressions aro…4f8ada3a92a69b926a855805b7273af20bc4d327 (link)
#140249Remove weak alias terminology676258125ecaa2a0ee386d4311857f47227ed794 (link)
#140316Introduce BoxMarker to improve pretty-printing correctness811001142947076865ab8fda8a87f6eff86d3823 (link)
#140347ci: clean more disk space in codebuild3c44de5caa192bf27dcaa2865f7628f28815f8cd (link)
#140349ci: use aws codebuild for the dist-x86_64-linux job58cb389ea83ffbe73206abf143f65efb6086d66e (link)
#140379rustc-dev-guide subtree update79423ca0196dc2cb74480da44c83f0be10ebdab1 (link)
previous master: 7d65abfe80
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@GuillaumeGomez
GuillaumeGomez
deleted the

rollup-aj9o3ch

branch
April 28, 2025 20:31

This was referenced Apr 28, 2025
 Merged

 Closed

 Merged

 Merged

 Merged

@rust-timer
rust-timer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (25cdf1f): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.6%[-0.6%, -0.6%]1
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary 0.6%, secondary 3.5%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		0.7%[0.4%, 1.5%]11
Regressions ❌ 
 (secondary)		3.5%[2.3%, 4.8%]2
Improvements ✅ 
 (primary)		-0.4%[-0.4%, -0.4%]1
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)0.6%[-0.4%, 1.5%]12
Cycles
Results (primary -0.2%, secondary 3.0%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		1.2%[0.9%, 1.6%]2
Regressions ❌ 
 (secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅ 
 (primary)		-0.6%[-0.9%, -0.4%]6
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-0.2%[-0.9%, 1.6%]8
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 765.314s -> 765.701s (0.05%)
Artifact size: 365.17 MiB -> 365.36 MiB (0.05%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcCI-spurious-fail-rust-lld-crashCI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruptionmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

15 participants

@GuillaumeGomez@bors@rust-log-analyzer@ChrisDenton@rust-highfive@rust-timer@rustbot@hwhsu1231@tshepang@ZuseZ4@BoxyUwU@yuk1ty@marcoieni@JohnTitor@nnethercote

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 7 pull requests - #140388
Merged
bors merged 39 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-aj9o3ch
Apr 28, 2025
Merged
Rollup of 7 pull requests#140388
bors merged 39 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-aj9o3ch
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
hwhsu1231and others
added 30 commits
April 18, 2025 18:49
@hwhsu1231
fix(docs): add newlines between prefix/suffix chapters
399cf1f
add newlines between prefix/suffix chapters in SUMMARY.md
to ensure correct extraction by mdbook-i18n-helpers.
@tshepang
toolchain version does not need to be specified
1b5f2aa
- Rust backcompat removes the need to specify the version here
- Using these commands can result in a needless toolchain getting
downloaded, like in the case where user only has Nightly installed
@ZuseZ4
update build and test instructions
e9896cc
@ZuseZ4
Merge pull requestrust-lang#2350from rust-lang/update-autodiff-buil…
deed996
…d-instr
update build and test instructions
@GuillaumeGomez
Fix detection of main function if there are expressions around it
3536324
@GuillaumeGomez
Add regression ui test forrust-lang#140162and forrust-lang#139651
81438c0
Preparing for merge from rustc
745500f
Merge from rustc
1b315ad
@BoxyUwU
Remove weak alias terminology
bdfeb8f
@tshepang
typo
ba6dd90
@tshepang
Merge pull requestrust-lang#2353from rust-lang/tshepang-patch-1
e6472b3
typo
@GuillaumeGomez
Improve code
3ededc1
@GuillaumeGomez
If there is a ; alone, we consider that the doctest needs to be put…
3ef98a5
… inside a function
@yuk1ty
Fix error message for static references or mutable references
bffb760
@tshepang
Merge pull requestrust-lang#2345from rust-lang/extraneous
7a70f33
toolchain version does not need to be specified
@tshepang
Merge pull requestrust-lang#2343from hwhsu1231-fork/fix-prefix-chapter
3945ae9
fix(docs): add newlines between prefix/suffix chapters
@tshepang
use correct code block markers
79faff2
@tshepang
Merge pull requestrust-lang#2354from rust-lang/tshepang-fix-code-bl…
26a60d4
…ocks
use correct code block markers
@tshepang
copy-paste ease
9eeadbf
@tshepang
Merge pull requestrust-lang#2355from rust-lang/tshepang-patch-1
e40391a
copy-paste ease
@tshepang
replace command that does not work
9c4d568
@tshepang
Merge pull requestrust-lang#2356from rust-lang/tshepang-patch-2
89bb181
replace command that does not work
@GuillaumeGomez
Fix bad handling of macros if there is already a main function
aa69e3a
@marcoieni
ci: clean more disk space in codebuild
474466d
@JohnTitor
Merge pull requestrust-lang#2351from rust-lang/rustc-pull
d91ffb6
Preparing for merge from rustc
de491f9
Merge from rustc
aa15830
@tshepang
Merge pull requestrust-lang#2358from rust-lang/rustc-pull
1b53c12
Rustc pull update
@nnethercote
Introduce BoxMarker to pretty-printing.
aff1be2
The pretty-printers open and close "boxes" of text a lot. The open and
close operations must be matched. The matching is currently all implicit
and very easy to get wrong. (rust-lang#140280 and rust-lang#140246 are two recent
pretty-printing fixes that both involved unclosed boxes.)
This commit introduces `BoxMarker`, a marker type that represents an
open box. It makes box opening/closing explicit, which makes it much
easier to understand and harder to get wrong.
The commit also removes many comments are on `end` calls saying things
like "end outer head-block", "Close the outer-box". These demonstrate
how confusing the implicit approach was, but aren't necessary any more.
@nnethercote
Use PrintState::head in PrintState::block_to_string.
61a66b1
@GuillaumeGomez
GuillaumeGomez
commented
Apr 28, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ p=5 rollup=never
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit dd3ca71 has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dd3ca71 with merge 6655f5c...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
rust-log-analyzer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)
Click to see the possible cause of the failure (guessed by this bot)
---- [run-make] tests\run-make\amdgpu-kd stdout ----
error: rmake recipe failed to complete
status: exit code: 1
command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake.exe"
stdout: none
--- stderr -------------------------------
command failed at line 18
Command { cmd: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "--crate-name" "foo" "--target=amdgcn-amd-amdhsa" "-Ctarget-cpu=gfx900" "--crate-type" "cdylib" "foo.rs", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe", defused: true, armed_location: Location { file: "D:\\a\\rust\\rust\\tests\\run-make\\amdgpu-kd\\rmake.rs", line: 12, col: 5 } }, already_executed: true }
output status: `exit code: 1`
=== STDOUT ===
=== STDERR ===
error: linking with `rust-lld` failed: exit code: 0xc0000374
|
= note: "rust-lld" "-flavor" "gnu" "--version-script=C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\list" "--no-undefined-version" "<1 object files omitted>" "--as-needed" "-L" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\raw-dylibs" "-Bdynamic" "--eh-frame-hdr" "-z" "noexecstack" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "-o" "foo.elf" "--gc-sections" "-shared"
= note: some arguments are omitted. use `--verbose` to show all linker arguments
= note: error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 279 passed; 1 failed; 110 ignored; 0 measured; 6 filtered out; finished in 202.94s
Some tests failed in compiletest suite=run-make mode=run-make host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 2:28:20
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Mon Apr 28 14:12:18 CUT 2025
network time: Mon, 28 Apr 2025 14:12:18 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 28, 2025
@ChrisDenton
ChrisDenton
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
spurious
@bors retry x86_64-mingw-1 0xc0000374
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@ChrisDentonChrisDenton
added
the 
CI-spurious-fail-rust-lld-crash
CI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruption
label
Apr 28, 2025
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dd3ca71 with merge 25cdf1f...
@rust-highfive
rust-highfive
commented
Apr 28, 2025

Copy link


Copy Markdown

Contributor
📣 Toolstate changed by #140388!
Tested on commit 25cdf1f.

Direct link to PR: #140388
💔 reference on windows: test-pass → test-fail (cc @ehuss).

💔 reference on linux: test-pass → test-fail (cc @ehuss).
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 28, 2025
@rust-highfive
📣 Toolstate changed byrust-lang/rust#140388!
054bf2b
Tested on commit rust-lang/rust@25cdf1f.
Direct link to PR: <rust-lang/rust#140388>
💔 reference on windows: test-pass → test-fail (cc @ehuss).
💔 reference on linux: test-pass → test-fail (cc @ehuss).
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: GuillaumeGomez

Pushing 25cdf1f to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Apr 28, 2025
@bors
bors
merged commit 25cdf1f
into
rust-lang:masterApr 28, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 28, 2025
@github-actions
github-actionsBot
commented
Apr 28, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7d65abf (parent) -> 25cdf1f (this PR)
Test differences
Show 8 test diffs

Stage 1
  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J0)
Stage 2
  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J1)
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 25cdf1f67463c9365d8d83778c933ec7480e940b --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-arm-linux: 3456.9s -> 6261.6s (81.1%)
  2. dist-aarch64-linux: 5480.9s -> 7688.6s (40.3%)
  3. dist-x86_64-mingw: 7434.0s -> 9140.9s (23.0%)
  4. x86_64-apple-1: 7256.8s -> 8119.9s (11.9%)
  5. dist-aarch64-apple: 4672.3s -> 5184.4s (11.0%)
  6. dist-x86_64-linux: 5555.9s -> 4994.8s (-10.1%)
  7. i686-msvc-1: 9172.8s -> 10079.0s (9.9%)
  8. dist-apple-various: 6409.8s -> 5839.6s (-8.9%)
  9. x86_64-apple-2: 5323.5s -> 5737.7s (7.8%)
  10. x86_64-gnu-llvm-19-1: 5186.8s -> 5547.5s (7.0%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#140056Fix a wrong error message in 2024 editiond17b7f61e47b3d955ba3ffc936d2c6595af6d870 (link)
#140220Fix detection of main function if there are expressions aro…4f8ada3a92a69b926a855805b7273af20bc4d327 (link)
#140249Remove weak alias terminology676258125ecaa2a0ee386d4311857f47227ed794 (link)
#140316Introduce BoxMarker to improve pretty-printing correctness811001142947076865ab8fda8a87f6eff86d3823 (link)
#140347ci: clean more disk space in codebuild3c44de5caa192bf27dcaa2865f7628f28815f8cd (link)
#140349ci: use aws codebuild for the dist-x86_64-linux job58cb389ea83ffbe73206abf143f65efb6086d66e (link)
#140379rustc-dev-guide subtree update79423ca0196dc2cb74480da44c83f0be10ebdab1 (link)
previous master: 7d65abfe80
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@GuillaumeGomez
GuillaumeGomez
deleted the

rollup-aj9o3ch

branch
April 28, 2025 20:31

This was referenced Apr 28, 2025
 Merged

 Closed

 Merged

 Merged

 Merged

@rust-timer
rust-timer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (25cdf1f): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.6%[-0.6%, -0.6%]1
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary 0.6%, secondary 3.5%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		0.7%[0.4%, 1.5%]11
Regressions ❌ 
 (secondary)		3.5%[2.3%, 4.8%]2
Improvements ✅ 
 (primary)		-0.4%[-0.4%, -0.4%]1
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)0.6%[-0.4%, 1.5%]12
Cycles
Results (primary -0.2%, secondary 3.0%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		1.2%[0.9%, 1.6%]2
Regressions ❌ 
 (secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅ 
 (primary)		-0.6%[-0.9%, -0.4%]6
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-0.2%[-0.9%, 1.6%]8
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 765.314s -> 765.701s (0.05%)
Artifact size: 365.17 MiB -> 365.36 MiB (0.05%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcCI-spurious-fail-rust-lld-crashCI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruptionmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

15 participants

@GuillaumeGomez@bors@rust-log-analyzer@ChrisDenton@rust-highfive@rust-timer@rustbot@hwhsu1231@tshepang@ZuseZ4@BoxyUwU@yuk1ty@marcoieni@JohnTitor@nnethercote

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Rollup of 7 pull requests - #140388
Merged
bors merged 39 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-aj9o3ch
Apr 28, 2025
Merged
Rollup of 7 pull requests#140388
bors merged 39 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-aj9o3ch
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
hwhsu1231and others
added 30 commits
April 18, 2025 18:49
@hwhsu1231
fix(docs): add newlines between prefix/suffix chapters
399cf1f
add newlines between prefix/suffix chapters in SUMMARY.md
to ensure correct extraction by mdbook-i18n-helpers.
@tshepang
toolchain version does not need to be specified
1b5f2aa
- Rust backcompat removes the need to specify the version here
- Using these commands can result in a needless toolchain getting
downloaded, like in the case where user only has Nightly installed
@ZuseZ4
update build and test instructions
e9896cc
@ZuseZ4
Merge pull requestrust-lang#2350from rust-lang/update-autodiff-buil…
deed996
…d-instr
update build and test instructions
@GuillaumeGomez
Fix detection of main function if there are expressions around it
3536324
@GuillaumeGomez
Add regression ui test forrust-lang#140162and forrust-lang#139651
81438c0
Preparing for merge from rustc
745500f
Merge from rustc
1b315ad
@BoxyUwU
Remove weak alias terminology
bdfeb8f
@tshepang
typo
ba6dd90
@tshepang
Merge pull requestrust-lang#2353from rust-lang/tshepang-patch-1
e6472b3
typo
@GuillaumeGomez
Improve code
3ededc1
@GuillaumeGomez
If there is a ; alone, we consider that the doctest needs to be put…
3ef98a5
… inside a function
@yuk1ty
Fix error message for static references or mutable references
bffb760
@tshepang
Merge pull requestrust-lang#2345from rust-lang/extraneous
7a70f33
toolchain version does not need to be specified
@tshepang
Merge pull requestrust-lang#2343from hwhsu1231-fork/fix-prefix-chapter
3945ae9
fix(docs): add newlines between prefix/suffix chapters
@tshepang
use correct code block markers
79faff2
@tshepang
Merge pull requestrust-lang#2354from rust-lang/tshepang-fix-code-bl…
26a60d4
…ocks
use correct code block markers
@tshepang
copy-paste ease
9eeadbf
@tshepang
Merge pull requestrust-lang#2355from rust-lang/tshepang-patch-1
e40391a
copy-paste ease
@tshepang
replace command that does not work
9c4d568
@tshepang
Merge pull requestrust-lang#2356from rust-lang/tshepang-patch-2
89bb181
replace command that does not work
@GuillaumeGomez
Fix bad handling of macros if there is already a main function
aa69e3a
@marcoieni
ci: clean more disk space in codebuild
474466d
@JohnTitor
Merge pull requestrust-lang#2351from rust-lang/rustc-pull
d91ffb6
Preparing for merge from rustc
de491f9
Merge from rustc
aa15830
@tshepang
Merge pull requestrust-lang#2358from rust-lang/rustc-pull
1b53c12
Rustc pull update
@nnethercote
Introduce BoxMarker to pretty-printing.
aff1be2
The pretty-printers open and close "boxes" of text a lot. The open and
close operations must be matched. The matching is currently all implicit
and very easy to get wrong. (rust-lang#140280 and rust-lang#140246 are two recent
pretty-printing fixes that both involved unclosed boxes.)
This commit introduces `BoxMarker`, a marker type that represents an
open box. It makes box opening/closing explicit, which makes it much
easier to understand and harder to get wrong.
The commit also removes many comments are on `end` calls saying things
like "end outer head-block", "Close the outer-box". These demonstrate
how confusing the implicit approach was, but aren't necessary any more.
@nnethercote
Use PrintState::head in PrintState::block_to_string.
61a66b1
@GuillaumeGomez
GuillaumeGomez
commented
Apr 28, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ p=5 rollup=never
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit dd3ca71 has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dd3ca71 with merge 6655f5c...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
rust-log-analyzer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)
Click to see the possible cause of the failure (guessed by this bot)
---- [run-make] tests\run-make\amdgpu-kd stdout ----
error: rmake recipe failed to complete
status: exit code: 1
command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake.exe"
stdout: none
--- stderr -------------------------------
command failed at line 18
Command { cmd: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "--crate-name" "foo" "--target=amdgcn-amd-amdhsa" "-Ctarget-cpu=gfx900" "--crate-type" "cdylib" "foo.rs", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe", defused: true, armed_location: Location { file: "D:\\a\\rust\\rust\\tests\\run-make\\amdgpu-kd\\rmake.rs", line: 12, col: 5 } }, already_executed: true }
output status: `exit code: 1`
=== STDOUT ===
=== STDERR ===
error: linking with `rust-lld` failed: exit code: 0xc0000374
|
= note: "rust-lld" "-flavor" "gnu" "--version-script=C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\list" "--no-undefined-version" "<1 object files omitted>" "--as-needed" "-L" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\raw-dylibs" "-Bdynamic" "--eh-frame-hdr" "-z" "noexecstack" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "-o" "foo.elf" "--gc-sections" "-shared"
= note: some arguments are omitted. use `--verbose` to show all linker arguments
= note: error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 279 passed; 1 failed; 110 ignored; 0 measured; 6 filtered out; finished in 202.94s
Some tests failed in compiletest suite=run-make mode=run-make host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 2:28:20
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Mon Apr 28 14:12:18 CUT 2025
network time: Mon, 28 Apr 2025 14:12:18 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 28, 2025
@ChrisDenton
ChrisDenton
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
spurious
@bors retry x86_64-mingw-1 0xc0000374
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@ChrisDentonChrisDenton
added
the 
CI-spurious-fail-rust-lld-crash
CI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruption
label
Apr 28, 2025
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dd3ca71 with merge 25cdf1f...
@rust-highfive
rust-highfive
commented
Apr 28, 2025

Copy link


Copy Markdown

Contributor
📣 Toolstate changed by #140388!
Tested on commit 25cdf1f.

Direct link to PR: #140388
💔 reference on windows: test-pass → test-fail (cc @ehuss).

💔 reference on linux: test-pass → test-fail (cc @ehuss).
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 28, 2025
@rust-highfive
📣 Toolstate changed byrust-lang/rust#140388!
054bf2b
Tested on commit rust-lang/rust@25cdf1f.
Direct link to PR: <rust-lang/rust#140388>
💔 reference on windows: test-pass → test-fail (cc @ehuss).
💔 reference on linux: test-pass → test-fail (cc @ehuss).
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: GuillaumeGomez

Pushing 25cdf1f to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Apr 28, 2025
@bors
bors
merged commit 25cdf1f
into
rust-lang:masterApr 28, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 28, 2025
@github-actions
github-actionsBot
commented
Apr 28, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7d65abf (parent) -> 25cdf1f (this PR)
Test differences
Show 8 test diffs

Stage 1
  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J0)
Stage 2
  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J1)
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 25cdf1f67463c9365d8d83778c933ec7480e940b --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-arm-linux: 3456.9s -> 6261.6s (81.1%)
  2. dist-aarch64-linux: 5480.9s -> 7688.6s (40.3%)
  3. dist-x86_64-mingw: 7434.0s -> 9140.9s (23.0%)
  4. x86_64-apple-1: 7256.8s -> 8119.9s (11.9%)
  5. dist-aarch64-apple: 4672.3s -> 5184.4s (11.0%)
  6. dist-x86_64-linux: 5555.9s -> 4994.8s (-10.1%)
  7. i686-msvc-1: 9172.8s -> 10079.0s (9.9%)
  8. dist-apple-various: 6409.8s -> 5839.6s (-8.9%)
  9. x86_64-apple-2: 5323.5s -> 5737.7s (7.8%)
  10. x86_64-gnu-llvm-19-1: 5186.8s -> 5547.5s (7.0%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#140056Fix a wrong error message in 2024 editiond17b7f61e47b3d955ba3ffc936d2c6595af6d870 (link)
#140220Fix detection of main function if there are expressions aro…4f8ada3a92a69b926a855805b7273af20bc4d327 (link)
#140249Remove weak alias terminology676258125ecaa2a0ee386d4311857f47227ed794 (link)
#140316Introduce BoxMarker to improve pretty-printing correctness811001142947076865ab8fda8a87f6eff86d3823 (link)
#140347ci: clean more disk space in codebuild3c44de5caa192bf27dcaa2865f7628f28815f8cd (link)
#140349ci: use aws codebuild for the dist-x86_64-linux job58cb389ea83ffbe73206abf143f65efb6086d66e (link)
#140379rustc-dev-guide subtree update79423ca0196dc2cb74480da44c83f0be10ebdab1 (link)
previous master: 7d65abfe80
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@GuillaumeGomez
GuillaumeGomez
deleted the

rollup-aj9o3ch

branch
April 28, 2025 20:31

This was referenced Apr 28, 2025
 Merged

 Closed

 Merged

 Merged

 Merged

@rust-timer
rust-timer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (25cdf1f): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.6%[-0.6%, -0.6%]1
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary 0.6%, secondary 3.5%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		0.7%[0.4%, 1.5%]11
Regressions ❌ 
 (secondary)		3.5%[2.3%, 4.8%]2
Improvements ✅ 
 (primary)		-0.4%[-0.4%, -0.4%]1
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)0.6%[-0.4%, 1.5%]12
Cycles
Results (primary -0.2%, secondary 3.0%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		1.2%[0.9%, 1.6%]2
Regressions ❌ 
 (secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅ 
 (primary)		-0.6%[-0.9%, -0.4%]6
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-0.2%[-0.9%, 1.6%]8
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 765.314s -> 765.701s (0.05%)
Artifact size: 365.17 MiB -> 365.36 MiB (0.05%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcCI-spurious-fail-rust-lld-crashCI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruptionmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

15 participants

@GuillaumeGomez@bors@rust-log-analyzer@ChrisDenton@rust-highfive@rust-timer@rustbot@hwhsu1231@tshepang@ZuseZ4@BoxyUwU@yuk1ty@marcoieni@JohnTitor@nnethercote

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 7 pull requests - #140388
Merged
bors merged 39 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-aj9o3ch
Apr 28, 2025
Merged
Rollup of 7 pull requests#140388
bors merged 39 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-aj9o3ch
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
hwhsu1231and others
added 30 commits
April 18, 2025 18:49
@hwhsu1231
fix(docs): add newlines between prefix/suffix chapters
399cf1f
add newlines between prefix/suffix chapters in SUMMARY.md
to ensure correct extraction by mdbook-i18n-helpers.
@tshepang
toolchain version does not need to be specified
1b5f2aa
- Rust backcompat removes the need to specify the version here
- Using these commands can result in a needless toolchain getting
downloaded, like in the case where user only has Nightly installed
@ZuseZ4
update build and test instructions
e9896cc
@ZuseZ4
Merge pull requestrust-lang#2350from rust-lang/update-autodiff-buil…
deed996
…d-instr
update build and test instructions
@GuillaumeGomez
Fix detection of main function if there are expressions around it
3536324
@GuillaumeGomez
Add regression ui test forrust-lang#140162and forrust-lang#139651
81438c0
Preparing for merge from rustc
745500f
Merge from rustc
1b315ad
@BoxyUwU
Remove weak alias terminology
bdfeb8f
@tshepang
typo
ba6dd90
@tshepang
Merge pull requestrust-lang#2353from rust-lang/tshepang-patch-1
e6472b3
typo
@GuillaumeGomez
Improve code
3ededc1
@GuillaumeGomez
If there is a ; alone, we consider that the doctest needs to be put…
3ef98a5
… inside a function
@yuk1ty
Fix error message for static references or mutable references
bffb760
@tshepang
Merge pull requestrust-lang#2345from rust-lang/extraneous
7a70f33
toolchain version does not need to be specified
@tshepang
Merge pull requestrust-lang#2343from hwhsu1231-fork/fix-prefix-chapter
3945ae9
fix(docs): add newlines between prefix/suffix chapters
@tshepang
use correct code block markers
79faff2
@tshepang
Merge pull requestrust-lang#2354from rust-lang/tshepang-fix-code-bl…
26a60d4
…ocks
use correct code block markers
@tshepang
copy-paste ease
9eeadbf
@tshepang
Merge pull requestrust-lang#2355from rust-lang/tshepang-patch-1
e40391a
copy-paste ease
@tshepang
replace command that does not work
9c4d568
@tshepang
Merge pull requestrust-lang#2356from rust-lang/tshepang-patch-2
89bb181
replace command that does not work
@GuillaumeGomez
Fix bad handling of macros if there is already a main function
aa69e3a
@marcoieni
ci: clean more disk space in codebuild
474466d
@JohnTitor
Merge pull requestrust-lang#2351from rust-lang/rustc-pull
d91ffb6
Preparing for merge from rustc
de491f9
Merge from rustc
aa15830
@tshepang
Merge pull requestrust-lang#2358from rust-lang/rustc-pull
1b53c12
Rustc pull update
@nnethercote
Introduce BoxMarker to pretty-printing.
aff1be2
The pretty-printers open and close "boxes" of text a lot. The open and
close operations must be matched. The matching is currently all implicit
and very easy to get wrong. (rust-lang#140280 and rust-lang#140246 are two recent
pretty-printing fixes that both involved unclosed boxes.)
This commit introduces `BoxMarker`, a marker type that represents an
open box. It makes box opening/closing explicit, which makes it much
easier to understand and harder to get wrong.
The commit also removes many comments are on `end` calls saying things
like "end outer head-block", "Close the outer-box". These demonstrate
how confusing the implicit approach was, but aren't necessary any more.
@nnethercote
Use PrintState::head in PrintState::block_to_string.
61a66b1
@GuillaumeGomez
GuillaumeGomez
commented
Apr 28, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ p=5 rollup=never
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit dd3ca71 has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dd3ca71 with merge 6655f5c...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
rust-log-analyzer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)
Click to see the possible cause of the failure (guessed by this bot)
---- [run-make] tests\run-make\amdgpu-kd stdout ----
error: rmake recipe failed to complete
status: exit code: 1
command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake.exe"
stdout: none
--- stderr -------------------------------
command failed at line 18
Command { cmd: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "--crate-name" "foo" "--target=amdgcn-amd-amdhsa" "-Ctarget-cpu=gfx900" "--crate-type" "cdylib" "foo.rs", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe", defused: true, armed_location: Location { file: "D:\\a\\rust\\rust\\tests\\run-make\\amdgpu-kd\\rmake.rs", line: 12, col: 5 } }, already_executed: true }
output status: `exit code: 1`
=== STDOUT ===
=== STDERR ===
error: linking with `rust-lld` failed: exit code: 0xc0000374
|
= note: "rust-lld" "-flavor" "gnu" "--version-script=C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\list" "--no-undefined-version" "<1 object files omitted>" "--as-needed" "-L" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\raw-dylibs" "-Bdynamic" "--eh-frame-hdr" "-z" "noexecstack" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "-o" "foo.elf" "--gc-sections" "-shared"
= note: some arguments are omitted. use `--verbose` to show all linker arguments
= note: error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 279 passed; 1 failed; 110 ignored; 0 measured; 6 filtered out; finished in 202.94s
Some tests failed in compiletest suite=run-make mode=run-make host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 2:28:20
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Mon Apr 28 14:12:18 CUT 2025
network time: Mon, 28 Apr 2025 14:12:18 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 28, 2025
@ChrisDenton
ChrisDenton
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
spurious
@bors retry x86_64-mingw-1 0xc0000374
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@ChrisDentonChrisDenton
added
the 
CI-spurious-fail-rust-lld-crash
CI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruption
label
Apr 28, 2025
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dd3ca71 with merge 25cdf1f...
@rust-highfive
rust-highfive
commented
Apr 28, 2025

Copy link


Copy Markdown

Contributor
📣 Toolstate changed by #140388!
Tested on commit 25cdf1f.

Direct link to PR: #140388
💔 reference on windows: test-pass → test-fail (cc @ehuss).

💔 reference on linux: test-pass → test-fail (cc @ehuss).
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 28, 2025
@rust-highfive
📣 Toolstate changed byrust-lang/rust#140388!
054bf2b
Tested on commit rust-lang/rust@25cdf1f.
Direct link to PR: <rust-lang/rust#140388>
💔 reference on windows: test-pass → test-fail (cc @ehuss).
💔 reference on linux: test-pass → test-fail (cc @ehuss).
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: GuillaumeGomez

Pushing 25cdf1f to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Apr 28, 2025
@bors
bors
merged commit 25cdf1f
into
rust-lang:masterApr 28, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 28, 2025
@github-actions
github-actionsBot
commented
Apr 28, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7d65abf (parent) -> 25cdf1f (this PR)
Test differences
Show 8 test diffs

Stage 1
  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J0)
Stage 2
  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J1)
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 25cdf1f67463c9365d8d83778c933ec7480e940b --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-arm-linux: 3456.9s -> 6261.6s (81.1%)
  2. dist-aarch64-linux: 5480.9s -> 7688.6s (40.3%)
  3. dist-x86_64-mingw: 7434.0s -> 9140.9s (23.0%)
  4. x86_64-apple-1: 7256.8s -> 8119.9s (11.9%)
  5. dist-aarch64-apple: 4672.3s -> 5184.4s (11.0%)
  6. dist-x86_64-linux: 5555.9s -> 4994.8s (-10.1%)
  7. i686-msvc-1: 9172.8s -> 10079.0s (9.9%)
  8. dist-apple-various: 6409.8s -> 5839.6s (-8.9%)
  9. x86_64-apple-2: 5323.5s -> 5737.7s (7.8%)
  10. x86_64-gnu-llvm-19-1: 5186.8s -> 5547.5s (7.0%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#140056Fix a wrong error message in 2024 editiond17b7f61e47b3d955ba3ffc936d2c6595af6d870 (link)
#140220Fix detection of main function if there are expressions aro…4f8ada3a92a69b926a855805b7273af20bc4d327 (link)
#140249Remove weak alias terminology676258125ecaa2a0ee386d4311857f47227ed794 (link)
#140316Introduce BoxMarker to improve pretty-printing correctness811001142947076865ab8fda8a87f6eff86d3823 (link)
#140347ci: clean more disk space in codebuild3c44de5caa192bf27dcaa2865f7628f28815f8cd (link)
#140349ci: use aws codebuild for the dist-x86_64-linux job58cb389ea83ffbe73206abf143f65efb6086d66e (link)
#140379rustc-dev-guide subtree update79423ca0196dc2cb74480da44c83f0be10ebdab1 (link)
previous master: 7d65abfe80
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@GuillaumeGomez
GuillaumeGomez
deleted the

rollup-aj9o3ch

branch
April 28, 2025 20:31

This was referenced Apr 28, 2025
 Merged

 Closed

 Merged

 Merged

 Merged

@rust-timer
rust-timer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (25cdf1f): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.6%[-0.6%, -0.6%]1
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary 0.6%, secondary 3.5%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		0.7%[0.4%, 1.5%]11
Regressions ❌ 
 (secondary)		3.5%[2.3%, 4.8%]2
Improvements ✅ 
 (primary)		-0.4%[-0.4%, -0.4%]1
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)0.6%[-0.4%, 1.5%]12
Cycles
Results (primary -0.2%, secondary 3.0%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		1.2%[0.9%, 1.6%]2
Regressions ❌ 
 (secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅ 
 (primary)		-0.6%[-0.9%, -0.4%]6
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-0.2%[-0.9%, 1.6%]8
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 765.314s -> 765.701s (0.05%)
Artifact size: 365.17 MiB -> 365.36 MiB (0.05%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcCI-spurious-fail-rust-lld-crashCI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruptionmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

15 participants

@GuillaumeGomez@bors@rust-log-analyzer@ChrisDenton@rust-highfive@rust-timer@rustbot@hwhsu1231@tshepang@ZuseZ4@BoxyUwU@yuk1ty@marcoieni@JohnTitor@nnethercote

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 7 pull requests - #140388
Merged
bors merged 39 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-aj9o3ch
Apr 28, 2025
Merged
Rollup of 7 pull requests#140388
bors merged 39 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-aj9o3ch
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
hwhsu1231and others
added 30 commits
April 18, 2025 18:49
@hwhsu1231
fix(docs): add newlines between prefix/suffix chapters
399cf1f
add newlines between prefix/suffix chapters in SUMMARY.md
to ensure correct extraction by mdbook-i18n-helpers.
@tshepang
toolchain version does not need to be specified
1b5f2aa
- Rust backcompat removes the need to specify the version here
- Using these commands can result in a needless toolchain getting
downloaded, like in the case where user only has Nightly installed
@ZuseZ4
update build and test instructions
e9896cc
@ZuseZ4
Merge pull requestrust-lang#2350from rust-lang/update-autodiff-buil…
deed996
…d-instr
update build and test instructions
@GuillaumeGomez
Fix detection of main function if there are expressions around it
3536324
@GuillaumeGomez
Add regression ui test forrust-lang#140162and forrust-lang#139651
81438c0
Preparing for merge from rustc
745500f
Merge from rustc
1b315ad
@BoxyUwU
Remove weak alias terminology
bdfeb8f
@tshepang
typo
ba6dd90
@tshepang
Merge pull requestrust-lang#2353from rust-lang/tshepang-patch-1
e6472b3
typo
@GuillaumeGomez
Improve code
3ededc1
@GuillaumeGomez
If there is a ; alone, we consider that the doctest needs to be put…
3ef98a5
… inside a function
@yuk1ty
Fix error message for static references or mutable references
bffb760
@tshepang
Merge pull requestrust-lang#2345from rust-lang/extraneous
7a70f33
toolchain version does not need to be specified
@tshepang
Merge pull requestrust-lang#2343from hwhsu1231-fork/fix-prefix-chapter
3945ae9
fix(docs): add newlines between prefix/suffix chapters
@tshepang
use correct code block markers
79faff2
@tshepang
Merge pull requestrust-lang#2354from rust-lang/tshepang-fix-code-bl…
26a60d4
…ocks
use correct code block markers
@tshepang
copy-paste ease
9eeadbf
@tshepang
Merge pull requestrust-lang#2355from rust-lang/tshepang-patch-1
e40391a
copy-paste ease
@tshepang
replace command that does not work
9c4d568
@tshepang
Merge pull requestrust-lang#2356from rust-lang/tshepang-patch-2
89bb181
replace command that does not work
@GuillaumeGomez
Fix bad handling of macros if there is already a main function
aa69e3a
@marcoieni
ci: clean more disk space in codebuild
474466d
@JohnTitor
Merge pull requestrust-lang#2351from rust-lang/rustc-pull
d91ffb6
Preparing for merge from rustc
de491f9
Merge from rustc
aa15830
@tshepang
Merge pull requestrust-lang#2358from rust-lang/rustc-pull
1b53c12
Rustc pull update
@nnethercote
Introduce BoxMarker to pretty-printing.
aff1be2
The pretty-printers open and close "boxes" of text a lot. The open and
close operations must be matched. The matching is currently all implicit
and very easy to get wrong. (rust-lang#140280 and rust-lang#140246 are two recent
pretty-printing fixes that both involved unclosed boxes.)
This commit introduces `BoxMarker`, a marker type that represents an
open box. It makes box opening/closing explicit, which makes it much
easier to understand and harder to get wrong.
The commit also removes many comments are on `end` calls saying things
like "end outer head-block", "Close the outer-box". These demonstrate
how confusing the implicit approach was, but aren't necessary any more.
@nnethercote
Use PrintState::head in PrintState::block_to_string.
61a66b1
@GuillaumeGomez
GuillaumeGomez
commented
Apr 28, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ p=5 rollup=never
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit dd3ca71 has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dd3ca71 with merge 6655f5c...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
rust-log-analyzer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)
Click to see the possible cause of the failure (guessed by this bot)
---- [run-make] tests\run-make\amdgpu-kd stdout ----
error: rmake recipe failed to complete
status: exit code: 1
command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake.exe"
stdout: none
--- stderr -------------------------------
command failed at line 18
Command { cmd: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "--crate-name" "foo" "--target=amdgcn-amd-amdhsa" "-Ctarget-cpu=gfx900" "--crate-type" "cdylib" "foo.rs", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe", defused: true, armed_location: Location { file: "D:\\a\\rust\\rust\\tests\\run-make\\amdgpu-kd\\rmake.rs", line: 12, col: 5 } }, already_executed: true }
output status: `exit code: 1`
=== STDOUT ===
=== STDERR ===
error: linking with `rust-lld` failed: exit code: 0xc0000374
|
= note: "rust-lld" "-flavor" "gnu" "--version-script=C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\list" "--no-undefined-version" "<1 object files omitted>" "--as-needed" "-L" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\raw-dylibs" "-Bdynamic" "--eh-frame-hdr" "-z" "noexecstack" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "-o" "foo.elf" "--gc-sections" "-shared"
= note: some arguments are omitted. use `--verbose` to show all linker arguments
= note: error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 279 passed; 1 failed; 110 ignored; 0 measured; 6 filtered out; finished in 202.94s
Some tests failed in compiletest suite=run-make mode=run-make host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 2:28:20
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Mon Apr 28 14:12:18 CUT 2025
network time: Mon, 28 Apr 2025 14:12:18 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 28, 2025
@ChrisDenton
ChrisDenton
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
spurious
@bors retry x86_64-mingw-1 0xc0000374
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@ChrisDentonChrisDenton
added
the 
CI-spurious-fail-rust-lld-crash
CI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruption
label
Apr 28, 2025
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dd3ca71 with merge 25cdf1f...
@rust-highfive
rust-highfive
commented
Apr 28, 2025

Copy link


Copy Markdown

Contributor
📣 Toolstate changed by #140388!
Tested on commit 25cdf1f.

Direct link to PR: #140388
💔 reference on windows: test-pass → test-fail (cc @ehuss).

💔 reference on linux: test-pass → test-fail (cc @ehuss).
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 28, 2025
@rust-highfive
📣 Toolstate changed byrust-lang/rust#140388!
054bf2b
Tested on commit rust-lang/rust@25cdf1f.
Direct link to PR: <rust-lang/rust#140388>
💔 reference on windows: test-pass → test-fail (cc @ehuss).
💔 reference on linux: test-pass → test-fail (cc @ehuss).
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: GuillaumeGomez

Pushing 25cdf1f to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Apr 28, 2025
@bors
bors
merged commit 25cdf1f
into
rust-lang:masterApr 28, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 28, 2025
@github-actions
github-actionsBot
commented
Apr 28, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7d65abf (parent) -> 25cdf1f (this PR)
Test differences
Show 8 test diffs

Stage 1
  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J0)
Stage 2
  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J1)
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 25cdf1f67463c9365d8d83778c933ec7480e940b --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-arm-linux: 3456.9s -> 6261.6s (81.1%)
  2. dist-aarch64-linux: 5480.9s -> 7688.6s (40.3%)
  3. dist-x86_64-mingw: 7434.0s -> 9140.9s (23.0%)
  4. x86_64-apple-1: 7256.8s -> 8119.9s (11.9%)
  5. dist-aarch64-apple: 4672.3s -> 5184.4s (11.0%)
  6. dist-x86_64-linux: 5555.9s -> 4994.8s (-10.1%)
  7. i686-msvc-1: 9172.8s -> 10079.0s (9.9%)
  8. dist-apple-various: 6409.8s -> 5839.6s (-8.9%)
  9. x86_64-apple-2: 5323.5s -> 5737.7s (7.8%)
  10. x86_64-gnu-llvm-19-1: 5186.8s -> 5547.5s (7.0%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#140056Fix a wrong error message in 2024 editiond17b7f61e47b3d955ba3ffc936d2c6595af6d870 (link)
#140220Fix detection of main function if there are expressions aro…4f8ada3a92a69b926a855805b7273af20bc4d327 (link)
#140249Remove weak alias terminology676258125ecaa2a0ee386d4311857f47227ed794 (link)
#140316Introduce BoxMarker to improve pretty-printing correctness811001142947076865ab8fda8a87f6eff86d3823 (link)
#140347ci: clean more disk space in codebuild3c44de5caa192bf27dcaa2865f7628f28815f8cd (link)
#140349ci: use aws codebuild for the dist-x86_64-linux job58cb389ea83ffbe73206abf143f65efb6086d66e (link)
#140379rustc-dev-guide subtree update79423ca0196dc2cb74480da44c83f0be10ebdab1 (link)
previous master: 7d65abfe80
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@GuillaumeGomez
GuillaumeGomez
deleted the

rollup-aj9o3ch

branch
April 28, 2025 20:31

This was referenced Apr 28, 2025
 Merged

 Closed

 Merged

 Merged

 Merged

@rust-timer
rust-timer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (25cdf1f): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.6%[-0.6%, -0.6%]1
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary 0.6%, secondary 3.5%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		0.7%[0.4%, 1.5%]11
Regressions ❌ 
 (secondary)		3.5%[2.3%, 4.8%]2
Improvements ✅ 
 (primary)		-0.4%[-0.4%, -0.4%]1
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)0.6%[-0.4%, 1.5%]12
Cycles
Results (primary -0.2%, secondary 3.0%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		1.2%[0.9%, 1.6%]2
Regressions ❌ 
 (secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅ 
 (primary)		-0.6%[-0.9%, -0.4%]6
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-0.2%[-0.9%, 1.6%]8
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 765.314s -> 765.701s (0.05%)
Artifact size: 365.17 MiB -> 365.36 MiB (0.05%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcCI-spurious-fail-rust-lld-crashCI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruptionmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

15 participants

@GuillaumeGomez@bors@rust-log-analyzer@ChrisDenton@rust-highfive@rust-timer@rustbot@hwhsu1231@tshepang@ZuseZ4@BoxyUwU@yuk1ty@marcoieni@JohnTitor@nnethercote

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Rollup of 7 pull requests - #140388
Merged
bors merged 39 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-aj9o3ch
Apr 28, 2025
Merged
Rollup of 7 pull requests#140388
bors merged 39 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-aj9o3ch
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
hwhsu1231and others
added 30 commits
April 18, 2025 18:49
@hwhsu1231
fix(docs): add newlines between prefix/suffix chapters
399cf1f
add newlines between prefix/suffix chapters in SUMMARY.md
to ensure correct extraction by mdbook-i18n-helpers.
@tshepang
toolchain version does not need to be specified
1b5f2aa
- Rust backcompat removes the need to specify the version here
- Using these commands can result in a needless toolchain getting
downloaded, like in the case where user only has Nightly installed
@ZuseZ4
update build and test instructions
e9896cc
@ZuseZ4
Merge pull requestrust-lang#2350from rust-lang/update-autodiff-buil…
deed996
…d-instr
update build and test instructions
@GuillaumeGomez
Fix detection of main function if there are expressions around it
3536324
@GuillaumeGomez
Add regression ui test forrust-lang#140162and forrust-lang#139651
81438c0
Preparing for merge from rustc
745500f
Merge from rustc
1b315ad
@BoxyUwU
Remove weak alias terminology
bdfeb8f
@tshepang
typo
ba6dd90
@tshepang
Merge pull requestrust-lang#2353from rust-lang/tshepang-patch-1
e6472b3
typo
@GuillaumeGomez
Improve code
3ededc1
@GuillaumeGomez
If there is a ; alone, we consider that the doctest needs to be put…
3ef98a5
… inside a function
@yuk1ty
Fix error message for static references or mutable references
bffb760
@tshepang
Merge pull requestrust-lang#2345from rust-lang/extraneous
7a70f33
toolchain version does not need to be specified
@tshepang
Merge pull requestrust-lang#2343from hwhsu1231-fork/fix-prefix-chapter
3945ae9
fix(docs): add newlines between prefix/suffix chapters
@tshepang
use correct code block markers
79faff2
@tshepang
Merge pull requestrust-lang#2354from rust-lang/tshepang-fix-code-bl…
26a60d4
…ocks
use correct code block markers
@tshepang
copy-paste ease
9eeadbf
@tshepang
Merge pull requestrust-lang#2355from rust-lang/tshepang-patch-1
e40391a
copy-paste ease
@tshepang
replace command that does not work
9c4d568
@tshepang
Merge pull requestrust-lang#2356from rust-lang/tshepang-patch-2
89bb181
replace command that does not work
@GuillaumeGomez
Fix bad handling of macros if there is already a main function
aa69e3a
@marcoieni
ci: clean more disk space in codebuild
474466d
@JohnTitor
Merge pull requestrust-lang#2351from rust-lang/rustc-pull
d91ffb6
Preparing for merge from rustc
de491f9
Merge from rustc
aa15830
@tshepang
Merge pull requestrust-lang#2358from rust-lang/rustc-pull
1b53c12
Rustc pull update
@nnethercote
Introduce BoxMarker to pretty-printing.
aff1be2
The pretty-printers open and close "boxes" of text a lot. The open and
close operations must be matched. The matching is currently all implicit
and very easy to get wrong. (rust-lang#140280 and rust-lang#140246 are two recent
pretty-printing fixes that both involved unclosed boxes.)
This commit introduces `BoxMarker`, a marker type that represents an
open box. It makes box opening/closing explicit, which makes it much
easier to understand and harder to get wrong.
The commit also removes many comments are on `end` calls saying things
like "end outer head-block", "Close the outer-box". These demonstrate
how confusing the implicit approach was, but aren't necessary any more.
@nnethercote
Use PrintState::head in PrintState::block_to_string.
61a66b1
@GuillaumeGomez
GuillaumeGomez
commented
Apr 28, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ p=5 rollup=never
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit dd3ca71 has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dd3ca71 with merge 6655f5c...
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2025
@bors
Auto merge ofrust-lang#140388- GuillaumeGomez:rollup-aj9o3ch, r=Gui…
6655f5c
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#140056 (Fix a wrong error message in 2024 edition)
- rust-lang#140220 (Fix detection of main function if there are expressions around it)
- rust-lang#140249 (Remove `weak` alias terminology)
- rust-lang#140316 (Introduce `BoxMarker` to improve pretty-printing correctness)
- rust-lang#140347 (ci: clean more disk space in codebuild)
- rust-lang#140349 (ci: use aws codebuild for the `dist-x86_64-linux` job)
- rust-lang#140379 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
rust-log-analyzer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)
Click to see the possible cause of the failure (guessed by this bot)
---- [run-make] tests\run-make\amdgpu-kd stdout ----
error: rmake recipe failed to complete
status: exit code: 1
command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake.exe"
stdout: none
--- stderr -------------------------------
command failed at line 18
Command { cmd: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "--crate-name" "foo" "--target=amdgcn-amd-amdhsa" "-Ctarget-cpu=gfx900" "--crate-type" "cdylib" "foo.rs", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe", defused: true, armed_location: Location { file: "D:\\a\\rust\\rust\\tests\\run-make\\amdgpu-kd\\rmake.rs", line: 12, col: 5 } }, already_executed: true }
output status: `exit code: 1`
=== STDOUT ===
=== STDERR ===
error: linking with `rust-lld` failed: exit code: 0xc0000374
|
= note: "rust-lld" "-flavor" "gnu" "--version-script=C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\list" "--no-undefined-version" "<1 object files omitted>" "--as-needed" "-L" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustch5txN7\\raw-dylibs" "-Bdynamic" "--eh-frame-hdr" "-z" "noexecstack" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\amdgpu-kd\\rmake_out" "-o" "foo.elf" "--gc-sections" "-shared"
= note: some arguments are omitted. use `--verbose` to show all linker arguments
= note: error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 279 passed; 1 failed; 110 ignored; 0 measured; 6 filtered out; finished in 202.94s
Some tests failed in compiletest suite=run-make mode=run-make host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 2:28:20
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Mon Apr 28 14:12:18 CUT 2025
network time: Mon, 28 Apr 2025 14:12:18 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 28, 2025
@ChrisDenton
ChrisDenton
commented
Apr 28, 2025

Copy link


Copy Markdown

Member
spurious
@bors retry x86_64-mingw-1 0xc0000374
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2025
@ChrisDentonChrisDenton
added
the 
CI-spurious-fail-rust-lld-crash
CI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruption
label
Apr 28, 2025
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dd3ca71 with merge 25cdf1f...
@rust-highfive
rust-highfive
commented
Apr 28, 2025

Copy link


Copy Markdown

Contributor
📣 Toolstate changed by #140388!
Tested on commit 25cdf1f.

Direct link to PR: #140388
💔 reference on windows: test-pass → test-fail (cc @ehuss).

💔 reference on linux: test-pass → test-fail (cc @ehuss).
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 28, 2025
@rust-highfive
📣 Toolstate changed byrust-lang/rust#140388!
054bf2b
Tested on commit rust-lang/rust@25cdf1f.
Direct link to PR: <rust-lang/rust#140388>
💔 reference on windows: test-pass → test-fail (cc @ehuss).
💔 reference on linux: test-pass → test-fail (cc @ehuss).
@bors
bors
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: GuillaumeGomez

Pushing 25cdf1f to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Apr 28, 2025
@bors
bors
merged commit 25cdf1f
into
rust-lang:masterApr 28, 2025
@rustbotrustbot
added this to the 1.88.0 milestone
Apr 28, 2025
@github-actions
github-actionsBot
commented
Apr 28, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7d65abf (parent) -> 25cdf1f (this PR)
Test differences
Show 8 test diffs

Stage 1
  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J0)
Stage 2
  • [ui] tests/rustdoc-ui/doctest/macro-after-main.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/test-main-alongside-exprs.rs: [missing] -> pass (J1)
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 25cdf1f67463c9365d8d83778c933ec7480e940b --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-arm-linux: 3456.9s -> 6261.6s (81.1%)
  2. dist-aarch64-linux: 5480.9s -> 7688.6s (40.3%)
  3. dist-x86_64-mingw: 7434.0s -> 9140.9s (23.0%)
  4. x86_64-apple-1: 7256.8s -> 8119.9s (11.9%)
  5. dist-aarch64-apple: 4672.3s -> 5184.4s (11.0%)
  6. dist-x86_64-linux: 5555.9s -> 4994.8s (-10.1%)
  7. i686-msvc-1: 9172.8s -> 10079.0s (9.9%)
  8. dist-apple-various: 6409.8s -> 5839.6s (-8.9%)
  9. x86_64-apple-2: 5323.5s -> 5737.7s (7.8%)
  10. x86_64-gnu-llvm-19-1: 5186.8s -> 5547.5s (7.0%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#140056Fix a wrong error message in 2024 editiond17b7f61e47b3d955ba3ffc936d2c6595af6d870 (link)
#140220Fix detection of main function if there are expressions aro…4f8ada3a92a69b926a855805b7273af20bc4d327 (link)
#140249Remove weak alias terminology676258125ecaa2a0ee386d4311857f47227ed794 (link)
#140316Introduce BoxMarker to improve pretty-printing correctness811001142947076865ab8fda8a87f6eff86d3823 (link)
#140347ci: clean more disk space in codebuild3c44de5caa192bf27dcaa2865f7628f28815f8cd (link)
#140349ci: use aws codebuild for the dist-x86_64-linux job58cb389ea83ffbe73206abf143f65efb6086d66e (link)
#140379rustc-dev-guide subtree update79423ca0196dc2cb74480da44c83f0be10ebdab1 (link)
previous master: 7d65abfe80
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@GuillaumeGomez
GuillaumeGomez
deleted the

rollup-aj9o3ch

branch
April 28, 2025 20:31

This was referenced Apr 28, 2025
 Merged

 Closed

 Merged

 Merged

 Merged

@rust-timer
rust-timer
commented
Apr 28, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (25cdf1f): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.6%[-0.6%, -0.6%]1
All ❌✅ (primary)--0
Max RSS (memory usage)
Results (primary 0.6%, secondary 3.5%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		0.7%[0.4%, 1.5%]11
Regressions ❌ 
 (secondary)		3.5%[2.3%, 4.8%]2
Improvements ✅ 
 (primary)		-0.4%[-0.4%, -0.4%]1
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)0.6%[-0.4%, 1.5%]12
Cycles
Results (primary -0.2%, secondary 3.0%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		1.2%[0.9%, 1.6%]2
Regressions ❌ 
 (secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅ 
 (primary)		-0.6%[-0.9%, -0.4%]6
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-0.2%[-0.9%, 1.6%]8
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 765.314s -> 765.701s (0.05%)
Artifact size: 365.17 MiB -> 365.36 MiB (0.05%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcCI-spurious-fail-rust-lld-crashCI spurious failure: `rust-lld` crashing / SIGSEGV / 0xc0000374 heap corruptionmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects


None yet


Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

15 participants

@GuillaumeGomez@bors@rust-log-analyzer@ChrisDenton@rust-highfive@rust-timer@rustbot@hwhsu1231@tshepang@ZuseZ4@BoxyUwU@yuk1ty@marcoieni@JohnTitor@nnethercote