Skip to content

Fix for async drop ice with partly dropped tuple - #140458

Merged
bors merged 1 commit into
rust-lang:masterfrom
azhogin:azhogin/async-drop-fix-dropped-tuple-ice
Apr 30, 2025
Merged

Fix for async drop ice with partly dropped tuple#140458
bors merged 1 commit into
rust-lang:masterfrom
azhogin:azhogin/async-drop-fix-dropped-tuple-ice

Conversation

@azhogin

@azhoginazhogin commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

Fixes#140427.
Problem was with block data access with block id from new added blocks in patch.

@rustbot

rustbot commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 29, 2025
@rustbot

rustbot commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@azhogin

azhogin commented Apr 29, 2025

Copy link
Copy Markdown
ContributorAuthor

r? oli-obk

@rustbotrustbot assigned oli-obk and unassigned lcnrApr 29, 2025
This was referenced Apr 29, 2025
Closed
Closed
@oli-obk

oli-obk commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit f420ceb has been approved by oli-obk

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk

oli-obk commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 29, 2025
@oli-obk

oli-obk commented Apr 29, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

needs rustfmt

@azhogin
azhoginforce-pushed the azhogin/async-drop-fix-dropped-tuple-ice branch from f420ceb to cce706eCompareApril 29, 2025 14:41
@oli-obk

oli-obk commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit cce706e has been approved by oli-obk

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 29, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 30, 2025
@Zalathar
Rollup merge ofrust-lang#140458- azhogin:azhogin/async-drop-fix-dro…
4cb39af
…pped-tuple-ice, r=oli-obk
Fix for async drop ice with partly dropped tuple
Fixesrust-lang#140427.
Problem was with block data access with block id from new added blocks in patch.
@ZalatharZalathar mentioned this pull request Apr 30, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
@bors
Auto merge ofrust-lang#140501- Zalathar:rollup-86sqqur, r=Zalathar
c639c67
Rollup of 14 pull requests
Successful merges:
- rust-lang#140380 (transmutability: uninit transition matches unit byte only)
- rust-lang#140385 (Subtree update of `rust-analyzer`)
- rust-lang#140395 (organize and extend forbidden target feature tests)
- rust-lang#140430 (Improve test coverage of HIR pretty printing.)
- rust-lang#140458 (Fix for async drop ice with partly dropped tuple)
- rust-lang#140460 (Fix handling of LoongArch target features not supported by LLVM 19)
- rust-lang#140465 (chore: edit and move tests)
- rust-lang#140467 (Don't FCW assoc consts in patterns)
- rust-lang#140468 (Minor tweaks to make some normalization (adjacent) code less confusing)
- rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4)
- rust-lang#140476 (chore: delete unused ui/auxiliary crates)
- rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs)
- rust-lang#140486 (rustfmt: Also allow bool literals as first item of let chain)
- rust-lang#140494 (Parser: Document restrictions)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 30, 2025
@Zalathar
Rollup merge ofrust-lang#140458- azhogin:azhogin/async-drop-fix-dro…
a44da0a
…pped-tuple-ice, r=oli-obk
Fix for async drop ice with partly dropped tuple
Fixesrust-lang#140427.
Problem was with block data access with block id from new added blocks in patch.
@ZalatharZalathar mentioned this pull request Apr 30, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
@bors
Auto merge ofrust-lang#140510- Zalathar:rollup-zcbws0g, r=Zalathar
902555b
Rollup of 13 pull requests
Successful merges:
- rust-lang#140380 (transmutability: uninit transition matches unit byte only)
- rust-lang#140385 (Subtree update of `rust-analyzer`)
- rust-lang#140395 (organize and extend forbidden target feature tests)
- rust-lang#140458 (Fix for async drop ice with partly dropped tuple)
- rust-lang#140460 (Fix handling of LoongArch target features not supported by LLVM 19)
- rust-lang#140465 (chore: edit and move tests)
- rust-lang#140467 (Don't FCW assoc consts in patterns)
- rust-lang#140468 (Minor tweaks to make some normalization (adjacent) code less confusing)
- rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4)
- rust-lang#140476 (chore: delete unused ui/auxiliary crates)
- rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs)
- rust-lang#140486 (rustfmt: Also allow bool literals as first item of let chain)
- rust-lang#140494 (Parser: Document restrictions)
r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 30, 2025
@matthiaskrgr
Rollup merge ofrust-lang#140458- azhogin:azhogin/async-drop-fix-dro…
9248ef2
…pped-tuple-ice, r=oli-obk
Fix for async drop ice with partly dropped tuple
Fixesrust-lang#140427.
Problem was with block data access with block id from new added blocks in patch.
@matthiaskrgrmatthiaskrgr mentioned this pull request Apr 30, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
@bors
Auto merge ofrust-lang#140528- matthiaskrgr:rollup-ewstp7o, r=matth…
466106f
…iaskrgr
Rollup of 11 pull requests
Successful merges:
- rust-lang#140380 (transmutability: uninit transition matches unit byte only)
- rust-lang#140385 (Subtree update of `rust-analyzer`)
- rust-lang#140458 (Fix for async drop ice with partly dropped tuple)
- rust-lang#140465 (chore: edit and move tests)
- rust-lang#140467 (Don't FCW assoc consts in patterns)
- rust-lang#140468 (Minor tweaks to make some normalization (adjacent) code less confusing)
- rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4)
- rust-lang#140476 (chore: delete unused ui/auxiliary crates)
- rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs)
- rust-lang#140486 (rustfmt: Also allow bool literals as first item of let chain)
- rust-lang#140494 (Parser: Document restrictions)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr mentioned this pull request Apr 30, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
@bors
Auto merge ofrust-lang#140529- matthiaskrgr:rollup-jpaa2ky, r=matth…
b45dd71
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#140385 (Subtree update of `rust-analyzer`)
- rust-lang#140458 (Fix for async drop ice with partly dropped tuple)
- rust-lang#140465 (chore: edit and move tests)
- rust-lang#140467 (Don't FCW assoc consts in patterns)
- rust-lang#140468 (Minor tweaks to make some normalization (adjacent) code less confusing)
- rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4)
- rust-lang#140476 (chore: delete unused ui/auxiliary crates)
- rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs)
- rust-lang#140486 (rustfmt: Also allow bool literals as first item of let chain)
- rust-lang#140494 (Parser: Document restrictions)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 3648f3a into rust-lang:masterApr 30, 2025
@rustbotrustbot added this to the 1.88.0 milestone Apr 30, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
@rust-timer
Unrolled build forrust-lang#140458
3730892
Rollup merge of rust-lang#140458 - azhogin:azhogin/async-drop-fix-dropped-tuple-ice, r=oli-obk
Fix for async drop ice with partly dropped tuple
Fixesrust-lang#140427.
Problem was with block data access with block id from new added blocks in patch.
@petrochenkovpetrochenkov added the F-async_drop `#![feature(async_drop)]` label May 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obkoli-obk

Labels

F-async_drop`#![feature(async_drop)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

async drop ice with partly dropped tuple

7 participants

@azhogin@rustbot@oli-obk@bors@rust-log-analyzer@petrochenkov@lcnr