Skip to content

Require sanitizers be enabled for asan_odr_windows.rs - #140481

Merged
bors merged 1 commit into
rust-lang:masterfrom
dpaoliello:reqasan
Apr 30, 2025
Merged

Require sanitizers be enabled for asan_odr_windows.rs#140481
bors merged 1 commit into
rust-lang:masterfrom
dpaoliello:reqasan

Conversation

@dpaoliello

@dpaoliellodpaoliello commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

Issue Details:
The asan_odr_windows.rs test is failing on AArch64 Windows, as sanitizers aren't supported on that platform.

Fix Details:
Apply the correct "need sanitizer" requirements to the test.

@rustbot

rustbot commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 29, 2025
@rustbot

rustbot commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in tests/ui/sanitizer

cc @rcvalle

@wesleywiser

wesleywiser commented Apr 29, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit c3befaa has been approved by wesleywiser

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2025
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 30, 2025
@ChrisDenton
Rollup merge ofrust-lang#140481- dpaoliello:reqasan, r=wesleywiser
c9e0cce
Require sanitizers be enabled for asan_odr_windows.rs
Issue Details:
The `asan_odr_windows.rs` test is failing on AArch64 Windows, as sanitizers aren't supported on that platform.
Fix Details:
Apply the correct "need sanitizer" requirements to the test.
@ChrisDentonChrisDenton mentioned this pull request Apr 30, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
@bors
Auto merge ofrust-lang#140495- ChrisDenton:rollup-wqm2yat, r=ChrisD…
0b7df37
…enton
Rollup of 9 pull requests
Successful merges:
- rust-lang#139192 (mention provenance in the pointer::wrapping_offset docs)
- rust-lang#140176 (Fix linking statics on Arm64EC)
- rust-lang#140404 (rm `TypeVistable` impls for `Canonical`)
- rust-lang#140437 (enable msa feature for mips in codegen tests)
- rust-lang#140438 (Add `rust.debug-assertions-tools` option)
- rust-lang#140446 (chore: fix some tests)
- rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4)
- rust-lang#140476 (chore: delete unused ui/auxiliary crates)
- rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 30, 2025
@Zalathar
Rollup merge ofrust-lang#140481- dpaoliello:reqasan, r=wesleywiser
bc38611
Require sanitizers be enabled for asan_odr_windows.rs
Issue Details:
The `asan_odr_windows.rs` test is failing on AArch64 Windows, as sanitizers aren't supported on that platform.
Fix Details:
Apply the correct "need sanitizer" requirements to the test.
@ZalatharZalathar mentioned this pull request Apr 30, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
@bors
Auto merge ofrust-lang#140501- Zalathar:rollup-86sqqur, r=Zalathar
c639c67
Rollup of 14 pull requests
Successful merges:
- rust-lang#140380 (transmutability: uninit transition matches unit byte only)
- rust-lang#140385 (Subtree update of `rust-analyzer`)
- rust-lang#140395 (organize and extend forbidden target feature tests)
- rust-lang#140430 (Improve test coverage of HIR pretty printing.)
- rust-lang#140458 (Fix for async drop ice with partly dropped tuple)
- rust-lang#140460 (Fix handling of LoongArch target features not supported by LLVM 19)
- rust-lang#140465 (chore: edit and move tests)
- rust-lang#140467 (Don't FCW assoc consts in patterns)
- rust-lang#140468 (Minor tweaks to make some normalization (adjacent) code less confusing)
- rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4)
- rust-lang#140476 (chore: delete unused ui/auxiliary crates)
- rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs)
- rust-lang#140486 (rustfmt: Also allow bool literals as first item of let chain)
- rust-lang#140494 (Parser: Document restrictions)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 30, 2025
@Zalathar
Rollup merge ofrust-lang#140481- dpaoliello:reqasan, r=wesleywiser
ba1d1c3
Require sanitizers be enabled for asan_odr_windows.rs
Issue Details:
The `asan_odr_windows.rs` test is failing on AArch64 Windows, as sanitizers aren't supported on that platform.
Fix Details:
Apply the correct "need sanitizer" requirements to the test.
@ZalatharZalathar mentioned this pull request Apr 30, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
@bors
Auto merge ofrust-lang#140510- Zalathar:rollup-zcbws0g, r=Zalathar
902555b
Rollup of 13 pull requests
Successful merges:
- rust-lang#140380 (transmutability: uninit transition matches unit byte only)
- rust-lang#140385 (Subtree update of `rust-analyzer`)
- rust-lang#140395 (organize and extend forbidden target feature tests)
- rust-lang#140458 (Fix for async drop ice with partly dropped tuple)
- rust-lang#140460 (Fix handling of LoongArch target features not supported by LLVM 19)
- rust-lang#140465 (chore: edit and move tests)
- rust-lang#140467 (Don't FCW assoc consts in patterns)
- rust-lang#140468 (Minor tweaks to make some normalization (adjacent) code less confusing)
- rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4)
- rust-lang#140476 (chore: delete unused ui/auxiliary crates)
- rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs)
- rust-lang#140486 (rustfmt: Also allow bool literals as first item of let chain)
- rust-lang#140494 (Parser: Document restrictions)
r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 30, 2025
@matthiaskrgr
Rollup merge ofrust-lang#140481- dpaoliello:reqasan, r=wesleywiser
a9868d5
Require sanitizers be enabled for asan_odr_windows.rs
Issue Details:
The `asan_odr_windows.rs` test is failing on AArch64 Windows, as sanitizers aren't supported on that platform.
Fix Details:
Apply the correct "need sanitizer" requirements to the test.
@matthiaskrgrmatthiaskrgr mentioned this pull request Apr 30, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
@bors
Auto merge ofrust-lang#140528- matthiaskrgr:rollup-ewstp7o, r=matth…
466106f
…iaskrgr
Rollup of 11 pull requests
Successful merges:
- rust-lang#140380 (transmutability: uninit transition matches unit byte only)
- rust-lang#140385 (Subtree update of `rust-analyzer`)
- rust-lang#140458 (Fix for async drop ice with partly dropped tuple)
- rust-lang#140465 (chore: edit and move tests)
- rust-lang#140467 (Don't FCW assoc consts in patterns)
- rust-lang#140468 (Minor tweaks to make some normalization (adjacent) code less confusing)
- rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4)
- rust-lang#140476 (chore: delete unused ui/auxiliary crates)
- rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs)
- rust-lang#140486 (rustfmt: Also allow bool literals as first item of let chain)
- rust-lang#140494 (Parser: Document restrictions)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr mentioned this pull request Apr 30, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
@bors
Auto merge ofrust-lang#140529- matthiaskrgr:rollup-jpaa2ky, r=matth…
b45dd71
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#140385 (Subtree update of `rust-analyzer`)
- rust-lang#140458 (Fix for async drop ice with partly dropped tuple)
- rust-lang#140465 (chore: edit and move tests)
- rust-lang#140467 (Don't FCW assoc consts in patterns)
- rust-lang#140468 (Minor tweaks to make some normalization (adjacent) code less confusing)
- rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4)
- rust-lang#140476 (chore: delete unused ui/auxiliary crates)
- rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs)
- rust-lang#140486 (rustfmt: Also allow bool literals as first item of let chain)
- rust-lang#140494 (Parser: Document restrictions)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1ce0601 into rust-lang:masterApr 30, 2025
@rustbotrustbot added this to the 1.88.0 milestone Apr 30, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
@rust-timer
Unrolled build forrust-lang#140481
41d9b10
Rollup merge of rust-lang#140481 - dpaoliello:reqasan, r=wesleywiser
Require sanitizers be enabled for asan_odr_windows.rs
Issue Details:
The `asan_odr_windows.rs` test is failing on AArch64 Windows, as sanitizers aren't supported on that platform.
Fix Details:
Apply the correct "need sanitizer" requirements to the test.
@dpaoliello
dpaoliello deleted the reqasan branch May 1, 2025 19:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiserwesleywiserwesleywiser approved these changes

Assignees

@BoxyUwUBoxyUwU

Labels

PG-exploit-mitigationsProject group: Exploit mitigationsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

5 participants

@dpaoliello@rustbot@wesleywiser@bors@BoxyUwU