') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Simplify `Vec::as_non_null` implementation and make it `const` by viliml · Pull Request #140685 · rust-lang/rust · GitHub
Skip to content

Simplify Vec::as_non_null implementation and make it const - #140685

Merged
bors merged 1 commit into
rust-lang:masterfrom
viliml:patch-1
May 16, 2025
Merged

Simplify Vec::as_non_null implementation and make it const#140685
bors merged 1 commit into
rust-lang:masterfrom
viliml:patch-1

Conversation

@viliml

@vilimlviliml commented May 5, 2025

Copy link
Copy Markdown
Contributor

Tracking issue: #130364.

@rustbot

rustbot commented May 5, 2025

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 5, 2025
@Mark-Simulacrum

Mark-Simulacrum commented May 13, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented May 13, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 53459ff has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2025
@bors

bors commented May 13, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 53459ff with merge e4f35df...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 13, 2025
@bors
Auto merge ofrust-lang#140685- viliml:patch-1, r=Mark-Simulacrum
e4f35df
Simplify `Vec::as_non_null` implementation and make it `const`
Tracking issue: rust-lang#130364.
@bors

bors commented May 13, 2025

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 13, 2025
@Mark-Simulacrum

Mark-Simulacrum commented May 14, 2025

Copy link
Copy Markdown
Member

@bors retry System.IO.IOException: There is not enough space on the disk. msvc-1

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 15, 2025
@matthiaskrgr
Rollup merge ofrust-lang#140685- viliml:patch-1, r=Mark-Simulacrum
81a229e
Simplify `Vec::as_non_null` implementation and make it `const`
Tracking issue: rust-lang#130364.
@matthiaskrgrmatthiaskrgr mentioned this pull request May 15, 2025
Closed
compiler-errors added a commit to compiler-errors/rust that referenced this pull request May 15, 2025
@compiler-errors
Rollup merge ofrust-lang#140685- viliml:patch-1, r=Mark-Simulacrum
fc11361
Simplify `Vec::as_non_null` implementation and make it `const`
Tracking issue: rust-lang#130364.
@compiler-errorscompiler-errors mentioned this pull request May 15, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2025
@bors
Auto merge ofrust-lang#141041- compiler-errors:rollup-tz4bpbf, r=co…
622f000
…mpiler-errors
Rollup of 14 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140130 (Add LLDB providers for BTreeMap and BTreeSet)
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140834 (move (or remove) some impl Trait tests)
- rust-lang#140910 (Remove `stable` attribute from wasi fs (read_exact|write_all)_at)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc)
- rust-lang#140977 ([win] Use a dash instead of slash for linker to avoid breaking lld)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141003 (Improve ternary operator recovery)
- rust-lang#141013 (Implement methods to set STARTUPINFO flags for Command API on Windows)
- rust-lang#141026 (rustc-dev-guide subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2025
@bors
Auto merge ofrust-lang#141040- matthiaskrgr:rollup-rym8mkn, r=matth…
985d931
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr mentioned this pull request May 15, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
6d1875f
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7a8fd99 into rust-lang:masterMay 16, 2025
@rustbotrustbot added this to the 1.89.0 milestone May 16, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2025
@rust-timer
Unrolled build forrust-lang#140685
5a83c6f
Rollup merge of rust-lang#140685 - viliml:patch-1, r=Mark-Simulacrum
Simplify `Vec::as_non_null` implementation and make it `const`
Tracking issue: rust-lang#130364.
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request May 21, 2025
@matthiaskrgr
Rollup merge ofrust-lang#140685- viliml:patch-1, r=Mark-Simulacrum
583855e
Simplify `Vec::as_non_null` implementation and make it `const`
Tracking issue: rust-lang#130364.
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request May 21, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
a31a781
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

4 participants

@viliml@rustbot@Mark-Simulacrum@bors