Skip to content

remove RustfmtState to reduce initial_rustfmt complexity - #141027

Merged
bors merged 1 commit into
rust-lang:masterfrom
onur-ozkan:simpler-rustfmt-initialization
May 16, 2025
Merged

remove RustfmtState to reduce initial_rustfmt complexity#141027
bors merged 1 commit into
rust-lang:masterfrom
onur-ozkan:simpler-rustfmt-initialization

Conversation

@onur-ozkan

@onur-ozkanonur-ozkan commented May 15, 2025

Copy link
Copy Markdown
Contributor

The current use of RustfmtState doesn't serve its main purpose as it never does the lazy evaulation since Build::build forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have RustfmtState complexity at all.

@rustbot

rustbot commented May 15, 2025

Copy link
Copy Markdown
Collaborator

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 15, 2025
@rustbot

rustbot commented May 15, 2025

Copy link
Copy Markdown
Collaborator

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onur-ozkan
onur-ozkanforce-pushed the simpler-rustfmt-initialization branch from 2798020 to 859cf5bCompareMay 15, 2025 10:51
@onur-ozkan
remove RustfmtState to reduce initial_rustfmt complexity
92116bc
The current use of `RustfmtState` doesn't serve its main purpose as it
never does the lazy evaulation since `Build::build` forces it to be ready
on the early stage. If we want rustfmt to be ready on the early stage, we
don't need to have `RustfmtState` complexity at all.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
onur-ozkanforce-pushed the simpler-rustfmt-initialization branch from 859cf5b to 92116bcCompareMay 15, 2025 11:03
albertlarsan68
albertlarsan68 approved these changes May 15, 2025
View reviewed changes

@albertlarsan68albertlarsan68 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@albertlarsan68

albertlarsan68 commented May 15, 2025

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented May 15, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 92116bc has been approved by albertlarsan68

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 15, 2025
@matthiaskrgr
Rollup merge ofrust-lang#141027- onur-ozkan:simpler-rustfmt-initial…
da78e8d
…ization, r=albertlarsan68
remove `RustfmtState` to reduce `initial_rustfmt` complexity
The current use of `RustfmtState` doesn't serve its main purpose as it never does the lazy evaulation since `Build::build` forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have `RustfmtState` complexity at all.
@matthiaskrgrmatthiaskrgr mentioned this pull request May 15, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2025
@bors
Auto merge ofrust-lang#141040- matthiaskrgr:rollup-rym8mkn, r=matth…
985d931
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr mentioned this pull request May 15, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
6d1875f
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 3e6a286 into rust-lang:masterMay 16, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2025
@rust-timer
Unrolled build forrust-lang#141027
a11e14b
Rollup merge of rust-lang#141027 - onur-ozkan:simpler-rustfmt-initialization, r=albertlarsan68
remove `RustfmtState` to reduce `initial_rustfmt` complexity
The current use of `RustfmtState` doesn't serve its main purpose as it never does the lazy evaulation since `Build::build` forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have `RustfmtState` complexity at all.
@rustbotrustbot added this to the 1.89.0 milestone May 16, 2025
@onur-ozkan
onur-ozkan deleted the simpler-rustfmt-initialization branch May 16, 2025 04:27
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request May 21, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
a31a781
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albertlarsan68albertlarsan68albertlarsan68 approved these changes

Assignees

@albertlarsan68albertlarsan68

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

5 participants

@onur-ozkan@rustbot@rust-log-analyzer@albertlarsan68@bors
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
remove `RustfmtState` to reduce `initial_rustfmt` complexity by onur-ozkan · Pull Request #141027 · rust-lang/rust · GitHub
Skip to content
remove RustfmtState to reduce initial_rustfmt complexity - #141027
Merged
bors merged 1 commit into
rust-lang:masterfrom 
onur-ozkan:simpler-rustfmt-initialization
May 16, 2025
Merged
remove RustfmtState to reduce initial_rustfmt complexity#141027
bors merged 1 commit into
rust-lang:masterfrom 
onur-ozkan:simpler-rustfmt-initialization
Conversation
@onur-ozkan
@onur-ozkanonur-ozkan
commented
May 15, 2025

Copy link


Copy Markdown

Contributor
The current use of RustfmtState doesn't serve its main purpose as it never does the lazy evaulation since Build::build forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have RustfmtState complexity at all.
@rustbot
rustbot
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
r? @albertlarsan68
rustbot has assigned @albertlarsan68.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbotrustbot
added

A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
May 15, 2025
@rustbot
rustbot
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
This PR modifies src/bootstrap/src/core/config.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onur-ozkan
onur-ozkanforce-pushed
the
simpler-rustfmt-initialization
branch
from
2798020 to
859cf5bCompareMay 15, 2025 10:51
@onur-ozkan
remove RustfmtState to reduce initial_rustfmt complexity
92116bc
The current use of `RustfmtState` doesn't serve its main purpose as it
never does the lazy evaulation since `Build::build` forces it to be ready
on the early stage. If we want rustfmt to be ready on the early stage, we
don't need to have `RustfmtState` complexity at all.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
onur-ozkanforce-pushed
the
simpler-rustfmt-initialization
branch
from
859cf5b to
92116bcCompareMay 15, 2025 11:03
albertlarsan68
albertlarsan68
approved these changes
May 15, 2025
View reviewed changes
@albertlarsan68albertlarsan68
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@albertlarsan68
albertlarsan68
commented
May 15, 2025

Copy link


Copy Markdown

Member
@bors r+
@bors
bors
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 92116bc has been approved by albertlarsan68
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 15, 2025
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 15, 2025
@matthiaskrgr
Rollup merge ofrust-lang#141027- onur-ozkan:simpler-rustfmt-initial…
da78e8d
…ization, r=albertlarsan68
remove `RustfmtState` to reduce `initial_rustfmt` complexity
The current use of `RustfmtState` doesn't serve its main purpose as it never does the lazy evaulation since `Build::build` forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have `RustfmtState` complexity at all.
@matthiaskrgrmatthiaskrgr
mentioned this pull request
May 15, 2025
 Closed

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2025
@bors
Auto merge ofrust-lang#141040- matthiaskrgr:rollup-rym8mkn, r=matth…
985d931
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr
mentioned this pull request
May 15, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
6d1875f
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 3e6a286
into
rust-lang:masterMay 16, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2025
@rust-timer
Unrolled build forrust-lang#141027
a11e14b
Rollup merge of rust-lang#141027 - onur-ozkan:simpler-rustfmt-initialization, r=albertlarsan68
remove `RustfmtState` to reduce `initial_rustfmt` complexity
The current use of `RustfmtState` doesn't serve its main purpose as it never does the lazy evaulation since `Build::build` forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have `RustfmtState` complexity at all.
@rustbotrustbot
added this to the 1.89.0 milestone
May 16, 2025
@onur-ozkan
onur-ozkan
deleted the

simpler-rustfmt-initialization

branch
May 16, 2025 04:27
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
May 21, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
a31a781
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@albertlarsan68albertlarsan68albertlarsan68 approved these changes

Assignees

@albertlarsan68albertlarsan68

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects


None yet


Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

5 participants

@onur-ozkan@rustbot@rust-log-analyzer@albertlarsan68@bors

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
remove `RustfmtState` to reduce `initial_rustfmt` complexity by onur-ozkan · Pull Request #141027 · rust-lang/rust · GitHub
Skip to content
remove RustfmtState to reduce initial_rustfmt complexity - #141027
Merged
bors merged 1 commit into
rust-lang:masterfrom 
onur-ozkan:simpler-rustfmt-initialization
May 16, 2025
Merged
remove RustfmtState to reduce initial_rustfmt complexity#141027
bors merged 1 commit into
rust-lang:masterfrom 
onur-ozkan:simpler-rustfmt-initialization
Conversation
@onur-ozkan
@onur-ozkanonur-ozkan
commented
May 15, 2025

Copy link


Copy Markdown

Contributor
The current use of RustfmtState doesn't serve its main purpose as it never does the lazy evaulation since Build::build forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have RustfmtState complexity at all.
@rustbot
rustbot
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
r? @albertlarsan68
rustbot has assigned @albertlarsan68.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbotrustbot
added

A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
May 15, 2025
@rustbot
rustbot
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
This PR modifies src/bootstrap/src/core/config.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onur-ozkan
onur-ozkanforce-pushed
the
simpler-rustfmt-initialization
branch
from
2798020 to
859cf5bCompareMay 15, 2025 10:51
@onur-ozkan
remove RustfmtState to reduce initial_rustfmt complexity
92116bc
The current use of `RustfmtState` doesn't serve its main purpose as it
never does the lazy evaulation since `Build::build` forces it to be ready
on the early stage. If we want rustfmt to be ready on the early stage, we
don't need to have `RustfmtState` complexity at all.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
onur-ozkanforce-pushed
the
simpler-rustfmt-initialization
branch
from
859cf5b to
92116bcCompareMay 15, 2025 11:03
albertlarsan68
albertlarsan68
approved these changes
May 15, 2025
View reviewed changes
@albertlarsan68albertlarsan68
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@albertlarsan68
albertlarsan68
commented
May 15, 2025

Copy link


Copy Markdown

Member
@bors r+
@bors
bors
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 92116bc has been approved by albertlarsan68
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 15, 2025
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 15, 2025
@matthiaskrgr
Rollup merge ofrust-lang#141027- onur-ozkan:simpler-rustfmt-initial…
da78e8d
…ization, r=albertlarsan68
remove `RustfmtState` to reduce `initial_rustfmt` complexity
The current use of `RustfmtState` doesn't serve its main purpose as it never does the lazy evaulation since `Build::build` forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have `RustfmtState` complexity at all.
@matthiaskrgrmatthiaskrgr
mentioned this pull request
May 15, 2025
 Closed

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2025
@bors
Auto merge ofrust-lang#141040- matthiaskrgr:rollup-rym8mkn, r=matth…
985d931
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr
mentioned this pull request
May 15, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
6d1875f
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 3e6a286
into
rust-lang:masterMay 16, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2025
@rust-timer
Unrolled build forrust-lang#141027
a11e14b
Rollup merge of rust-lang#141027 - onur-ozkan:simpler-rustfmt-initialization, r=albertlarsan68
remove `RustfmtState` to reduce `initial_rustfmt` complexity
The current use of `RustfmtState` doesn't serve its main purpose as it never does the lazy evaulation since `Build::build` forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have `RustfmtState` complexity at all.
@rustbotrustbot
added this to the 1.89.0 milestone
May 16, 2025
@onur-ozkan
onur-ozkan
deleted the

simpler-rustfmt-initialization

branch
May 16, 2025 04:27
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
May 21, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
a31a781
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@albertlarsan68albertlarsan68albertlarsan68 approved these changes

Assignees

@albertlarsan68albertlarsan68

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects


None yet


Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

5 participants

@onur-ozkan@rustbot@rust-log-analyzer@albertlarsan68@bors

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
remove `RustfmtState` to reduce `initial_rustfmt` complexity by onur-ozkan · Pull Request #141027 · rust-lang/rust · GitHub
Skip to content
remove RustfmtState to reduce initial_rustfmt complexity - #141027
Merged
bors merged 1 commit into
rust-lang:masterfrom 
onur-ozkan:simpler-rustfmt-initialization
May 16, 2025
Merged
remove RustfmtState to reduce initial_rustfmt complexity#141027
bors merged 1 commit into
rust-lang:masterfrom 
onur-ozkan:simpler-rustfmt-initialization
Conversation
@onur-ozkan
@onur-ozkanonur-ozkan
commented
May 15, 2025

Copy link


Copy Markdown

Contributor
The current use of RustfmtState doesn't serve its main purpose as it never does the lazy evaulation since Build::build forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have RustfmtState complexity at all.
@rustbot
rustbot
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
r? @albertlarsan68
rustbot has assigned @albertlarsan68.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbotrustbot
added

A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
May 15, 2025
@rustbot
rustbot
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
This PR modifies src/bootstrap/src/core/config.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onur-ozkan
onur-ozkanforce-pushed
the
simpler-rustfmt-initialization
branch
from
2798020 to
859cf5bCompareMay 15, 2025 10:51
@onur-ozkan
remove RustfmtState to reduce initial_rustfmt complexity
92116bc
The current use of `RustfmtState` doesn't serve its main purpose as it
never does the lazy evaulation since `Build::build` forces it to be ready
on the early stage. If we want rustfmt to be ready on the early stage, we
don't need to have `RustfmtState` complexity at all.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
onur-ozkanforce-pushed
the
simpler-rustfmt-initialization
branch
from
859cf5b to
92116bcCompareMay 15, 2025 11:03
albertlarsan68
albertlarsan68
approved these changes
May 15, 2025
View reviewed changes
@albertlarsan68albertlarsan68
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@albertlarsan68
albertlarsan68
commented
May 15, 2025

Copy link


Copy Markdown

Member
@bors r+
@bors
bors
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 92116bc has been approved by albertlarsan68
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 15, 2025
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 15, 2025
@matthiaskrgr
Rollup merge ofrust-lang#141027- onur-ozkan:simpler-rustfmt-initial…
da78e8d
…ization, r=albertlarsan68
remove `RustfmtState` to reduce `initial_rustfmt` complexity
The current use of `RustfmtState` doesn't serve its main purpose as it never does the lazy evaulation since `Build::build` forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have `RustfmtState` complexity at all.
@matthiaskrgrmatthiaskrgr
mentioned this pull request
May 15, 2025
 Closed

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2025
@bors
Auto merge ofrust-lang#141040- matthiaskrgr:rollup-rym8mkn, r=matth…
985d931
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr
mentioned this pull request
May 15, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
6d1875f
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 3e6a286
into
rust-lang:masterMay 16, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2025
@rust-timer
Unrolled build forrust-lang#141027
a11e14b
Rollup merge of rust-lang#141027 - onur-ozkan:simpler-rustfmt-initialization, r=albertlarsan68
remove `RustfmtState` to reduce `initial_rustfmt` complexity
The current use of `RustfmtState` doesn't serve its main purpose as it never does the lazy evaulation since `Build::build` forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have `RustfmtState` complexity at all.
@rustbotrustbot
added this to the 1.89.0 milestone
May 16, 2025
@onur-ozkan
onur-ozkan
deleted the

simpler-rustfmt-initialization

branch
May 16, 2025 04:27
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
May 21, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
a31a781
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@albertlarsan68albertlarsan68albertlarsan68 approved these changes

Assignees

@albertlarsan68albertlarsan68

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects


None yet


Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

5 participants

@onur-ozkan@rustbot@rust-log-analyzer@albertlarsan68@bors

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
remove `RustfmtState` to reduce `initial_rustfmt` complexity by onur-ozkan · Pull Request #141027 · rust-lang/rust · GitHub
Skip to content
remove RustfmtState to reduce initial_rustfmt complexity - #141027
Merged
bors merged 1 commit into
rust-lang:masterfrom 
onur-ozkan:simpler-rustfmt-initialization
May 16, 2025
Merged
remove RustfmtState to reduce initial_rustfmt complexity#141027
bors merged 1 commit into
rust-lang:masterfrom 
onur-ozkan:simpler-rustfmt-initialization
Conversation
@onur-ozkan
@onur-ozkanonur-ozkan
commented
May 15, 2025

Copy link


Copy Markdown

Contributor
The current use of RustfmtState doesn't serve its main purpose as it never does the lazy evaulation since Build::build forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have RustfmtState complexity at all.
@rustbot
rustbot
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
r? @albertlarsan68
rustbot has assigned @albertlarsan68.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbotrustbot
added

A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
May 15, 2025
@rustbot
rustbot
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
This PR modifies src/bootstrap/src/core/config.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onur-ozkan
onur-ozkanforce-pushed
the
simpler-rustfmt-initialization
branch
from
2798020 to
859cf5bCompareMay 15, 2025 10:51
@onur-ozkan
remove RustfmtState to reduce initial_rustfmt complexity
92116bc
The current use of `RustfmtState` doesn't serve its main purpose as it
never does the lazy evaulation since `Build::build` forces it to be ready
on the early stage. If we want rustfmt to be ready on the early stage, we
don't need to have `RustfmtState` complexity at all.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
onur-ozkanforce-pushed
the
simpler-rustfmt-initialization
branch
from
859cf5b to
92116bcCompareMay 15, 2025 11:03
albertlarsan68
albertlarsan68
approved these changes
May 15, 2025
View reviewed changes
@albertlarsan68albertlarsan68
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@albertlarsan68
albertlarsan68
commented
May 15, 2025

Copy link


Copy Markdown

Member
@bors r+
@bors
bors
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 92116bc has been approved by albertlarsan68
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 15, 2025
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 15, 2025
@matthiaskrgr
Rollup merge ofrust-lang#141027- onur-ozkan:simpler-rustfmt-initial…
da78e8d
…ization, r=albertlarsan68
remove `RustfmtState` to reduce `initial_rustfmt` complexity
The current use of `RustfmtState` doesn't serve its main purpose as it never does the lazy evaulation since `Build::build` forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have `RustfmtState` complexity at all.
@matthiaskrgrmatthiaskrgr
mentioned this pull request
May 15, 2025
 Closed

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2025
@bors
Auto merge ofrust-lang#141040- matthiaskrgr:rollup-rym8mkn, r=matth…
985d931
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr
mentioned this pull request
May 15, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
6d1875f
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 3e6a286
into
rust-lang:masterMay 16, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2025
@rust-timer
Unrolled build forrust-lang#141027
a11e14b
Rollup merge of rust-lang#141027 - onur-ozkan:simpler-rustfmt-initialization, r=albertlarsan68
remove `RustfmtState` to reduce `initial_rustfmt` complexity
The current use of `RustfmtState` doesn't serve its main purpose as it never does the lazy evaulation since `Build::build` forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have `RustfmtState` complexity at all.
@rustbotrustbot
added this to the 1.89.0 milestone
May 16, 2025
@onur-ozkan
onur-ozkan
deleted the

simpler-rustfmt-initialization

branch
May 16, 2025 04:27
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
May 21, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
a31a781
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@albertlarsan68albertlarsan68albertlarsan68 approved these changes

Assignees

@albertlarsan68albertlarsan68

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects


None yet


Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

5 participants

@onur-ozkan@rustbot@rust-log-analyzer@albertlarsan68@bors

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
remove `RustfmtState` to reduce `initial_rustfmt` complexity by onur-ozkan · Pull Request #141027 · rust-lang/rust · GitHub
Skip to content
remove RustfmtState to reduce initial_rustfmt complexity - #141027
Merged
bors merged 1 commit into
rust-lang:masterfrom 
onur-ozkan:simpler-rustfmt-initialization
May 16, 2025
Merged
remove RustfmtState to reduce initial_rustfmt complexity#141027
bors merged 1 commit into
rust-lang:masterfrom 
onur-ozkan:simpler-rustfmt-initialization
Conversation
@onur-ozkan
@onur-ozkanonur-ozkan
commented
May 15, 2025

Copy link


Copy Markdown

Contributor
The current use of RustfmtState doesn't serve its main purpose as it never does the lazy evaulation since Build::build forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have RustfmtState complexity at all.
@rustbot
rustbot
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
r? @albertlarsan68
rustbot has assigned @albertlarsan68.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbotrustbot
added

A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
May 15, 2025
@rustbot
rustbot
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
This PR modifies src/bootstrap/src/core/config.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onur-ozkan
onur-ozkanforce-pushed
the
simpler-rustfmt-initialization
branch
from
2798020 to
859cf5bCompareMay 15, 2025 10:51
@onur-ozkan
remove RustfmtState to reduce initial_rustfmt complexity
92116bc
The current use of `RustfmtState` doesn't serve its main purpose as it
never does the lazy evaulation since `Build::build` forces it to be ready
on the early stage. If we want rustfmt to be ready on the early stage, we
don't need to have `RustfmtState` complexity at all.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
onur-ozkanforce-pushed
the
simpler-rustfmt-initialization
branch
from
859cf5b to
92116bcCompareMay 15, 2025 11:03
albertlarsan68
albertlarsan68
approved these changes
May 15, 2025
View reviewed changes
@albertlarsan68albertlarsan68
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@albertlarsan68
albertlarsan68
commented
May 15, 2025

Copy link


Copy Markdown

Member
@bors r+
@bors
bors
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 92116bc has been approved by albertlarsan68
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 15, 2025
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 15, 2025
@matthiaskrgr
Rollup merge ofrust-lang#141027- onur-ozkan:simpler-rustfmt-initial…
da78e8d
…ization, r=albertlarsan68
remove `RustfmtState` to reduce `initial_rustfmt` complexity
The current use of `RustfmtState` doesn't serve its main purpose as it never does the lazy evaulation since `Build::build` forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have `RustfmtState` complexity at all.
@matthiaskrgrmatthiaskrgr
mentioned this pull request
May 15, 2025
 Closed

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2025
@bors
Auto merge ofrust-lang#141040- matthiaskrgr:rollup-rym8mkn, r=matth…
985d931
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr
mentioned this pull request
May 15, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
6d1875f
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 3e6a286
into
rust-lang:masterMay 16, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2025
@rust-timer
Unrolled build forrust-lang#141027
a11e14b
Rollup merge of rust-lang#141027 - onur-ozkan:simpler-rustfmt-initialization, r=albertlarsan68
remove `RustfmtState` to reduce `initial_rustfmt` complexity
The current use of `RustfmtState` doesn't serve its main purpose as it never does the lazy evaulation since `Build::build` forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have `RustfmtState` complexity at all.
@rustbotrustbot
added this to the 1.89.0 milestone
May 16, 2025
@onur-ozkan
onur-ozkan
deleted the

simpler-rustfmt-initialization

branch
May 16, 2025 04:27
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
May 21, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
a31a781
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@albertlarsan68albertlarsan68albertlarsan68 approved these changes

Assignees

@albertlarsan68albertlarsan68

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects


None yet


Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

5 participants

@onur-ozkan@rustbot@rust-log-analyzer@albertlarsan68@bors

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
remove `RustfmtState` to reduce `initial_rustfmt` complexity by onur-ozkan · Pull Request #141027 · rust-lang/rust · GitHub
Skip to content
remove RustfmtState to reduce initial_rustfmt complexity - #141027
Merged
bors merged 1 commit into
rust-lang:masterfrom 
onur-ozkan:simpler-rustfmt-initialization
May 16, 2025
Merged
remove RustfmtState to reduce initial_rustfmt complexity#141027
bors merged 1 commit into
rust-lang:masterfrom 
onur-ozkan:simpler-rustfmt-initialization
Conversation
@onur-ozkan
@onur-ozkanonur-ozkan
commented
May 15, 2025

Copy link


Copy Markdown

Contributor
The current use of RustfmtState doesn't serve its main purpose as it never does the lazy evaulation since Build::build forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have RustfmtState complexity at all.
@rustbot
rustbot
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
r? @albertlarsan68
rustbot has assigned @albertlarsan68.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbotrustbot
added

A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
May 15, 2025
@rustbot
rustbot
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
This PR modifies src/bootstrap/src/core/config.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onur-ozkan
onur-ozkanforce-pushed
the
simpler-rustfmt-initialization
branch
from
2798020 to
859cf5bCompareMay 15, 2025 10:51
@onur-ozkan
remove RustfmtState to reduce initial_rustfmt complexity
92116bc
The current use of `RustfmtState` doesn't serve its main purpose as it
never does the lazy evaulation since `Build::build` forces it to be ready
on the early stage. If we want rustfmt to be ready on the early stage, we
don't need to have `RustfmtState` complexity at all.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
onur-ozkanforce-pushed
the
simpler-rustfmt-initialization
branch
from
859cf5b to
92116bcCompareMay 15, 2025 11:03
albertlarsan68
albertlarsan68
approved these changes
May 15, 2025
View reviewed changes
@albertlarsan68albertlarsan68
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@albertlarsan68
albertlarsan68
commented
May 15, 2025

Copy link


Copy Markdown

Member
@bors r+
@bors
bors
commented
May 15, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 92116bc has been approved by albertlarsan68
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 15, 2025
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 15, 2025
@matthiaskrgr
Rollup merge ofrust-lang#141027- onur-ozkan:simpler-rustfmt-initial…
da78e8d
…ization, r=albertlarsan68
remove `RustfmtState` to reduce `initial_rustfmt` complexity
The current use of `RustfmtState` doesn't serve its main purpose as it never does the lazy evaulation since `Build::build` forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have `RustfmtState` complexity at all.
@matthiaskrgrmatthiaskrgr
mentioned this pull request
May 15, 2025
 Closed

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2025
@bors
Auto merge ofrust-lang#141040- matthiaskrgr:rollup-rym8mkn, r=matth…
985d931
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr
mentioned this pull request
May 15, 2025
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
6d1875f
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 3e6a286
into
rust-lang:masterMay 16, 2025
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2025
@rust-timer
Unrolled build forrust-lang#141027
a11e14b
Rollup merge of rust-lang#141027 - onur-ozkan:simpler-rustfmt-initialization, r=albertlarsan68
remove `RustfmtState` to reduce `initial_rustfmt` complexity
The current use of `RustfmtState` doesn't serve its main purpose as it never does the lazy evaulation since `Build::build` forces it to be ready on the early stage. If we want rustfmt to be ready on the early stage, we don't need to have `RustfmtState` complexity at all.
@rustbotrustbot
added this to the 1.89.0 milestone
May 16, 2025
@onur-ozkan
onur-ozkan
deleted the

simpler-rustfmt-initialization

branch
May 16, 2025 04:27
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
May 21, 2025
@bors
Auto merge ofrust-lang#141050- matthiaskrgr:rollup-uyzqbmj, r=matth…
a31a781
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
- rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
- rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
- rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
- rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
- rust-lang#140990 (VxWorks: updates from recent libc versions)
- rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@albertlarsan68albertlarsan68albertlarsan68 approved these changes

Assignees

@albertlarsan68albertlarsan68

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects


None yet


Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

5 participants

@onur-ozkan@rustbot@rust-log-analyzer@albertlarsan68@bors