Skip to content

tests/ui/issues/: The Issues Strike Back [4/N] - #144403

Merged
bors merged 2 commits into
rust-lang:masterfrom
Kivooeo:issue4
Aug 10, 2025
Merged

tests/ui/issues/: The Issues Strike Back [4/N]#144403
bors merged 2 commits into
rust-lang:masterfrom
Kivooeo:issue4

Conversation

@Kivooeo

@KivooeoKivooeo commented Jul 24, 2025

Copy link
Copy Markdown
Member

Some tests/ui/issues/ housekeeping, to trim down number of tests directly under tests/ui/issues/. Part of #133895.

r? @jieyouxu

@rustbot

rustbot commented Jul 24, 2025

Copy link
Copy Markdown
Collaborator

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo
Kivooeoforce-pushed the issue4 branch 2 times, most recently from a7c2056 to f7e1327CompareJuly 25, 2025 10:33
@jieyouxujieyouxu added the S-no-work-capacity-tracking Status: Exempted from triagebot work capacity tracking. label Aug 7, 2025
jieyouxu
jieyouxu requested changes Aug 9, 2025
View reviewed changes

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some nits

Comment threadtests/ui/closures/unused-closure-warning-16256.rs
Comment threadtests/ui/coercion/array-slice-coercion-mismatch-15783.rs
Comment threadtests/ui/drop/early-return-drop-order.rs
Comment threadtests/ui/drop/vec-replace-skip-while-drop.rs
Comment threadtests/ui/fn/fn-traits-call-once-signature.rs
Comment threadtests/ui/statics/conditional-static-declaration.rs
Comment threadtests/ui/structs/static-struct-init-15043.rs
Comment threadtests/ui/traits/index-trait-multiple-impls.rs
Comment threadtests/ui/traits/lifetime-mismatch-trait-impl.rs
Comment threadtests/ui/statics/conditional-static-declaration.rs Outdated
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2025
@rustbot

rustbot commented Aug 9, 2025

Copy link
Copy Markdown
Collaborator

⚠️Warning⚠️

@Kivooeo

Kivooeo commented Aug 9, 2025

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 9, 2025
jieyouxu
jieyouxu approved these changes Aug 9, 2025
View reviewed changes

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu

jieyouxu commented Aug 9, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Aug 9, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 1676563 has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge ofrust-lang#144403- Kivooeo:issue4, r=jieyouxu
1d39978
`tests/ui/issues/`: The Issues Strike Back [4/N]
Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895.
r? `@jieyouxu`
@ZalatharZalathar mentioned this pull request Aug 10, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge ofrust-lang#144403- Kivooeo:issue4, r=jieyouxu
aca3bdf
`tests/ui/issues/`: The Issues Strike Back [4/N]
Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895.
r? ``@jieyouxu``
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge ofrust-lang#144403- Kivooeo:issue4, r=jieyouxu
5d85cc2
`tests/ui/issues/`: The Issues Strike Back [4/N]
Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895.
r? ```@jieyouxu```
@ZalatharZalathar mentioned this pull request Aug 10, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge ofrust-lang#144403- Kivooeo:issue4, r=jieyouxu
04ebd3d
`tests/ui/issues/`: The Issues Strike Back [4/N]
Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895.
r? ````@jieyouxu````
@ZalatharZalathar mentioned this pull request Aug 10, 2025
Closed
bors added a commit that referenced this pull request Aug 10, 2025
@bors
Auto merge of#145197- Zalathar:rollup-9a642pd, r=Zalathar
ba1a4f0
Rollup of 19 pull requests
Successful merges:
- #141624 (unstable-book: Add stubs for environment variables; document some of the important ones)
- #143093 (Simplify polonius location-sensitive analysis)
- #144402 (Stabilize loongarch32 inline asm)
- #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N])
- #144544 (Start reporting future breakage for `ILL_FORMED_ATTRIBUTE_INPUT` in dependencies)
- #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc)
- #145089 (Improve error output when a command fails in bootstrap)
- #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC)
- #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC)
- #145130 (improve "Documentation problem" issue template.)
- #145135 (Stabilize `duration_constructors_lite` feature)
- #145145 (some `derive_more` refactors)
- #145147 (rename `TraitRef::from_method` to `from_assoc`)
- #145156 (Override custom Cargo `build-dir` in bootstrap)
- #145160 (Change days-threshold to 28 in [behind-upstream])
- #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading)
- #145175 (Enable limit_rdylib_exports on Solaris)
- #145187 (Fix an unstable feature comment that wasn't a doc comment)
- #145191 (`suggest_borrow_generic_arg`: use the correct generic args)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge ofrust-lang#144403- Kivooeo:issue4, r=jieyouxu
99a3fa2
`tests/ui/issues/`: The Issues Strike Back [4/N]
Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895.
r? `````@jieyouxu`````
@ZalatharZalathar mentioned this pull request Aug 10, 2025
Closed
bors added a commit that referenced this pull request Aug 10, 2025
@bors
Auto merge of#145204- Zalathar:rollup-eyrrf5y, r=Zalathar
b6f3e72
Rollup of 18 pull requests
Successful merges:
- #141624 (unstable-book: Add stubs for environment variables; document some of the important ones)
- #143093 (Simplify polonius location-sensitive analysis)
- #144402 (Stabilize loongarch32 inline asm)
- #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N])
- #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc)
- #145089 (Improve error output when a command fails in bootstrap)
- #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC)
- #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC)
- #145130 (improve "Documentation problem" issue template.)
- #145135 (Stabilize `duration_constructors_lite` feature)
- #145145 (some `derive_more` refactors)
- #145147 (rename `TraitRef::from_method` to `from_assoc`)
- #145156 (Override custom Cargo `build-dir` in bootstrap)
- #145160 (Change days-threshold to 28 in [behind-upstream])
- #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading)
- #145175 (Enable limit_rdylib_exports on Solaris)
- #145187 (Fix an unstable feature comment that wasn't a doc comment)
- #145191 (`suggest_borrow_generic_arg`: use the correct generic args)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge ofrust-lang#144403- Kivooeo:issue4, r=jieyouxu
ea28c37
`tests/ui/issues/`: The Issues Strike Back [4/N]
Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895.
r? ``````@jieyouxu``````
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge ofrust-lang#144403- Kivooeo:issue4, r=jieyouxu
96760e2
`tests/ui/issues/`: The Issues Strike Back [4/N]
Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895.
r? ```````@jieyouxu```````
@ZalatharZalathar mentioned this pull request Aug 10, 2025
Merged
bors added a commit that referenced this pull request Aug 10, 2025
@bors
Auto merge of#145210- Zalathar:rollup-dm4reb2, r=Zalathar
80ff75f
Rollup of 17 pull requests
Successful merges:
- #141624 (unstable-book: Add stubs for environment variables; document some of the important ones)
- #143093 (Simplify polonius location-sensitive analysis)
- #144402 (Stabilize loongarch32 inline asm)
- #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N])
- #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc)
- #145089 (Improve error output when a command fails in bootstrap)
- #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC)
- #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC)
- #145130 (improve "Documentation problem" issue template.)
- #145135 (Stabilize `duration_constructors_lite` feature)
- #145145 (some `derive_more` refactors)
- #145147 (rename `TraitRef::from_method` to `from_assoc`)
- #145156 (Override custom Cargo `build-dir` in bootstrap)
- #145160 (Change days-threshold to 28 in [behind-upstream])
- #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading)
- #145187 (Fix an unstable feature comment that wasn't a doc comment)
- #145191 (`suggest_borrow_generic_arg`: use the correct generic args)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 10, 2025
@bors
Auto merge of#145210- Zalathar:rollup-dm4reb2, r=Zalathar
18eeac0
Rollup of 17 pull requests
Successful merges:
- #141624 (unstable-book: Add stubs for environment variables; document some of the important ones)
- #143093 (Simplify polonius location-sensitive analysis)
- #144402 (Stabilize loongarch32 inline asm)
- #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N])
- #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc)
- #145089 (Improve error output when a command fails in bootstrap)
- #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC)
- #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC)
- #145130 (improve "Documentation problem" issue template.)
- #145135 (Stabilize `duration_constructors_lite` feature)
- #145145 (some `derive_more` refactors)
- #145147 (rename `TraitRef::from_method` to `from_assoc`)
- #145156 (Override custom Cargo `build-dir` in bootstrap)
- #145160 (Change days-threshold to 28 in [behind-upstream])
- #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading)
- #145187 (Fix an unstable feature comment that wasn't a doc comment)
- #145191 (`suggest_borrow_generic_arg`: use the correct generic args)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 62b406d into rust-lang:masterAug 10, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 10, 2025
rust-timer added a commit that referenced this pull request Aug 10, 2025
@rust-timer
Unrolled build for#144403
2f3ea23
Rollup merge of #144403 - Kivooeo:issue4, r=jieyouxu
`tests/ui/issues/`: The Issues Strike Back [4/N]
Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of #133895.
r? ````````@jieyouxu````````
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

S-no-work-capacity-trackingStatus: Exempted from triagebot work capacity tracking.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Kivooeo@rustbot@rust-log-analyzer@jieyouxu@bors