Enable limit_rdylib_exports on Solaris

[bjorn3]

This (poorly named) target option controls whether or not cdylibs will export mangled rust symbols rather than just unmangled symbols. Presumably at some point in the past support for this wasn't implemented yet for Solaris, but cg_ssa::back::linker does have handling for this on Solaris now. And one of the Solaris target maintainers confirmed that building Rust with this option enabled works fine for them on Solaris: #t-compiler > solaris limit_rdylib_exports @ 💬

[rustbot]

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

These commits modify compiler targets.
(See the Target Tier Policy.)

[bjorn3]

cc @psumbera

[lqd]

I had read that conversation. I don't know if you want (or can) do try builds with this, and as you said psumbera tested it already.

Either way, r? lqd r=me whenever you want.

[lqd]

@bors r+

[bors]

📌 Commit 6de338b has been approved by lqd

It is now in the queue for this repository.

[Zalathar]

Possibly failed in rollup: #145204 (comment)

@bors r-
@bors try jobs=dist-sparcv9-solaris

[rust-bors]

⌛ Trying commit 6de338b with merge 0b6aaac…

To cancel the try build, run the command @bors try cancel.

[rust-bors]

💔 Test failed (CI). Failed jobs:

• bors build finished (web logs, extended logs)
• try - dist-sparcv9-solaris (web logs, extended logs)

[rustbot]

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

[bjorn3]

@bors2 try jobs=dist-sparcv9-solaris

[rust-bors]

💔 Test for 058e0cd failed: CI. Failed jobs:

• try - dist-sparcv9-solaris (web logs, extended logs)

[rust-log-analyzer]

The job dist-sparcv9-solaris failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] gimli test:false 4.513
[RUSTC-TIMING] object test:false 5.925
error: linking with `sparcv9-solaris-gcc` failed: exit status: 1
|
= note: "sparcv9-solaris-gcc" "-Wl,-M" "-Wl,/tmp/rustckoVf17/list" "-m64" "/tmp/rustckoVf17/symbols.o" "<1 object files omitted>" "/tmp/rustckoVf17/rmeta.o" "<1 object files omitted>" "-Wl,-z,ignore" "-Wl,-Bdynamic" "-lsocket" "-lposix4" "-lpthread" "-lresolv" "-Wl,-Bstatic" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/sparcv9-sun-solaris/release/deps/{libpanic_unwind-576066aea71040b7,libobject-42de11fbaba8a6f0,libmemchr-1269b5819ad29d5f,libaddr2line-ffa399e8d33a727a,libgimli-7718c281d3f7ddfe,librustc_demangle-18d5e4a68e177ea3,libstd_detect-a9f0a5ddeb619a4a,libhashbrown-7335bdf04caedc95,librustc_std_workspace_alloc-8b303960f4369ed2,libminiz_oxide-244fbf42d1952c98,libadler2-fdef1fc9ab9a4e63,libunwind-147d300e73828b63,libcfg_if-77b8b4f011955e2d,liblibc-3a8e43a40000b5f2,librustc_std_workspace_core-089abc0fb4aa3ed2,liballoc-cb97d4135d2d8cba,libcore-2b2fea2b0a75a66f,libcompiler_builtins-a2eaffc63113988a}.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lc" "-lm" "-lrt" "-lpthread" "-lsendfile" "-llgrp" "-L" "/tmp/rustckoVf17/raw-dylibs" "-L" "<sysroot>-std/sparcv9-sun-solaris/release/build/compiler_builtins-8df8598ce8895c14/out" "-o" "<sysroot>-std/sparcv9-sun-solaris/release/deps/libstd-db8c12fe786efb99.so" "-shared" "-Wl,-soname=libstd-db8c12fe786efb99.so" "-nodefaultlibs" "-Wl,-z,origin" "-Wl,-rpath,$ORIGIN/../lib"
= note: some arguments are omitted. use `--verbose` to show all linker arguments
= note: /opt/solaris/sparcv9/lib/gcc/sparcv9-pc-solaris2.11/8.4.0/../../../../sparcv9-pc-solaris2.11/bin/ld: warning: -z ignore ignored
/opt/solaris/sparcv9/lib/gcc/sparcv9-pc-solaris2.11/8.4.0/../../../../sparcv9-pc-solaris2.11/bin/ld:/tmp/rustckoVf17/list: file format not recognized; treating as linker script
/opt/solaris/sparcv9/lib/gcc/sparcv9-pc-solaris2.11/8.4.0/../../../../sparcv9-pc-solaris2.11/bin/ld:/tmp/rustckoVf17/list:1: syntax error
collect2: error: ld returned 1 exit status
[RUSTC-TIMING] std test:false 15.731
error: could not compile `std` (lib) due to 1 previous error

[bjorn3]

No clue why this fails. I guess I will just leave limit_rdylib_exports disabled.