Skip to content

tests: Add test for basic line-by-line stepping in a debugger - #144497

Merged
bors merged 1 commit into
rust-lang:masterfrom
Enselic:basic-stepping
Aug 4, 2025
Merged

tests: Add test for basic line-by-line stepping in a debugger#144497
bors merged 1 commit into
rust-lang:masterfrom
Enselic:basic-stepping

Conversation

@Enselic

@EnselicEnselic commented Jul 26, 2025

Copy link
Copy Markdown
Member

Let's wait with lldb testing until the test works properly with gdb.

This is a regression test to prevent further regressions of #33013 which unfortunately regressed in nightly-2023-04-24. See #33013 (comment).

@rustbot

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 26, 2025
@EnselicEnselic mentioned this pull request Jul 26, 2025
@rust-log-analyzer

This comment has been minimized.

Let's wait with lldb testing until the test works properly with gdb.
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 3, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 534b135 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2025
@ZalatharZalathar mentioned this pull request Aug 4, 2025
bors added a commit that referenced this pull request Aug 4, 2025
Rollup of 12 pull requests
Successful merges:
- #142205 (Mark `slice::swap_with_slice` unstably const)
- #144188 (`available_parallelism`: Add documentation for why we don't look at `ulimit`)
- #144322 (Add lint against dangling pointers from local variables)
- #144497 (tests: Add test for basic line-by-line stepping in a debugger)
- #144559 (Enable extract-insert-dyn.rs test on RISC-V (riscv64))
- #144667 (`AlignmentEnum` should just be `repr(usize)` now)
- #144706 (Do not give function allocations alignment in consteval and Miri.)
- #144746 (resolve: Cleanups and micro-optimizations to extern prelude)
- #144785 (Regression test for LLVM error with unsupported expression in static initializer for const pointer in array on macOS.)
- #144811 (Stylize `*-lynxos178-*` target maintainer handle to make it easier to copy/paste)
- #144848 (For "stage 1" ui-fulldeps, use the stage 1 compiler to query target info)
- #144853 (Remove unnecessary `rust_` prefixes)
Failed merges:
- #144794 (Port `#[coroutine]` to the new attribute system)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit cc7c63b into rust-lang:masterAug 4, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 4, 2025
@bors

bors commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 534b135 with merge 07b7dc9...

rust-timer added a commit that referenced this pull request Aug 4, 2025
Rollup merge of #144497 - Enselic:basic-stepping, r=Mark-Simulacrum
tests: Add test for basic line-by-line stepping in a debugger
Let's wait with lldb testing until the test works properly with gdb.
This is a regression test to prevent further regressions of #33013 which unfortunately regressed in **nightly-2023-04-24**. See #33013 (comment).
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Aug 4, 2025
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#142205 (Mark `slice::swap_with_slice` unstably const)
- rust-lang/rust#144188 (`available_parallelism`: Add documentation for why we don't look at `ulimit`)
- rust-lang/rust#144322 (Add lint against dangling pointers from local variables)
- rust-lang/rust#144497 (tests: Add test for basic line-by-line stepping in a debugger)
- rust-lang/rust#144559 (Enable extract-insert-dyn.rs test on RISC-V (riscv64))
- rust-lang/rust#144667 (`AlignmentEnum` should just be `repr(usize)` now)
- rust-lang/rust#144706 (Do not give function allocations alignment in consteval and Miri.)
- rust-lang/rust#144746 (resolve: Cleanups and micro-optimizations to extern prelude)
- rust-lang/rust#144785 (Regression test for LLVM error with unsupported expression in static initializer for const pointer in array on macOS.)
- rust-lang/rust#144811 (Stylize `*-lynxos178-*` target maintainer handle to make it easier to copy/paste)
- rust-lang/rust#144848 (For "stage 1" ui-fulldeps, use the stage 1 compiler to query target info)
- rust-lang/rust#144853 (Remove unnecessary `rust_` prefixes)
Failed merges:
- rust-lang/rust#144794 (Port `#[coroutine]` to the new attribute system)
r? `@ghost`
`@rustbot` modify labels: rollup
rust-borsBot pushed a commit that referenced this pull request Mar 15, 2026
tests/debuginfo/basic-stepping.rs: Remove ignore-aarch64
This test passes for me both with `gdb` and `lldb` when I run it on an aarch64 machine (namely [dev-desktop-eu-1](https://forge.rust-lang.org/infra/docs/dev-desktop.html)).
And as can be seen below, it now passes PR CI, including **aarch64-gnu-llvm-21-1**.
This test used to [fail](#144497 (comment)) PR CI, in particular **aarch64-gnu-llvm-19-1**.
I suggest we put this in a rollup as an iffy PR to see if we can get it through. If we can, we are one step closer towards closing #33013.
github-actionsBot pushed a commit to rust-lang/compiler-builtins that referenced this pull request Mar 31, 2026
tests/debuginfo/basic-stepping.rs: Remove ignore-aarch64
This test passes for me both with `gdb` and `lldb` when I run it on an aarch64 machine (namely [dev-desktop-eu-1](https://forge.rust-lang.org/infra/docs/dev-desktop.html)).
And as can be seen below, it now passes PR CI, including **aarch64-gnu-llvm-21-1**.
This test used to [fail](rust-lang/rust#144497 (comment)) PR CI, in particular **aarch64-gnu-llvm-19-1**.
I suggest we put this in a rollup as an iffy PR to see if we can get it through. If we can, we are one step closer towards closing rust-lang/rust#33013.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 25, 2026
triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes
The test `tests/debuginfo/basic-stepping.rs` has a history of [regressing for subtle reasons](rust-lang#33013 (comment)) ([retroactively](rust-lang#144497)), and has [expected behavior](rust-lang#153941) that is [not obvious](rust-lang#155377). So I'd like to keep an extra eye one it.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 25, 2026
triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes
The test `tests/debuginfo/basic-stepping.rs` has a history of [regressing for subtle reasons](rust-lang#33013 (comment)) ([retroactively](rust-lang#144497)), and has [expected behavior](rust-lang#153941) that is [not obvious](rust-lang#155377). So I'd like to keep an extra eye one it.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 25, 2026
triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes
The test `tests/debuginfo/basic-stepping.rs` has a history of [regressing for subtle reasons](rust-lang#33013 (comment)) ([retroactively](rust-lang#144497)), and has [expected behavior](rust-lang#153941) that is [not obvious](rust-lang#155377). So I'd like to keep an extra eye one it.
rust-timer added a commit that referenced this pull request Apr 26, 2026
Rollup merge of #155769 - Enselic:ping-enselic, r=Urgau
triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes
The test `tests/debuginfo/basic-stepping.rs` has a history of [regressing for subtle reasons](#33013 (comment)) ([retroactively](#144497)), and has [expected behavior](#153941) that is [not obvious](#155377). So I'd like to keep an extra eye one it.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Enselic@rustbot@rust-log-analyzer@Mark-Simulacrum@bors