Skip to content

Enable extract-insert-dyn.rs test on RISC-V (riscv64) - #144559

Merged
bors merged 1 commit into
rust-lang:masterfrom
CaiWeiran:extract-insert-dyn_test
Aug 4, 2025
Merged

Enable extract-insert-dyn.rs test on RISC-V (riscv64)#144559
bors merged 1 commit into
rust-lang:masterfrom
CaiWeiran:extract-insert-dyn_test

Conversation

@CaiWeiran

Copy link
Copy Markdown

This PR adds support for running the tests/codegen-llvm/simd/extract-insert-dyn.rs test on the RISC-V (riscv64) architecture.

Previously, this test would fail on RISC-V targets due to architecture-specific code generation issues. This patch modifies the test to ensure compatibility while preserving its intent.

The change has been tested locally using ./x test on a riscv64 target, and the test now passes as expected.

Notes:

  • This change is scoped specifically to improve RISC-V compatibility.
  • It does not affect behavior or test results on other architectures.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 28, 2025
@CaiWeiran

Copy link
Copy Markdown
Author

r?@wesleywiser Thanks

Comment threadtests/codegen-llvm/simd/extract-insert-dyn.rs
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 3, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 6c7dc05 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2025
@ZalatharZalathar mentioned this pull request Aug 4, 2025
bors added a commit that referenced this pull request Aug 4, 2025
Rollup of 12 pull requests
Successful merges:
- #142205 (Mark `slice::swap_with_slice` unstably const)
- #144188 (`available_parallelism`: Add documentation for why we don't look at `ulimit`)
- #144322 (Add lint against dangling pointers from local variables)
- #144497 (tests: Add test for basic line-by-line stepping in a debugger)
- #144559 (Enable extract-insert-dyn.rs test on RISC-V (riscv64))
- #144667 (`AlignmentEnum` should just be `repr(usize)` now)
- #144706 (Do not give function allocations alignment in consteval and Miri.)
- #144746 (resolve: Cleanups and micro-optimizations to extern prelude)
- #144785 (Regression test for LLVM error with unsupported expression in static initializer for const pointer in array on macOS.)
- #144811 (Stylize `*-lynxos178-*` target maintainer handle to make it easier to copy/paste)
- #144848 (For "stage 1" ui-fulldeps, use the stage 1 compiler to query target info)
- #144853 (Remove unnecessary `rust_` prefixes)
Failed merges:
- #144794 (Port `#[coroutine]` to the new attribute system)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 70587eb into rust-lang:masterAug 4, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 4, 2025
rust-timer added a commit that referenced this pull request Aug 4, 2025
Rollup merge of #144559 - CaiWeiran:extract-insert-dyn_test, r=Mark-Simulacrum
Enable extract-insert-dyn.rs test on RISC-V (riscv64)
This PR adds support for running the `tests/codegen-llvm/simd/extract-insert-dyn.rs` test on the RISC-V (riscv64) architecture.
Previously, this test would fail on RISC-V targets due to architecture-specific code generation issues. This patch modifies the test to ensure compatibility while preserving its intent.
The change has been tested locally using `./x test` on a riscv64 target, and the test now passes as expected.
### Notes:
- This change is scoped specifically to improve RISC-V compatibility.
- It does not affect behavior or test results on other architectures.
@bors

bors commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 6c7dc05 with merge 07b7dc9...

@ZalatharZalathar mentioned this pull request Aug 4, 2025
@Zalathar

Copy link
Copy Markdown
Member

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 4, 2025
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Aug 4, 2025
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#142205 (Mark `slice::swap_with_slice` unstably const)
- rust-lang/rust#144188 (`available_parallelism`: Add documentation for why we don't look at `ulimit`)
- rust-lang/rust#144322 (Add lint against dangling pointers from local variables)
- rust-lang/rust#144497 (tests: Add test for basic line-by-line stepping in a debugger)
- rust-lang/rust#144559 (Enable extract-insert-dyn.rs test on RISC-V (riscv64))
- rust-lang/rust#144667 (`AlignmentEnum` should just be `repr(usize)` now)
- rust-lang/rust#144706 (Do not give function allocations alignment in consteval and Miri.)
- rust-lang/rust#144746 (resolve: Cleanups and micro-optimizations to extern prelude)
- rust-lang/rust#144785 (Regression test for LLVM error with unsupported expression in static initializer for const pointer in array on macOS.)
- rust-lang/rust#144811 (Stylize `*-lynxos178-*` target maintainer handle to make it easier to copy/paste)
- rust-lang/rust#144848 (For "stage 1" ui-fulldeps, use the stage 1 compiler to query target info)
- rust-lang/rust#144853 (Remove unnecessary `rust_` prefixes)
Failed merges:
- rust-lang/rust#144794 (Port `#[coroutine]` to the new attribute system)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@CaiWeiran@rustbot@Mark-Simulacrum@bors@Zalathar@wesleywiser