Skip to content

defer opaque type errors, generally greatly reduce tainting - #145115

Merged
bors merged 2 commits into
rust-lang:masterfrom
lcnr:less-borrowck-tainting
Aug 9, 2025
Merged

defer opaque type errors, generally greatly reduce tainting#145115
bors merged 2 commits into
rust-lang:masterfrom
lcnr:less-borrowck-tainting

Conversation

@lcnr

@lcnrlcnr commented Aug 8, 2025•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

fixes the test for #135528, does not actually fix that issue properly.

This is useful as it causes the migration to #139587 to be a lot easier.

@rustbot

rustbot commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 8, 2025
@lcnrlcnr changed the title defer opaque type errors: greatly reduce taintingdefer opaque type errors, generally greatly reduce taintingAug 8, 2025
@lcnr
lcnrforce-pushed the less-borrowck-tainting branch from b03ac53 to 03d0af8CompareAugust 8, 2025 17:19
@lcnr
lcnrforce-pushed the less-borrowck-tainting branch from 03d0af8 to 4eee556CompareAugust 8, 2025 17:24
@rustbot

rustbot commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@compiler-errors

compiler-errors commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

lgtm

r? compiler-errors @bors r+ rollup

@bors

bors commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 4eee556 has been approved by compiler-errors

It is now in the queue for this repository.

@bors

bors commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2025
@ZalatharZalathar mentioned this pull request Aug 9, 2025
Merged
bors added a commit that referenced this pull request Aug 9, 2025
@bors
Auto merge of#145142- Zalathar:rollup-oi6s8kg, r=Zalathar
f2aa3e0
Rollup of 23 pull requests
Successful merges:
- #141658 (rustdoc search: prefer stable items in search results)
- #141828 (Add diagnostic explaining STATUS_STACK_BUFFER_OVERRUN not only being used for stack buffer overruns if link.exe exits with that exit code)
- #144823 (coverage: Extract HIR-related helper code out of the main module)
- #144883 (Remove unneeded `drop_in_place` calls)
- #144923 (Move several more float tests to floats/mod.rs)
- #144988 (Add annotations to the graphviz region graph on region origins)
- #145010 (Couple of minor abi handling cleanups)
- #145017 (Explicitly disable vector feature on s390x baseline of bad-reg test)
- #145027 (Optimize `char::is_alphanumeric`)
- #145050 (add member constraints tests)
- #145073 (update enzyme submodule to handle llvm 21)
- #145080 (Escape diff strings in MIR dataflow graphviz)
- #145082 (Fix some bad formatting in `-Zmacro-stats` output.)
- #145083 (Fix cross-compilation of Cargo)
- #145096 (Fix wasm target build with atomics feature)
- #145097 (remove unnecessary `TypeFoldable` impls)
- #145100 (Rank doc aliases lower than equivalently matched items)
- #145103 (rustc_metadata: remove unused private trait impls)
- #145115 (defer opaque type errors, generally greatly reduce tainting)
- #145119 (rustc_public: fix missing parenthesis in pretty discriminant)
- #145124 (Recover `for PAT = EXPR {}`)
- #145132 (Refactor map_unit_fn lint)
- #145134 (Reduce indirect assoc parent queries)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 9, 2025
@bors
Auto merge of#145142- Zalathar:rollup-oi6s8kg, r=Zalathar
ca77504
Rollup of 23 pull requests
Successful merges:
- #141658 (rustdoc search: prefer stable items in search results)
- #141828 (Add diagnostic explaining STATUS_STACK_BUFFER_OVERRUN not only being used for stack buffer overruns if link.exe exits with that exit code)
- #144823 (coverage: Extract HIR-related helper code out of the main module)
- #144883 (Remove unneeded `drop_in_place` calls)
- #144923 (Move several more float tests to floats/mod.rs)
- #144988 (Add annotations to the graphviz region graph on region origins)
- #145010 (Couple of minor abi handling cleanups)
- #145017 (Explicitly disable vector feature on s390x baseline of bad-reg test)
- #145027 (Optimize `char::is_alphanumeric`)
- #145050 (add member constraints tests)
- #145073 (update enzyme submodule to handle llvm 21)
- #145080 (Escape diff strings in MIR dataflow graphviz)
- #145082 (Fix some bad formatting in `-Zmacro-stats` output.)
- #145083 (Fix cross-compilation of Cargo)
- #145096 (Fix wasm target build with atomics feature)
- #145097 (remove unnecessary `TypeFoldable` impls)
- #145100 (Rank doc aliases lower than equivalently matched items)
- #145103 (rustc_metadata: remove unused private trait impls)
- #145115 (defer opaque type errors, generally greatly reduce tainting)
- #145119 (rustc_public: fix missing parenthesis in pretty discriminant)
- #145124 (Recover `for PAT = EXPR {}`)
- #145132 (Refactor map_unit_fn lint)
- #145134 (Reduce indirect assoc parent queries)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 9d989bf into rust-lang:masterAug 9, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 9, 2025
rust-timer added a commit that referenced this pull request Aug 9, 2025
@rust-timer
Unrolled build for#145115
b81c599
Rollup merge of #145115 - lcnr:less-borrowck-tainting, r=compiler-errors
defer opaque type errors, generally greatly reduce tainting
fixes the test for #135528, does not actually fix that issue properly.
This is useful as it causes the migration to #139587 to be a lot easier.
@jieyouxu

jieyouxu commented Aug 9, 2025

Copy link
Copy Markdown
Member

Hi bors this already merged
@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2025
@jieyouxu

jieyouxu commented Aug 9, 2025

Copy link
Copy Markdown
Member

@rustbot label: -S-waiting-on-author +S-waiting-on-bors +merged-by-bors

@rustbotrustbot added merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2025
@rustbotrustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 9, 2025
@lcnr
lcnr deleted the less-borrowck-tainting branch August 11, 2025 07:11
rust-cloud-vmsBot pushed a commit to makai410/rustc_public that referenced this pull request Aug 16, 2025
@bors
Auto merge of #145142 - Zalathar:rollup-oi6s8kg, r=Zalathar
2d9ae4b
Rollup of 23 pull requests
Successful merges:
- rust-lang/rust#141658 (rustdoc search: prefer stable items in search results)
- rust-lang/rust#141828 (Add diagnostic explaining STATUS_STACK_BUFFER_OVERRUN not only being used for stack buffer overruns if link.exe exits with that exit code)
- rust-lang/rust#144823 (coverage: Extract HIR-related helper code out of the main module)
- rust-lang/rust#144883 (Remove unneeded `drop_in_place` calls)
- rust-lang/rust#144923 (Move several more float tests to floats/mod.rs)
- rust-lang/rust#144988 (Add annotations to the graphviz region graph on region origins)
- rust-lang/rust#145010 (Couple of minor abi handling cleanups)
- rust-lang/rust#145017 (Explicitly disable vector feature on s390x baseline of bad-reg test)
- rust-lang/rust#145027 (Optimize `char::is_alphanumeric`)
- rust-lang/rust#145050 (add member constraints tests)
- rust-lang/rust#145073 (update enzyme submodule to handle llvm 21)
- rust-lang/rust#145080 (Escape diff strings in MIR dataflow graphviz)
- rust-lang/rust#145082 (Fix some bad formatting in `-Zmacro-stats` output.)
- rust-lang/rust#145083 (Fix cross-compilation of Cargo)
- rust-lang/rust#145096 (Fix wasm target build with atomics feature)
- rust-lang/rust#145097 (remove unnecessary `TypeFoldable` impls)
- rust-lang/rust#145100 (Rank doc aliases lower than equivalently matched items)
- rust-lang/rust#145103 (rustc_metadata: remove unused private trait impls)
- rust-lang/rust#145115 (defer opaque type errors, generally greatly reduce tainting)
- rust-lang/rust#145119 (rustc_public: fix missing parenthesis in pretty discriminant)
- rust-lang/rust#145124 (Recover `for PAT = EXPR {}`)
- rust-lang/rust#145132 (Refactor map_unit_fn lint)
- rust-lang/rust#145134 (Reduce indirect assoc parent queries)
r? `@ghost`
`@rustbot` modify labels: rollup
rust-cloud-vmsBot pushed a commit to makai410/rustc_public that referenced this pull request Aug 20, 2025
@bors
Auto merge of #145142 - Zalathar:rollup-oi6s8kg, r=Zalathar
c90eafb
Rollup of 23 pull requests
Successful merges:
- rust-lang/rust#141658 (rustdoc search: prefer stable items in search results)
- rust-lang/rust#141828 (Add diagnostic explaining STATUS_STACK_BUFFER_OVERRUN not only being used for stack buffer overruns if link.exe exits with that exit code)
- rust-lang/rust#144823 (coverage: Extract HIR-related helper code out of the main module)
- rust-lang/rust#144883 (Remove unneeded `drop_in_place` calls)
- rust-lang/rust#144923 (Move several more float tests to floats/mod.rs)
- rust-lang/rust#144988 (Add annotations to the graphviz region graph on region origins)
- rust-lang/rust#145010 (Couple of minor abi handling cleanups)
- rust-lang/rust#145017 (Explicitly disable vector feature on s390x baseline of bad-reg test)
- rust-lang/rust#145027 (Optimize `char::is_alphanumeric`)
- rust-lang/rust#145050 (add member constraints tests)
- rust-lang/rust#145073 (update enzyme submodule to handle llvm 21)
- rust-lang/rust#145080 (Escape diff strings in MIR dataflow graphviz)
- rust-lang/rust#145082 (Fix some bad formatting in `-Zmacro-stats` output.)
- rust-lang/rust#145083 (Fix cross-compilation of Cargo)
- rust-lang/rust#145096 (Fix wasm target build with atomics feature)
- rust-lang/rust#145097 (remove unnecessary `TypeFoldable` impls)
- rust-lang/rust#145100 (Rank doc aliases lower than equivalently matched items)
- rust-lang/rust#145103 (rustc_metadata: remove unused private trait impls)
- rust-lang/rust#145115 (defer opaque type errors, generally greatly reduce tainting)
- rust-lang/rust#145119 (rustc_public: fix missing parenthesis in pretty discriminant)
- rust-lang/rust#145124 (Recover `for PAT = EXPR {}`)
- rust-lang/rust#145132 (Refactor map_unit_fn lint)
- rust-lang/rust#145134 (Reduce indirect assoc parent queries)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@bors
Auto merge ofrust-lang#145142- Zalathar:rollup-oi6s8kg, r=Zalathar
702ff42
Rollup of 23 pull requests
Successful merges:
- rust-lang#141658 (rustdoc search: prefer stable items in search results)
- rust-lang#141828 (Add diagnostic explaining STATUS_STACK_BUFFER_OVERRUN not only being used for stack buffer overruns if link.exe exits with that exit code)
- rust-lang#144823 (coverage: Extract HIR-related helper code out of the main module)
- rust-lang#144883 (Remove unneeded `drop_in_place` calls)
- rust-lang#144923 (Move several more float tests to floats/mod.rs)
- rust-lang#144988 (Add annotations to the graphviz region graph on region origins)
- rust-lang#145010 (Couple of minor abi handling cleanups)
- rust-lang#145017 (Explicitly disable vector feature on s390x baseline of bad-reg test)
- rust-lang#145027 (Optimize `char::is_alphanumeric`)
- rust-lang#145050 (add member constraints tests)
- rust-lang#145073 (update enzyme submodule to handle llvm 21)
- rust-lang#145080 (Escape diff strings in MIR dataflow graphviz)
- rust-lang#145082 (Fix some bad formatting in `-Zmacro-stats` output.)
- rust-lang#145083 (Fix cross-compilation of Cargo)
- rust-lang#145096 (Fix wasm target build with atomics feature)
- rust-lang#145097 (remove unnecessary `TypeFoldable` impls)
- rust-lang#145100 (Rank doc aliases lower than equivalently matched items)
- rust-lang#145103 (rustc_metadata: remove unused private trait impls)
- rust-lang#145115 (defer opaque type errors, generally greatly reduce tainting)
- rust-lang#145119 (rustc_public: fix missing parenthesis in pretty discriminant)
- rust-lang#145124 (Recover `for PAT = EXPR {}`)
- rust-lang#145132 (Refactor map_unit_fn lint)
- rust-lang#145134 (Reduce indirect assoc parent queries)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@bors
Auto merge ofrust-lang#145142- Zalathar:rollup-oi6s8kg, r=Zalathar
14a528d
Rollup of 23 pull requests
Successful merges:
- rust-lang#141658 (rustdoc search: prefer stable items in search results)
- rust-lang#141828 (Add diagnostic explaining STATUS_STACK_BUFFER_OVERRUN not only being used for stack buffer overruns if link.exe exits with that exit code)
- rust-lang#144823 (coverage: Extract HIR-related helper code out of the main module)
- rust-lang#144883 (Remove unneeded `drop_in_place` calls)
- rust-lang#144923 (Move several more float tests to floats/mod.rs)
- rust-lang#144988 (Add annotations to the graphviz region graph on region origins)
- rust-lang#145010 (Couple of minor abi handling cleanups)
- rust-lang#145017 (Explicitly disable vector feature on s390x baseline of bad-reg test)
- rust-lang#145027 (Optimize `char::is_alphanumeric`)
- rust-lang#145050 (add member constraints tests)
- rust-lang#145073 (update enzyme submodule to handle llvm 21)
- rust-lang#145080 (Escape diff strings in MIR dataflow graphviz)
- rust-lang#145082 (Fix some bad formatting in `-Zmacro-stats` output.)
- rust-lang#145083 (Fix cross-compilation of Cargo)
- rust-lang#145096 (Fix wasm target build with atomics feature)
- rust-lang#145097 (remove unnecessary `TypeFoldable` impls)
- rust-lang#145100 (Rank doc aliases lower than equivalently matched items)
- rust-lang#145103 (rustc_metadata: remove unused private trait impls)
- rust-lang#145115 (defer opaque type errors, generally greatly reduce tainting)
- rust-lang#145119 (rustc_public: fix missing parenthesis in pretty discriminant)
- rust-lang#145124 (Recover `for PAT = EXPR {}`)
- rust-lang#145132 (Refactor map_unit_fn lint)
- rust-lang#145134 (Reduce indirect assoc parent queries)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Nov 16, 2025
@bors
Auto merge of #145142 - Zalathar:rollup-oi6s8kg, r=Zalathar
c32dfdd
Rollup of 23 pull requests
Successful merges:
- rust-lang/rust#141658 (rustdoc search: prefer stable items in search results)
- rust-lang/rust#141828 (Add diagnostic explaining STATUS_STACK_BUFFER_OVERRUN not only being used for stack buffer overruns if link.exe exits with that exit code)
- rust-lang/rust#144823 (coverage: Extract HIR-related helper code out of the main module)
- rust-lang/rust#144883 (Remove unneeded `drop_in_place` calls)
- rust-lang/rust#144923 (Move several more float tests to floats/mod.rs)
- rust-lang/rust#144988 (Add annotations to the graphviz region graph on region origins)
- rust-lang/rust#145010 (Couple of minor abi handling cleanups)
- rust-lang/rust#145017 (Explicitly disable vector feature on s390x baseline of bad-reg test)
- rust-lang/rust#145027 (Optimize `char::is_alphanumeric`)
- rust-lang/rust#145050 (add member constraints tests)
- rust-lang/rust#145073 (update enzyme submodule to handle llvm 21)
- rust-lang/rust#145080 (Escape diff strings in MIR dataflow graphviz)
- rust-lang/rust#145082 (Fix some bad formatting in `-Zmacro-stats` output.)
- rust-lang/rust#145083 (Fix cross-compilation of Cargo)
- rust-lang/rust#145096 (Fix wasm target build with atomics feature)
- rust-lang/rust#145097 (remove unnecessary `TypeFoldable` impls)
- rust-lang/rust#145100 (Rank doc aliases lower than equivalently matched items)
- rust-lang/rust#145103 (rustc_metadata: remove unused private trait impls)
- rust-lang/rust#145115 (defer opaque type errors, generally greatly reduce tainting)
- rust-lang/rust#145119 (rustc_public: fix missing parenthesis in pretty discriminant)
- rust-lang/rust#145124 (Recover `for PAT = EXPR {}`)
- rust-lang/rust#145132 (Refactor map_unit_fn lint)
- rust-lang/rust#145134 (Reduce indirect assoc parent queries)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Mar 27, 2026
@bors
Auto merge of #145142 - Zalathar:rollup-oi6s8kg, r=Zalathar
e861be1
Rollup of 23 pull requests
Successful merges:
- rust-lang/rust#141658 (rustdoc search: prefer stable items in search results)
- rust-lang/rust#141828 (Add diagnostic explaining STATUS_STACK_BUFFER_OVERRUN not only being used for stack buffer overruns if link.exe exits with that exit code)
- rust-lang/rust#144823 (coverage: Extract HIR-related helper code out of the main module)
- rust-lang/rust#144883 (Remove unneeded `drop_in_place` calls)
- rust-lang/rust#144923 (Move several more float tests to floats/mod.rs)
- rust-lang/rust#144988 (Add annotations to the graphviz region graph on region origins)
- rust-lang/rust#145010 (Couple of minor abi handling cleanups)
- rust-lang/rust#145017 (Explicitly disable vector feature on s390x baseline of bad-reg test)
- rust-lang/rust#145027 (Optimize `char::is_alphanumeric`)
- rust-lang/rust#145050 (add member constraints tests)
- rust-lang/rust#145073 (update enzyme submodule to handle llvm 21)
- rust-lang/rust#145080 (Escape diff strings in MIR dataflow graphviz)
- rust-lang/rust#145082 (Fix some bad formatting in `-Zmacro-stats` output.)
- rust-lang/rust#145083 (Fix cross-compilation of Cargo)
- rust-lang/rust#145096 (Fix wasm target build with atomics feature)
- rust-lang/rust#145097 (remove unnecessary `TypeFoldable` impls)
- rust-lang/rust#145100 (Rank doc aliases lower than equivalently matched items)
- rust-lang/rust#145103 (rustc_metadata: remove unused private trait impls)
- rust-lang/rust#145115 (defer opaque type errors, generally greatly reduce tainting)
- rust-lang/rust#145119 (rustc_public: fix missing parenthesis in pretty discriminant)
- rust-lang/rust#145124 (Recover `for PAT = EXPR {}`)
- rust-lang/rust#145132 (Refactor map_unit_fn lint)
- rust-lang/rust#145134 (Reduce indirect assoc parent queries)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@compiler-errorscompiler-errorscompiler-errors approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@compiler-errorscompiler-errors

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

6 participants

@lcnr@rustbot@compiler-errors@bors@jieyouxu@fee1-dead