Uh oh!
There was an error while loading. Please reload this page.
Rollup of 23 pull requests - #145142
Merged
Merged
Conversation
This adds - (ex) for regions whose origin is existential, - (p) for regoins whose origin is a placeholder, and - (p for <name>) if the originating placeholder is named. This has helped _my_ debugging and it doesn't create too bad clutter, I feel. The change is ridiculously small, but I turned it into a separate PR so we can bikeshed the format.
Directly creating the ArgAttributes rather than adjusting one is a bit clearer.
This restricts the uses of the unadjusted ABI to LLVM intrinsics. The Rust ABI works fine for the thread-local shim as it always returns pointers directly like the backend expects.
If the baseline s390x cpu is changed to a newer variant, such as z13, the vector feature may be enabled by default. When rust is packaged on fedora 38 and newer, it is set to z13. Explicitly disable vector support on the baseline test for consistent results across s390x cpus.
Avoid an unnecessary call to `unicode::Alphabetic` when `self` is an ASCII digit (ie `0..=9`).
used for stack buffer overruns if link.exe exits with that exit code `STATUS_STACK_BUFFER_OVERRUN` is also used for fast abnormal program termination, e.g. by abort(). Emit a special diagnostic to let people know that this most likely doesn't indicate a stack buffer overrun.
This clobbers the existing generic abs test, but it covers strictly more, so that seems fine.
Note that the behaviour of the f128 test is slightly changed to use the same nan mask as is used in test_float_bits_conv, which is the behaviour used by f16,f32,and f64.
This standardizes how max and min subnormals are generated. Since the new method doesn't use powf, it also enables some of the tests for f128 that were previously disabled due to issues with powf (although it looks like those issues were already fixed anyway). f16 signalling nan tests previously disabled are not re-enabled, since the underlying LLVM issue has not been closed.
Some cases that are currently handled incorrectly.
I also double-checked that everything looks good on some real-world crates.
bors
commented
Aug 9, 2025
Collaborator
Zalathar
commented
Aug 9, 2025
MemberAuthor
Once again, running a few jobs early seems to have a big payoff if they actually catch anything: @bors try jobs=test-various,dist-ohos-x86_64 |
Contributor
rust-borsBot
added a commit
that referenced
this pull request
Aug 9, 2025
Rollup of 23 pull requests try-job: test-various try-job: dist-ohos-x86_64
Contributor
bors
commented
Aug 9, 2025
Collaborator
bors added a commit
that referenced
this pull request
Aug 9, 2025
Rollup of 23 pull requests Successful merges: - #141658 (rustdoc search: prefer stable items in search results) - #141828 (Add diagnostic explaining STATUS_STACK_BUFFER_OVERRUN not only being used for stack buffer overruns if link.exe exits with that exit code) - #144823 (coverage: Extract HIR-related helper code out of the main module) - #144883 (Remove unneeded `drop_in_place` calls) - #144923 (Move several more float tests to floats/mod.rs) - #144988 (Add annotations to the graphviz region graph on region origins) - #145010 (Couple of minor abi handling cleanups) - #145017 (Explicitly disable vector feature on s390x baseline of bad-reg test) - #145027 (Optimize `char::is_alphanumeric`) - #145050 (add member constraints tests) - #145073 (update enzyme submodule to handle llvm 21) - #145080 (Escape diff strings in MIR dataflow graphviz) - #145082 (Fix some bad formatting in `-Zmacro-stats` output.) - #145083 (Fix cross-compilation of Cargo) - #145096 (Fix wasm target build with atomics feature) - #145097 (remove unnecessary `TypeFoldable` impls) - #145100 (Rank doc aliases lower than equivalently matched items) - #145103 (rustc_metadata: remove unused private trait impls) - #145115 (defer opaque type errors, generally greatly reduce tainting) - #145119 (rustc_public: fix missing parenthesis in pretty discriminant) - #145124 (Recover `for PAT = EXPR {}`) - #145132 (Refactor map_unit_fn lint) - #145134 (Reduce indirect assoc parent queries) r? `@ghost` `@rustbot` modify labels: rollup
rust-log-analyzer
commented
Aug 9, 2025
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Aug 9, 2025
Collaborator
💔 Test failed - checks-actions |
fee1-dead
commented
Aug 9, 2025
Member
https://triage.rust-lang.org/gha-logs/rust-lang/rust/47726534304#2025-08-09T07:27:09.9986295Z seems spurious? @bors retry |
bors
commented
Aug 9, 2025
Collaborator
bors
commented
Aug 9, 2025
Collaborator
☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 2de2456 (parent) -> ca77504 (this PR) Test differencesShow 216 test diffsStage 1
Stage 2
(and 42 additional test diffs) Additionally, 74 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard ca77504943887037504c7fc0b9bf06dab3910373 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
rust-timer
commented
Aug 9, 2025
Collaborator
📌 Perf builds for each rolled up PR:
previous master: 2de2456fb7 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
jieyouxu
commented
Aug 9, 2025
Member
@bors ping |
bors
commented
Aug 9, 2025
Collaborator
😪 I'm awake I'm awake |
rust-timer
commented
Aug 9, 2025
Collaborator
Finished benchmarking commit (ca77504): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 3.3%, secondary -0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 463.949s -> 463.988s (0.01%) |
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
Rollup of 23 pull requests Successful merges: - rust-lang#141658 (rustdoc search: prefer stable items in search results) - rust-lang#141828 (Add diagnostic explaining STATUS_STACK_BUFFER_OVERRUN not only being used for stack buffer overruns if link.exe exits with that exit code) - rust-lang#144823 (coverage: Extract HIR-related helper code out of the main module) - rust-lang#144883 (Remove unneeded `drop_in_place` calls) - rust-lang#144923 (Move several more float tests to floats/mod.rs) - rust-lang#144988 (Add annotations to the graphviz region graph on region origins) - rust-lang#145010 (Couple of minor abi handling cleanups) - rust-lang#145017 (Explicitly disable vector feature on s390x baseline of bad-reg test) - rust-lang#145027 (Optimize `char::is_alphanumeric`) - rust-lang#145050 (add member constraints tests) - rust-lang#145073 (update enzyme submodule to handle llvm 21) - rust-lang#145080 (Escape diff strings in MIR dataflow graphviz) - rust-lang#145082 (Fix some bad formatting in `-Zmacro-stats` output.) - rust-lang#145083 (Fix cross-compilation of Cargo) - rust-lang#145096 (Fix wasm target build with atomics feature) - rust-lang#145097 (remove unnecessary `TypeFoldable` impls) - rust-lang#145100 (Rank doc aliases lower than equivalently matched items) - rust-lang#145103 (rustc_metadata: remove unused private trait impls) - rust-lang#145115 (defer opaque type errors, generally greatly reduce tainting) - rust-lang#145119 (rustc_public: fix missing parenthesis in pretty discriminant) - rust-lang#145124 (Recover `for PAT = EXPR {}`) - rust-lang#145132 (Refactor map_unit_fn lint) - rust-lang#145134 (Reduce indirect assoc parent queries) r? `@ghost` `@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
Rollup of 23 pull requests Successful merges: - rust-lang#141658 (rustdoc search: prefer stable items in search results) - rust-lang#141828 (Add diagnostic explaining STATUS_STACK_BUFFER_OVERRUN not only being used for stack buffer overruns if link.exe exits with that exit code) - rust-lang#144823 (coverage: Extract HIR-related helper code out of the main module) - rust-lang#144883 (Remove unneeded `drop_in_place` calls) - rust-lang#144923 (Move several more float tests to floats/mod.rs) - rust-lang#144988 (Add annotations to the graphviz region graph on region origins) - rust-lang#145010 (Couple of minor abi handling cleanups) - rust-lang#145017 (Explicitly disable vector feature on s390x baseline of bad-reg test) - rust-lang#145027 (Optimize `char::is_alphanumeric`) - rust-lang#145050 (add member constraints tests) - rust-lang#145073 (update enzyme submodule to handle llvm 21) - rust-lang#145080 (Escape diff strings in MIR dataflow graphviz) - rust-lang#145082 (Fix some bad formatting in `-Zmacro-stats` output.) - rust-lang#145083 (Fix cross-compilation of Cargo) - rust-lang#145096 (Fix wasm target build with atomics feature) - rust-lang#145097 (remove unnecessary `TypeFoldable` impls) - rust-lang#145100 (Rank doc aliases lower than equivalently matched items) - rust-lang#145103 (rustc_metadata: remove unused private trait impls) - rust-lang#145115 (defer opaque type errors, generally greatly reduce tainting) - rust-lang#145119 (rustc_public: fix missing parenthesis in pretty discriminant) - rust-lang#145124 (Recover `for PAT = EXPR {}`) - rust-lang#145132 (Refactor map_unit_fn lint) - rust-lang#145134 (Reduce indirect assoc parent queries) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
drop_in_placecalls #144883 (Remove unneededdrop_in_placecalls)char::is_alphanumeric#145027 (Optimizechar::is_alphanumeric)-Zmacro-statsoutput. #145082 (Fix some bad formatting in-Zmacro-statsoutput.)TypeFoldableimpls #145097 (remove unnecessaryTypeFoldableimpls)for PAT = EXPR {}#145124 (Recoverfor PAT = EXPR {})r? @ghost
@rustbot modify labels: rollup
Create a similar rollup