Skip to content

Add static glibc to the nix dev shell - #145451

Merged
bors merged 1 commit into
rust-lang:masterfrom
WaffleLapkin:norailoveyou
Aug 18, 2025
Merged

Add static glibc to the nix dev shell#145451
bors merged 1 commit into
rust-lang:masterfrom
WaffleLapkin:norailoveyou

Conversation

@WaffleLapkin

@WaffleLapkinWaffleLapkin commented Aug 15, 2025

Copy link
Copy Markdown
Member

This fixes tests/ui/process/nofile-limit.rs which fails to link on nixos for me without this change.

@WaffleLapkin
add static glibc to the nix dev shell
1d00627
this fixes `tests/ui/process/nofile-limit.rs` which fails to link on
nixos for me without this change
@WaffleLapkinWaffleLapkin added O-NixOS Operating system: NixOS, https://nixos.org/ A-meta Area: Issues & PRs about the rust-lang/rust repository itself labels Aug 15, 2025
@rustbot

rustbot commented Aug 15, 2025

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2025
@WaffleLapkin

WaffleLapkin commented Aug 15, 2025

Copy link
Copy Markdown
MemberAuthor

r? Noratrieb

@rustbot

rustbot commented Aug 15, 2025

Copy link
Copy Markdown
Collaborator

Noratrieb is not on the review rotation at the moment.
They may take a while to respond.

@Noratrieb

Noratrieb commented Aug 16, 2025

Copy link
Copy Markdown
Member

borsrplus in the style of the ToysRUs logo

@bors

bors commented Aug 16, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 1d00627 has been approved by Noratrieb

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 16, 2025
@Zalathar
Rollup merge ofrust-lang#145451- WaffleLapkin:norailoveyou, r=Norat…
55fd065
…rieb
Add static glibc to the nix dev shell
This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.
@ZalatharZalathar mentioned this pull request Aug 16, 2025
Closed
bors added a commit that referenced this pull request Aug 16, 2025
@bors
Auto merge of#145488- Zalathar:rollup-xx2b6w1, r=Zalathar
a387a0c
Rollup of 11 pull requests
Successful merges:
- #139345 (Extend `QueryStability` to handle `IntoIterator` implementations)
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145309 (Fix `-Zregparm` for LLVM builtins)
- #145355 (Add codegen test for issue 122734)
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 17, 2025
@bors
Auto merge of#145488- Zalathar:rollup-xx2b6w1, r=Zalathar
9c7b793
Rollup of 11 pull requests
Successful merges:
- #139345 (Extend `QueryStability` to handle `IntoIterator` implementations)
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145309 (Fix `-Zregparm` for LLVM builtins)
- #145355 (Add codegen test for issue 122734)
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 17, 2025
@Zalathar
Rollup merge ofrust-lang#145451- WaffleLapkin:norailoveyou, r=Norat…
2320c0c
…rieb
Add static glibc to the nix dev shell
This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.
@ZalatharZalathar mentioned this pull request Aug 17, 2025
Closed
bors added a commit that referenced this pull request Aug 17, 2025
@bors
Auto merge of#145517- Zalathar:rollup-yalwww1, r=Zalathar
8cd7e46
Rollup of 10 pull requests
Successful merges:
- #140794 (Add information about group a lint belongs to)
- #144476 (rustdoc-search: search backend with partitioned suffix tree)
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 17, 2025
@Zalathar
Rollup merge ofrust-lang#145451- WaffleLapkin:norailoveyou, r=Norat…
b286f01
…rieb
Add static glibc to the nix dev shell
This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.
@ZalatharZalathar mentioned this pull request Aug 17, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 17, 2025
@Zalathar
Rollup merge ofrust-lang#145451- WaffleLapkin:norailoveyou, r=Norat…
6ff963b
…rieb
Add static glibc to the nix dev shell
This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 17, 2025
@Zalathar
Rollup merge ofrust-lang#145451- WaffleLapkin:norailoveyou, r=Norat…
ed2b7f2
…rieb
Add static glibc to the nix dev shell
This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.
@ZalatharZalathar mentioned this pull request Aug 17, 2025
Closed
bors added a commit that referenced this pull request Aug 17, 2025
@bors
Auto merge of#145521- Zalathar:rollup-d4mqeq0, r=Zalathar
c29e078
Rollup of 10 pull requests
Successful merges:
- #144476 (rustdoc-search: search backend with partitioned suffix tree)
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
- #145489 (library: Migrate from `cfg_if` to `cfg_select`)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 17, 2025
@bors
Auto merge of#145519- Zalathar:rollup-28idalp, r=Zalathar
f12e663
Rollup of 9 pull requests
Successful merges:
- #144476 (rustdoc-search: search backend with partitioned suffix tree)
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 17, 2025
@Zalathar
Rollup merge ofrust-lang#145451- WaffleLapkin:norailoveyou, r=Norat…
79e2adc
…rieb
Add static glibc to the nix dev shell
This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.
@ZalatharZalathar mentioned this pull request Aug 17, 2025
Closed
bors added a commit that referenced this pull request Aug 17, 2025
@bors
Auto merge of#145526- Zalathar:rollup-4boj5q8, r=Zalathar
789878b
Rollup of 10 pull requests
Successful merges:
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145309 (Fix `-Zregparm` for LLVM builtins)
- #145355 (Add codegen test for issue 122734)
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 17, 2025
@jhpratt
Rollup merge ofrust-lang#145451- WaffleLapkin:norailoveyou, r=Norat…
acc0d0f
…rieb
Add static glibc to the nix dev shell
This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.
@jhprattjhpratt mentioned this pull request Aug 17, 2025
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 17, 2025
@jhpratt
Rollup merge ofrust-lang#145451- WaffleLapkin:norailoveyou, r=Norat…
4f534b7
…rieb
Add static glibc to the nix dev shell
This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.
@jhprattjhpratt mentioned this pull request Aug 17, 2025
Closed
bors added a commit that referenced this pull request Aug 18, 2025
@bors
Auto merge of#145526- Zalathar:rollup-4boj5q8, r=Zalathar
ab964e1
Rollup of 10 pull requests
Successful merges:
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145309 (Fix `-Zregparm` for LLVM builtins)
- #145355 (Add codegen test for issue 122734)
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
@ZalatharZalathar mentioned this pull request Aug 18, 2025
Merged
bors added a commit that referenced this pull request Aug 18, 2025
@bors
Auto merge of#145551- Zalathar:rollup-eo75r94, r=Zalathar
e7ec3ca
Rollup of 10 pull requests
Successful merges:
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145309 (Fix `-Zregparm` for LLVM builtins)
- #145355 (Add codegen test for issue 122734)
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 18, 2025
@bors
Auto merge of#145551- Zalathar:rollup-eo75r94, r=Zalathar
239e8b1
Rollup of 10 pull requests
Successful merges:
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145309 (Fix `-Zregparm` for LLVM builtins)
- #145355 (Add codegen test for issue 122734)
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 3b396fc into rust-lang:masterAug 18, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 18, 2025
rust-timer added a commit that referenced this pull request Aug 18, 2025
@rust-timer
Unrolled build for#145451
2fa99e9
Rollup merge of #145451 - WaffleLapkin:norailoveyou, r=Noratrieb
Add static glibc to the nix dev shell
This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.
@WaffleLapkin
WaffleLapkin deleted the norailoveyou branch August 18, 2025 18:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@NoratriebNoratrieb

Labels

A-metaArea: Issues & PRs about the rust-lang/rust repository itselfO-NixOSOperating system: NixOS, https://nixos.org/S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

5 participants

@WaffleLapkin@rustbot@Noratrieb@bors@Mark-Simulacrum