Skip to content

Fix deprecation attributes on foreign statics - #145485

Merged
bors merged 2 commits into
rust-lang:masterfrom
JonathanBrouwer:fix-deprecation-targets
Aug 18, 2025
Merged

Fix deprecation attributes on foreign statics#145485
bors merged 2 commits into
rust-lang:masterfrom
JonathanBrouwer:fix-deprecation-targets

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

@rustbot

Copy link
Copy Markdown
Collaborator

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

@rustbotrustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 16, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@jdonszelmann

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Aug 16, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit a69ba29 has been approved by jdonszelmann

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2025
@jdonszelmann

Copy link
Copy Markdown
Contributor

@bors rollup=always

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 16, 2025
…rgets, r=jdonszelmann
Fix deprecation attributes on foreign statics
r? `@jdonszelmann`
Fixesrust-lang#145437
@ZalatharZalathar mentioned this pull request Aug 16, 2025
bors added a commit that referenced this pull request Aug 16, 2025
Rollup of 11 pull requests
Successful merges:
- #139345 (Extend `QueryStability` to handle `IntoIterator` implementations)
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145309 (Fix `-Zregparm` for LLVM builtins)
- #145355 (Add codegen test for issue 122734)
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 17, 2025
Rollup of 11 pull requests
Successful merges:
- #139345 (Extend `QueryStability` to handle `IntoIterator` implementations)
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145309 (Fix `-Zregparm` for LLVM builtins)
- #145355 (Add codegen test for issue 122734)
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 17, 2025
…rgets, r=jdonszelmann
Fix deprecation attributes on foreign statics
r? ``@jdonszelmann``
Fixesrust-lang#145437
@ZalatharZalathar mentioned this pull request Aug 17, 2025
bors added a commit that referenced this pull request Aug 17, 2025
Rollup of 10 pull requests
Successful merges:
- #140794 (Add information about group a lint belongs to)
- #144476 (rustdoc-search: search backend with partitioned suffix tree)
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 17, 2025
…rgets, r=jdonszelmann
Fix deprecation attributes on foreign statics
r? ```@jdonszelmann```
Fixesrust-lang#145437
@ZalatharZalathar mentioned this pull request Aug 17, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 17, 2025
…rgets, r=jdonszelmann
Fix deprecation attributes on foreign statics
r? ````@jdonszelmann````
Fixesrust-lang#145437
@ZalatharZalathar mentioned this pull request Aug 17, 2025
bors added a commit that referenced this pull request Aug 17, 2025
Rollup of 10 pull requests
Successful merges:
- #144476 (rustdoc-search: search backend with partitioned suffix tree)
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
- #145489 (library: Migrate from `cfg_if` to `cfg_select`)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 17, 2025
Rollup of 9 pull requests
Successful merges:
- #144476 (rustdoc-search: search backend with partitioned suffix tree)
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 17, 2025
…rgets, r=jdonszelmann
Fix deprecation attributes on foreign statics
r? `````@jdonszelmann`````
Fixesrust-lang#145437
@ZalatharZalathar mentioned this pull request Aug 17, 2025
bors added a commit that referenced this pull request Aug 17, 2025
Rollup of 10 pull requests
Successful merges:
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145309 (Fix `-Zregparm` for LLVM builtins)
- #145355 (Add codegen test for issue 122734)
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 17, 2025
…rgets, r=jdonszelmann
Fix deprecation attributes on foreign statics
r? ``````@jdonszelmann``````
Fixesrust-lang#145437
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 17, 2025
…rgets, r=jdonszelmann
Fix deprecation attributes on foreign statics
r? ```````@jdonszelmann```````
Fixesrust-lang#145437
@jhprattjhpratt mentioned this pull request Aug 17, 2025
bors added a commit that referenced this pull request Aug 18, 2025
Rollup of 10 pull requests
Successful merges:
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145309 (Fix `-Zregparm` for LLVM builtins)
- #145355 (Add codegen test for issue 122734)
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
@ZalatharZalathar mentioned this pull request Aug 18, 2025
bors added a commit that referenced this pull request Aug 18, 2025
Rollup of 10 pull requests
Successful merges:
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145309 (Fix `-Zregparm` for LLVM builtins)
- #145355 (Add codegen test for issue 122734)
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 18, 2025
Rollup of 10 pull requests
Successful merges:
- #144838 (Fix outdated doc comment)
- #145206 (Port `#[custom_mir(..)]` to the new attribute system)
- #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
- #145309 (Fix `-Zregparm` for LLVM builtins)
- #145355 (Add codegen test for issue 122734)
- #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
- #145451 (Add static glibc to the nix dev shell)
- #145460 (Speedup `copy_src_dirs` in bootstrap)
- #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
- #145485 (Fix deprecation attributes on foreign statics)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit ab57f43 into rust-lang:masterAug 18, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Aug 18, 2025
Rollup merge of #145485 - JonathanBrouwer:fix-deprecation-targets, r=jdonszelmann
Fix deprecation attributes on foreign statics
r? ````````@jdonszelmann````````
Fixes#145437
@rustbotrustbot added this to the 1.91.0 milestone Aug 18, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorrect useless_deprecated error on nightly

4 participants

@JonathanBrouwer@rustbot@jdonszelmann@bors