Skip to content

Download CI GCC into the correct directory - #145654

Merged
bors merged 1 commit into
rust-lang:masterfrom
Kobzol:gcc-ci-root
Aug 21, 2025
Merged

Download CI GCC into the correct directory#145654
bors merged 1 commit into
rust-lang:masterfrom
Kobzol:gcc-ci-root

Conversation

@Kobzol

@KobzolKobzol commented Aug 20, 2025•
edited
Loading

Copy link
Copy Markdown
Member

While doing various experiments with stage3 cross-compilations, I realized that bootstrap is unable to download LLVM from CI for a non-host target, which is quite annoying. Fixing this for LLVM will take some work, but in the meantime we can easily fix this for download-ci-gcc, which was implemented in a much more self-contained way.

@rustbot

rustbot commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 20, 2025
@rustbot

rustbot commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

This PR changes how GCC is built. Consider updating src/bootstrap/download-ci-gcc-stamp.

jieyouxu
jieyouxu approved these changes Aug 20, 2025
View reviewed changes

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu

jieyouxu commented Aug 20, 2025

Copy link
Copy Markdown
Member

r? jieyouxu @bors r+ rollup

@bors

bors commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 29f0d8b has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 20, 2025
@jhpratt
Rollup merge ofrust-lang#145654- Kobzol:gcc-ci-root, r=jieyouxu
c64a2ef
Download CI GCC into the correct directory
While doing various experiments with stage3 cross-compilations, I realized that bootstrap is unable to download LLVM from CI for a non-host target, which is quite annoying. Fixing this for LLVM will take some work, but in the meantime we can easily fix this for `download-ci-gcc`, which was implemented in a much more self-contained way.
@jhprattjhpratt mentioned this pull request Aug 20, 2025
Closed
bors added a commit that referenced this pull request Aug 20, 2025
@bors
Auto merge of#145680- jhpratt:rollup-cokwvpc, r=jhpratt
5bea2c6
Rollup of 12 pull requests
Successful merges:
- #143383 (stabilize `const_array_each_ref`)
- #144443 (Make target pointer width in target json an integer)
- #144758 ([Doc] Add links to the various collections)
- #144915 (Defer tail call ret ty equality to check_tail_calls)
- #145256 (Add new `--test-codegen-backend` bootstrap option)
- #145415 (std_detect: RISC-V: implement implication to "C")
- #145573 (Add an experimental unsafe(force_target_feature) attribute.)
- #145642 (Do not use effective_visibilities query for Adt types of a local trait while proving a where-clause)
- #145650 (Fix JS search scripts path)
- #145654 (Download CI GCC into the correct directory)
- #145662 (Enforce correct number of arguments for `"x86-interrupt"` functions)
- #145674 (Enable triagebot `[review-changes-since]` feature)
Failed merges:
- #145647 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 20, 2025
@jhpratt
Rollup merge ofrust-lang#145654- Kobzol:gcc-ci-root, r=jieyouxu
0920986
Download CI GCC into the correct directory
While doing various experiments with stage3 cross-compilations, I realized that bootstrap is unable to download LLVM from CI for a non-host target, which is quite annoying. Fixing this for LLVM will take some work, but in the meantime we can easily fix this for `download-ci-gcc`, which was implemented in a much more self-contained way.
@jhprattjhpratt mentioned this pull request Aug 20, 2025
Closed
bors added a commit that referenced this pull request Aug 20, 2025
@bors
Auto merge of#145681- jhpratt:rollup-7hn0ii7, r=jhpratt
5a72bc9
Rollup of 14 pull requests
Successful merges:
- #143383 (stabilize `const_array_each_ref`)
- #144443 (Make target pointer width in target json an integer)
- #144758 ([Doc] Add links to the various collections)
- #144915 (Defer tail call ret ty equality to check_tail_calls)
- #145137 (Consolidate panicking functions in `slice/index.rs`)
- #145256 (Add new `--test-codegen-backend` bootstrap option)
- #145297 (fix(debuginfo): handle false positives in overflow check)
- #145415 (std_detect: RISC-V: implement implication to "C")
- #145642 (Do not use effective_visibilities query for Adt types of a local trait while proving a where-clause)
- #145650 (Fix JS search scripts path)
- #145654 (Download CI GCC into the correct directory)
- #145662 (Enforce correct number of arguments for `"x86-interrupt"` functions)
- #145674 (Enable triagebot `[review-changes-since]` feature)
- #145678 (Fix typo in docstring)
r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 21, 2025
@jhpratt
Rollup merge ofrust-lang#145654- Kobzol:gcc-ci-root, r=jieyouxu
2d4db3c
Download CI GCC into the correct directory
While doing various experiments with stage3 cross-compilations, I realized that bootstrap is unable to download LLVM from CI for a non-host target, which is quite annoying. Fixing this for LLVM will take some work, but in the meantime we can easily fix this for `download-ci-gcc`, which was implemented in a much more self-contained way.
@jhprattjhpratt mentioned this pull request Aug 21, 2025
Closed
bors added a commit that referenced this pull request Aug 21, 2025
@bors
Auto merge of#145691- jhpratt:rollup-fekj1bx, r=jhpratt
b499c5c
Rollup of 15 pull requests
Successful merges:
- #143383 (stabilize `const_array_each_ref`)
- #144758 ([Doc] Add links to the various collections)
- #144915 (Defer tail call ret ty equality to check_tail_calls)
- #145137 (Consolidate panicking functions in `slice/index.rs`)
- #145256 (Add new `--test-codegen-backend` bootstrap option)
- #145297 (fix(debuginfo): handle false positives in overflow check)
- #145415 (std_detect: RISC-V: implement implication to "C")
- #145590 (Prevent impossible combinations in `ast::ModKind`.)
- #145621 (Fix some doc typos)
- #145642 (Do not use effective_visibilities query for Adt types of a local trait while proving a where-clause)
- #145650 (Fix JS search scripts path)
- #145654 (Download CI GCC into the correct directory)
- #145662 (Enforce correct number of arguments for `"x86-interrupt"` functions)
- #145674 (Enable triagebot `[review-changes-since]` feature)
- #145678 (Fix typo in docstring)
r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 21, 2025
@jhpratt
Rollup merge ofrust-lang#145654- Kobzol:gcc-ci-root, r=jieyouxu
c99d5b7
Download CI GCC into the correct directory
While doing various experiments with stage3 cross-compilations, I realized that bootstrap is unable to download LLVM from CI for a non-host target, which is quite annoying. Fixing this for LLVM will take some work, but in the meantime we can easily fix this for `download-ci-gcc`, which was implemented in a much more self-contained way.
This was referenced Aug 21, 2025
Closed
Merged
bors added a commit that referenced this pull request Aug 21, 2025
@bors
Auto merge of#145701- jhpratt:rollup-a0kg33p, r=jhpratt
57e620e
Rollup of 19 pull requests
Successful merges:
- #143383 (stabilize `const_array_each_ref`)
- #144758 ([Doc] Add links to the various collections)
- #144915 (Defer tail call ret ty equality to check_tail_calls)
- #145256 (Add new `--test-codegen-backend` bootstrap option)
- #145297 (fix(debuginfo): handle false positives in overflow check)
- #145390 (Shorten some dependency chains in the compiler)
- #145415 (std_detect: RISC-V: implement implication to "C")
- #145525 (stdlib: Replace typedef -> type alias in doc comment)
- #145590 (Prevent impossible combinations in `ast::ModKind`.)
- #145593 (UnsafePinned::raw_get: sync signature with get)
- #145621 (Fix some doc typos)
- #145627 (Unconditionally-const supertraits are considered not dyn compatible)
- #145642 (Do not use effective_visibilities query for Adt types of a local trait while proving a where-clause)
- #145650 (Fix JS search scripts path)
- #145654 (Download CI GCC into the correct directory)
- #145662 (Enforce correct number of arguments for `"x86-interrupt"` functions)
- #145673 (Add flock support for cygwin)
- #145674 (Enable triagebot `[review-changes-since]` feature)
- #145678 (Fix typo in docstring)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 2032ede into rust-lang:masterAug 21, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 21, 2025
rust-timer added a commit that referenced this pull request Aug 21, 2025
@rust-timer
Unrolled build for#145654
450dfac
Rollup merge of #145654 - Kobzol:gcc-ci-root, r=jieyouxu
Download CI GCC into the correct directory
While doing various experiments with stage3 cross-compilations, I realized that bootstrap is unable to download LLVM from CI for a non-host target, which is quite annoying. Fixing this for LLVM will take some work, but in the meantime we can easily fix this for `download-ci-gcc`, which was implemented in a much more self-contained way.
@Kobzol
Kobzol deleted the gcc-ci-root branch August 21, 2025 12:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Kobzol@rustbot@jieyouxu@bors@Mark-Simulacrum