Skip to content

Enforce correct number of arguments for "x86-interrupt" functions - #145662

Merged
bors merged 1 commit into
rust-lang:masterfrom
GrigorenkoPV:x86-interrupt
Aug 21, 2025
Merged

Enforce correct number of arguments for "x86-interrupt" functions#145662
bors merged 1 commit into
rust-lang:masterfrom
GrigorenkoPV:x86-interrupt

Conversation

@GrigorenkoPV

@GrigorenkoPVGrigorenkoPV commented Aug 20, 2025•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Tracking issue: #40180

Partially fixes#132835

@rustbot label: +F-abi_x86_interrupt +A-LLVM +O-x86_64 +O-x86_32 +A-ABI

@rustbot

rustbot commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-ABI Area: Concerning the application binary interface (ABI) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-abi_x86_interrupt O-x86_32 Target: x86 processors, 32 bit (like i686-*) (also known as IA-32, i386, i586, i686) O-x86_64 Target: x86-64 processors (like x86_64-*) (also known as amd64 and x64) labels Aug 20, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors

compiler-errors commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

I think this could be moved into HIR typeck or something to ensure that the type of the argument is valid, but this is good for now.

@bors r+ rollup

@bors

bors commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 2da0ec3 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 20, 2025
@jhpratt
Rollup merge ofrust-lang#145662- GrigorenkoPV:x86-interrupt, r=comp…
043d078
…iler-errors
Enforce correct number of arguments for `"x86-interrupt"` functions
Tracking issue: rust-lang#40180
Partially fixesrust-lang#132835
`@rustbot` label: +F-abi_x86_interrupt +A-LLVM +O-x86_64 +O-x86_32 +A-ABI
@jhprattjhpratt mentioned this pull request Aug 20, 2025
Closed
bors added a commit that referenced this pull request Aug 20, 2025
@bors
Auto merge of#145680- jhpratt:rollup-cokwvpc, r=jhpratt
5bea2c6
Rollup of 12 pull requests
Successful merges:
- #143383 (stabilize `const_array_each_ref`)
- #144443 (Make target pointer width in target json an integer)
- #144758 ([Doc] Add links to the various collections)
- #144915 (Defer tail call ret ty equality to check_tail_calls)
- #145256 (Add new `--test-codegen-backend` bootstrap option)
- #145415 (std_detect: RISC-V: implement implication to "C")
- #145573 (Add an experimental unsafe(force_target_feature) attribute.)
- #145642 (Do not use effective_visibilities query for Adt types of a local trait while proving a where-clause)
- #145650 (Fix JS search scripts path)
- #145654 (Download CI GCC into the correct directory)
- #145662 (Enforce correct number of arguments for `"x86-interrupt"` functions)
- #145674 (Enable triagebot `[review-changes-since]` feature)
Failed merges:
- #145647 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 20, 2025
@jhpratt
Rollup merge ofrust-lang#145662- GrigorenkoPV:x86-interrupt, r=comp…
08984d5
…iler-errors
Enforce correct number of arguments for `"x86-interrupt"` functions
Tracking issue: rust-lang#40180
Partially fixesrust-lang#132835
``@rustbot`` label: +F-abi_x86_interrupt +A-LLVM +O-x86_64 +O-x86_32 +A-ABI
@jhprattjhpratt mentioned this pull request Aug 20, 2025
Closed
bors added a commit that referenced this pull request Aug 20, 2025
@bors
Auto merge of#145681- jhpratt:rollup-7hn0ii7, r=jhpratt
5a72bc9
Rollup of 14 pull requests
Successful merges:
- #143383 (stabilize `const_array_each_ref`)
- #144443 (Make target pointer width in target json an integer)
- #144758 ([Doc] Add links to the various collections)
- #144915 (Defer tail call ret ty equality to check_tail_calls)
- #145137 (Consolidate panicking functions in `slice/index.rs`)
- #145256 (Add new `--test-codegen-backend` bootstrap option)
- #145297 (fix(debuginfo): handle false positives in overflow check)
- #145415 (std_detect: RISC-V: implement implication to "C")
- #145642 (Do not use effective_visibilities query for Adt types of a local trait while proving a where-clause)
- #145650 (Fix JS search scripts path)
- #145654 (Download CI GCC into the correct directory)
- #145662 (Enforce correct number of arguments for `"x86-interrupt"` functions)
- #145674 (Enable triagebot `[review-changes-since]` feature)
- #145678 (Fix typo in docstring)
r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 21, 2025
@jhpratt
Rollup merge ofrust-lang#145662- GrigorenkoPV:x86-interrupt, r=comp…
3e77b04
…iler-errors
Enforce correct number of arguments for `"x86-interrupt"` functions
Tracking issue: rust-lang#40180
Partially fixesrust-lang#132835
```@rustbot``` label: +F-abi_x86_interrupt +A-LLVM +O-x86_64 +O-x86_32 +A-ABI
@jhprattjhpratt mentioned this pull request Aug 21, 2025
Closed
bors added a commit that referenced this pull request Aug 21, 2025
@bors
Auto merge of#145691- jhpratt:rollup-fekj1bx, r=jhpratt
b499c5c
Rollup of 15 pull requests
Successful merges:
- #143383 (stabilize `const_array_each_ref`)
- #144758 ([Doc] Add links to the various collections)
- #144915 (Defer tail call ret ty equality to check_tail_calls)
- #145137 (Consolidate panicking functions in `slice/index.rs`)
- #145256 (Add new `--test-codegen-backend` bootstrap option)
- #145297 (fix(debuginfo): handle false positives in overflow check)
- #145415 (std_detect: RISC-V: implement implication to "C")
- #145590 (Prevent impossible combinations in `ast::ModKind`.)
- #145621 (Fix some doc typos)
- #145642 (Do not use effective_visibilities query for Adt types of a local trait while proving a where-clause)
- #145650 (Fix JS search scripts path)
- #145654 (Download CI GCC into the correct directory)
- #145662 (Enforce correct number of arguments for `"x86-interrupt"` functions)
- #145674 (Enable triagebot `[review-changes-since]` feature)
- #145678 (Fix typo in docstring)
r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 21, 2025
@jhpratt
Rollup merge ofrust-lang#145662- GrigorenkoPV:x86-interrupt, r=comp…
e1c7e3c
…iler-errors
Enforce correct number of arguments for `"x86-interrupt"` functions
Tracking issue: rust-lang#40180
Partially fixesrust-lang#132835
````@rustbot```` label: +F-abi_x86_interrupt +A-LLVM +O-x86_64 +O-x86_32 +A-ABI
This was referenced Aug 21, 2025
Closed
Merged
bors added a commit that referenced this pull request Aug 21, 2025
@bors
Auto merge of#145701- jhpratt:rollup-a0kg33p, r=jhpratt
57e620e
Rollup of 19 pull requests
Successful merges:
- #143383 (stabilize `const_array_each_ref`)
- #144758 ([Doc] Add links to the various collections)
- #144915 (Defer tail call ret ty equality to check_tail_calls)
- #145256 (Add new `--test-codegen-backend` bootstrap option)
- #145297 (fix(debuginfo): handle false positives in overflow check)
- #145390 (Shorten some dependency chains in the compiler)
- #145415 (std_detect: RISC-V: implement implication to "C")
- #145525 (stdlib: Replace typedef -> type alias in doc comment)
- #145590 (Prevent impossible combinations in `ast::ModKind`.)
- #145593 (UnsafePinned::raw_get: sync signature with get)
- #145621 (Fix some doc typos)
- #145627 (Unconditionally-const supertraits are considered not dyn compatible)
- #145642 (Do not use effective_visibilities query for Adt types of a local trait while proving a where-clause)
- #145650 (Fix JS search scripts path)
- #145654 (Download CI GCC into the correct directory)
- #145662 (Enforce correct number of arguments for `"x86-interrupt"` functions)
- #145673 (Add flock support for cygwin)
- #145674 (Enable triagebot `[review-changes-since]` feature)
- #145678 (Fix typo in docstring)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 99c647f into rust-lang:masterAug 21, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 21, 2025
rust-timer added a commit that referenced this pull request Aug 21, 2025
@rust-timer
Unrolled build for#145662
9895970
Rollup merge of #145662 - GrigorenkoPV:x86-interrupt, r=compiler-errors
Enforce correct number of arguments for `"x86-interrupt"` functions
Tracking issue: #40180
Partially fixes#132835
`````@rustbot````` label: +F-abi_x86_interrupt +A-LLVM +O-x86_64 +O-x86_32 +A-ABI
@GrigorenkoPV
GrigorenkoPV deleted the x86-interrupt branch August 21, 2025 19:22
@GrigorenkoPVGrigorenkoPV mentioned this pull request Aug 21, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jackh726jackh726

Labels

A-ABIArea: Concerning the application binary interface (ABI)A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.F-abi_x86_interruptO-x86_32Target: x86 processors, 32 bit (like i686-*) (also known as IA-32, i386, i586, i686)O-x86_64Target: x86-64 processors (like x86_64-*) (also known as amd64 and x64)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

extern "x86-interrupt" fn allows absurd signatures

6 participants

@GrigorenkoPV@rustbot@rust-log-analyzer@compiler-errors@bors@jackh726