support integer literals in `${concat()}` by cyrgani · Pull Request #146308 · rust-lang/rust

cyrgani · 2025-09-07T19:38:32Z

Tracking issue: #124225

Adds support for using integer literals as arguments to ${concat()} macro expressions.
Integer formatting such as 1_000 is preserved by this.

rustbot · 2025-09-07T19:38:36Z

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jackh726 · 2025-09-11T18:35:32Z

@bors r+ rollup

bors · 2025-09-11T18:35:35Z

📌 Commit 1cb749a has been approved by jackh726

It is now in the queue for this repository.

…=jackh726 support integer literals in `${concat()}` Tracking issue: rust-lang#124225 Adds support for using integer literals as arguments to `${concat()}` macro expressions. Integer formatting such as `1_000` is preserved by this.

Rollup of 16 pull requests Successful merges: - #145660 (initial implementation of the darwin_objc unstable feature) - #145895 (thread parking: fix docs and examples) - #146308 (support integer literals in `${concat()}`) - #146323 (check before test for hardware capabilites in bits 32~63 of usize) - #146332 (tidy: make behavior of extra-checks more uniform) - #146338 (Extends AArch64 branch protection support to include GCS) - #146374 (Update `browser-ui-test` version to `0.22.2`) - #146413 (Improve suggestion in case a bare URL is surrounded by brackets) - #146426 (Bump miow to 0.60.1) - #146432 (Implement `Socket::take_error` for Hermit) - #146433 (rwlock tests: fix miri macos test regression) - #146435 (Change the default value of `gcc.download-ci-gcc` to `true`) - #146439 (fix cfg for poison test macro) - #146448 ([rustdoc] Correctly handle literal search on paths) - #146449 (Fix `libgccjit` symlink when we build GCC locally) - #146455 (test: remove an outdated normalization for rustc versions) Failed merges: - #146389 (Convert `no_std` and `no_core` to the new attribute infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

…=jackh726 support integer literals in `${concat()}` Tracking issue: rust-lang#124225 Adds support for using integer literals as arguments to `${concat()}` macro expressions. Integer formatting such as `1_000` is preserved by this.

Rollup of 16 pull requests Successful merges: - #144549 (match clang's `va_arg` assembly on arm targets) - #145660 (initial implementation of the darwin_objc unstable feature) - #145895 (thread parking: fix docs and examples) - #146308 (support integer literals in `${concat()}`) - #146323 (check before test for hardware capabilites in bits 32~63 of usize) - #146332 (tidy: make behavior of extra-checks more uniform) - #146374 (Update `browser-ui-test` version to `0.22.2`) - #146413 (Improve suggestion in case a bare URL is surrounded by brackets) - #146426 (Bump miow to 0.60.1) - #146432 (Implement `Socket::take_error` for Hermit) - #146433 (rwlock tests: fix miri macos test regression) - #146435 (Change the default value of `gcc.download-ci-gcc` to `true`) - #146439 (fix cfg for poison test macro) - #146448 ([rustdoc] Correctly handle literal search on paths) - #146449 (Fix `libgccjit` symlink when we build GCC locally) - #146455 (test: remove an outdated normalization for rustc versions) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - #144549 (match clang's `va_arg` assembly on arm targets) - #145895 (thread parking: fix docs and examples) - #146308 (support integer literals in `${concat()}`) - #146323 (check before test for hardware capabilites in bits 32~63 of usize) - #146332 (tidy: make behavior of extra-checks more uniform) - #146374 (Update `browser-ui-test` version to `0.22.2`) - #146413 (Improve suggestion in case a bare URL is surrounded by brackets) - #146426 (Bump miow to 0.60.1) - #146432 (Implement `Socket::take_error` for Hermit) - #146433 (rwlock tests: fix miri macos test regression) - #146435 (Change the default value of `gcc.download-ci-gcc` to `true`) - #146439 (fix cfg for poison test macro) - #146448 ([rustdoc] Correctly handle literal search on paths) - #146449 (Fix `libgccjit` symlink when we build GCC locally) - #146455 (test: remove an outdated normalization for rustc versions) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #146308 - cyrgani:concat-integer-literals, r=jackh726 support integer literals in `${concat()}` Tracking issue: #124225 Adds support for using integer literals as arguments to `${concat()}` macro expressions. Integer formatting such as `1_000` is preserved by this.

Rollup of 15 pull requests Successful merges: - rust-lang/rust#144549 (match clang's `va_arg` assembly on arm targets) - rust-lang/rust#145895 (thread parking: fix docs and examples) - rust-lang/rust#146308 (support integer literals in `${concat()}`) - rust-lang/rust#146323 (check before test for hardware capabilites in bits 32~63 of usize) - rust-lang/rust#146332 (tidy: make behavior of extra-checks more uniform) - rust-lang/rust#146374 (Update `browser-ui-test` version to `0.22.2`) - rust-lang/rust#146413 (Improve suggestion in case a bare URL is surrounded by brackets) - rust-lang/rust#146426 (Bump miow to 0.60.1) - rust-lang/rust#146432 (Implement `Socket::take_error` for Hermit) - rust-lang/rust#146433 (rwlock tests: fix miri macos test regression) - rust-lang/rust#146435 (Change the default value of `gcc.download-ci-gcc` to `true`) - rust-lang/rust#146439 (fix cfg for poison test macro) - rust-lang/rust#146448 ([rustdoc] Correctly handle literal search on paths) - rust-lang/rust#146449 (Fix `libgccjit` symlink when we build GCC locally) - rust-lang/rust#146455 (test: remove an outdated normalization for rustc versions) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - rust-lang#144549 (match clang's `va_arg` assembly on arm targets) - rust-lang#145895 (thread parking: fix docs and examples) - rust-lang#146308 (support integer literals in `${concat()}`) - rust-lang#146323 (check before test for hardware capabilites in bits 32~63 of usize) - rust-lang#146332 (tidy: make behavior of extra-checks more uniform) - rust-lang#146374 (Update `browser-ui-test` version to `0.22.2`) - rust-lang#146413 (Improve suggestion in case a bare URL is surrounded by brackets) - rust-lang#146426 (Bump miow to 0.60.1) - rust-lang#146432 (Implement `Socket::take_error` for Hermit) - rust-lang#146433 (rwlock tests: fix miri macos test regression) - rust-lang#146435 (Change the default value of `gcc.download-ci-gcc` to `true`) - rust-lang#146439 (fix cfg for poison test macro) - rust-lang#146448 ([rustdoc] Correctly handle literal search on paths) - rust-lang#146449 (Fix `libgccjit` symlink when we build GCC locally) - rust-lang#146455 (test: remove an outdated normalization for rustc versions) r? `@ghost` `@rustbot` modify labels: rollup

…aumeGomez remove duplicated columns from `rustc_error_code::error_codes!` Possible because of rust-lang#146308 ~~, but currently still blocked on the next stage0 bump~~.

Rollup merge of #146584 - cyrgani:error-codes-macro, r=GuillaumeGomez remove duplicated columns from `rustc_error_code::error_codes!` Possible because of #146308 ~~, but currently still blocked on the next stage0 bump~~.

remove duplicated columns from `rustc_error_code::error_codes!` Possible because of rust-lang/rust#146308 ~~, but currently still blocked on the next stage0 bump~~.

cyrgani added the F-macro_metavar_expr_concat `#![feature(macro_metavar_expr_concat)]` label Sep 7, 2025

rustbot assigned jackh726 Sep 7, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 7, 2025

tgross35 reviewed Sep 7, 2025
View reviewed changes

Comment threadtests/ui/macros/metavar-expressions/concat-integer-literals.rs Outdated

cyrgani force-pushed the concat-integer-literals branch from daab25d to 89fe0f3Compare September 7, 2025 20:07

support integer literals in ${concat()}
1cb749a

cyrgani force-pushed the concat-integer-literals branch from 89fe0f3 to 1cb749aCompare September 7, 2025 20:09

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2025

Zalathar mentioned this pull request Sep 12, 2025
Rollup of 16 pull requests #146461
Closed

Zalathar mentioned this pull request Sep 12, 2025
Rollup of 16 pull requests #146462
Closed

Zalathar mentioned this pull request Sep 12, 2025
Rollup of 15 pull requests #146468
Merged

bors merged commit 40520c6 into rust-lang:masterSep 12, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Sep 12, 2025

cyrgani deleted the concat-integer-literals branch September 12, 2025 17:07

cyrgani mentioned this pull request Sep 15, 2025
remove duplicated columns from rustc_error_code::error_codes!#146584
Merged

Navigation Menu

Uh oh!

Uh oh!

support integer literals in `${concat()}` - #146308

support integer literals in `${concat()}`#146308
bors merged 1 commit into
rust-lang:masterfrom
cyrgani:concat-integer-literals

cyrgani commented Sep 7, 2025•
edited by rustbot
Loading

Uh oh!

rustbot commented Sep 7, 2025

Uh oh!

Uh oh!

jackh726 commented Sep 11, 2025

Uh oh!

bors commented Sep 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

cyrgani commented Sep 7, 2025• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 7, 2025

Uh oh!

Uh oh!

jackh726 commented Sep 11, 2025

Uh oh!

bors commented Sep 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cyrgani commented Sep 7, 2025•
edited by rustbot
Loading