tidy: make behavior of extra-checks more uniform by lolbinarycat · Pull Request #146332 · rust-lang/rust

lolbinarycat · 2025-09-08T14:03:49Z

This mostly affects console output, but it also makes py:lint work with --bless.

rustbot · 2025-09-08T14:03:54Z

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

lolbinarycat · 2025-09-08T14:04:01Z

r? @Kobzol

rustbot · 2025-09-08T14:04:04Z

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

Kobzol

Thank you! Left one comment.

View changes since this review

Kobzol · 2025-09-09T06:28:41Z

 let res = run_ruff(root_path, outdir, py_path, &cfg_args, &file_args, args);

- if res.is_err() && show_diff {
+ if res.is_err() && show_diff && !bless {


I'm not sure if ruff --fix can actually fix all the issues that it can find (probably yes for formatting, but I doubt that also for linting)? If not, then we should probably still show the diff even if we used bless mode (in case it returned something).

ruff definitely can't fix all the issues that it can find, but I believe --diff only shows the diff for machine-applicable suggestions, so there would not be anything to show in bless mode. If you want to show the diff for everything, that would be ruff check --diff --unsafe-fixes.

I see. Ok, makes sense I guess.

Kobzol · 2025-09-11T15:46:59Z

@bors r+ rollup

bors · 2025-09-11T15:47:01Z

📌 Commit 8222f7d has been approved by Kobzol

It is now in the queue for this repository.

…ularize, r=Kobzol tidy: make behavior of extra-checks more uniform

Rollup of 16 pull requests Successful merges: - #145660 (initial implementation of the darwin_objc unstable feature) - #145895 (thread parking: fix docs and examples) - #146308 (support integer literals in `${concat()}`) - #146323 (check before test for hardware capabilites in bits 32~63 of usize) - #146332 (tidy: make behavior of extra-checks more uniform) - #146338 (Extends AArch64 branch protection support to include GCS) - #146374 (Update `browser-ui-test` version to `0.22.2`) - #146413 (Improve suggestion in case a bare URL is surrounded by brackets) - #146426 (Bump miow to 0.60.1) - #146432 (Implement `Socket::take_error` for Hermit) - #146433 (rwlock tests: fix miri macos test regression) - #146435 (Change the default value of `gcc.download-ci-gcc` to `true`) - #146439 (fix cfg for poison test macro) - #146448 ([rustdoc] Correctly handle literal search on paths) - #146449 (Fix `libgccjit` symlink when we build GCC locally) - #146455 (test: remove an outdated normalization for rustc versions) Failed merges: - #146389 (Convert `no_std` and `no_core` to the new attribute infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

…ularize, r=Kobzol tidy: make behavior of extra-checks more uniform

Rollup of 16 pull requests Successful merges: - #144549 (match clang's `va_arg` assembly on arm targets) - #145660 (initial implementation of the darwin_objc unstable feature) - #145895 (thread parking: fix docs and examples) - #146308 (support integer literals in `${concat()}`) - #146323 (check before test for hardware capabilites in bits 32~63 of usize) - #146332 (tidy: make behavior of extra-checks more uniform) - #146374 (Update `browser-ui-test` version to `0.22.2`) - #146413 (Improve suggestion in case a bare URL is surrounded by brackets) - #146426 (Bump miow to 0.60.1) - #146432 (Implement `Socket::take_error` for Hermit) - #146433 (rwlock tests: fix miri macos test regression) - #146435 (Change the default value of `gcc.download-ci-gcc` to `true`) - #146439 (fix cfg for poison test macro) - #146448 ([rustdoc] Correctly handle literal search on paths) - #146449 (Fix `libgccjit` symlink when we build GCC locally) - #146455 (test: remove an outdated normalization for rustc versions) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - #144549 (match clang's `va_arg` assembly on arm targets) - #145895 (thread parking: fix docs and examples) - #146308 (support integer literals in `${concat()}`) - #146323 (check before test for hardware capabilites in bits 32~63 of usize) - #146332 (tidy: make behavior of extra-checks more uniform) - #146374 (Update `browser-ui-test` version to `0.22.2`) - #146413 (Improve suggestion in case a bare URL is surrounded by brackets) - #146426 (Bump miow to 0.60.1) - #146432 (Implement `Socket::take_error` for Hermit) - #146433 (rwlock tests: fix miri macos test regression) - #146435 (Change the default value of `gcc.download-ci-gcc` to `true`) - #146439 (fix cfg for poison test macro) - #146448 ([rustdoc] Correctly handle literal search on paths) - #146449 (Fix `libgccjit` symlink when we build GCC locally) - #146455 (test: remove an outdated normalization for rustc versions) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #146332 - lolbinarycat:tidy-extra-checks-regularize, r=Kobzol tidy: make behavior of extra-checks more uniform

Rollup of 15 pull requests Successful merges: - rust-lang/rust#144549 (match clang's `va_arg` assembly on arm targets) - rust-lang/rust#145895 (thread parking: fix docs and examples) - rust-lang/rust#146308 (support integer literals in `${concat()}`) - rust-lang/rust#146323 (check before test for hardware capabilites in bits 32~63 of usize) - rust-lang/rust#146332 (tidy: make behavior of extra-checks more uniform) - rust-lang/rust#146374 (Update `browser-ui-test` version to `0.22.2`) - rust-lang/rust#146413 (Improve suggestion in case a bare URL is surrounded by brackets) - rust-lang/rust#146426 (Bump miow to 0.60.1) - rust-lang/rust#146432 (Implement `Socket::take_error` for Hermit) - rust-lang/rust#146433 (rwlock tests: fix miri macos test regression) - rust-lang/rust#146435 (Change the default value of `gcc.download-ci-gcc` to `true`) - rust-lang/rust#146439 (fix cfg for poison test macro) - rust-lang/rust#146448 ([rustdoc] Correctly handle literal search on paths) - rust-lang/rust#146449 (Fix `libgccjit` symlink when we build GCC locally) - rust-lang/rust#146455 (test: remove an outdated normalization for rustc versions) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - rust-lang#144549 (match clang's `va_arg` assembly on arm targets) - rust-lang#145895 (thread parking: fix docs and examples) - rust-lang#146308 (support integer literals in `${concat()}`) - rust-lang#146323 (check before test for hardware capabilites in bits 32~63 of usize) - rust-lang#146332 (tidy: make behavior of extra-checks more uniform) - rust-lang#146374 (Update `browser-ui-test` version to `0.22.2`) - rust-lang#146413 (Improve suggestion in case a bare URL is surrounded by brackets) - rust-lang#146426 (Bump miow to 0.60.1) - rust-lang#146432 (Implement `Socket::take_error` for Hermit) - rust-lang#146433 (rwlock tests: fix miri macos test regression) - rust-lang#146435 (Change the default value of `gcc.download-ci-gcc` to `true`) - rust-lang#146439 (fix cfg for poison test macro) - rust-lang#146448 ([rustdoc] Correctly handle literal search on paths) - rust-lang#146449 (Fix `libgccjit` symlink when we build GCC locally) - rust-lang#146455 (test: remove an outdated normalization for rustc versions) r? `@ghost` `@rustbot` modify labels: rollup

lolbinarycat added 4 commits September 8, 2025 08:08

all tidy extra checks now print what they do in present tense
469a80e

tidy: py:lint extra check now works with --bless
a9d884d

tidy extra checks that interact with --bless now all recommend using it
c19d81b

tidy extra checks: use Error::FailedCheck correctly
8222f7d

rustbot assigned Kobzol Sep 8, 2025

rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 8, 2025

Kobzol reviewed Sep 9, 2025
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2025

Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 12, 2025
Rollup merge ofrust-lang#146332- lolbinarycat:tidy-extra-checks-reg…
917580c
…ularize, r=Kobzol tidy: make behavior of extra-checks more uniform

Zalathar mentioned this pull request Sep 12, 2025
Rollup of 16 pull requests #146461
Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 12, 2025
Rollup merge ofrust-lang#146332- lolbinarycat:tidy-extra-checks-reg…
86ab13c
…ularize, r=Kobzol tidy: make behavior of extra-checks more uniform

Zalathar mentioned this pull request Sep 12, 2025
Rollup of 16 pull requests #146462
Closed

Zalathar mentioned this pull request Sep 12, 2025
Rollup of 15 pull requests #146468
Merged

bors merged commit 27954ec into rust-lang:masterSep 12, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Sep 12, 2025

rust-timer added a commit that referenced this pull request Sep 12, 2025
Unrolled build for#146332
fb7722d
Rollup merge of #146332 - lolbinarycat:tidy-extra-checks-regularize, r=Kobzol tidy: make behavior of extra-checks more uniform

Navigation Menu

Uh oh!

Uh oh!

tidy: make behavior of extra-checks more uniform - #146332

tidy: make behavior of extra-checks more uniform#146332
bors merged 4 commits into
rust-lang:masterfrom
lolbinarycat:tidy-extra-checks-regularize

lolbinarycat commented Sep 8, 2025

Uh oh!

rustbot commented Sep 8, 2025

Uh oh!

lolbinarycat commented Sep 8, 2025

Uh oh!

rustbot commented Sep 8, 2025

Uh oh!

Kobzol left a comment •
edited by rustbot
Loading

Uh oh!

KobzolSep 9, 2025

Uh oh!

lolbinarycatSep 10, 2025

Uh oh!

KobzolSep 11, 2025

Uh oh!

Kobzol commented Sep 11, 2025

Uh oh!

bors commented Sep 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

lolbinarycat commented Sep 8, 2025

Uh oh!

rustbot commented Sep 8, 2025

Uh oh!

lolbinarycat commented Sep 8, 2025

Uh oh!

rustbot commented Sep 8, 2025

Uh oh!

Kobzol left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KobzolSep 9, 2025

Choose a reason for hiding this comment

Uh oh!

lolbinarycatSep 10, 2025

Choose a reason for hiding this comment

Uh oh!

KobzolSep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Kobzol commented Sep 11, 2025

Uh oh!

bors commented Sep 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kobzol left a comment •
edited by rustbot
Loading