implement VecDeque extend_from_within and prepend_from_within by antonilol · Pull Request #147161 · rust-lang/rust

antonilol · 2025-09-29T19:32:57Z

Tracking issue: #146975

rustbot · 2025-09-30T19:51:37Z

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

joboet

The implementation looks good to me, though I wouldn't mind a few more comments... 😉

View changes since this review

joboet · 2025-10-20T15:22:19Z

+ assert_eq!(
+ clone_counts.each_ref().map(|c| {
+ let old = c.get();
+ c.set(0);


Any reason why the counts are reset here?

Oh that's a leftover from before splitting the tests in one that needs panic = "unwind" and the rest, will remove it.

joboet · 2025-10-20T15:29:34Z

I find these tests incredibly hard to read. Could you test this another way? Perhaps by giving each element an ID and then testing which elements were cloned/destroyed by each operation...

I get that, will try this.

joboet · 2025-10-20T15:35:51Z

+ debug_assert!(
+ !(src_wraps && dst_wraps),
+ "BUG: at most one of src and dst can wrap. src={src} dst={dst} count={count} cap={}",
+ self.capacity(),
+ );


It's true that this can be derived from the function's safety invariants, but that derivation isn't really obvious. Would you mind adding a comment that explains why this must be true? Perhaps something like
Wrapping occurs if capacity is contained within wrapped_src..wrapped_src + count/wrapped_dst..wrapped_dst + count. Since these two ranges must not overlap as per the safety invariants of this function, only one range can wrap.

I like this, it is really intuitive, will add this.

rustbot · 2025-10-23T11:49:36Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

antonilol · 2025-10-23T11:57:30Z

I added extra comments in the tests and the SpecExtendFromWithin implementation for T: Clone, also rewrote the tests so they are easier to read and understand

antonilol · 2025-10-23T11:59:15Z

@rustbot label -S-waiting-on-author +S-waiting-on-review

joboet · 2025-10-31T13:39:24Z

Alright, let's merge it!
@bors r+

bors · 2025-10-31T13:39:26Z

📌 Commit 63bb238 has been approved by joboet

It is now in the queue for this repository.

…thin, r=joboet implement VecDeque extend_from_within and prepend_from_within Tracking issue: rust-lang#146975

Rollup of 7 pull requests Successful merges: - #139310 (add first HelenOS compilation targets) - #144420 (smart pointer (try_)map) - #145974 (Stabilize -Zno-jump-tables into -Cjump-tables=bool) - #147161 (implement VecDeque extend_from_within and prepend_from_within) - #147780 (Implement VecDeque::extract_if) - #148319 (docs: Fix argument names for `carrying_mul_add`) - #148322 (Enable file locking support in illumos) r? `@ghost` `@rustbot` modify labels: rollup

…thin, r=joboet implement VecDeque extend_from_within and prepend_from_within Tracking issue: rust-lang#146975

Rollup of 9 pull requests Successful merges: - #139310 (add first HelenOS compilation targets) - #147161 (implement VecDeque extend_from_within and prepend_from_within) - #147622 (`unicode_data` refactors) - #147780 (Implement VecDeque::extract_if) - #147942 (Enable regression labeling aliases) - #147986 (Use fstatat() in DirEntry::metadata on Apple platforms) - #148103 (cg_llvm: Pass `debuginfo_compression` through FFI as an enum) - #148319 (docs: Fix argument names for `carrying_mul_add`) - #148322 (Enable file locking support in illumos) r? `@ghost` `@rustbot` modify labels: rollup

…thin, r=joboet implement VecDeque extend_from_within and prepend_from_within Tracking issue: rust-lang#146975

Rollup of 9 pull requests Successful merges: - #139310 (add first HelenOS compilation targets) - #147161 (implement VecDeque extend_from_within and prepend_from_within) - #147622 (`unicode_data` refactors) - #147780 (Implement VecDeque::extract_if) - #147942 (Enable regression labeling aliases) - #147986 (Use fstatat() in DirEntry::metadata on Apple platforms) - #148103 (cg_llvm: Pass `debuginfo_compression` through FFI as an enum) - #148319 (docs: Fix argument names for `carrying_mul_add`) - #148322 (Enable file locking support in illumos) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147161 - antonilol:vec-deque-extend-from-within, r=joboet implement VecDeque extend_from_within and prepend_from_within Tracking issue: #146975

…thin, r=joboet implement VecDeque extend_from_within and prepend_from_within Tracking issue: rust-lang#146975

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#139310 (add first HelenOS compilation targets) - rust-lang#147161 (implement VecDeque extend_from_within and prepend_from_within) - rust-lang#147622 (`unicode_data` refactors) - rust-lang#147780 (Implement VecDeque::extract_if) - rust-lang#147942 (Enable regression labeling aliases) - rust-lang#147986 (Use fstatat() in DirEntry::metadata on Apple platforms) - rust-lang#148103 (cg_llvm: Pass `debuginfo_compression` through FFI as an enum) - rust-lang#148319 (docs: Fix argument names for `carrying_mul_add`) - rust-lang#148322 (Enable file locking support in illumos) r? `@ghost` `@rustbot` modify labels: rollup

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 29, 2025

antonilol mentioned this pull request Sep 29, 2025
Tracking Issue for new VecDeque methods prepend, extend_front, splice, extend_from_within and prepend_from_within#146975
Open
9 tasks

This comment has been minimized.
Sign in to view

antonilol marked this pull request as ready for review September 30, 2025 19:51

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2025

rustbot assigned joboet Sep 30, 2025

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 30, 2025

antonilol force-pushed the vec-deque-extend-from-within branch from bddd849 to af568e6Compare September 30, 2025 20:39

joboet reviewed Oct 20, 2025
View reviewed changes

joboet added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2025

antonilol force-pushed the vec-deque-extend-from-within branch from 5b6f437 to a3ebd87Compare October 23, 2025 11:49

implement VecDeque extend_from_within and prepend_from_within, add tests
63bb238

antonilol force-pushed the vec-deque-extend-from-within branch from a3ebd87 to 63bb238Compare October 23, 2025 11:53

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 23, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 31, 2025
Rollup merge ofrust-lang#147161- antonilol:vec-deque-extend-from-wi…
78a1cb5
…thin, r=joboet implement VecDeque extend_from_within and prepend_from_within Tracking issue: rust-lang#146975

matthiaskrgr mentioned this pull request Oct 31, 2025
Rollup of 7 pull requests #148331
Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 31, 2025
Rollup merge ofrust-lang#147161- antonilol:vec-deque-extend-from-wi…
b306d67
…thin, r=joboet implement VecDeque extend_from_within and prepend_from_within Tracking issue: rust-lang#146975

matthiaskrgr mentioned this pull request Oct 31, 2025
Rollup of 9 pull requests #148337
Merged

Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
Rollup merge ofrust-lang#147161- antonilol:vec-deque-extend-from-wi…
d7f9192
…thin, r=joboet implement VecDeque extend_from_within and prepend_from_within Tracking issue: rust-lang#146975

Zalathar mentioned this pull request Nov 1, 2025
Rollup of 19 pull requests #148351
Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
Rollup merge ofrust-lang#147161- antonilol:vec-deque-extend-from-wi…
15f08d4
…thin, r=joboet implement VecDeque extend_from_within and prepend_from_within Tracking issue: rust-lang#146975

Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
Rollup merge ofrust-lang#147161- antonilol:vec-deque-extend-from-wi…
2c297c4
…thin, r=joboet implement VecDeque extend_from_within and prepend_from_within Tracking issue: rust-lang#146975

Zalathar mentioned this pull request Nov 1, 2025
Rollup of 19 pull requests #148354
Closed

bors merged commit 53c52a2 into rust-lang:masterNov 1, 2025
11 checks passed

rustbot added this to the 1.93.0 milestone Nov 1, 2025

rust-timer added a commit that referenced this pull request Nov 1, 2025
Unrolled build for#147161
2837296
Rollup merge of #147161 - antonilol:vec-deque-extend-from-within, r=joboet implement VecDeque extend_from_within and prepend_from_within Tracking issue: #146975

antonilol deleted the vec-deque-extend-from-within branch November 1, 2025 17:20

Uh oh!

Uh oh!

Conversation

antonilol commented Sep 29, 2025• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

rustbot commented Sep 30, 2025

Uh oh!

joboet left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joboetOct 20, 2025

Choose a reason for hiding this comment

Uh oh!

antonilolOct 22, 2025

Choose a reason for hiding this comment

Uh oh!

joboetOct 20, 2025

Choose a reason for hiding this comment

Uh oh!

antonilolOct 22, 2025

Choose a reason for hiding this comment

Uh oh!

joboetOct 20, 2025

Choose a reason for hiding this comment

Uh oh!

antonilolOct 22, 2025

Choose a reason for hiding this comment

Uh oh!

rustbot commented Oct 23, 2025

Uh oh!

antonilol commented Oct 23, 2025

Uh oh!

antonilol commented Oct 23, 2025

Uh oh!

joboet commented Oct 31, 2025

Uh oh!

bors commented Oct 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

antonilol commented Sep 29, 2025•
edited by rustbot
Loading

joboet left a comment •
edited by rustbot
Loading