Uh oh!
There was an error while loading. Please reload this page.
Rollup of 19 pull requests - #148351
Closed
Zalathar wants to merge 64 commits into
Closed
Conversation
…` where `U: ?Unpin`
Targets theoretically possible, but not provided yet: - 32-bit arm See also notes in the PR, I was unable to run anything non-trivial on ARM HelenOS, there are issues with the linker/loader, incomplete support of atomics, and overall a lot of confusion about the precise version of ARM architecture that the HelenOS builds target. - riscv, mips (These targets currently don't run HelenOS at all. HelenOS says it should work, but the builds are broken for quite some time now.)
Signed-off-by: tison <wander4096@gmail.com>
Instead of `include_str!()`ing `range_search.rs`, just make it a normal module under `core::unicode`. This means the same source code doesn't have to be checked in twice, and it plays nicer with IDEs. Also rename it to `rt` since it includes functions for searching the bitsets and case conversion tables as well as the range represesentation.
Remove `#[rustfmt::skip]` from all the generated modules in `unicode_data.rs`. This means we won't have to worry so much about getting indetation and formatting right when generating code. Exempted for now some tables which would be too big when formatted by `rustfmt`.
This check was made redundant (it will always be true) when we removed all ASCII characters from the tables (rust-lang@a8c6694).
To make the final output code easier to see: * Get rid of the unnecessary line-noise of `.unwrap()`ing calls to `write!()` by moving the `.unwrap()` into a macro. * Join consecutive `write!()` calls using a single multiline format string. * Replace `.push()` and `.push_str(format!())` with `write!()`. * If after doing all of the above, there is only a single `write!()` call in the function, just construct the string directly with `format!()`.
Instead of generating a standalone executable to test `unicode_data`, generate normal tests in `coretests`. This ensures tests are always generated, and will be run as part of the normal testsuite. Also change the generated tests to loop over lookup tables, rather than generating a separate `assert_eq!()` statement for every codepoint. The old approach produced a massive (20,000 lines plus) file which took minutes to compile!
Zalathar
commented
Nov 1, 2025
MemberAuthor
Rollup of everything. @bors r+ rollup=never p=5 |
bors
commented
Nov 1, 2025
Collaborator
Zalathar
commented
Nov 1, 2025
MemberAuthor
Running some side jobs since the queue is somewhat backed-up. @bors try jobs= x86_64-msvc-1,i686-msvc-1,x86_64-mingw-1,test-various,armhf-gnu,aarch64-apple |
Contributor
Unknown value for argument "jobs". Run |
Zalathar
commented
Nov 1, 2025
MemberAuthor
@bors try jobs=x86_64-msvc-1,i686-msvc-1,x86_64-mingw-1,test-various,armhf-gnu,aarch64-apple |
This comment has been minimized.
This comment has been minimized.
rust-borsBot
added a commit
that referenced
this pull request
Nov 1, 2025
Rollup of 19 pull requests try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: test-various try-job: armhf-gnu try-job: aarch64-apple
rust-log-analyzer
commented
Nov 1, 2025
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
💔 Test for 68ef2c3 failed: CI. Failed jobs:
|
Zalathar
commented
Nov 1, 2025
MemberAuthor
Failure was possibly caused by: @bors r- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
&pin mut|const T#139751 (Implement pin-project in pattern matching for&pin mut|const T)unicode_datarefactors #147622 (unicode_datarefactors)debuginfo_compressionthrough FFI as an enum #148103 (cg_llvm: Passdebuginfo_compressionthrough FFI as an enum)import#148301 ([rustdoc search] Include extern crates when filtering onimport)carrying_mul_add#148319 (docs: Fix argument names forcarrying_mul_add)build.warnings=denyrather than -Dwarnings #148332 (bootstrap: Use cargo'sbuild.warnings=denyrather than -Dwarnings)nonpoison::Condvarshould takeMutexGuardby reference #148343 (nonpoison::Condvarshould takeMutexGuardby reference)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup