Uh oh!
There was an error while loading. Please reload this page.
[DebugInfo] Improve formatting of MSVC enum struct variants - #147178
Merged
Conversation
rustbot
commented
Sep 30, 2025
Collaborator
rustbot has assigned @Mark-Simulacrum. Use |
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
commented
Oct 1, 2025
Member
r=me with commit squashed |
Walnut356force-pushed
the
msvc_enum_summary
branch
from
October 2, 2025 09:22
0072f08 to
608c661CompareMark-Simulacrum
commented
Oct 11, 2025
Member
@bors r+ |
bors
commented
Oct 11, 2025
Collaborator
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Oct 12, 2025
…k-Simulacrum [DebugInfo] Improve formatting of MSVC enum struct variants More robust handling mirroring the `TupleSummaryProvider` function before: <img width="1168" height="28" alt="image" src="https://github.com/user-attachments/assets/994f0884-55c2-4d3d-b1b2-97df17f0c9f0" /> after: <img width="813" height="31" alt="image" src="https://github.com/user-attachments/assets/8ad3dfa0-3aa7-42a9-bf50-6f5eaf0365aa" /> This shouldn't affect any tests as we don't run debuginfo tests for MSVC afaik
bors added a commit
that referenced
this pull request
Oct 12, 2025
Rollup of 12 pull requests Successful merges: - #138799 (core: simplify `Extend` for tuples) - #146692 (Save x.py's help text for saving output time) - #147168 (Don't unconditionally build alloc for `no-std` targets) - #147178 ([DebugInfo] Improve formatting of MSVC enum struct variants) - #147240 (Add an ACP list item to the library tracking issue template) - #147246 (Explain not existed key in BTreeMap::split_off) - #147393 (Extract most code from `define_feedable!`) - #147495 (Update wasm-component-ld to 0.5.18) - #147503 (Fix documentation of Instant::now on mac) - #147541 (Change int-to-ptr transmute lowering back to inttoptr) - #147549 (Replace `LLVMRustContextCreate` with normal LLVM-C API calls) - #147596 (Adjust the Arm targets in CI to reflect latest changes) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 12, 2025
…k-Simulacrum [DebugInfo] Improve formatting of MSVC enum struct variants More robust handling mirroring the `TupleSummaryProvider` function before: <img width="1168" height="28" alt="image" src="https://github.com/user-attachments/assets/994f0884-55c2-4d3d-b1b2-97df17f0c9f0" /> after: <img width="813" height="31" alt="image" src="https://github.com/user-attachments/assets/8ad3dfa0-3aa7-42a9-bf50-6f5eaf0365aa" /> This shouldn't affect any tests as we don't run debuginfo tests for MSVC afaik
bors added a commit
that referenced
this pull request
Oct 12, 2025
Rollup of 7 pull requests Successful merges: - #147168 (Don't unconditionally build alloc for `no-std` targets) - #147178 ([DebugInfo] Improve formatting of MSVC enum struct variants) - #147495 (Update wasm-component-ld to 0.5.18) - #147576 (Fix ICE on offsetted ZST pointer) - #147592 (Add tidy to the target of ./x check) - #147597 (Add a regression test for #72207) - #147604 (Some clippy cleanups in compiler) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
that referenced
this pull request
Oct 12, 2025
Rollup of 6 pull requests Successful merges: - #147168 (Don't unconditionally build alloc for `no-std` targets) - #147178 ([DebugInfo] Improve formatting of MSVC enum struct variants) - #147495 (Update wasm-component-ld to 0.5.18) - #147592 (Add tidy to the target of ./x check) - #147597 (Add a regression test for #72207) - #147604 (Some clippy cleanups in compiler) r? `@ghost` `@rustbot` modify labels: rollup
Uh oh!
There was an error while loading. Please reload this page.
rust-timer added a commit
that referenced
this pull request
Oct 12, 2025
Rollup merge of #147178 - Walnut356:msvc_enum_summary, r=Mark-Simulacrum [DebugInfo] Improve formatting of MSVC enum struct variants More robust handling mirroring the `TupleSummaryProvider` function before: <img width="1168" height="28" alt="image" src="https://github.com/user-attachments/assets/994f0884-55c2-4d3d-b1b2-97df17f0c9f0" /> after: <img width="813" height="31" alt="image" src="https://github.com/user-attachments/assets/8ad3dfa0-3aa7-42a9-bf50-6f5eaf0365aa" /> This shouldn't affect any tests as we don't run debuginfo tests for MSVC afaik
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More robust handling mirroring the
TupleSummaryProviderfunctionbefore:
after:
This shouldn't affect any tests as we don't run debuginfo tests for MSVC afaik