Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #147609
Closed
matthiaskrgr wants to merge 14 commits into
Closed
Conversation
It's possible for targets to only support `core` and not `alloc`. Instead of building alloc unconditionally, pass a list of crates to build into `std_cargo`, and only pass `-p alloc` if the list of crates wasn't already filtered to a subset. The original use case was to reuse `std_cargo` for a rustc_driver that doesn't emit metadata. But this seems like a reasonable change regardless.
Keeping it up-to-date with upstream for the latest bug fixes and such related to wasm-tools-implemented internals.
This commit adds src/tools/tidy into `./x check`. It enables rust-analyzer hightlights errors/warns on all codes in src/tools/tidy. Since tidy is implicitly checked by `./x test tidy`, this new check is off by default.
A grep for `const_usize.*align` found the same code copied to rustc_codegen_gcc but I don't see other cases where we get this wrong.
Don't unconditionally build alloc for `no-std` targets It's possible for targets to only support `core` and not `alloc`. Instead of building alloc unconditionally, pass a list of crates to build into `std_cargo`, and only pass `-p alloc` if the list of crates wasn't already filtered to a subset. The original use case was to reuse `std_cargo` for a rustc_driver that doesn't emit metadata. But this seems like a reasonable change regardless.
…k-Simulacrum [DebugInfo] Improve formatting of MSVC enum struct variants More robust handling mirroring the `TupleSummaryProvider` function before: <img width="1168" height="28" alt="image" src="https://github.com/user-attachments/assets/994f0884-55c2-4d3d-b1b2-97df17f0c9f0" /> after: <img width="813" height="31" alt="image" src="https://github.com/user-attachments/assets/8ad3dfa0-3aa7-42a9-bf50-6f5eaf0365aa" /> This shouldn't affect any tests as we don't run debuginfo tests for MSVC afaik
…-ld, r=Mark-Simulacrum Update wasm-component-ld to 0.5.18 Keeping it up-to-date with upstream for the latest bug fixes and such related to wasm-tools-implemented internals.
…nnethercote Fix ICE on offsetted ZST pointer I'm not sure this is the *right* fix, but it's simple enough and does roughly what I'd expect. Like with the previous optimization to codegen usize rather than a zero-sized static, there's no guarantee that we continue returning a particular value from the offsetting. A grep for `const_usize.*align` found the same code copied to rustc_codegen_gcc and cranelift but a quick skim didn't find other cases of similar 'optimization'. That said, I'm not convinced I caught everything, it's not trivial to search for this. Closesrust-lang#147516
…thar Add tidy to the target of ./x check ## Context Discussion: https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/tidy.20isn't.20in.20.2E.2Fx.20check/with/544323712 Currently `tidy` (src/tools/tidy) is not included in the list of `./x check`. It means that rust-analyzer doesn't work for codes in the directory if you use `./x check` as the analyzer on your IDE. ## Change This PR adds src/tools/tidy into the target of `./x check`. It enables rust-analyzer highlight errors/warns on all codes in the directory. Note that since tidy is implicitly checked by `./x test tidy`, this new check is off by default.
Add a regression test for rust-lang#72207Closesrust-lang#72207
Some clippy cleanups in compiler This extracts some of the changes from rust-lang#147591 that were worth preserving in my opinion r? compiler
matthiaskrgr
commented
Oct 12, 2025
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
Oct 12, 2025
Collaborator
bors
commented
Oct 12, 2025
Collaborator
bors added a commit
that referenced
this pull request
Oct 12, 2025
Rollup of 7 pull requests Successful merges: - #147168 (Don't unconditionally build alloc for `no-std` targets) - #147178 ([DebugInfo] Improve formatting of MSVC enum struct variants) - #147495 (Update wasm-component-ld to 0.5.18) - #147576 (Fix ICE on offsetted ZST pointer) - #147592 (Add tidy to the target of ./x check) - #147597 (Add a regression test for #72207) - #147604 (Some clippy cleanups in compiler) r? `@ghost` `@rustbot` modify labels: rollup
rust-log-analyzer
commented
Oct 12, 2025
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Oct 12, 2025
Collaborator
💔 Test failed - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
no-stdtargets #147168 (Don't unconditionally build alloc forno-stdtargets)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup