Skip to content

[beta] backports - #147284

Merged
bors merged 7 commits into
rust-lang:betafrom
cuviper:beta-next
Oct 8, 2025
Merged

[beta] backports#147284
bors merged 7 commits into
rust-lang:betafrom
cuviper:beta-next

Conversation

@cuviper

@cuvipercuviper commented Oct 2, 2025•
edited
Loading

Copy link
Copy Markdown
Member

r? cuviper

lcnr added 3 commits October 2, 2025 16:20
@lcnr@cuviper
yeet fastpath
b664386
(cherry picked from commit 4fcafc9)
@lcnr@cuviper
remove test for no_core
dad01bc
(cherry picked from commit 83532f8)
@lcnr@cuviper
add test
34182f6
(cherry picked from commit 7a0adc0)
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 2, 2025
@rustbot

rustbot commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

⚠️Warning⚠️

@cuviper

cuviper commented Oct 3, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=1 rollup=never

@bors

bors commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 98e2fd3 has been approved by cuviper

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2025
bors added a commit that referenced this pull request Oct 3, 2025
@bors
Auto merge of#147284- cuviper:beta-next, r=cuviper
93b26c2
[beta] backports
- remove incorrect fast path #146919
- Update LLVM to 21.1.2 #146953
- Fix infinite recursion in Path::eq with String #146958
r? cuviper
@bors

bors commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 98e2fd3 with merge 93b26c2...

@bors

bors commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 3, 2025
@hkBst

hkBst commented Oct 3, 2025

Copy link
Copy Markdown
Member

fails with: System.IO.IOException: No space left on device : '/home/runner/actions-runner/cached/_diag/Worker_20251003-040227-utc.log'

@cuviper

cuviper commented Oct 3, 2025

Copy link
Copy Markdown
MemberAuthor

Hmm, I don't see any CI changes on master for that kind of error -- maybe it was spurious?

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2025
bors added a commit that referenced this pull request Oct 3, 2025
@bors
Auto merge of#147284- cuviper:beta-next, r=cuviper
12b7c51
[beta] backports
- remove incorrect fast path #146919
- Update LLVM to 21.1.2 #146953
- Fix infinite recursion in Path::eq with String #146958
r? cuviper
@bors

bors commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 98e2fd3 with merge 12b7c51...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 4, 2025
@cuviper

cuviper commented Oct 4, 2025

Copy link
Copy Markdown
MemberAuthor

@bors retry

@borsbors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2025
@borsbors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2025
@cuviper

cuviper commented Oct 6, 2025

Copy link
Copy Markdown
MemberAuthor

Well 3-in-a-row is pretty clearly busted -- but this time the message makes it clear that ld is really rust-lld, so this could be related to the LLVM upgrade somehow.

cc @rust-lang/wg-llvm

@dianqk

dianqk commented Oct 7, 2025

Copy link
Copy Markdown
Member

@bors try jobs=x86_64-gnu-distcheck

rust-borsBot added a commit that referenced this pull request Oct 7, 2025
@rust-bors
Auto merge of#147284- cuviper:beta-next, r=<try>
5e62eab
[beta] backports
try-job: x86_64-gnu-distcheck
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-borsBot commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

💔 Test for 5e62eab failed: CI. Failed jobs:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cuviper

cuviper commented Oct 7, 2025

Copy link
Copy Markdown
MemberAuthor

Trying without the LLVM update:

@bors try jobs=x86_64-gnu-distcheck

rust-borsBot added a commit that referenced this pull request Oct 7, 2025
@rust-bors
Auto merge of#147284- cuviper:beta-next, r=<try>
74f2a49
[beta] backports
try-job: x86_64-gnu-distcheck
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-borsBot commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 74f2a49 (74f2a496fe66118ac4158e52509b67c22abb4536, parent: aa7859c0dec2de6c9cab34b03028bcef7b1fc25d)

@cuviper

cuviper commented Oct 8, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r+

@bors

bors commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 0d2b92c has been approved by cuviper

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025
@bors

bors commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 0d2b92c with merge 21cd82a...

@bors

bors commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 21cd82a to beta...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 8, 2025
@bors
bors merged commit 21cd82a into rust-lang:betaOct 8, 2025
12 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Oct 8, 2025
@nikic

nikic commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

I was able to reproduce the crash in a local docker run yesterday, but when I tried again today (on the same commit, with the LLVM update included) it worked :(

@dianqk

dianqk commented Oct 9, 2025

Copy link
Copy Markdown
Member

I guess this is due to the task running out of disk space. I got the same crash in #147463 (comment), but I didn't change any code in LLVM.

@nikic

nikic commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Oh, that explains what happened during my local test as well. I did run out of disk space between the two runs and cleaned up the volume, but didn't make the connection that it could be the cause of the crash.

@dianqkdianqk mentioned this pull request Oct 10, 2025
Closed
@cuvipercuviper mentioned this pull request Oct 22, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuvipercuviper

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

12 participants

@cuviper@rustbot@bors@hkBst@rust-log-analyzer@weihanglo@jieyouxu@dianqk@nikic@lcnr@el-ev@JonathanBrouwer