Skip to content

Make #[link="dl"] an FCW rather than an error - #147262

Merged
bors merged 2 commits into
rust-lang:masterfrom
JonathanBrouwer:fix-link
Oct 5, 2025
Merged

Make #[link="dl"] an FCW rather than an error#147262
bors merged 2 commits into
rust-lang:masterfrom
JonathanBrouwer:fix-link

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Oct 2, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#147254
I forgot to implement the T-lang decision in #143193 (comment), this implements that decision

r? @jdonszelmann
Can be reviewed commit-by-commit
This needs a beta backport

@rustbot

rustbot commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbotrustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 2, 2025
@JonathanBrouwerJonathanBrouwer changed the title Make #[link="dl"] an FCW warning rather than an errorMake #[link="dl"] an FCW rather than an errorOct 2, 2025
@cyrganicyrgani added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 2, 2025
jieyouxu
jieyouxu requested changes Oct 2, 2025
View reviewed changes

@jieyouxujieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some test nits

View changes since this review

Comment threadtests/ui/attributes/link-dl.rs Outdated
Comment threadtests/ui/attributes/link-dl.rs
@apiraino

apiraino commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 2, 2025
@traviscrosstraviscross added the I-lang-radar Items that are on lang's radar and will need eventual work or consideration. label Oct 2, 2025
jieyouxu
jieyouxu approved these changes Oct 4, 2025
View reviewed changes

@jieyouxujieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good with a test nit

View changes since this review

Comment threadtests/ui/attributes/link-dl.rs Outdated
@jieyouxujieyouxu self-assigned this Oct 4, 2025
@jieyouxu

jieyouxu commented Oct 4, 2025

Copy link
Copy Markdown
Member

@rustbot author

@rustbotrustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2025
@rustbot

rustbot commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbotrustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 4, 2025
@JonathanBrouwer

JonathanBrouwer commented Oct 4, 2025

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2025
@jieyouxu

jieyouxu commented Oct 5, 2025

Copy link
Copy Markdown
Member

Thanks
@bors r+ rollup

@bors

bors commented Oct 5, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 1c85a1d has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 5, 2025
@Zalathar
Rollup merge ofrust-lang#147262- JonathanBrouwer:fix-link, r=jieyouxu
6fef758
Make #[link="dl"] an FCW rather than an error
Fixesrust-lang#147254
I forgot to implement the T-lang decision in rust-lang#143193 (comment), this implements that decision
r? `@jdonszelmann`
Can be reviewed commit-by-commit
This needs a beta backport
@ZalatharZalathar mentioned this pull request Oct 5, 2025
Closed
bors added a commit that referenced this pull request Oct 5, 2025
@bors
Auto merge of#147366- Zalathar:rollup-f6ipp2q, r=Zalathar
3d46260
Rollup of 3 pull requests
Successful merges:
- #146874 (compiler: Hint at multiple crate versions if trait impl is for wrong ADT )
- #147262 (Make #[link="dl"] an FCW rather than an error)
- #147364 (update autodiff testcases)
r? `@ghost`
`@rustbot` modify labels: rollup
@ZalatharZalathar mentioned this pull request Oct 5, 2025
Merged
bors added a commit that referenced this pull request Oct 5, 2025
@bors
Auto merge of#147371- Zalathar:rollup-897uitw, r=Zalathar
bcbbdcb
Rollup of 5 pull requests
Successful merges:
- #144908 (Fix doctest output json)
- #147262 (Make #[link="dl"] an FCW rather than an error)
- #147364 (update autodiff testcases)
- #147367 (Trivial code cleanup in resolve)
- #147369 (Fill out AVR target metadata)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit d97e346 into rust-lang:masterOct 5, 2025
10 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 5, 2025
rust-timer added a commit that referenced this pull request Oct 5, 2025
@rust-timer
Unrolled build for#147262
08d9bc5
Rollup merge of #147262 - JonathanBrouwer:fix-link, r=jieyouxu
Make #[link="dl"] an FCW rather than an error
Fixes#147254
I forgot to implement the T-lang decision in #143193 (comment), this implements that decision
r? ``@jdonszelmann``
Can be reviewed commit-by-commit
This needs a beta backport
@bors

bors commented Oct 5, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1c85a1d with merge bcbbdcb...

@cuvipercuviper mentioned this pull request Oct 6, 2025
Merged
@cuvipercuviper modified the milestones: 1.92.0, 1.91.0Oct 6, 2025
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 6, 2025
bors added a commit that referenced this pull request Oct 6, 2025
@bors
Auto merge of#147284- cuviper:beta-next, r=cuviper
664f2e1
[beta] backports
- remove incorrect fast path #146919
- Update LLVM to 21.1.2 #146953
- Fix infinite recursion in Path::eq with String #146958
- Make #[link="dl"] an FCW rather than an error #147262
r? cuviper
bors added a commit that referenced this pull request Oct 8, 2025
@bors
Auto merge of#147284- cuviper:beta-next, r=cuviper
21cd82a
[beta] backports
- remove incorrect fast path #146919
- Fix infinite recursion in Path::eq with String #146958
- Make #[link="dl"] an FCW rather than an error #147262
r? cuviper
@matthiaskrgr

matthiaskrgr commented Oct 12, 2025

Copy link
Copy Markdown
Member

@bors retry r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jdonszelmannjdonszelmann

@jieyouxujieyouxu

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)beta-acceptedAccepted for backporting to the compiler in the beta channel.I-lang-radarItems that are on lang's radar and will need eventual work or consideration.S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

#[link="dl"] should be an FCW, not a hard error. Affects 450+ crates.

10 participants

@JonathanBrouwer@rustbot@apiraino@jieyouxu@bors@matthiaskrgr@cuviper@traviscross@jdonszelmann@cyrgani