Skip to content

some more proc_macro cleanups - #147386

Merged
bors merged 3 commits into
rust-lang:masterfrom
cyrgani:proc-macro-cleanup-2
Oct 8, 2025
Merged

some more proc_macro cleanups#147386
bors merged 3 commits into
rust-lang:masterfrom
cyrgani:proc-macro-cleanup-2

Conversation

@cyrgani

@cyrganicyrgani commented Oct 5, 2025•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Several smaller cleanups to proc_macro. Commits 1 and 3 seem pretty trivial to me, commit 2 might be worth it or not.

Followup to #147166.

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2025
@rustbot

rustbot commented Oct 5, 2025

Copy link
Copy Markdown
Collaborator

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@petrochenkov

petrochenkov commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

The second commit makes sense to me, the arena's use is limited, and if the &mut self doesn't cause any inconvenience, then it's better to use it, because it's simpler.

petrochenkov
petrochenkov reviewed Oct 6, 2025
View reviewed changes
Comment threadlibrary/proc_macro/src/bridge/arena.rs Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 6, 2025
@cyrgani
cyrganiforce-pushed the proc-macro-cleanup-2 branch from df4d26e to 7aa52eaCompareOctober 7, 2025 19:21
@cyrganicyrgani added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 7, 2025
@petrochenkov

petrochenkov commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 7aa52ea has been approved by petrochenkov

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025
@matthiaskrgrmatthiaskrgr mentioned this pull request Oct 8, 2025
Merged
bors added a commit that referenced this pull request Oct 8, 2025
@bors
Auto merge of#147475- matthiaskrgr:rollup-iyrkv0g, r=matthiaskrgr
7a52736
Rollup of 6 pull requests
Successful merges:
- #144006 (clarify wording of match ergonomics diagnostics (`rust_2024_incompatible_pat` lint and error))
- #147386 (some more `proc_macro` cleanups)
- #147412 (Convert impossible cases in macro resolution into assertions)
- #147464 (prefer repeat_n() over repeat().take())
- #147469 (Add rustdoc crate name in error)
- #147472 (refactor: replace `LLVMRustAtomicLoad/Store` with LLVM built-in functions)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 5c13022 into rust-lang:masterOct 8, 2025
10 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 8, 2025
rust-timer added a commit that referenced this pull request Oct 8, 2025
@rust-timer
Unrolled build for#147386
5f946f3
Rollup merge of #147386 - cyrgani:proc-macro-cleanup-2, r=petrochenkov
some more `proc_macro` cleanups
Several smaller cleanups to `proc_macro`. Commits 1 and 3 seem pretty trivial to me, commit 2 might be worth it or not.
Followup to #147166.
@cyrgani
cyrgani deleted the proc-macro-cleanup-2 branch October 8, 2025 19:27
@cyrganicyrgani mentioned this pull request Oct 8, 2025
Merged
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
@matthiaskrgr
Rollup merge ofrust-lang#147386- cyrgani:proc-macro-cleanup-2, r=pe…
7e44c2b
…trochenkov
some more `proc_macro` cleanups
Several smaller cleanups to `proc_macro`. Commits 1 and 3 seem pretty trivial to me, commit 2 might be worth it or not.
Followup to rust-lang#147166.
chenyukang added a commit to chenyukang/rust that referenced this pull request Oct 14, 2025
@chenyukang
Rollup merge ofrust-lang#147497- cyrgani:proc-macro-cleanups-3, r=p…
8c04cf0
…etrochenkov
`proc_macro` cleanups (3/N)
Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 14, 2025
@Zalathar
Rollup merge ofrust-lang#147497- cyrgani:proc-macro-cleanups-3, r=p…
9bab601
…etrochenkov
`proc_macro` cleanups (3/N)
Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 14, 2025
@Zalathar
Rollup merge ofrust-lang#147497- cyrgani:proc-macro-cleanups-3, r=p…
ebbb223
…etrochenkov
`proc_macro` cleanups (3/N)
Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#147497- cyrgani:proc-macro-cleanups-3, r=p…
3ee0174
…etrochenkov
`proc_macro` cleanups (3/N)
Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#147497- cyrgani:proc-macro-cleanups-3, r=p…
df59997
…etrochenkov
`proc_macro` cleanups (3/N)
Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 14, 2025
@Zalathar
Rollup merge ofrust-lang#147497- cyrgani:proc-macro-cleanups-3, r=p…
428be2f
…etrochenkov
`proc_macro` cleanups (3/N)
Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#147497- cyrgani:proc-macro-cleanups-3, r=p…
0cec036
…etrochenkov
`proc_macro` cleanups (3/N)
Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
rust-timer added a commit that referenced this pull request Oct 14, 2025
@rust-timer
Unrolled build for#147497
b83bae4
Rollup merge of #147497 - cyrgani:proc-macro-cleanups-3, r=petrochenkov
`proc_macro` cleanups (3/N)
Followup to #147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
@bvanjoibvanjoi mentioned this pull request Oct 22, 2025
Closed
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@Zalathar
Rollup merge ofrust-lang#147497- cyrgani:proc-macro-cleanups-3, r=p…
1497b43
…etrochenkov
`proc_macro` cleanups (3/N)
Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cyrgani@rustbot@petrochenkov@bors